From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.2137.1592440306240256301 for ; Wed, 17 Jun 2020 17:31:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GygBobE7; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: eric.dong@intel.com) IronPort-SDR: EXZ1BvwHdOyEU98IPSyTL+xoKYtSvG3/bgWbM/4E93RkmIzGmjJ1tnANBS5AXHtkWXrUZLFKl9 7xyn9Gr4BV5Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 17:31:45 -0700 IronPort-SDR: LGUrwtgmYVCphOD3xFtGFBGzkGmXdyNnwJcnV/rheeVDbO4A0HT1RjJ1H4nHmeWdBTbTgnhQUy IU/1x8XD2ZbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,524,1583222400"; d="scan'208";a="450448578" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga005.jf.intel.com with ESMTP; 17 Jun 2020 17:31:45 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 17:31:45 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 17 Jun 2020 17:31:44 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 17 Jun 2020 17:31:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 17:31:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TbZlSBNB75KVu02QJFh8uhIKWtXSvbov+VLCdQDjt4LfPGuQwtHPgol/qk6l0WYG4HwaXPx050tYjPWrXb2Wly21lJTjYP7Gg576bUfFB75oabQvYFNJihwsRlmijVPzFknNqciVy6+ZpJ0PdDVCuxu73zjjviN8pYSuNYK6wWrdB3oR0P7EParI/K+nmNhhuhKNB0erVbGxjyZfM/zHzkg8u55MBcAQncB6royi6CZTcty9IyIaeuEQxP9Rlur1uQ9belGQyof4Hceld3P3Ux31rFux6avuqxjpnNL6IwGx8E3t5w9lyetYDAv5LD/GYMIyGO7KOHOU861X36UKaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHkv/Yy4wgISnmGvgG9/DgKGMiCYMoJ2FhoYKTYNpc8=; b=NrHTmqwDeN/5V4tzwRMvL3pCW4QS153RFpAg+kXqsx+3yJDEM0xGNK3sEV6a4VmKMM4V68CkZgtfeBuf1laH2yVYL16sLpljjxQAOir4O2F7s7w8pNIG2elj8CohU320hIwLNPufq8850dAGjFCeH/9dMaN8uCJtuCBxvooOpzfS2/q5jNui91Ed4vvwViY52aHzSmJVQfuPLY1vUvns087+qIJO+a9fEBAOuxAOk6QK+ycRWaveC8MoMQADm5ULQwU9gA3VRFBj7LGLbQJOmDAmaYcXNb3VNDu4Wt5kkTw+hHWIK9Z7zlJjT9QkpvKxQZ5+4OwgpXWHGAA/E0PjhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHkv/Yy4wgISnmGvgG9/DgKGMiCYMoJ2FhoYKTYNpc8=; b=GygBobE7CQj7u2apxXm1KxIEJBtT/f6KUy8yLRZSNa42w3SMa5se41KkWmnnctgcpYTCi0Fyne5kbpmWp0N8znJgyswHzATnZmECyzG9YkEefnPE6AthaIywg9MhWgUgQ/wylHw1nlG3mcuRyETjaw2Q9m9sLnlqmJMOtePRkeU= Received: from DM6PR11MB3274.namprd11.prod.outlook.com (2603:10b6:5:b::26) by DM5PR1101MB2170.namprd11.prod.outlook.com (2603:10b6:4:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.21; Thu, 18 Jun 2020 00:31:42 +0000 Received: from DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7]) by DM6PR11MB3274.namprd11.prod.outlook.com ([fe80::cc01:6f05:1402:e7d7%6]) with mapi id 15.20.3109.021; Thu, 18 Jun 2020 00:31:42 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Ray Ni , "Chan, Amy" , "Chaganty, Rangasai V" , "Oram, Isaac W" Subject: Re: [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule Thread-Topic: [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule Thread-Index: AQHWRIZNBjkkl3Q9NUu+8OzU57JVHKjdhoiw Date: Thu, 18 Jun 2020 00:31:42 +0000 Message-ID: References: <20200617090326.1213-1-ray.ni@intel.com> In-Reply-To: <20200617090326.1213-1-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57c9bbbe-6702-4e02-91e7-08d8131ef91b x-ms-traffictypediagnostic: DM5PR1101MB2170: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0438F90F17 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QaqK5+8F8nzcU8VN39DdyAGKW9krc4EOVOidIjFY5IOdERGu6dl44HHOyr0D9s9H6XXD/PkG6VkXG4pMKWw7ELuLS3cpB7dx+f6GUIHk3VLbmiq3GvqdBdacm3Rx3RRnmNbnSlZ6Ry2+BFmd1zZlxO2HSDqXEwuUncbzwKAwRuqK3J4iMvj5L9VyqgL229rJKSDSnb2d73HRky6UUw4uKGwugq+Vplk1ELcmJ826F5WpmZbbN4YIebJjh1SSo4op0tePTEpa3USgKU9OP/9cor9JX0tPRwzG7XhnzG16N5HEynMwBjeVArIHJFZ6wHGlrb+wqT5Af9YDoj59JG9eNw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3274.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(66946007)(66476007)(316002)(7696005)(52536014)(83380400001)(76116006)(66556008)(64756008)(4326008)(8936002)(54906003)(66446008)(110136005)(107886003)(5660300002)(6506007)(86362001)(53546011)(2906002)(55016002)(8676002)(186003)(26005)(478600001)(9686003)(33656002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: iQ3TorWxowHo1pXvn9kTfEowmw6ALBlj5BqBdOnglDY04+zUjZEQnnYurJUlZaQyjwGNyfJX7aRaHhU2Orlzy7QLmxuaEi2aGOSFdZysnvYRykMMgMRQwLHOl8OG3nPY8nDXoCf/xezDeP/B+q3uZE4awtE1a9LEQlkX6cgTueAXjBgzo1D2xI5/Nj5lr9hJOOqk7gd+I1s+ic+6PvmJ6zeDUZ4nEVQr7n2qG8wJt+ZIG324OH8bnUCzYBp1jH9miJ3nZsWsaxbY7JjfWVpqsEjtD6P2P0qxmYIYGGZCNgGC5JeVtTRs1ma+Xgshc7Q16v65TuEupkv9ShxmCtHq28IBl6oUxr14LJXrQnAvoiU+zIK/4qDOd2NXj2udrvAyF+vclfS5Ze3oyKL7PFNXW6YSPGu4akjeWYGe5HK5gHVRM6R+sUCEAZLpfxmlWg3XWHuz1HE8GXNxSsPvGW+MkJAL3c8ZiW0/rtsHJwfcwoc= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 57c9bbbe-6702-4e02-91e7-08d8131ef91b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 00:31:42.1745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LYPb7LROX6LqvIUXPSrA8qdyFPjkgkmx6615EtruJMQ/qrdaAldwWoHrn+Y7DZZRMdeNcpo29j/y1BLWTFNQNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2170 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, June 17, 2020 5:03 PM > To: devel@edk2.groups.io > Cc: Ray Ni ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V ; Oram, Isaac W > > Subject: [PATCH] Features/Intel/Readme.md: clarify feature package > dependency rule >=20 > From: Ray Ni >=20 > Original statement only says depending on another feature package > is not allowed. It gives developers impression that board level > packages are allowed to depend on. >=20 > This patch clarifies the package dependency rule. >=20 > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Amy Chan > Cc: Rangasai V Chaganty > Cc: Isaac W Oram > --- > Features/Intel/Readme.md | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Features/Intel/Readme.md b/Features/Intel/Readme.md > index 9729f90a41..1a03a4c0d2 100644 > --- a/Features/Intel/Readme.md > +++ b/Features/Intel/Readme.md > @@ -17,8 +17,10 @@ document as needed. > ### Advanced Feature Attributes >=20 > Advanced features should be: >=20 > * _Cohesive_, the feature should not contain any functionality unrelated= to > the feature. >=20 > -* _Complete_, the feature must have a complete design that minimizes > dependencies. A feature package cannot directly >=20 > - depend on another feature package. >=20 > +* _Complete_, the feature must have a complete design that minimizes > dependencies. A feature package can only depend >=20 > + on following packages: >=20 > + * edk2 repo: `MdePkg`, `MdeModulePkg`, `UefiCpuPkg`, `FmpDevicePkg`, > `SecurityPkg`, `NetworkPkg`, `ShellPkg`. >=20 > + * edk2-platforms repo: `MinPlatformPkg`, `IntelSiliconPkg`. >=20 > * _Easy to Integrate_, the feature should expose well-defined software > interfaces to use and configure the feature. >=20 > * It should also present a set of simple and well-documented standard = EDK > II configuration options such as PCDs to >=20 > configure the feature. >=20 > -- > 2.25.1