public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jayaprakash, N" <n.jayaprakash@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Rebecca Cran <rebecca@nuviainc.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
Date: Thu, 28 Oct 2021 03:00:57 +0000	[thread overview]
Message-ID: <DM6PR11MB333778920E510DF7D980F0C4EE869@DM6PR11MB3337.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB33376C02F538B8B8C925CBB9EE839@DM6PR11MB3337.namprd11.prod.outlook.com>

Hi Mike,

Could you look into this PR?

Regards,
JP

-----Original Message-----
From: Jayaprakash, N 
Sent: 25 October 2021 22:10
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@nuviainc.com>
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc

Hi Mike,

I have send V2 version of patch series to remove complete Py 2.7 support(including py 2.7.2 and py 2.7.10 versions removal).
Separate patches created for code and document changes. 
 
There was some issue with running send email on my system, you would have got multiple emails with the same set of patches.
Please ignore the duplicate patch emails.

These are the patches sent for removing py 2.7 support completely from edk2-libc.   
  AppPkg/Applications/Python: To remove the py2.7.2 uefi port code                              -    Code changes 2.7.2
  AppPkg/Applications/Python: to remove document references to py2.7.2                    -   Document changes 2.7.2
  AppPkg/Applications/Python: to remove py2.7.10 support from edk2-libc                    -   Code changes 2.7.10
  AppPkg/Applications/Python: to remove py2.7.10 references from edk2-libc               -   Document changes 2.7.10  

Please review and do the needful.

Regards,
JP

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: 23 October 2021 22:40
To: Jayaprakash, N <n.jayaprakash@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Rebecca Cran <rebecca@nuviainc.com>
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc

Can you please send V2 of the patch series with the Readme changes in its own patch?

Thanks,

Mike

> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Friday, October 22, 2021 4:23 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Hi Mike,
> 
> Could you look into this and let me know if there is anything else need to be done.
> 
> Regards,
> JP
> -----Original Message-----
> From: Jayaprakash, N
> Sent: 20 October 2021 23:15
> To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Hi Mike,
> 
> Thanks for the review comments.
> 
> The PythonReadMe.txt available @ https://github.com/tianocore/edk2-
> libc/blob/master/AppPkg/Applications/Python/PythonReadMe.txt
> is the readme file for Py2.7.2 and we don't need to retain this file. 
> So I have deleted this file as part of the patch sent for review.
> 
> Py 2.7.10 and Py 3.6.8 have their respective readme files as 
> Py2710ReadMe.txt @ https://github.com/jpshivakavi/edk2-
> libc/tree/master/AppPkg/Applications/Python/Python-2.7.10
> Py368ReadMe.txt @
> https://github.com/jpshivakavi/edk2-libc/tree/master/AppPkg/Applicatio
> ns/Python/Python-3.6.8
> 
> 
> Besides this, I have taken care of all the other documentation changes 
> required as given below
> 
> Updated the readme.md file from this location and removed the 
> reference to Py2.7.2 license 
> https://github.com/tianocore/edk2-libc/blob/master/Readme.md
> 
> 	AppPkg/Applications/Python/Python-2.7.2/Tools/pybench
> 	AppPkg/Applications/Python/Python-2.7.2
> 
> Updated the readme.txt from the below location to remove references to 2.7.2 and replace it with 3.6.8 references.
> https://github.com/tianocore/edk2-libc/blob/master/AppPkg/ReadMe.txt
> Also updated the version of this readme file along with the date
> 		   Version 1.03
>                                  18 Oct. 2021
> 
> 
> Besides documentation changes following changes have been done to 
> delete py 2.7.2 support from edk2-libc Updated the AppPkg.dsc file to remove the Python 2.7.2 inf references.
> https://github.com/jpshivakavi/edk2-libc/blob/remove_py272_support/App
> Pkg/AppPkg.dsc
> 
> 
> Removed all files and folders corresponding to Py2.7.2 support from 
> https://github.com/jpshivakavi/edk2-libc/tree/master/AppPkg/Applicatio
> ns/Python
> Efi\
> Ia32\
> PyMod-2.7.2\
> Python-2.7.2\
> X64\
> PythonCore.inf    // Inf file for py 2.7.2
> PythonReadme.txt // Readme file for Py 2.7.2
> 
> 
> Let me know if there is anything else needed.
> 
> Regards,
> JP
> 
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: 20 October 2021 21:35
> To: devel@edk2.groups.io; Jayaprakash, N <n.jayaprakash@intel.com>; 
> Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
> AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> 
> Hi JP,
> 
> Can you also update the documentation to remove references to Python 2.x or update for Python 3.x?
> 
> For example, the following file has Python 2.x references.
> 
> https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications
> /Python/PythonReadMe.txt
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> > Jayaprakash, N
> > Sent: Tuesday, October 19, 2021 8:43 PM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Jayaprakash, N 
> > <n.jayaprakash@intel.com>
> > Subject: [edk2-devel] [edk2-libc Patch 1/1]
> > AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc
> >
> >
> >
> > 
> >


  reply	other threads:[~2021-10-28  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  3:42 [edk2-libc Patch 0/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc Jayaprakash, N
2021-10-20  3:42 ` [edk2-libc Patch 1/1] " Jayaprakash, N
2021-10-20 16:04   ` [edk2-devel] " Michael D Kinney
2021-10-20 17:44     ` Jayaprakash, N
2021-10-22 11:22       ` Jayaprakash, N
2021-10-23 17:09         ` Michael D Kinney
2021-10-25 16:40           ` Jayaprakash, N
2021-10-28  3:00             ` Jayaprakash, N [this message]
2021-10-29  5:09               ` Michael D Kinney
2021-10-29 17:02                 ` Jayaprakash, N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB333778920E510DF7D980F0C4EE869@DM6PR11MB3337.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox