From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.1491.1591752401385663061 for ; Tue, 09 Jun 2020 18:26:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lmLfe5ec; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: prince.agyeman@intel.com) IronPort-SDR: JqBk/2KtvE5VznjWL6tlzRVGy904K7FqJ1KkvZ7reKmHu/MroLDbx+NDtPAJsE4MjCUNYwONSx Ugu+nXKxmdug== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 18:26:40 -0700 IronPort-SDR: e8KKFdVP9/3McbM3qxwWppeykQk4CjXqhOJPeszDC3xRiBWuCqcdqKsdA66IF2API3xNiStME3 4PNJedVMzUtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,494,1583222400"; d="scan'208";a="296026904" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 09 Jun 2020 18:26:40 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 18:26:39 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 18:26:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdW0S1Iux2xVSwNtZUkXZA8+KRjS0z8DWUSH7fVI6QI0GrOd0GxlYWc/SzQizh1cF2c6A1wr3SOhC2rD6hA12P4NWRdzwpwOR7/pkUi2GAG1ftE86/bwA73tDdQuEe9sc4ZwYs+44pCjey292CXxbKoKchXGQWfHcBibhCa3u+SiknAAGeYFBcNP+sgH2hh1j9gchQVTweRAQvlGebySeEI2NIHPETrtbLyRl+0U86kop0ad6aSWkSFk1iVKcPC6lktKagzDMbGVycJm3aZtUtsDCS9CXHwkHXD5JRq6Wsr5iWhYDttBoeQKfS7K4cy6E9Fq4BCHvfer8z87qQ1AQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=prVR8fEZu9YAfC7loeSxXBpStgmV8uMJFMXpOI1yO8U=; b=MD/29if0rEnJEAVZ4c27W7/J+47dsZSh3fFCIo4I14qCys2FX4PTHbEnPrmgLqXu7QrmiqbBweQXuj54kn4Rjrw88faGZx/pf+2/kcfwNGZYYhgaq6tE/e2tpv2wlb8iqso8D4cCWBLllVbFmLKCsqgQJlp8v8nc6KIoq93NYHc5m+cdxr99xs4Cu+E3rl8wWVAJLm0w68gcAgF110a9ChPU1ucmMJeMp/E5Yk2R1pwq6OfEEAT3PBFud1Wkv6V54qrI1gmFYgAfkWiVesBTh2Ga2XbS5ShcVPIv/6rxX7gJBuK1PnexQNQHLTvoXBSxCQ+WrOOWuJdAN0xoXeeYow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=prVR8fEZu9YAfC7loeSxXBpStgmV8uMJFMXpOI1yO8U=; b=lmLfe5ecGfLKAhHaRyrDcqNxV+fr2QXWYnLyzPSw20R9ZmscbyYhjseNWLD5AVCmcUWBV9rZlqw5JfdkCl8N6D03ocxY2aRAI/tpjrfOYY3bmbsPtmxtKezIXbMLgAMmcJYAVLCkZtQzMqJ8K5gx0KxL4Pw96XRtcU2TdVoHuqE= Received: from DM6PR11MB3465.namprd11.prod.outlook.com (2603:10b6:5:b::18) by DM6PR11MB4563.namprd11.prod.outlook.com (2603:10b6:5:28e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 01:26:38 +0000 Received: from DM6PR11MB3465.namprd11.prod.outlook.com ([fe80::de5:83c9:de10:9d41]) by DM6PR11MB3465.namprd11.prod.outlook.com ([fe80::de5:83c9:de10:9d41%6]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 01:26:38 +0000 From: "Agyeman, Prince" To: "Tan, Ming" , "devel@edk2.groups.io" Subject: Re: [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about status code Thread-Topic: [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about status code Thread-Index: AQHWPlCQVA9iZMFgwUCU/kLTccRNm6jRDziQ Date: Wed, 10 Jun 2020 01:26:38 +0000 Message-ID: References: <20200609112353.20824-1-ming.tan@intel.com> <20200609112353.20824-5-ming.tan@intel.com> In-Reply-To: <20200609112353.20824-5-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f8badae-9f10-42cb-856f-08d80cdd5283 x-ms-traffictypediagnostic: DM6PR11MB4563: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wY816nbXcp2nZwaKSCMB550qJSjkA3SWGbzRPo2Xc/Ucy0Qx0oLNyjXBICtUFi//AVJYfEA1bWGl63GibdS43Ww7hIsfmE2xuRaCYLsId2vf30V7dhCfH8TQTh2CSHWOp67OZVB6yUHV+gjPdmvecjS0W0SFdVYmGeTjzhMhzsX/FJlP0rkdaAezpl1qWZJTPO9Yj3TlqjVgaQxv/qUVq83gkkCQn+elhdEwZMWrTy7jSg1JIBI+1sQFU+nOAX4Nx/6kec1vcEVQSGyWMQR+PB0XiWcHQ/BfNU+lZEwz7frCqNC4U52FEA8eI777OVQxhbCONswJjxzoImplCtw1K+fKAEZcO8So9fGZAMMsW5T19QmNCrqaI6nbQbHvUlvPJxVxJ0qTg4Q7ZI0YqLMcJA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3465.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(346002)(136003)(39860400002)(366004)(396003)(7696005)(5660300002)(86362001)(53546011)(26005)(6506007)(66556008)(83380400001)(66476007)(64756008)(76116006)(66446008)(71200400001)(66946007)(33656002)(52536014)(19627235002)(966005)(478600001)(316002)(55016002)(8676002)(2906002)(186003)(110136005)(8936002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: UXU7IJnh++1sM+85tTCfvBZbYPoC8J6/hvxo52YIQQC3wBVyTmZZ6G/DW4IIZb+4xVlDUtmN4Zh3kqU7D9cyp7wAYD3HKU4DE06+/TurzV+FkhzhS5spw+m9hr8xTy9s2qsJACgIfmbdBU5fJCiWACL5+uEQ0Pooei0YBqvuoXVsw6bbCC+7a8sFwslVqeJ3rSfwnOLTTJeiJTzzzg/SMQ9GIIvwEZjVe+rlUSaK2y3PrmuZHH6QY+ha8h9FXxbyc+zTqG9cSBxrgzjsx4cstLsgOTnFyj2RkQaOEAyLGtRI22saf90oCApmBNa7QxeH8MEOQEHcHo+MarqbB7CJWYoOAWms2VgJYDeG4I2e6vlLdBdK3uf//czGDqAlp5GupsJWQYp4PEcRrqekA01+lz/pdn3hFsQM6StoMAF7V9amdF037kVWjFCiWNL8ha8qt490o8Hpp6FVJRE13l4kkuwn/G7RWUxfov2jurFV8TVJh28oplApX95YsvWo395l MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8badae-9f10-42cb-856f-08d80cdd5283 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 01:26:38.3392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0PCVlo4c81Qx4Puy40ZH1dahk/Reb7iQNyRb4cB9qMGkFftTCmxXE/qSwNtejIBh3KFuSuU67wcckaTD9YXaokhHLow7A8zE7aXnvl1EGdU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4563 Return-Path: prince.agyeman@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Prince Agyeman -----Original Message----- From: Tan, Ming =20 Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Agyeman, Prince Subject: [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type ab= out status code REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeM= odulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedA= tBuild in dsc files. Cc: Agyeman Prince Signed-off-by: Ming Tan --- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPc= d.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index cd98d09f01..52cdf9ec0f 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds +++ c @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the X58Ich10 boar= d. #-# Copyright (c) 2019 Intel Corporation. All rights reserved.
+# Co= pyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
# # S= PDX-License-Identifier: BSD-2-Clause-Patent #@@ -37,12 +37,6 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE gEfiMdeM= odulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE gEfiMdeModulePkgTok= enSpaceGuid.PcdPciBusHotplugDeviceSupport|FALSE- gEfiMdeModulePkgTokenSpac= eGuid.PcdStatusCodeUseMemory|TRUE-!if $(TARGET) =3D=3D RELEASE- gEfiMdeMod= ulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE-!else- gEfiMdeModulePkgT= okenSpaceGuid.PcdStatusCodeUseSerial|TRUE-!endif gEfiMdeModulePkgTokenSpa= ceGuid.PcdSupportUpdateCapsuleReset|FALSE gUefiCpuPkgTokenSpaceGuid.PcdCp= uHotPlugSupport|FALSE gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmEnableBspElectio= n|FALSE@@ -128,6 +122,12 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 gEfiMdeModule= PkgTokenSpaceGuid.PcdVariableStoreSize|0xc000 gEfiMdeModulePkgTokenSpaceG= uid.PcdVpdBaseAddress|0x0+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUse= Memory|TRUE+!if $(TARGET) =3D=3D RELEASE+ gEfiMdeModulePkgTokenSpaceGuid.P= cdStatusCodeUseSerial|FALSE+!else+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatu= sCodeUseSerial|TRUE+!endif # DEBUG_INIT 0x00000001 // Initializatio= n # DEBUG_WARN 0x00000002 // Warnings # DEBUG_LOAD 0x0000000= 4 // Load events--=20 2.24.0.windows.2