From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.99.1599601248099881110 for ; Tue, 08 Sep 2020 14:40:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oIsBENhD; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: guo.dong@intel.com) IronPort-SDR: WARjJOGGvVUww6LHGMSPClt/wfIeK8pZnO1FNMkTKxBNtcTBQ5tqHtcODrv8cHdlT1s7H8R5HI P8B5uyH2RTqA== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="219786718" X-IronPort-AV: E=Sophos;i="5.76,407,1592895600"; d="scan'208";a="219786718" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 14:40:46 -0700 IronPort-SDR: SI0Yb4nhgSDnaBApjb7NH6QI3iZhc8baJyo0cpUI/q4IU9FS8EIxHQ4ZXO6ct8vdWCY8PObVdB dLguxoOvEu+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,407,1592895600"; d="scan'208";a="343676192" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 08 Sep 2020 14:40:46 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 14:40:45 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 14:40:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 14:40:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFg4lg1po35MUTPoS7cVegCLgMCIm9GVDfA1VJ3TGmEwb9ID1goIIi+Ol5Xn4q67yXVRJplWMrCpg2kJbyXj/90ngy0DqahYRoDnN5fGuMe1JU0lxYKIZOCIQeKGv1M8VymHwtafKdep5X/n/UTSiQipRrgYvyX9zcAcmW8I1JHEBRXQcaNnU5AycTh3M6dEMPksfiQje+KCCJaDpEIWDyQaYvvhnl1bSIvEa6G3rY1gCkS/W5TqbvlaQQGx9XiyGxbkZLd04rV9c+IitbQU4+xGn3JdDz+4kgTO50OlO+JmsmthWUMMggTpv5hrNa11QI2bjsc6uAZ/ej2qZ7sBZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sp/11VfmVLGCNHWaV659QxQbXeePb70po6nuS/3DW4s=; b=IJlWuJMZcUfLpClIL1TbGcBqCZktWzLoa3zSf7Q035oV40QHGTxXyhT7bNM6MIhvbAC9HL42M8Oco3MjJBxGWdqx/E/5OCP/2BZVDRfNfIBwk7keh488gQ7eSY2Euh9OAdIE0B9FQSiaOui+ke6bZEJsNlRDNFIIXuuAkP2wW9fO+m0Qvfs+PuZDXHRyJOAAzQRXTESsGqWeqSD9WATNml01X8dhVWC28S9z3yAt68s350e7tbe/n9qJEjImTI0RoEdjRH8PhS4csVH5RoiJt1ob5Nt17CKSWWcCx8lrbkUAmPTVe4pdKI3WqNTNsbfusNEyUV603kBZrEp9Oa+XSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sp/11VfmVLGCNHWaV659QxQbXeePb70po6nuS/3DW4s=; b=oIsBENhDvHazEw9wtsP5ZOsNnL4GwgrxXaq0yfgMfoFKLN9ihewDsMerbmeAfFxHmqfKPSANaS/a+u/TSu6Rn/L+FjAZsg8+NP7980yckkk8CaMc54h7v/xzDJR9FfhIx1AKfyWX8zXJhMlGvacCDSBl/WNNBgvvLxnavpxZPm8= Received: from DM6PR11MB3627.namprd11.prod.outlook.com (2603:10b6:5:13b::11) by DM5PR1101MB2092.namprd11.prod.outlook.com (2603:10b6:4:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 8 Sep 2020 21:40:44 +0000 Received: from DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::31e1:ea43:1322:e03c]) by DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::31e1:ea43:1322:e03c%7]) with mapi id 15.20.3370.016; Tue, 8 Sep 2020 21:40:44 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "marcello.bauer@9elements.com" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables Thread-Topic: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tables Thread-Index: AQHWVR+g6zwTqFy/U0W2l+NbSoAMg6lfpRYw Date: Tue, 8 Sep 2020 21:40:44 +0000 Message-ID: References: <20200708120125.24344-1-marcello.bauer@9elements.com> <20200708120125.24344-2-marcello.bauer@9elements.com> In-Reply-To: <20200708120125.24344-2-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94692dbb-fef9-4e65-01eb-08d8543fd748 x-ms-traffictypediagnostic: DM5PR1101MB2092: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FO+UmqKuhtsdxCRq2aNz91QdqCVdyh+rAfQclm4bQ8Xz/6MiQdX2rbKTsbNrg9tlgexqpK05NtIDvBTe6kRUo/WV9Nzz3eLnOIqNs5vRXy5Mhn9Lz3Y7ZAKynWuGy5LJ/O8makgr2Y4YyjkbYZkxI15z6WChjNQoffqTDBorwWakWOLZmXmRyaNB59FfVlyHUym+yQE2si2AhZDW0uM31jGDaDxORKdwXTMQ/nnJGDUYIZL952UeE6nYoB1y/vNYzwdo2zHOXDTvfeDsv01gaDgXRKCqY6e2A+jxHcMFUKHKIoppboJ3hwlVSxMtauiShzNTClhBYvnDMhfmY6GQ021yqpqm/jCm64n1y3DYUQ8UjEiyoLk/IAuRMq8XcZUFGDaV+rCOBbOoU+BNzkeVGg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3627.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(2906002)(4326008)(71200400001)(86362001)(54906003)(9686003)(83380400001)(107886003)(478600001)(55016002)(8936002)(7696005)(26005)(110136005)(966005)(33656002)(52536014)(8676002)(316002)(186003)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(5660300002)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1bc6pcyMsGMI9mI7HjsyDGyzbNiFiRE9vmsh3ORguBcrHwHmaKNTY2wEU50DsHuwLttFqXIZ5UbRwqDBOUuGySQt+Lm3gl8k2S//oP9jBJWutGIF6EYFqEw6IaAYSbC2MrztpfuAm5xBQu94aMUgYTI1NylWpQACEHf4e3Xl+zjj+Ve2QZ83CwKpFLsV0bbBgCOn55g0DgDcBcIX4HKAce1MTx7cjQ7rwC/VAvAoMjfDTlwmVMzApcqRY6TUruWDQ6+60+AY5Dy+eAswccrTPLFi1sdKkwEo0RDi/DRYNhOcoTDWhCznXjnSNjlIUgSPNTcSmsJ6zhyfA18Ng062j/P+lofwstQGqbY800L0KNnBgeLu2gTR2SMgxdR370wO4iWN6wEmis7okj5o8YJb9FEBfHWiOW4vo9rD+1+DUuuwATX56+spl6h96TS4j6jOwvV0VFY4X6RwTQvN8t6azLKaIzVK7h5Ycve0AwPA4PHoR/AHxGMeE9GAoziYVqF9g2eFuyA6ahJdzrQVEKhSTgXHXgU7gR4e8aKMX07TbRoEqC/6Rx+byCyd6hrvYcIKG8zpR5umsRgeek2TwBzIhqR/3TKKM8i1SfZdUTeOpnF+TBjn3ldwcxpQDccIttC1YS4BEUS0ETWgtASZ+TMzFQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94692dbb-fef9-4e65-01eb-08d8543fd748 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 21:40:44.3209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YDM4VMDsC1+YV5+XyE05wiMKWUtgmUpBF85bGeiim713VbOYjHNQtYCO3H+6L7EWYKePbG7UY3fNYEALa+0vOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2092 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Marcello, In the UEFI payload, we should not hardcoded any memory usage. It means UEF= I payload should use the memory map whatever reported from the bootloader. = I plan to remove this hardcoded memory usage soon. Before that, it is OK for me to merge this change if you want. BTW, did you see any issue with current implement? Thanks, Guo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Wednesday, July 8, 2020 5:01 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH v1 1/1] UefipayloadPkg: Protect coreboot tab= les >=20 > From: Patrick Rudolph >=20 > Signed-off-by: Patrick Rudolph > Signed-off-by: Marcello Sylvester Bauer > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > --- > UefiPayloadPkg/BlSupportPei/BlSupportPei.c | 26 ++++++++++++++------ > 1 file changed, 19 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiPayloadPkg/BlSupportPei/BlSupportPei.c > b/UefiPayloadPkg/BlSupportPei/BlSupportPei.c > index 22972453117a..b3ff065a537e 100644 > --- a/UefiPayloadPkg/BlSupportPei/BlSupportPei.c > +++ b/UefiPayloadPkg/BlSupportPei/BlSupportPei.c > @@ -390,24 +390,36 @@ BlPeiEntryPoint ( > EFI_PEI_GRAPHICS_DEVICE_INFO_HOB GfxDeviceInfo; >=20 > EFI_PEI_GRAPHICS_DEVICE_INFO_HOB *NewGfxDeviceInfo; >=20 >=20 >=20 > - >=20 > - // >=20 > - // Report lower 640KB of RAM. Attribute EFI_RESOURCE_ATTRIBUTE_TESTED >=20 > - // is intentionally omitted to prevent erasing of the coreboot header >=20 > - // record before it is processed by ParseMemoryInfo. >=20 > + // Report lower 640KB of RAM. >=20 > + // Mark memory as reserved to keep coreboot header in place. >=20 > // >=20 > BuildResourceDescriptorHob ( >=20 > - EFI_RESOURCE_SYSTEM_MEMORY, >=20 > + EFI_RESOURCE_MEMORY_RESERVED, >=20 > ( >=20 > EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > + EFI_RESOURCE_ATTRIBUTE_TESTED | >=20 > EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | >=20 > EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | >=20 > EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | >=20 > EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE >=20 > ), >=20 > (EFI_PHYSICAL_ADDRESS)(0), >=20 > - (UINT64)(0xA0000) >=20 > + (UINT64)(0x1000) >=20 > + ); >=20 > + >=20 > + BuildResourceDescriptorHob ( >=20 > + EFI_RESOURCE_SYSTEM_MEMORY, >=20 > + ( >=20 > + EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | >=20 > + EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | >=20 > + EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | >=20 > + EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE >=20 > + ), >=20 > + (EFI_PHYSICAL_ADDRESS)(0x1000), >=20 > + (UINT64)(0x9F000) >=20 > ); >=20 >=20 >=20 > BuildResourceDescriptorHob ( >=20 > -- > 2.27.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#62229): https://edk2.groups.io/g/devel/message/62229 > Mute This Topic: https://groups.io/mt/75374752/1781375 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D