From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.2728.1632849588578985059 for ; Tue, 28 Sep 2021 10:19:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TaGUXoRU; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: guo.dong@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="204250327" X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="204250327" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 10:19:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="478781403" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 28 Sep 2021 10:19:47 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 10:19:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 10:19:47 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 10:19:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WK6fbB/921w3G4TwtOSAGZHy8z+3PRq++5eL3ElwYO0JOB9LTNoHCUz2ogQrmkpWbLKuCec0JN7CgkEmfTah4YhlsG6Xy5g/xJZt2mPKNkX8wNsY8oczgeEyOSuYJtbnEGzcp+k4TB3Vp+cHg+2+w4AYgqneh2mj+n5DqxawbXp2LYfx1JZVZWYPaOU8UStiLkUpqa/gS6HUFhBGRS2WvLwRUboIW5rSUF8YeKBwv4fzpG3VelNDMEXDxDPALCC+Rk9pdCDd63PBw8/+KGa0KEvbnIFMAe3+UYbalPumR5ss6ZCgQ6VNWoj3wHbCUFNrIvfTE2OSG3KqB5HNMte3+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gfYIPoW3CML6xniT9JK6c8EKdZWi2aGjYaMicQ8emH4=; b=aXHuyCpPCbuZGXVyzSiRCfH6TPNSOsxJv3xG9CwZlpQPt9jw9uiJoHFn9VnM54yhqVWaQdcs5+emVQg4PDUNQSNqT8MpfXBuwuNNQf7CVxLx3qZ99Wdc86QFof8KJKgw9O7cfSGHmPfElhEvbBFQHq4n15AYOUYPCdm4bO0Hzvp2pvvzCY2CoKHoZGNvhQOgAIlUyaCPFbInE9bLzdFYngwNqa9NtDE3h6EPA/1z6bh8KqUizg8XxZJFOS7b7n6JumgXuzbSQ+otuD+kTUXSfmcy63w6GYiKRNKYFVNTeasS2sxsrT/1aO5v/w4DeTLEEpPW0VBGatmmT4h7iebQVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfYIPoW3CML6xniT9JK6c8EKdZWi2aGjYaMicQ8emH4=; b=TaGUXoRUMvm7Qpgt57YBp1urcYf6uNofIcjmpbX7LHtzPpHv5LkDnEQHzY75/mC8K4Py8jZ+a4nyPAEf2EQRC/+UGQR6d6/buSOrka0HVMJIY87WgAPRQpzCMfSaBWx8nfcnXdv6ylUywKeCJUABVaJNPnDJb7HdN6CLhRUHEjU= Received: from DM6PR11MB3627.namprd11.prod.outlook.com (2603:10b6:5:13b::11) by DM6PR11MB3897.namprd11.prod.outlook.com (2603:10b6:5:4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Tue, 28 Sep 2021 17:19:42 +0000 Received: from DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::7120:62a2:72b9:e929]) by DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::7120:62a2:72b9:e929%6]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 17:19:42 +0000 From: "Guo Dong" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Topic: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootloader ACPI table Thread-Index: AQHXscG3jVQY8WbnLUea9P9uVpiw06u1njKAgAD8l0CAAh3MAIAA/dfA Date: Tue, 28 Sep 2021 17:19:42 +0000 Message-ID: References: <20210925035903.1644-1-guo.dong@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c36307e-c6dd-4654-ddcf-08d982a42920 x-ms-traffictypediagnostic: DM6PR11MB3897: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1ZbEg8xSkseh9tHhrkZn11PLbI+rHf2vH09LO+w/jayyn5yzqNw/MflF1tX1+3Vbve7+fkWyMZStQl1FGjTmd/5ISKaAcRLaJqmzaTSd1nVeLn7NsjnTMQGuVJk46YH1TJ3jTPicQd5776X3i4wBqt4f1Y9VUOtlnOJq9lCTN35FFveWWw44vjywp5UnhXrnOaznBam3+XxBrBiJIBo8UOhFPOEsANGjfMlV7u9eVN2mDp2IWLP9xhxyGxp87t3lCOr4RHShNmva+9Ud5gtBBJDmNKckJz7wRXUdqGYWwMHW8fGO/JDnZIJ0qFFrjEXuZFxocNz6IyBcO05Tgu3mK13r2XyWHp4pPu0F9RPt5B/BC8EkEjs6yFKJQvKjXqm3VE6vW8u+kWN+E6+4emA+joxwDYhwmuPATjq3cAqrrgo2OvepqTySAyKZbkayTcbBNpxaqcyOJX1k2INRk/282+FNaMmp/3qk9XdBo2sqFHeaw6rbS6T2OByw2xi+Dm98SIoxtpXtR/cwDXIVBKLhrwfOBtYRwdF0pObfHR0CcgFukkkq074UftwKv1y+Y0Ymq1kn4v+GEzEC1AheQaBQelqH7mkXBPF7XdxyLIbe5KKnC9dXGgac/Bo7lN/Um0pYeWDxZh8LKdIHn73qefiDbpzWyw3dhT4WXw0v6sjAMew/XYZ+1WJLiSt2lvMI7TUWRQg0nWrW6Ko1SQTNjLDWGILFXJWgj3RFxaWDk7VTRLk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3627.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(110136005)(38100700002)(508600001)(6506007)(107886003)(52536014)(54906003)(8676002)(5660300002)(2906002)(4326008)(186003)(33656002)(7696005)(53546011)(122000001)(26005)(66556008)(66476007)(66946007)(8936002)(86362001)(38070700005)(316002)(55016002)(71200400001)(83380400001)(64756008)(66446008)(9686003)(76116006)(81973001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OeSYk+sRZNbsKcQCEZqZDdolkH/d9Ez/aRTwSHPY7K3Du4zbHJFMZe2cCmix?= =?us-ascii?Q?73+kbiRHJZZr82ObuKJ0qG3324A6TSZXd7RrCeut4sYlSEsT9oM37Dag+nas?= =?us-ascii?Q?RTvA+erAN6kHKJi6HGCTiDh+1brXeeJ2NEXk9fS4HWrx/nBX4/9BMeTiVuEl?= =?us-ascii?Q?LvJlgmH4fsApvuALGSZ/J+BXAAb2rSoIMoJDnj86WYrosl3SWGtUMYtGF4me?= =?us-ascii?Q?8AP2hgzWva4DW+SNQ6bjTzTg0FNPqu9IF851PtWv4RiFzYDONdrVH86FesFc?= =?us-ascii?Q?7xIW6yUY9VRE0QLIVMKtaQFqiIoIp30ixyqiWiR7U0FwNAOc8NISH4Ip7s51?= =?us-ascii?Q?ilZ6NUWGtyMDoSgA0S0neJN1JGdaqMLbbo8iNEKmbehih4R/VngdqIUF3RQY?= =?us-ascii?Q?WAxwKr3CT0I6l6yx3CritDEk04CFo9wd9iCowqo24cJIZi5Q/Rf19Bsrc324?= =?us-ascii?Q?BiIJzFl4W+19/fMFTR3yB0hKAjprSTnF9+XEPV6cy8nbRw+Mz6+MCdU4mVhT?= =?us-ascii?Q?pqsDmlwsaIGlHw/yMw1DyPJ/wSmdrZu10g1TZpvA5oQr/cG4ADcg4np2vgFZ?= =?us-ascii?Q?B6LwETD+ZIgCPlxDSHI9MBkVb/Ck5BXGAa+UzyNfbMnJuHGts6mCiDsMerjR?= =?us-ascii?Q?zPwy+DnFUoSETVOzC/+0oi2amb0zXCapBjce8nJr9WNLfY7XMJPAaDkZGgG0?= =?us-ascii?Q?yIM4C68uLraj2wPYmfZy1G6wVLLzHZCK5o3gt9lgi95rOWxBcg+ogdV7BVkc?= =?us-ascii?Q?Q3VZBHR593tkpHPxrHyXDRGFx3xZrdWPLIVHzcesy4crJ0uIKL95grfp0A5k?= =?us-ascii?Q?fCgXHp5kcPkqMURk4/eX2JHvWENIu3Ks7J1F7Q8BhCzM9C+2sWm9jUFddsGS?= =?us-ascii?Q?KRdeNLY890gTQUaiWT1IkXHAxvMwjyL2FQCtVi4mFeLAgPP3mwCDqOyPh2wa?= =?us-ascii?Q?TtzSSxTx3Vkcha7GMy+O66jUOq6kqGlStx2nhxzX42FLioVzmD7qw5UKm8bc?= =?us-ascii?Q?T4bWBByXPmOXU8FGWUy+Y44ZldtasvG4CcwoIY7JJK8NGZEdH72g/+OJzGaI?= =?us-ascii?Q?1yFeOA9f1haMzGFC5+6fdbYcWrc/IJPqpTdO/vcRMVj84l6IiHRJnKaWLMKc?= =?us-ascii?Q?Z+V6WtAzh9uYqtIBu/rCFFjdMU0AcvnHsyfeHyqD8NLP8zMIkoDz29P9Opfb?= =?us-ascii?Q?J/+kmn/qCnSN4IAc99uZDFEN0hdS2KgFhKjYrqcCrMUZ4i1YQm3A4G1fehgy?= =?us-ascii?Q?YV89seGOdjGedkt2M4eoumNiHDghMb0QR0UpXkFRrLhgyE+LNH41MI7lXDik?= =?us-ascii?Q?Bkq56m2KPQSHXODc7Pyw2JlQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c36307e-c6dd-4654-ddcf-08d982a42920 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 17:19:42.4893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zj0P6RAooPwcsHzlC/Ovx8ADgCAunA+0EEZob/nQtJCVWiXZ7Z+nZWUEpX3nJg2m/oOEk1yViEMFhWI142yGeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3897 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure. I updated the patch per comments. Thanks, Guo -----Original Message----- From: Ni, Ray =20 Sent: Monday, September 27, 2021 7:11 PM To: Dong, Guo ; devel@edk2.groups.io Cc: Ma, Maurice ; You, Benjamin Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootload= er ACPI table I prefer we still let caller to provide the HOB pointer. This also eliminates a global variable "mAcpiBoardInfo". You could change the BuildHobFromAcpi() to return the HOB pointer. So that the pointer can be directly passed to ParseMemoryInfo(). Thanks, Ray > -----Original Message----- > From: Dong, Guo > Sent: Monday, September 27, 2021 2:32 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > Hi Ray, >=20 > In this patch, we added a shared file AcpiTable.c for both universal payl= oad and non-universal payload. > The exposed API from this file is: EFI_STATUS BuildHobFromAcpi ( IN = UINT64 AcpiTableBase); > This function will build an ACPI board HOB based on the information from = ACPI table. >=20 > For universal payload, it calls this function to build a hob for other mo= dules. The main function is very simple and clear. >=20 > For non-universal payload, ACPI board HOB is used in the ParseMemoryInfo(= ) callback for PCIE base info. > So we could get this HOB from the caller, or get this HOB inside the call= back. I select to do it inside the callback. >=20 > Thanks, > Guo >=20 > -----Original Message----- > From: Ni, Ray > Sent: Saturday, September 25, 2021 7:48 PM > To: Dong, Guo ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [`edk2-devel][PATCH] UefiPayloadPkg: Build a HOB from bootlo= ader ACPI table >=20 >=20 > - Status =3D ParseMemoryInfo (MemInfoCallbackMmio, &AcpiBoardInfo); >=20 > + Status =3D ParseMemoryInfo (MemInfoCallbackMmio, NULL); >=20 > Guo, > I am curious why you changed this part. > Without this change, MemInfoCallbackMmio() can get the AcpiBoardInfo from= the parameter. > With the change, it has to locate the Guided HOB itself. >=20 >=20 > Other parts look good to me. >=20 > Thanks, > Ray