From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.5196.1623294229521902948 for ; Wed, 09 Jun 2021 20:03:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ePC33FtN; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: guo.dong@intel.com) IronPort-SDR: akmIexWzd6aVjIK6izHYp0MIr0pZnWBXVjRTq6t83QefF5LRmcMmLOUbOeV5b0LPcxHdMsUaQL Pk0ZSZ5wOEUg== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="205248470" X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="205248470" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 20:03:46 -0700 IronPort-SDR: FE4Ueywa4adQzoxzJXQJG018ki0qA1R7Ick2dYWlhqgZFWCx1Thwq8+xm/yxtYDuKrSF0QZf+A evQWPpXyH17w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="482635665" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 09 Jun 2021 20:03:46 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 9 Jun 2021 20:03:46 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 9 Jun 2021 20:03:46 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 9 Jun 2021 20:03:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAEknc1g6bK4/2ENoawsG2KhB/gYGDWs67uoyZWQlTbqpIFzHCHTpUle3VeqC5WQJrGGbpp4fat8yQBCp1FUmj1XW1T1aBNACRn7rgV6+k9qpLZmQV7JnZFEv8K9d39RNLOssGX4NDgNLSOP/SJyRue3uZWNZlQhBSG/IZmyUmQZWehD7SJ/fIUspx8QV59IblRkC995pSPGKcD1PYU2KexnHYwY5RvP9/X/116qXzV8e62sE/S/oGy6Q7BxZkOa2vcfhiRnzkMbRdPA79/sVbjo+y1mgodroZD50SQJCSxQs+I5X80JlQGWVBBVn5z88aHbrJNOcCLjchyEB+Xh0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bgoQ1YAlmwhqkitNJcq45Lvvd50L4PdDM6yBuniBZ20=; b=HEFfK/apqh+oGo1NEVOjQx702bSFO5LIiyxKUjdC9PLf5IY4in9Na2lDbfZb7yi4aIBnE0AjjtqVXHFeoMchGpl/1WolkHcq9W9Q51KUy7C2PG6jEM5800/MZmxwidrkjTmDAggMVDsG/yE+8DeD0R/iYHlAmpi7O92QaRA3oqfRe1yd+uYQXQLePARAaKROgNn52mni8+C3k8L2/kVfyt4FWsy64gXA1FDckJDC+yVPo7yr/Sa/wf0NC9wh3dUDj+WkkLFz3tUDWCwnkckBmX5R1hyHDoYZ/nJf40TA63wu64ohIIzC9UgBPd1ecXRgEp2IxqgSSl1HZLh7uqWBsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bgoQ1YAlmwhqkitNJcq45Lvvd50L4PdDM6yBuniBZ20=; b=ePC33FtNGUGw9VQANwQGEm0nYJmqzvSwYH/JxuRZ29aLDmx7fuBryVPyozrjLOLiBsS8Sd1/yP/D948nxBEmqx7/ep43OBRrqS0pBsFln1WiMVpANxEdbwMxl5thwJg24zfyUvC3v+1g6XMcr30rDGL8zipfnRysXn9VYjeNkyw= Received: from DM6PR11MB3627.namprd11.prod.outlook.com (2603:10b6:5:13b::11) by DM5PR11MB1756.namprd11.prod.outlook.com (2603:10b6:3:114::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22; Thu, 10 Jun 2021 03:03:45 +0000 Received: from DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::7140:f102:7429:8359]) by DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::7140:f102:7429:8359%6]) with mapi id 15.20.4219.022; Thu, 10 Jun 2021 03:03:45 +0000 From: "Guo Dong" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic to pass PCD across binary Thread-Topic: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic to pass PCD across binary Thread-Index: AQHXXZlbK646q3fqJkC0mgNPz4k0hasMjmQw Date: Thu, 10 Jun 2021 03:03:44 +0000 Message-ID: References: <20210610013826.1986-1-zhiguang.liu@intel.com> In-Reply-To: <20210610013826.1986-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.104.146.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f909a8e-126d-4323-a01d-08d92bbc5c2e x-ms-traffictypediagnostic: DM5PR11MB1756: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yl3eXDxTpMAsRxKo0K4YUSrQVmbbSrmMJT1rnT6ePny/XSQNhakWaol01Q+sW7UXXbQ7o9oDWIuT08b1fwlV7dn2Rznn/KZgU8AdYki3lT4q7OjO4wr2vInbI6aK3WW79Ex7KCcSQ5eG8ibtiV+0tgDH71l5jh8qsxQuFFRverMZQVXM+NnQ391wxWGGAGzKEEfNkheu7Hc8BFIbPMZQ7NS4CKasGfTU7qhIfjdDTVvQwkQeo5LooHiVTgQHQvdfiU1UEY1dZenAfTGsnXuDVBG1hcI/VUio4n/HcBbxxmm5ZwdCkpw+y/4v0yRzBjuTWduEr+JvH0wICoAL0Na2eIRtcJk8Ym3iYiOFucvjTESckzUQVAEu35U+yAO6iZz9MDlUHuBk7YZRSN5HGy/fQRLtPcsc/4oUpm9JrYcXR6+aYNBn9SiyvMBmA2Rq15OARD9FXiQWZ5HddRtru5I9L7t50mnvRNcqGGi4e/Dm9k5js7S0oIiqP0VvzHT7FXnQx25+m2dg3bKoB3+lnuzs8gqNPvkai2uAnmI4jG7KZHNSabUXswgYEdIkMRDe9Ul87w4qYIoOr9kK+xmuUuDeTk+AYoKX9EFBuFfqK3loMMc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3627.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(376002)(346002)(110136005)(316002)(86362001)(55016002)(83380400001)(53546011)(52536014)(6506007)(33656002)(7696005)(64756008)(66556008)(26005)(8676002)(5660300002)(2906002)(54906003)(76116006)(66446008)(9686003)(66476007)(66946007)(186003)(8936002)(71200400001)(4326008)(38100700002)(122000001)(107886003)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HdhvbW7izMchyQHbKVGpDBD4nPG+IrdJbl1HLsAU0k2qYtAAfoPGNX41oV12?= =?us-ascii?Q?L3DrwoNm/gsM/VWWvrfLIy77zFwMKdF1J2SwXNyI2YMAEYiAc10bx3iO85gP?= =?us-ascii?Q?DKnHrqoNu5jsrGe7rFY4NUT37JllfueZGyuvq5JBCYhGFgafzKe/uSB/mw9h?= =?us-ascii?Q?zWslxdWJddE8q+FCOICZr9aZFXCoqFBdNRwWwLb/agyrbudZ8BSFrNZ6i76I?= =?us-ascii?Q?vICfR9iNQADctnztWTXOnKybsPGavBrAhtdxaOXBV2iFe15nIuOAubwM50Ss?= =?us-ascii?Q?yPzGqm8mtGKKAhdy0gwXkS5xgsrqv0dE90PTngEFsu4Gd4r4I3YgOPcKL1XY?= =?us-ascii?Q?3aS+OHtssgrkBtPXKlir7JMJ2xmwoxNxCquvms26Gdj5Nk+jjffcJejP42T4?= =?us-ascii?Q?cagJ29T/1bmXbr4LP6xHmy2JutFqaxfGQ+HEegc8KTvQH0FYihADVc1U52A3?= =?us-ascii?Q?8/e9473rRItNU+suPKCrdmWAywFC3R8GrMG9ujVSQEfGaofAPdfF5u2/1Lrd?= =?us-ascii?Q?66efRfBtUodeoyyXxhv/A8jKSWpWuTOqaEaiByvxZqewerrd/czUwoWKybQJ?= =?us-ascii?Q?79d+YrBiz1s6StTfrugKroOZ/G+qYbTQhA14r1f6eckVcb+VYe1Bqy5PfZgp?= =?us-ascii?Q?eDRj/gQBQ/tEXajM4FtfIuEYDCsMfx5SLg2W4rYidro5khViM0FDP/EMtEZf?= =?us-ascii?Q?3F7yn+AciK23SQkd5Znzb2XZircrFc5vN12awRnEDL3NJMPZo2/ulYCO8b4P?= =?us-ascii?Q?YAU35bLc0tLGu3gETd1hVHxgzyU5eF9N1ld1BDvUOJv0SU1y4ryLe2xtCStb?= =?us-ascii?Q?hP/vMOXHbFI2VRB15RhSKsgnK/MIi3zailotFdLHYb3yexSHFdFOnLxH3X8v?= =?us-ascii?Q?AeRNWCnTDSQ5s9TGfxyOEyom0BQq0Ioh/r973sL+oQQTl8MLEdPvbfS1xMUa?= =?us-ascii?Q?+pva5GJW4c3L6ZlioXo4ig02SkIwbhRBo0ZdamXfVoYntSUWEjRI0YF54y2H?= =?us-ascii?Q?ejsPPihafIu8CHqRd9joC5ryb42cALb14GCgjYft0CKj8PUqE/vvFyNngv6k?= =?us-ascii?Q?Gz0pVpkxuYTajG31lqWu5OSeedQpyDRzoEZ3A8INdbGZVrSdUPX9MNZH55fs?= =?us-ascii?Q?U52ktuTkUbCFRlyrvCu7UcfDeOTxCKuxFKYiG58Cc8swWQ0kXR7OwzFLZQ3D?= =?us-ascii?Q?Pd22Pxl9tLLDkIo4OOmQtRCTyoM7XIEHpG+IEFsLilQCI4EKLPOeKUacANgQ?= =?us-ascii?Q?BniSUsp2U+6DlkdxbHzNZFM8Ru3QQAJSBrRsa7YfJ4Aewfym85ga1edmAgwn?= =?us-ascii?Q?mjqN9h6wdwaUiq5xp+afqvbm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f909a8e-126d-4323-a01d-08d92bbc5c2e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2021 03:03:44.8612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ueh6PgBKmh8FP83RPbLYYm8kOuVj2Du4GJ1DmQYDOmNEl0jBzzY3y19wrfwaezkNYjVEIFmdBoZd89J0N6E2Tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1756 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch 1) changed PCD type from Dynamic to DynamicEX 2) added 3 PCDs. It would be great if you could describe why 3 PCDs are added in the commit = message. With that: Reviewed-by: Guo Dong Thanks, Guo > -----Original Message----- > From: Liu, Zhiguang > Sent: Wednesday, June 9, 2021 6:38 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [Patch V3] UefiPayloadPkg: Use DynamicEx instead of Dynamic to > pass PCD across binary >=20 > V1: > When passing PCD database from Edk2 boot loader to Universal Payload, the > local > token number in boot loader PCD database can be different with that in > Payload > PCD database. > Dynamic PCD directly use local token number, while DynamicEx will search > token number > by Guid and ExTokenNumber, which are unique pair and can make sure > finding the correct > token number in boot loader's PCD database > V2: > Remove PCD PcdFlashNvStorageFtwWorkingBase and > PcdFlashNvStorageFtwSpareBase, because they > are not consumed by any modules. > Explicitly define some PCDs as DynamicEx, or their default type will be > Dynamic >=20 > V3: > Not remove some PCDs for they will be consumed soon >=20 > Cc: Maurice Ma > Cc: Guo Dong > Cc: Benjamin You >=20 > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 37ad5a0ae7..4b0ec3a059 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -336,11 +336,11 @@ >=20 >=20 >=20 > ########################################################## > ###################### >=20 > # >=20 > -# Pcd Dynamic Section - list of all EDK II PCD Entries defined by this P= latform >=20 > +# Pcd DynamicEx Section - list of all EDK II PCD Entries defined by this > Platform >=20 > # >=20 >=20 > ########################################################## > ###################### >=20 >=20 >=20 > -[PcdsDynamicDefault] >=20 > +[PcdsDynamicExDefault] >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|0 >=20 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|0 >=20 > @@ -363,6 +363,9 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0 >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0 >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE >=20 > + gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0 >=20 >=20 >=20 >=20 > ########################################################## > ###################### >=20 > # >=20 > -- > 2.30.0.windows.2