From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.5031.1650604149315262896 for ; Thu, 21 Apr 2022 22:09:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DH5yWwFf; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650604149; x=1682140149; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=thIDvesRG5cjzutgHdZBaVFLcCBORWLhwnKFgXxtDgM=; b=DH5yWwFfT1JxAqFdHGucycjL6b2harZsrlMcaKG98SWSSQ7+e6LKZSGT 8Bxi8phYQjN76YxosHM6or7mrMsclj15K4rO7SpSUxL0KOgSUQ00Gzg9Z iCUT/ML/YLcLzXn3xYTGFStN+5DQdeeOB2tWnKwcllVeevojeWUIJc0Sf 8aARDI/c4JfmjI6YRFWcco7m2AZ/kQ7vXFcx1rnXlPrGuki4he1Thm65d 5amurHje5RrmQQMTA7pj4VBvaOj9wJG9A8uXO7J592hBHc+Dr8WU474qh pzIkIn6ffKygCl7mGxurP7lvIoCToSHeMw/Eo6JgSj34biGOmRloOYcSM g==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="251899558" X-IronPort-AV: E=Sophos;i="5.90,280,1643702400"; d="scan'208";a="251899558" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 22:09:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,280,1643702400"; d="scan'208";a="648465554" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 21 Apr 2022 22:09:07 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 21 Apr 2022 22:09:05 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 21 Apr 2022 22:09:05 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 21 Apr 2022 22:09:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 21 Apr 2022 22:09:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ia2GpZEQCx1Ik71NGUYpFleL+v3BTSIKEwy2EfHW3jcynAV9O6OlSLObXs20Ybf31/2S6nwag0defHF4VQ7mtca2z8HJknIwxtB5pC9iQcrKKyYvHAp8lLbTPdMBt3pKDvFi/7//IAC4Dt6LNGpkNwGZIbikRQmc2H0HtSfxJTM7Uc2XYDvBNssb5e+RQVvzhORE/RIfRy596w+WuZ2Yrr3naEdpESGeBi1Pz55Xy7po+sjTcILf/1kAMbakBVjv+aiqype4THr+KqSZzS2qraWPmdXLeV237wjzTcRFjwwXK/Ul5rwCMz2QnKXGApzgi4ODJleWaEPT3FHVe13NeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SOyZ/h1CLlCdwibvU+05KNUPsXammNP1N99VwQYHUso=; b=TgN3BAzNj0LvvMf1gwslGrPODgSO6zMiD9A7513K5K9JgGmO8OyGWH20Ez3tyfR5EWQ4h33QGLWWfnnrZyHq1rgEDkfJVKMSPtsarTvm9dQhKixLNOlABR7YTn1DykS8HgyTdBG6X3RXsu4gs3N3HpCUkY46eAPMle3m+GyA7HTN2wx5c0XPoNPpvi9rVrGmbpp2uEAJTRg73bwC1Bi39R8d5D+1hsfy9+ahKcPrZksrFToIew18qslqH/HNCzWI59Hfya69e6YCbav42yHfRQUJQoIcPVTbvJG/YqBlqIHsKJej9IGVwVuKruuGlQUV9tNk4mSqH4eMqDOpeuQWIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3627.namprd11.prod.outlook.com (2603:10b6:5:13b::11) by BYAPR11MB3384.namprd11.prod.outlook.com (2603:10b6:a03:75::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.25; Fri, 22 Apr 2022 05:08:32 +0000 Received: from DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::c4d8:57d8:f4ff:dd1a]) by DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::c4d8:57d8:f4ff:dd1a%4]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 05:08:32 +0000 From: "Guo Dong" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Ni, Ray" , "You, Benjamin" , "Rhodes, Sean" , "Liu, Zhiguang" Subject: Re: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Topic: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Index: AQHYVfw2tW3kRE1rc0a+/8C0x7Xjmaz7Xptg Date: Fri, 22 Apr 2022 05:08:32 +0000 Message-ID: References: <20220422035047.1130-1-dun.tan@intel.com> In-Reply-To: <20220422035047.1130-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d48e4aff-5528-49ea-b785-08da241e2581 x-ms-traffictypediagnostic: BYAPR11MB3384:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m/HNSk4HjBkNz1Eiym+pjofE0ToVHEnJ31b2hwyAseLdgeoKWZmPH6CJbIhZdanNGHqPgw0sM9J5D/dDpiaO52UmltHfcUu9Ni+su62b/LP2971udmWXmOVcU5jCAgpZtTWXx51caqaJu5paj4d8Nq1yosGm7MIeBIVFaQtgE7DPVoa7HXJBQ3Tmrm9nTnHkcbsgc+5965fMhJ8eOm0qZfxM7VBBT7lAEHQOxyVbuqBGF4W0b8GzQZrb8IQQ1jPHyYfBjNv5I56G+4zgd4KZnGZ0XcZwhOMYKVkKg1WShuMKmGsfpkB0iMDvycevwxa/XPd3rGPBSLtwanAVh1PtuaycfFaMP1DEXRhnYPBBR7KNkYC2UCmbGnnB9TM5dy0hzSagytztLKH7hshCGk4xfl/EB90UcIKlrI6q7qwwpsabZXAbVVYw6tUTDx+wHkjC7NvwTJULIQuQgrB3gmt9S/daEP3yQhPgZYixq9OlmK49RK8rjs8wcpf2lARBR5VrKO93LCsKDZ2A/2J8EgTpSlvI/5uWk6LswC8TN3bRlKQN+gFKHQrDwVIF02EvaysnVtyaYc+g1MCggeIm3aagNNsyLfg//634sisSP4WeSTJlXq58Fsf6Sy/784KSdV05FqPDGf+oHyoUIdXQCDL7D4Xcxj71y7VRi3n3vuYuzdz7lD39mTVkkkmWbFW2TmR6X+wFxC2MKvpCttB4Qe7fIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3627.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(38070700005)(66446008)(53546011)(86362001)(52536014)(110136005)(55016003)(8936002)(71200400001)(76116006)(122000001)(82960400001)(316002)(54906003)(508600001)(66556008)(66476007)(66946007)(64756008)(4326008)(5660300002)(8676002)(7696005)(186003)(9686003)(107886003)(26005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/F563E3vF4rp/qqSdlZTIIv2Quk5Tmzp0bx6Rr3TrEsZr9Rd7y8Xaum7MDwg?= =?us-ascii?Q?Gg7Nvhnskq86PGi9HfD/N2oFgDG7DnqL2l8Mf99at51ejeXTKM6CC2k8PEIC?= =?us-ascii?Q?rjy13rF/T5nso5dOctZBFqf/Aw99q18QSUeHYfxJuuQ756KeqAPnClqvbp6t?= =?us-ascii?Q?t/V6wv+iKin4wjjLP193piXHFDUnRez1vlBnznEd278XwPiiOEZus2VpTy85?= =?us-ascii?Q?588i5okyzcpo3dReepdp89i44LM7jXG17OhSgTzCLGqDcrSlsDboPTDTinS/?= =?us-ascii?Q?pfi3HOOgYVALzsGg6Lhgkb9Sufz3708BQecNto8vISzUYHefpwYxhq7egqtu?= =?us-ascii?Q?pN2MUQEB3sY3PtG4j/6IvF7LtuepSiDpvCfoLzGSzqcsrYsDL2VtwvLj14g1?= =?us-ascii?Q?uF2ZtYU61Hj54JSsx+jgukHN6vGJFY2ZY90YOaYfYQwpD/QwlEuhuw/E8Og2?= =?us-ascii?Q?tq9rmvp1//xAS/NSHMBR1oYnRpI3oxJJYnPupktI3gUn/gKBlSffTdbUVCjX?= =?us-ascii?Q?88Vr179pxGSr/BQO0LFeEhhvv/e3mDVGwzRDoDksHxo9JtW8PzH7J7qW8JPH?= =?us-ascii?Q?9ecZuXTJNyr7mc1pyFY2p60P+/Zyy27ZOShkOqHKvp6vRNlBfgGCqvOY4bxP?= =?us-ascii?Q?8pWP11cLxZmn+oqOZiuCaudTJOG4NVG/qCemtmIVsz2Xw7lrLb8c55tiXII5?= =?us-ascii?Q?sDW9guqdVYLUVjSrWWzT0ttS/+Lpl1bv2p7+Huq85x30FS68hHrNaunxuG+q?= =?us-ascii?Q?jrVDA4JQ2x2LoV2/VpufZlWij9855KVkd//uGiOFH8W4h9QTLBn1Evtim4cG?= =?us-ascii?Q?wtYAmRq0ZO5bdJ8BX7XwCHbkE6Jb2pbeHcGjfjZZzouYWFK04WUtUpC5h4jQ?= =?us-ascii?Q?1jmO18iRDJqws0628pVOhNyhpbrGsnzlEaFv26kwhmfXTkADMTUmdbhWoaLN?= =?us-ascii?Q?WhNTglEzH8iFvBe/uVQDZam8iL2dLYCZOK2275/31GajRmuLJNcpxElg/yec?= =?us-ascii?Q?pNPmvqPhjdt0I353nl0+dpfRIXhiC3tE/F4Ryr8vOpk8S70swP1zJu2FgY+n?= =?us-ascii?Q?dNnggFqr2yWFcyFOoZ8pFKNYZ3TigPbzWuOPdcd0QHmRMPegVNfscfI+Crkq?= =?us-ascii?Q?RyRm7LafOXXZ4sgc75w1Ys1uo2/6rh7dMesE0mupcWA9wIGKs+azIeQEVug8?= =?us-ascii?Q?sidKOaU14rLWsEYHW9PVJQpVa30bMdch0ALYDMAevC/vAn+vp8t+X9OoSu3E?= =?us-ascii?Q?ij7o4S23JmTBoTANBWq8GynNuC9phPue3j1S+Jw3r30Az9+mRYV1i+4efpgl?= =?us-ascii?Q?lC0bCUZkeEN/ZCSjmJf+dK3WTnSFTrflT1nEABx45mWwNwamJyoqlpKffFGa?= =?us-ascii?Q?C/0OnROMB5DBPgx/OlHZxA2QpxyBlM70vUDl0EhAJ010zI/bmKn8sA12aFBp?= =?us-ascii?Q?OjR3XMRsUxFDWivyIIsHcz7fwMxbVpHOHlXF60wJFXL6o7CytpgnLpuXTge7?= =?us-ascii?Q?qTpEfXQ/0yL86a4YnbXt/fyjORjXxfwvm16LC1iMe6jyWjxWC+wlNq1rUOTo?= =?us-ascii?Q?GoGez3dnShf9v+hl6MXANRgCRU6fmpsTRBG/yawMWlEwXuMR0d+1fq+f5lW2?= =?us-ascii?Q?7kYf8jdT4iwXGxXxe/W0eQw0Bq9kho7rvtapJjqxk54bw3xMXHjbIUDYOFvg?= =?us-ascii?Q?Sr/00MbKJ5hxqqTh+8nf4K25HrrQ/JjjBEiUBzXIcqhXKfV0yUq8Y+wXxx52?= =?us-ascii?Q?stDxxfRQew=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d48e4aff-5528-49ea-b785-08da241e2581 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 05:08:32.2598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P7hkwZrAa4MaeKCjqORWHNFLUy3D7moYcFzw6EK4yV9qDd27fmf9DwkRfDFbNzZzw1q1B/EoB31upku6t9Ga7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3384 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Minor comments: It would be great if adding some descriptions to the fields to make its usa= ge more clear. Maybe we need give this header file and structure a more generic name by us= ing "OS" instead of "LINUX" so that bootloader could pass command line to A= ndroid and other OSes using same structure. With current definition it looks bootloader could only pass 1 command line = to payload. I am not sure if there is a case that bootloader need pass mult= iple command line so that payload could pick up one of them for OS. +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; Thanks, Guo -----Original Message----- From: Tan, Dun =20 Sent: Thursday, April 21, 2022 8:51 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Guo ; You, Benjam= in ; Rhodes, Sean ; Liu, Zhi= guang Subject: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Add definition for UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE Hob. This Hob is used to pass Linux Kernel command Line to Payload Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes Cc: Zhiguang Liu Signed-off-by: Dun Tan --- UefiPayloadPkg/Include/Guid/LinuxCommandLine.h | 28 ++++++++++++++++++++++= ++++++ UefiPayloadPkg/UefiPayloadPkg.dec | 1 + 2 files changed, 29 insertions(+) diff --git a/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h b/UefiPayloadPk= g/Include/Guid/LinuxCommandLine.h new file mode 100644 index 0000000000..0bb75238e7 --- /dev/null +++ b/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h @@ -0,0 +1,28 @@ +/** @file + Define the structure for the Linux command line Hob. + +Copyright (c) 2022, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef LINUX_COMMAND_LINE_GUID_H_ +#define LINUX_COMMAND_LINE_GUID_H_ + +#include +#include + +#pragma pack (1) + +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; + +#pragma pack() + +#define UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE_REVISION 1 + +extern GUID gEdkiiLinuxCommandLineGuid; #endif diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayload= Pkg.dec index 5c1aeb8235..494ef94932 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dec +++ b/UefiPayloadPkg/UefiPayloadPkg.dec @@ -35,6 +35,7 @@ gUefiAcpiBoardInfoGuid =3D {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x= 2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}} gUefiSerialPortInfoGuid =3D { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98,= 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } } gLoaderMemoryMapInfoGuid =3D { 0xa1ff7424, 0x7a1a, 0x478e, { 0xa9, 0xe4,= 0x92, 0xf3, 0x57, 0xd1, 0x28, 0x32 } } + gEdkiiLinuxCommandLineGuid =3D {0xb5aeb34f, 0x3047, 0x4955, {0xb8,=20 + 0x80, 0xad, 0xd3, 0x6d, 0x86, 0xdc, 0x0f}} =20 # SMM variable support gNvVariableInfoGuid =3D { 0x7a345dca, 0xc26, 0x4f2a, { 0xa8, 0x9a,= 0x57, 0xc0, 0x8d, 0xdd, 0x22, 0xee } } -- 2.31.1.windows.1