From: "Guo Dong" <guo.dong@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"marcello.bauer@9elements.com" <marcello.bauer@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Christian Walter <christian.walter@9elements.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Scan for PCI devices after end of DXE
Date: Tue, 8 Sep 2020 21:27:34 +0000 [thread overview]
Message-ID: <DM6PR11MB36275A30D5454200DD3BD94E9E290@DM6PR11MB3627.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200716111011.22538-2-marcello.bauer@9elements.com>
Please CC all UefiPayloadPkg maintainers or the patch might be filtered.
Only trusted console devices would be connected in order to support TCG physical presence before ReadyToLock. Instead of connect all PCI devices in PlatformBootManagerBeforeConsole (), please check why PlatformBootManagerAfterConsole() could not meet the requirement since all other PCI devices are expected to be connected using EfiBootManagerConnectAll ().
Thanks,
Guo
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcello
> Sylvester Bauer
> Sent: Thursday, July 16, 2020 4:10 AM
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>; Christian Walter
> <christian.walter@9elements.com>; Ma, Maurice <maurice.ma@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star
> <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Scan for PCI devices after
> end of DXE
>
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> This allows EFI applications to iterate over those devices.
> An example is iPXE.efi that requires those devices to be present.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> | 1 +
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> | 76 ++++++++++++++++++++
> 2 files changed, 77 insertions(+)
>
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> index 1f5a0bcad038..a7c6bc2d6440 100644
> ---
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf
> @@ -57,6 +57,7 @@ [Protocols]
> gEfiBootLogoProtocolGuid ## CONSUMES
>
> gEfiDxeSmmReadyToLockProtocolGuid
>
> gEfiSmmAccess2ProtocolGuid
>
> + gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
>
>
>
> [Pcd]
>
> gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
>
> diff --git
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> index c5c6af0abcb2..ff7df53231ce 100644
> ---
> a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> +++
> b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> @@ -138,6 +138,79 @@ PlatformRegisterFvBootOption (
> }
>
> }
>
>
>
> +STATIC
>
> +EFI_STATUS
>
> +VisitAllInstancesOfProtocol (
>
> + IN EFI_GUID *Id,
>
> + IN PROTOCOL_INSTANCE_CALLBACK CallBackFunction,
>
> + IN VOID *Context
>
> + )
>
> +{
>
> + EFI_STATUS Status;
>
> + UINTN HandleCount;
>
> + EFI_HANDLE *HandleBuffer;
>
> + UINTN Index;
>
> + VOID *Instance;
>
> +
>
> + //
>
> + // Start to check all the PciIo to find all possible device
>
> + //
>
> + HandleCount = 0;
>
> + HandleBuffer = NULL;
>
> + Status = gBS->LocateHandleBuffer (
>
> + ByProtocol,
>
> + Id,
>
> + NULL,
>
> + &HandleCount,
>
> + &HandleBuffer
>
> + );
>
> + if (EFI_ERROR (Status)) {
>
> + return Status;
>
> + }
>
> +
>
> + for (Index = 0; Index < HandleCount; Index++) {
>
> + Status = gBS->HandleProtocol (HandleBuffer[Index], Id, &Instance);
>
> + if (EFI_ERROR (Status)) {
>
> + continue;
>
> + }
>
> +
>
> + Status = (*CallBackFunction) (
>
> + HandleBuffer[Index],
>
> + Instance,
>
> + Context
>
> + );
>
> + }
>
> +
>
> + gBS->FreePool (HandleBuffer);
>
> +
>
> + return EFI_SUCCESS;
>
> +}
>
> +
>
> +STATIC
>
> +EFI_STATUS
>
> +EFIAPI
>
> +ConnectRootBridge (
>
> + IN EFI_HANDLE RootBridgeHandle,
>
> + IN VOID *Instance,
>
> + IN VOID *Context
>
> + )
>
> +{
>
> + EFI_STATUS Status;
>
> +
>
> + //
>
> + // Make the PCI bus driver connect the root bridge, non-recursively. This
>
> + // will produce a number of child handles with PciIo on them.
>
> + //
>
> + Status = gBS->ConnectController (
>
> + RootBridgeHandle, // ControllerHandle
>
> + NULL, // DriverImageHandle
>
> + NULL, // RemainingDevicePath -- produce all
>
> + // children
>
> + FALSE // Recursive
>
> + );
>
> + return Status;
>
> +}
>
> +
>
> /**
>
> Do the platform specific action before the console is connected.
>
>
>
> @@ -157,6 +230,9 @@ PlatformBootManagerBeforeConsole (
> EFI_INPUT_KEY Down;
>
> EFI_BOOT_MANAGER_LOAD_OPTION BootOption;
>
>
>
> + VisitAllInstancesOfProtocol (&gEfiPciRootBridgeIoProtocolGuid,
>
> + ConnectRootBridge, NULL);
>
> +
>
> PlatformConsoleInit ();
>
>
>
> //
>
> --
> 2.27.0
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#62679): https://edk2.groups.io/g/devel/message/62679
> Mute This Topic: https://groups.io/mt/75539006/1781375
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com]
> -=-=-=-=-=-=
prev parent reply other threads:[~2020-09-08 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 11:10 [PATCH v1 0/1] UefiPayloadPkg: Scan for PCI devices Marcello Sylvester Bauer
2020-07-16 11:10 ` [PATCH v1 1/1] UefiPayloadPkg: Scan for PCI devices after end of DXE Marcello Sylvester Bauer
2020-09-08 21:27 ` Guo Dong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB36275A30D5454200DD3BD94E9E290@DM6PR11MB3627.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox