Re: [edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs

["Guo Dong" <guo.dong@intel.com>]

It is good to have a GitHub patch link. Please CC package maintainers,  or it might be filtered out.
Please separate this patch since it updated MdeModulePkg and UefiPayloadPkg.
Some generic comments on UEFI payload changes:
	Please update comments In PciPlatformDxe.c, e.g.:
	1) Driver description: "Implementation for a generic GOP driver.", this is not a GOP driver, and the OptionRom could from other cards.
	2)  Make comments more readable. E.g. 
		  //
		  // 0x30
		  //
	3) Add function description
	4) check function return status. E.g. I think PciPlatformPrepController() should return EFI_SUCCESS instead of EFI_UNSUPPORTED.

Thanks,
Guo

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcello
> Sylvester Bauer
> Sent: Monday, July 13, 2020 9:40 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs
> 
> Fix Option ROM enumeration and support scanning.
> 
> (Resent because of missing CC)
> 
> Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-
> Option_ROMs
> PR: https://github.com/tianocore/edk2/pull/790
> 
> Patrick Rudolph (2):
>   MdeModulePkg: Fix OptionROM scanning
>   UefiPayloadPkg: Scan for Option ROMs
> 
>  UefiPayloadPkg/UefiPayloadPkgIa32.dsc                 |   1 +
>  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc              |   1 +
>  UefiPayloadPkg/UefiPayloadPkg.fdf                     |   1 +
>  UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf      |  46 +++
>  UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h        |  19 +
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c |  10 +-
>  UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c        | 365
> ++++++++++++++++++++
>  7 files changed, 439 insertions(+), 4 deletions(-)
>  create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf
>  create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h
>  create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c
> 
> --
> 2.27.0
> 
> 
>