From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.28314.1599591323882090318 for ; Tue, 08 Sep 2020 11:55:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Cdp2xwKS; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: guo.dong@intel.com) IronPort-SDR: 0GK3/lcK+tRLyworSvYEbNlSSBAvxorj34i8SdrkdqmYS6MizHpxgjvr2+6BBzQgGLHlDut/Vp VDchh4UT3nHw== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="155692948" X-IronPort-AV: E=Sophos;i="5.76,406,1592895600"; d="scan'208";a="155692948" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 11:55:22 -0700 IronPort-SDR: faABMvmpmYDtxaUgSJJlpp6e/zFXTzJvWv6QCenzPprGu7+YyEUJ3up7JsvgjOMbFtE9+xJhu6 v0RCr1NzoQyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,406,1592895600"; d="scan'208";a="505176323" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 08 Sep 2020 11:55:22 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 11:55:21 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 11:55:21 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 11:55:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eOeM9DOYc3hbCIdOPnXua4lfqIpyjtbDS87aiQ6Bhfj7qK8N+8cmGQpYwPM0qgmOWlED8NduRjN59H22wh05UwOIr76jQp5SHAy06EIQR18u9d+xbBts283Kzl3dSKX3ioLRtNEZBpNJ3jSvF25QA/fk7IbASlChyzispBY+0cHTPbfI5XNJr6FNkO6ZVsa0scjeDd/zVZ6mOWH0P6R97E8Iq6JM8qudXgRK8xZsbHlKjqQPXVKGOYr6OizyIbnJsy0oLPkn2ScHYkP92qMbJ0+upX10hvPuYzja6rJ9j1CltrZUs2MxXw+4F1d2E4yCMcGpIfzNhv+43n+eJRzGgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fmouHWyNAJ88LnCczqAxLGov4IRdUp1ZTgicrYftO7c=; b=D7U1EpTUfm3IWIZYqsUVZlJU4hJPna9/bnuNsztQvRhbLwXg6VOFExBoau4+PhHc0rlZR2wBZiiCBMkZS/DAgqCruIytwK8fFKbwglygAwBJHKaQMVFMk56DeB02XDxNeu4e5HsmM+Hb+w+ofnBLm19ihgrHaL15UWfnEcFhoz6o3MHDXGPklTGjltjdugxiUCtlwq4ADsttYo6V+dGnpy+cMk4B+/prhzHfSEcg0rpNdLlg5Hv9C13a8m8c2mQ/9pgmWEsiDuQen0xV6nOvntvK0vWDHI8VjxZdKgpgpd8rPG4y9HtCGQ8Hnav/5GEkH6uOptmZ9mkUkNOZLTL0qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fmouHWyNAJ88LnCczqAxLGov4IRdUp1ZTgicrYftO7c=; b=Cdp2xwKSyyaRxCqLkUZAr4R471lCo+Tn+Fo5xSvjeqH4PegMFAHA0h/1qzGD0j/WeiWZA60Qo7x0QMSuI7qE/+YgoUaD7JiUvYBvPRbmj3OfKsOTdW77xgUhN27pbNT546aIQozHmnaOXUB+7Tuc8VALhn+S0ipqv3VdaZRNyxo= Received: from DM6PR11MB3627.namprd11.prod.outlook.com (2603:10b6:5:13b::11) by DM6PR11MB4737.namprd11.prod.outlook.com (2603:10b6:5:2a2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Tue, 8 Sep 2020 18:55:13 +0000 Received: from DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::31e1:ea43:1322:e03c]) by DM6PR11MB3627.namprd11.prod.outlook.com ([fe80::31e1:ea43:1322:e03c%7]) with mapi id 15.20.3370.016; Tue, 8 Sep 2020 18:55:13 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "marcello.bauer@9elements.com" CC: "Ma, Maurice" , "You, Benjamin" Subject: Re: [edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs Thread-Topic: [edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs Thread-Index: AQHWWTRIf3JIWkaADUSkewFBmIpzfqlfY0fA Date: Tue, 8 Sep 2020 18:55:12 +0000 Message-ID: References: <20200713163944.9893-1-marcello.bauer@9elements.com> In-Reply-To: <20200713163944.9893-1-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.2.51.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b5a7c11-6281-4ee4-f070-08d85428b822 x-ms-traffictypediagnostic: DM6PR11MB4737: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZE5NWY6EUD+qQD5ImbY7VnD5m7WdTb8/hsKliKk+Uanj1WnmhtO4+IqDXXe3kTrKmCVwB21a6yEiF5Jg6mMlm/ofwjKIGicjlfM0dqZgd609LWHhycCmPt3gwbECyWcw1zfNXQMH0ln75Oz7zB91fPr8U7ooVFUOwK/38SViuyDGINFVSwGg2ujSpbh0aIARg/Oj5oE7WBVgYjXwuh2C83RvFYI8rGaOb/7m72xDuXmJDSlufZY6A2OIXuc035yDG5G3ulLpU9HGr7ouvpiX7buvCbEI6nYUnGcxsaNlJ8rLj+NKf3CsT1NJKXjvLQVxcjGT5ubyzai+o8OQQGEZ/KnHEYZTymPOYq7jntRO4kJEzFUrcJI58Y6jazvgvldhxF/ZDX+RiLwUEb543swbuQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3627.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(55016002)(53546011)(54906003)(186003)(6506007)(107886003)(966005)(26005)(19627235002)(5660300002)(8936002)(8676002)(7696005)(9686003)(110136005)(478600001)(316002)(4326008)(76116006)(52536014)(33656002)(64756008)(86362001)(66446008)(2906002)(71200400001)(66556008)(83380400001)(66476007)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: R7JYbaD5TVsAkzRN38Mcnr3ajGg0Lpu7KbmjMGggNah++rvYy8IzvxXlmI4mBiLPyGTtRFIRTFs+zMRNKTZYKI6yq2wrLyXHvWJpOZtuxBbs8QrkjQJxrq4UUeACErM1FSTx4lTBKwFtzRIyR1EUrfaawrC1mWAdjnb3Zh9FDtOyEGto+Xarfg0HsQ7tjgqrYwli7CToyu4E5bz5KOr/wxsaj82afSUgEqUID0bLChIUNRux3W31riP5tugRhaLg9YJ3Ut5ZhwKuSjhd+yTuW+lALzLmqvVLN5nZ1/ZeCwEUVwQ/G1ojub6IVumuZE0INT3UUSPNA7Mc3HnOIqi+ZDU0gfiazzrmGeEG2ZuHpHO0VgsciaelyN5OjHTBH68tn0p1YvxXvJaUubDj/m341YhJ3dOXqvlPZsVjljuLUxuCbdqIU/x5E4bNXC57N8RU94QudctTLRBYCzJiIA0YVV3hH1654IIiEoWMmpGZWo2r3XkCiguR+q7EWXwqVlB3Eoe6yW5jKvVRcG55/6aYOQgstirVvU3W38n8hZLKIo6yuC1n+oeDduVmmJEHE460QMT9CA6lhaDyWrIgK8ClpdSe1Ii+b3gEirw/G8n0VK1uQVRRxLly9QX1GakscTTCIPlCg4M2Evo9xwcF7V7rLg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3627.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5a7c11-6281-4ee4-f070-08d85428b822 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 18:55:13.5618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cQpEGq/UkkAB6oYT0kDsVZ5Ry1WY0f0091nx4Gw/PoYDx5sSbugxmsR4Je61/OF9UJyDBXLpeJfDNimM3y2kTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4737 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It is good to have a GitHub patch link. Please CC package maintainers, or= it might be filtered out. Please separate this patch since it updated MdeModulePkg and UefiPayloadPk= g. Some generic comments on UEFI payload changes: Please update comments In PciPlatformDxe.c, e.g.: 1) Driver description: "Implementation for a generic GOP driver.", this i= s not a GOP driver, and the OptionRom could from other cards. 2) Make comments more readable. E.g.=20 =09 // =09 // 0x30 =09 // 3) Add function description 4) check function return status. E.g. I think PciPlatformPrepController()= should return EFI_SUCCESS instead of EFI_UNSUPPORTED. Thanks, Guo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Monday, July 13, 2020 9:40 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROM= s >=20 > Fix Option ROM enumeration and support scanning. >=20 > (Resent because of missing CC) >=20 > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg- > Option_ROMs > PR: https://github.com/tianocore/edk2/pull/790 >=20 > Patrick Rudolph (2): > MdeModulePkg: Fix OptionROM scanning > UefiPayloadPkg: Scan for Option ROMs >=20 > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkg.fdf | 1 + > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf | 46 +++ > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h | 19 + > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 +- > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c | 365 > ++++++++++++++++++++ > 7 files changed, 439 insertions(+), 4 deletions(-) > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c >=20 > -- > 2.27.0 >=20 >=20 >=20