From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.1255.1587143047501473533 for ; Fri, 17 Apr 2020 10:04:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=orGGby+l; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ashley.e.desimone@intel.com) IronPort-SDR: fP7ycS9xzBKyaO0FCAU5mjf+O/yhQ3Y2sob+imGtAR0ynAy5GUOL93lWGisAXrzOFGQ/RwVabk 9Zq3Not2WCig== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 10:04:05 -0700 IronPort-SDR: l4krrAHsV9eQaNpTX2gAK29k5tdskOudU3mzRi2O1KqVURBZ0SByXSq3EdYiioJ670YFlVdH2a jKcLOE6DhUvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="289324277" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga002.fm.intel.com with ESMTP; 17 Apr 2020 10:04:03 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 10:04:03 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 10:04:03 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 10:04:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Au8KXU2dQJvgu2O7Xp+AjDugFvDlAHNuDJPLJFOlOE9BW2ldBPDf+X49vJpIZ5lU1yiMbgKxDuHR/GcKMcWx06RgtrnplgdGW+yq1nZTzBrolrgxFG1WJsJSNO2KmtVl2WXl8qe2ZNUpijsRY78JXih9bqszHiPQGcGg42HDUuo/G7TNx/td/I8cCyRgugdKTokUN43r67XMiWcI7V2kwoae693JflS7c+0T1nQevnPUVrmF4vDa/z6AIx2iLg431hmD+a3Z4mQ5BzwLBGsV5EYMxUI0muc4T/5PMNhM6wdtEfESYmynWP4wncZunJaEnOkrQATrPU5tNXIEWN1/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUozdeTsptyge3WBIzMXxy+oqP/kwfuTFIp5DTwovtI=; b=UUOLFqiXzFysdtWEYmow4wney99+mIV31BPW31Y82uBkGQHrSe426bx1ZiHqCeZrdax0PIZtZJblCGrF2j+dG/sKBlrhno5kLXe6aGGPdS60AKDq9m8Va9Ra9w5CAn3qsg2dl01WFCINKqgxT9Au+PgJARt9UxG2pS+y5MyqRLZYNfqCLAc6ck//k4izZzAP5UmrutscS6iAJYv/kkXGGaDI50Nu11ln8zwbM2acis4a0xmaKkq8EmnTMuqMLkpETfQSAlWPS46HHVG9TneZHlGAXWi63ISUm4azeofi8n8rFUqoE8TBDnT2CIvd3kdNSLYTprUxLquWIw+Dxx8Yzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gUozdeTsptyge3WBIzMXxy+oqP/kwfuTFIp5DTwovtI=; b=orGGby+lDHPUZi65KFNDiyXSYgX/6DSeB6HVIqv65BLN+kQ4GfBMsppzoilqImT2F+zoE1evdWlr8FfRHWQbsRgyI20iJAbgv0FbrtMEYLKe4gC2GqhvqH3SVoIEHDIXIV1Pkw/q1O+b7zMMw712cLD+0IS3Xab6XvbgD1oeOiM= Received: from DM6PR11MB3628.namprd11.prod.outlook.com (2603:10b6:5:144::25) by DM6PR11MB3083.namprd11.prod.outlook.com (2603:10b6:5:65::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Fri, 17 Apr 2020 17:04:01 +0000 Received: from DM6PR11MB3628.namprd11.prod.outlook.com ([fe80::2c41:705f:b0ee:e36c]) by DM6PR11MB3628.namprd11.prod.outlook.com ([fe80::2c41:705f:b0ee:e36c%5]) with mapi id 15.20.2921.027; Fri, 17 Apr 2020 17:04:01 +0000 From: "Ashley E Desimone" To: "Bjorge, Erik C" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH 4/6] EdkRepo: Add manifest_repo_props() Thread-Topic: [edk2-staging/EdkRepo] [PATCH 4/6] EdkRepo: Add manifest_repo_props() Thread-Index: AQHWFGi8zMFhvaDMA0ysK+/VYwwNGah9aoGAgAAgw5A= Date: Fri, 17 Apr 2020 17:04:01 +0000 Message-ID: References: <20200417033123.34972-1-ashley.e.desimone@intel.com> <20200417033123.34972-5-ashley.e.desimone@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashley.e.desimone@intel.com; x-originating-ip: [192.55.52.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e3a44f6-9051-4b3e-232a-08d7e2f153de x-ms-traffictypediagnostic: DM6PR11MB3083: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0376ECF4DD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3628.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(396003)(366004)(376002)(136003)(346002)(39860400002)(7696005)(86362001)(2906002)(76116006)(8676002)(6506007)(55016002)(478600001)(26005)(53546011)(186003)(8936002)(66946007)(66446008)(64756008)(9686003)(33656002)(52536014)(71200400001)(66476007)(110136005)(4326008)(54906003)(81156014)(66556008)(5660300002)(107886003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4SkSFTgu6mQreC/nvtkqxayqz+2fT9jSq0kCIQ6D4NqzcGYQXNfly+jCOUmz30Ku6qKww3YbmBM7QjwD5tuWHAaZDmKYJIGQs26qkGUnjUcPo7R9NPFePQ+48Vdob5tdaSj5kgU9dlGsVYppLvIVQY0pkv4gtoIvUOiQYkJcbxbNRKFV9M9x1lJ804DNCfYoYzTkIHCO83O85oAK8nQ0sUqUG6r8+AyU4snaHUvvfCMFLWTo8zUcj06Jmbc5T/x0M19ENBcvUPqSMOdo7Kxrsv/XRi7xeb6sX+yThuVOs+vVOS/hc7Ang3ajg0Tk+NlpH+wMGZd4jn3WVRh4q4elNrV5aCNsAkwLM54N7KxiHSkjJvfiSgGZoiDaXlR7tYzQFrAOX0xoVtpWZ0sh2q1TzzPl6sKvYTrHVEoamBFCUigGuYN+kLEI3rsA7OUqwGgO x-ms-exchange-antispam-messagedata: t5OCws1VU12hT6k8yV/LE1vhdQ03dbV8sTY4MXeh1gI/rIeSYjASzQFUToc9kMZM2Tr2wX4xc1olXRi1GDcWRAqjCock3WbA1uDkWf3iXFVS1LgCM1JG/t7+1a66BePokVk/95jH3h9FPDP+Wsh/yw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2e3a44f6-9051-4b3e-232a-08d7e2f153de X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2020 17:04:01.7607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y4hVMvCHcF1P6CRM35mplCnPrFDFJ6fIvKbRhlMGlwSVqjBs7khotBL8vS4wJ08TqTWkw5Sh1aSIo2WUN6Yad8rCE4HmdQ29UnYnirmy8qA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3083 Return-Path: ashley.e.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am going to go with it was a long day. I will send out an updated patch s= et for review taking your feedback into account. Thanks, Ashley -----Original Message----- From: Bjorge, Erik C =20 Sent: Friday, April 17, 2020 8:09 AM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman= , Prince Subject: RE: [edk2-staging/EdkRepo] [PATCH 4/6] EdkRepo: Add manifest_repo_= props() Why is this not a list comprehension? return [x for x in self.prop_list if manifest_repo in x.name] -----Original Message----- From: Desimone, Ashley E =20 Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barke= lew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 4/6] EdkRepo: Add manifest_repo_prop= s() Add the manifest_repo_props() function to the BaseConfig class which return= s a list of all CfgProp objects for a given manifest repository. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/config/config_factory.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_facto= ry.py index 6f89589..e053f8b 100644 --- a/edkrepo/config/config_factory.py +++ b/edkrepo/config/config_factory.py @@ -118,6 +118,17 @@ class BaseConfig(): """Returns a list of available manifest repos""" if self.cfg.has_section('manifest-repos'): return self.cfg.options('manifest-repos') + =20 + def manifest_repo_props(self, manifest_repo): + """ + Returns a list of cfg_prop objects that pertain to a given manifes= t + repo + """ + repo_props =3D [] + for prop in self.prop_list: + if manifest_repo in prop.name: + repo_props.append(prop) + return repo_props =20 class GlobalConfig(BaseConfig): """ -- 2.16.2.windows.1