Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/7] EdkRepo: Adding support for archiving combos

["Desimone, Ashley E" <ashley.e.desimone@intel.com>]

Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Tuesday, March 31, 2020 3:42 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/7] EdkRepo: Adding support for archiving combos

Adding support to check the archived attribute on branch combos.  This allows a combo to be archived and available if required but not dirty up the combo list.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
---
 edkrepo_manifest_parser/edk_manifest.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/edkrepo_manifest_parser/edk_manifest.py b/edkrepo_manifest_parser/edk_manifest.py
index dd3512b..7b513dc 100644
--- a/edkrepo_manifest_parser/edk_manifest.py
+++ b/edkrepo_manifest_parser/edk_manifest.py
@@ -306,7 +306,11 @@ class ManifestXml(BaseXmlHelper):
 
     @property
     def combinations(self):
-        return self._tuple_list(self.__combinations.values())
+        return self._tuple_list([x for x in 
+ self.__combinations.values() if not x.archived])
+
+    @property
+    def archived_combinations(self):
+        return self._tuple_list([x for x in 
+ self.__combinations.values() if x.archived])
 
     def get_repo_sources(self, combo_name):
         if combo_name in self.__combo_sources:
@@ -645,6 +649,10 @@ class _Combination():
             self.description = element.attrib['description']
         except:
             self.description = None   #description is optional attribute
+        try:
+            self.archived = (element.attrib['archived'].lower() == 'true')
+        except:
+            self.archived = False
 
     @property
     def tuple(self):
--
2.21.0.windows.1