* [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL [not found] <cover.1703641932.git.junfengx.guan@intel.com> @ 2023-12-27 1:56 ` Junfeng Guan 2024-01-11 2:18 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 4+ messages in thread From: Junfeng Guan @ 2023-12-27 1:56 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Yi Li Refer to Uefi spec 2.10 section 13.19.5, update the label definitions for NVDIMM SPA location cookie. Signed-off-by: Junfeng Guan <junfengx.guan@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Yi Li <yi1.li@intel.com> --- MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h b/MdePkg/Include/Protocol/NvdimmLabel.h index e46999a3ab4a..2352c9bd1652 100644 --- a/MdePkg/Include/Protocol/NvdimmLabel.h +++ b/MdePkg/Include/Protocol/NvdimmLabel.h @@ -122,6 +122,12 @@ typedef struct { /// #define EFI_NVDIMM_LABEL_FLAGS_UPDATING 0x00000008 +/// +/// When set, the SPALocationCookie in the namespace label is valid and should match the +/// current value in the NFIT SPA Range Structure. +/// +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND 0x00000010 + typedef struct { /// /// Unique Label Identifier UUID per RFC 4122. @@ -196,10 +202,18 @@ typedef struct { /// EFI_GUID AddressAbstractionGuid; + /// + /// When creating the label, this value is set to the value from the NFIT SPA Range Structure if the + /// SPALocationCookie flag (bit 2) is set. If EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the SPALocationCookie + /// value stored in the namespace label should match the current value in the NFIT SPA Range Structure. + /// Otherwise, the data may not be read correctly. + /// + UINT64 SPALocationCookie; + /// /// Shall be 0. /// - UINT8 Reserved1[88]; + UINT8 Reserved1[80]; /// /// 64-bit Fletcher64 checksum of all fields in this Label. -- 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112934): https://edk2.groups.io/g/devel/message/112934 Mute This Topic: https://groups.io/mt/103394864/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL 2023-12-27 1:56 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Junfeng Guan @ 2024-01-11 2:18 ` gaoliming via groups.io 2024-01-11 7:54 ` Junfeng Guan 0 siblings, 1 reply; 4+ messages in thread From: gaoliming via groups.io @ 2024-01-11 2:18 UTC (permalink / raw) To: devel, junfengx.guan Cc: 'Michael D Kinney', 'Zhiguang Liu', 'Yi Li' Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan > 发送时间: 2023年12月27日 9:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li > <yi1.li@intel.com> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the > EFI_NVDIMM_LABEL > > Refer to Uefi spec 2.10 section 13.19.5, update the label definitions > for NVDIMM SPA location cookie. > > Signed-off-by: Junfeng Guan <junfengx.guan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Yi Li <yi1.li@intel.com> > --- > MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h > b/MdePkg/Include/Protocol/NvdimmLabel.h > index e46999a3ab4a..2352c9bd1652 100644 > --- a/MdePkg/Include/Protocol/NvdimmLabel.h > +++ b/MdePkg/Include/Protocol/NvdimmLabel.h > @@ -122,6 +122,12 @@ typedef struct { > /// > #define EFI_NVDIMM_LABEL_FLAGS_UPDATING 0x00000008 > > +/// > +/// When set, the SPALocationCookie in the namespace label is valid and > should match the > +/// current value in the NFIT SPA Range Structure. > +/// > +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND 0x00000010 > + > typedef struct { > /// > /// Unique Label Identifier UUID per RFC 4122. > @@ -196,10 +202,18 @@ typedef struct { > /// > EFI_GUID AddressAbstractionGuid; > > + /// > + /// When creating the label, this value is set to the value from the NFIT > SPA Range Structure if the > + /// SPALocationCookie flag (bit 2) is set. If > EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the > SPALocationCookie > + /// value stored in the namespace label should match the current value in > the NFIT SPA Range Structure. > + /// Otherwise, the data may not be read correctly. > + /// > + UINT64 SPALocationCookie; > + > /// > /// Shall be 0. > /// > - UINT8 Reserved1[88]; > + UINT8 Reserved1[80]; > > /// > /// 64-bit Fletcher64 checksum of all fields in this Label. > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113572): https://edk2.groups.io/g/devel/message/113572 Mute This Topic: https://groups.io/mt/103655517/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL 2024-01-11 2:18 ` 回复: " gaoliming via groups.io @ 2024-01-11 7:54 ` Junfeng Guan 2024-01-16 0:58 ` Junfeng Guan 0 siblings, 1 reply; 4+ messages in thread From: Junfeng Guan @ 2024-01-11 7:54 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1 Hi Liming, Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5191 Could you help push it? B.R. Junfeng -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Thursday, January 11, 2024 10:19 AM To: devel@edk2.groups.io; Guan, JunfengX <junfengx.guan@intel.com> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan > 发送时间: 2023年12月27日 9:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi > Li <yi1.li@intel.com> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of > the EFI_NVDIMM_LABEL > > Refer to Uefi spec 2.10 section 13.19.5, update the label definitions > for NVDIMM SPA location cookie. > > Signed-off-by: Junfeng Guan <junfengx.guan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Yi Li <yi1.li@intel.com> > --- > MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h > b/MdePkg/Include/Protocol/NvdimmLabel.h > index e46999a3ab4a..2352c9bd1652 100644 > --- a/MdePkg/Include/Protocol/NvdimmLabel.h > +++ b/MdePkg/Include/Protocol/NvdimmLabel.h > @@ -122,6 +122,12 @@ typedef struct { > /// > #define EFI_NVDIMM_LABEL_FLAGS_UPDATING 0x00000008 > > +/// > +/// When set, the SPALocationCookie in the namespace label is valid > +and > should match the > +/// current value in the NFIT SPA Range Structure. > +/// > +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND 0x00000010 > + > typedef struct { > /// > /// Unique Label Identifier UUID per RFC 4122. > @@ -196,10 +202,18 @@ typedef struct { > /// > EFI_GUID AddressAbstractionGuid; > > + /// > + /// When creating the label, this value is set to the value from > + the NFIT > SPA Range Structure if the > + /// SPALocationCookie flag (bit 2) is set. If > EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the SPALocationCookie > + /// value stored in the namespace label should match the current > + value in > the NFIT SPA Range Structure. > + /// Otherwise, the data may not be read correctly. > + /// > + UINT64 SPALocationCookie; > + > /// > /// Shall be 0. > /// > - UINT8 Reserved1[88]; > + UINT8 Reserved1[80]; > > /// > /// 64-bit Fletcher64 checksum of all fields in this Label. > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113592): https://edk2.groups.io/g/devel/message/113592 Mute This Topic: https://groups.io/mt/103658299/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL 2024-01-11 7:54 ` Junfeng Guan @ 2024-01-16 0:58 ` Junfeng Guan 0 siblings, 0 replies; 4+ messages in thread From: Junfeng Guan @ 2024-01-16 0:58 UTC (permalink / raw) To: gaoliming, devel@edk2.groups.io; +Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1 Hi Liming, Would you like help to push this PR: https://github.com/tianocore/edk2/pull/5191 Thanks. B.R. Junfeng -----Original Message----- From: Guan, JunfengX Sent: Thursday, January 11, 2024 3:55 PM To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <Zhiguang.Liu@intel.com>; Li, Yi1 <yi1.li@intel.com> Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Hi Liming, Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5191 Could you help push it? B.R. Junfeng -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Thursday, January 11, 2024 10:19 AM To: devel@edk2.groups.io; Guan, JunfengX <junfengx.guan@intel.com> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan > 发送时间: 2023年12月27日 9:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi > Li <yi1.li@intel.com> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of > the EFI_NVDIMM_LABEL > > Refer to Uefi spec 2.10 section 13.19.5, update the label definitions > for NVDIMM SPA location cookie. > > Signed-off-by: Junfeng Guan <junfengx.guan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Yi Li <yi1.li@intel.com> > --- > MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h > b/MdePkg/Include/Protocol/NvdimmLabel.h > index e46999a3ab4a..2352c9bd1652 100644 > --- a/MdePkg/Include/Protocol/NvdimmLabel.h > +++ b/MdePkg/Include/Protocol/NvdimmLabel.h > @@ -122,6 +122,12 @@ typedef struct { > /// > #define EFI_NVDIMM_LABEL_FLAGS_UPDATING 0x00000008 > > +/// > +/// When set, the SPALocationCookie in the namespace label is valid > +and > should match the > +/// current value in the NFIT SPA Range Structure. > +/// > +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND 0x00000010 > + > typedef struct { > /// > /// Unique Label Identifier UUID per RFC 4122. > @@ -196,10 +202,18 @@ typedef struct { > /// > EFI_GUID AddressAbstractionGuid; > > + /// > + /// When creating the label, this value is set to the value from > + the NFIT > SPA Range Structure if the > + /// SPALocationCookie flag (bit 2) is set. If > EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the SPALocationCookie > + /// value stored in the namespace label should match the current > + value in > the NFIT SPA Range Structure. > + /// Otherwise, the data may not be read correctly. > + /// > + UINT64 SPALocationCookie; > + > /// > /// Shall be 0. > /// > - UINT8 Reserved1[88]; > + UINT8 Reserved1[80]; > > /// > /// 64-bit Fletcher64 checksum of all fields in this Label. > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113857): https://edk2.groups.io/g/devel/message/113857 Mute This Topic: https://groups.io/mt/103658299/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-16 4:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1703641932.git.junfengx.guan@intel.com>
2023-12-27 1:56 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Junfeng Guan
2024-01-11 2:18 ` 回复: " gaoliming via groups.io
2024-01-11 7:54 ` Junfeng Guan
2024-01-16 0:58 ` Junfeng Guan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox