From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.9587.1597214276972421636 for ; Tue, 11 Aug 2020 23:37:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=K4TEc9TG; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) IronPort-SDR: lgwdxWX/S01zQ5JiUy8BLiRA/GrfpmQJByBpKS0WVWAOLB4wAXPRN0Y9EyrQLtlM+sHqXPMHHz obDxjitedB6w== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="153866354" X-IronPort-AV: E=Sophos;i="5.76,303,1592895600"; d="scan'208";a="153866354" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 23:37:56 -0700 IronPort-SDR: Fv6vA0Fb1luUORJ0zWZR0VD8YKIW1IKniop6cHEataTwM7oFrFjqX3nqAiBzit39kkhPWKrVei QAI4PMegM10w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,303,1592895600"; d="scan'208";a="324982886" Received: from unknown (HELO fmsmsx604.amr.corp.intel.com) ([10.18.84.214]) by orsmga008.jf.intel.com with ESMTP; 11 Aug 2020 23:37:55 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 23:37:54 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 23:37:54 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 23:37:55 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 23:37:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bkrjkbqKkY6IeI56FzeKU9NyDLb4or9+cB+pRq1i39PgqRL52hDdTDZ3EuoZR0CnRWabJ8lLk5YUnoY0zVqDF1lS1xtwIXsV4k31+Gwl0p3fLMpOlENelX+nM5PgOneHarF+npBE15Mh9/SQoDgjWPupwULwRFlSKe31oWBfGdpSruFC451/9pPo8isvN6IAXkzwR6Iaqjo3X1bSGVIqy64APM889T6xoKpjqBYfPXmqfu9dHBTYnh16AY6vrGoS8coKHbmJKnacrbyeveUC3BTRe66zaYxBVxKYnk5vPsxFm8H/Xx6LjQSU8PkgcjFf7QXMglWywtFH0kUIOiGuuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mblhlVmAEsGy3Vti2Wx/VzvPbyyDCtoP2pmzjumQhQs=; b=iIfWJcW4UzMHCMrqE8zDxgkk3tmNG0HdPDVDvByGaXwr1/alhZpJSGjS7Y03E0e3buEOIapdJNLweNetxsYJte6fQsd9lyVczbC5Pgh2bMxamdaaW47tmR3v/EOpWTCTbUMmAIsfPUbhwK0gRmPVaLAcmodUw6Xr6Bpl5sxGXtUvVRZhtAqtgYMWKpLNdP8PIW7ENyO2DKAU3t8k3pO/e62R4Xy369RN+DeXzdoRtLM3+uwv+msQAZnyjXLdXJrvwBu+nr87YdXPYGDJo8IP7aOuTCW3l2DasiqMNVudf12gGC5N7UBM8cfNBxEcECuQ/znMwH8lQkSdkksrQBQPCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mblhlVmAEsGy3Vti2Wx/VzvPbyyDCtoP2pmzjumQhQs=; b=K4TEc9TG95K/2HY1g85n2rrhxuFiZzA7NKKXRWaQjNED2Nktli/JzoRmkknmNqzmVuLpkRNfr5bf2hvGjFRiISArfr72YQ+qUD6ryH85L+9nsf8q+Z1Oj+UfpA8ggOf4voU2aVkMSnuk3SUyO6N0YbceyUDj7inRa39TCptIAPM= Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by DM6PR11MB2618.namprd11.prod.outlook.com (2603:10b6:5:c0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Wed, 12 Aug 2020 06:37:51 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::5111:3ecb:21f:eeb6]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::5111:3ecb:21f:eeb6%7]) with mapi id 15.20.3283.015; Wed, 12 Aug 2020 06:37:51 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Ni, Ray" , "Gary Lin" , Andrew Fish Subject: Re: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Thread-Topic: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Thread-Index: AQHWcEbwAuxfy8wEq02v8oVYzwrkDak0BYug Date: Wed, 12 Aug 2020 06:37:51 +0000 Message-ID: References: <20200812012124.18220-1-zhichao.gao@intel.com> <20200812012124.18220-2-zhichao.gao@intel.com> In-Reply-To: <20200812012124.18220-2-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6cdcc4f0-b209-4873-1a95-08d83e8a3cc2 x-ms-traffictypediagnostic: DM6PR11MB2618: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i6cbiujTKWAHzvE5ZgyGfauEzNUEn8G/uAQVibJ04LRmvljMnw5Narh5E055UVTQWkWSZbfmR9pAzX37ZsopR2tdG+lnrLpCkXckY+haPBQeuwLJs43jgPUsTBS6WN2R0p19appwQd0lImdLKM8r8wiCqhsxxUEp0tTru8c876pRpwRpkkG/599oZhcJDN7gX+beb/MdCiAQTe0FcrBPKzJIO2FvW1G7hRyNcEkb9susw6u3XKXGc4YLr4EYYc3PB8e/FPkS4ut8CvBpoSzk8Pierk6ijpUFxmASrJXA4QWU61FQf5bX29gmviaxA8KrQ7EQF6J+nf86Q1Qq3h/SYDI9xCXWLs54kLmC4XhkOXuQd8xZEOf66FGYof6emTRLsExtR5EzQUmc7HmVehjgIA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3673.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(8936002)(33656002)(66556008)(53546011)(52536014)(64756008)(4326008)(76116006)(66446008)(6636002)(26005)(186003)(8676002)(66476007)(5660300002)(6506007)(66946007)(2906002)(478600001)(86362001)(54906003)(966005)(71200400001)(316002)(9686003)(83380400001)(55016002)(110136005)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: P6crkBAY9MY1xMb26eMzhrUY5emHyqwOkeKWkOSQgZK4KDxTBLyUrOQE8Y3YaWlz47EQ2077sLXAeg0zhew3g+bpAcCqfyEci3TlOVoQHybU1Swx+EOSv+PjZO3b39NbvLPOD+L/m1V9r+JsltxchZ5+AqfYM1CjRDS4sU25y5DfZvfhqkLKBIwRHrbHvw4D6oroeFQ20gk6v4h5PCKA0leyoYop8wBsa+YL8w7V6gh2LWpiGEfrYhLzpNPtSK5IRQ95eMLHuIyp0aPlLTXAGea5xuHIR0jEBZmjsQtzzYNu1G8okSW+GpOX6dqBtw8vSnbNtOyzyEzSl7csfKPXK74Z1BLqsxGwGluHIjx9u8wu/TF5uovouUPE3alvN/cybpCfes7iOxbzJrKo0GTHbBCym1lkmwZsRIVG6m13KG39rqS1fQd21CdCWw6j19ZFKEq8bgf0lMVTzWIEdbknJHbMtNPeEX81TwB3znkt5ejlCZ2FrdzurKSxsdIbno7c+a0/hcLyfhh0PieF3BMUXJm9LyTufVvGEbi5pBvGQJpcnXDXtekjUlYMWXif0yznTjsS2ct135HZ9NaZ9PPRAwg29wlwHCHzTJUoedSxdrUfAxUBlNrGFIavbh2TRa51o9j2icc/XPmEFEjZNkXoKA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cdcc4f0-b209-4873-1a95-08d83e8a3cc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 06:37:51.7508 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5nuv6YJ8N0mtPTy5KJlWtP6vLOhrmSOZ5serN38UyFBvCReNVq4TR1MxIHQoVu2EAA+4vcyzi3LAIc+k9AGC+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2618 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, August 12, 2020 9:21 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > ; Ni, Ray ; Gary Lin > ; Andrew Fish > Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put the > UDF check ahead of MBR >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 >=20 > Refer to UEFI spec 2.8, Section 13.3.2, a block device should be scanned= as > below order: > 1. GPT > 2. ISO 9660 (El Torito) (UDF should aslo be here) 3. MBR 4. no partition= found > Note: UDF is using the same boot method as CD, so put it in the same pri= ority > with ISO 9660. >=20 > This would also solve the issue that ISO image with MBR would be treat a= s > MBR device instead of CD/DVD. That would make the behavior of the image > boot different: > If the CD/DVD's MBR be handled correctly, it would be enumerated as a > bootable device with MBR path and FAT filesystem. Some Linux Distributio= ns > boot from such path (FAT with MBR path for ISO) would come into the grub > console instead of the installation selection. > With this change, the CD/DVD would always be enumerated with CD path. > And it would always boot to the installation selection. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Gary Lin > Cc: Andrew Fish > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > index 6a43c3cafb..473e091320 100644 > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c > @@ -35,11 +35,19 @@ EFI_DRIVER_BINDING_PROTOCOL > gPartitionDriverBinding =3D { >=20 > // > // Prioritized function list to detect partition table. > +// Refer to UEFI Spec 13.3.2 Partition Discovery, the block device // > +should be scanned in below order: > +// 1. GPT > +// 2. ISO 9660 (El Torito) (or UDF) > +// 3. MBR > +// 4. no partiton found > +// Note: UDF is using a same method as booting from CD-ROM, so put it > along > +// with CD-ROM check. > // > PARTITION_DETECT_ROUTINE mPartitionDetectRoutineTable[] =3D { > PartitionInstallGptChildHandles, > - PartitionInstallMbrChildHandles, > PartitionInstallUdfChildHandles, > + PartitionInstallMbrChildHandles, Reviewed-by: Hao A Wu Best Regards, Hao Wu > NULL > }; >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20