From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.2776.1611278243270319283 for ; Thu, 21 Jan 2021 17:17:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qWZgFplQ; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) IronPort-SDR: hgsKNk6CThPtNL7MbznNSrtw57ZTUvsyN727vz60ShwFciRlyZrgqTkFgitxOh6MV+NyWM/Tky t5LxJkYGnfuw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240911575" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="240911575" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 17:17:14 -0800 IronPort-SDR: 9KLAsK5jewIg1FA+XB7SwHn3K0p1m17K6L3PGgW+l4NYB0eVb7mEzeSIbhXnV2dx1H124rADIr ENdVx5n2meXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="403415867" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 21 Jan 2021 17:17:14 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 17:17:12 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Jan 2021 17:17:12 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 21 Jan 2021 17:17:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxd6ZCD7KctDoe9X6Siim99B3KNqKTQ2mj36z72gDgyxK/OGetaqkwWA3CEXAdOShdzdTNlj/qsMlO7y8tY3SdQCu114LmYaZ9+cJ09+Kob3jtYDRaYVYfyMyqbgVQcETfFSbVJklo0IKbzMX7B3yLEhqaKdhW0AeDDoabZkpCX53XWGgk/jkHC5pW7ZacU16mEgXx1vxZo4/UWdEG28butyUOduABxIDnHzV4HaCF0Z7DJ8VrpqsaGhn9b0AGr7dqYPIC7odJDu52mUnR83rHQaZHVJ+Dnkc5ROznotsEsTx97jMbES86coAP3JeI73jRxZ4ijBRtS/JLUjEQqpRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4DrV5sYgpQJbrimML/rjSu7us37DKCyAtJ6MshnNpB8=; b=eFswfXGEK+2jNfsh98SfO2oYKYc+cOxqQ2QFwzm3OClkODy0f7o5zfYNjO68Sa4EjpLu2C8u4zXb4UdCRHaekmczUDY/3HAlBDgURvs978LbcBvckSNimM9t9hp0KKND7V1AKW1zqd/Rhd8MG4uxxLqESVsCl8RAuS9I0CmW2uiFHIrxH/6RZ4oGTygTWCotLamoLjDmHg6H6kxesgFNOm5n+scQCIwUg33bFPn5BUKUTP7qenSER33PlEiyJq3aHtZPgfmirVRwW7srC6Cu+sHtpqv7QwMVuqERqhdhV3va2afXQu9s/biogdG8GsEJRL0zM0r98CAGy4RkBlBKkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4DrV5sYgpQJbrimML/rjSu7us37DKCyAtJ6MshnNpB8=; b=qWZgFplQrhnHQuB22K7nym4cz6vGfLeh6+dnQhGRkrJVckYgPEz+/9g+8wMbHIGMhgBhSJ7zqR9vmbHt+ngLyB0c1bgFANnT8ZkHurek3MD4DkxuIyBeSp0Ub/W2oL5TSbmuVEWVzzUzUCFrIEq0TMFDCLPf/U7+GMRGGVzJGG0= Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by DM5PR11MB1834.namprd11.prod.outlook.com (2603:10b6:3:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Fri, 22 Jan 2021 01:17:09 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::f1d6:c7b3:7879:efa1]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::f1d6:c7b3:7879:efa1%3]) with mapi id 15.20.3763.014; Fri, 22 Jan 2021 01:17:09 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "patrick.rudolph@9elements.com" CC: "Wang, Jian J" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Usb/Keyboard.c: remove Get/SetConfig calls Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/Usb/Keyboard.c: remove Get/SetConfig calls Thread-Index: AQHW70Uz4Wx1+oYINkm77U8hbRVd9qoy2aRQ Date: Fri, 22 Jan 2021 01:17:09 +0000 Message-ID: References: <20210120155900.3343123-1-patrick.rudolph@9elements.com> In-Reply-To: <20210120155900.3343123-1-patrick.rudolph@9elements.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5b0c4be-0b00-49ac-7c5a-08d8be7370fe x-ms-traffictypediagnostic: DM5PR11MB1834: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: anvSTKTszooo+huUrxFBSszmYQN57rDjYZcyT6AR9P7UmSkXKbab0KOFgUliay8XRcAtES3t7k3K1Pm2sY6N0hs55K1kiERARUcC+ejJNfmN9ul9TgElyDfQZA+tgRVNOvsC6A7cqaRkRdAd4Vj5MgyxBMDlivgAR7xxt7v1rYzZN2zSv/dFhmZPIvWANftyM5DBmeu5EMibfkI7Z5aegcfTl33yhfK/HSylFzQvMJjMQEzFl8hLaLz3ouD0ckMxProZwgH0NDq+wo2zxdwCH4rSK1v6zALfGWuDRgT6nJhHdqK5YoyCG5rxFkbpgN7x2PD785NhKUWHJp9FojuiHT90VFfdx91a7+q+kRULDtqHqnel2+KJnoNpNBEG2A2zxTYTtFuue5Tzf3POzt1reN20TerNYkmA4BbOFmX+9zvI+zISipcyQ2bYPqFPEYAWGe0PFyIJ43RbRMJHZu3+BQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3673.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(71200400001)(54906003)(53546011)(6506007)(2906002)(966005)(83380400001)(33656002)(4326008)(110136005)(8936002)(478600001)(66446008)(26005)(52536014)(316002)(8676002)(55016002)(66946007)(64756008)(66476007)(66556008)(7696005)(9686003)(86362001)(186003)(107886003)(76116006)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?VLa30ArGTMG5EFYuec6GuLMyXBL4uZM99FI/kCfe/MLkeB2eUk4YiqgnY0xk?= =?us-ascii?Q?jo5Miz0z2nhoba573+wi+FxgmruSsLl0StQAoyoCyI5Y/sNTXrIUO1KePp0I?= =?us-ascii?Q?V6+PD0UO7l4/deRbPHCvvtvEpTpnFvkatDxBZM5RK3Yne0EoAAdmsQnPqqIR?= =?us-ascii?Q?KYw3lkWC2SIvvil9MoetMfclIAJK2NBCQH2FvF5G2UQgS17G7zz2FfUTXNoL?= =?us-ascii?Q?QhF4oxkfGuW2wgaXe9kr0itiXv7t2d39karfTN+SNsZ1OvFQQ+D2S69MNeZ8?= =?us-ascii?Q?ycuFIrRh2Cu83t+qzYyE26w/7RuogzVSkLWIeKNt7WOYpVA2DlP3dI9vIo6r?= =?us-ascii?Q?omquTXA2ZSGm1vBJKyke/I7qO1dabyFa17KKidSZi0f8bb28S1v9ae8uD5YP?= =?us-ascii?Q?4st8BgZNl3AjCt7QCZzGtBXQbpBSyjT9vHHdqz6Qb5bEkpBO7ST+//pSxYvH?= =?us-ascii?Q?IR+0HkApwED7t+qOIfe80WR49kEXhvIlebqC79wGOynat0RhVivdsA7EedGs?= =?us-ascii?Q?Y1W4admnEpVR1Ra/9MzzTJyjyyFsAkwYXfSWSKxpIRxex32LUF94N08/5HDx?= =?us-ascii?Q?up59p+5FtxgDjJyQKeArybRO5PpVPaIAnAfHhIs79PNqoLFtVTsa/gr+hVZh?= =?us-ascii?Q?DCfCB5k1vMdHPaaiwg7BvjmIkznKhulG3g8UtqH1wj2QVDNYbA5lvV6LhZDX?= =?us-ascii?Q?cTjvQoTWsW+LCi2CdAsmF3W9NiYMdSiIGdos9kI+v+TtHr4reIQzhAF9y4hL?= =?us-ascii?Q?VCve90V47XaoL9dYuG8EH4Hrj7kaSpoZ27lhhUmS3TFIt02dGNvVmRbTSJ/w?= =?us-ascii?Q?YzESGD1KaeyMUGsd20JhqzioZjlZVyosvWaN1FWsi8RhJbTaXjmuuuulcmox?= =?us-ascii?Q?/uXrhqqBWS5UK3ph4eWa39E+5zDgln/feyzJUNkYfiyLH9GzXDIc6hZel2OP?= =?us-ascii?Q?KQBO88X7YYPjMmMwHKX9Nf+1qZfzOCtYposiZG4CEWV7velV0B46QWH1W3B2?= =?us-ascii?Q?S+SV?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5b0c4be-0b00-49ac-7c5a-08d8be7370fe X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 01:17:09.8588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rx5MRr1o/x3SY2WHgjjE56Juws4nyvJ5gSQeYwgO3Av69pu6JiPTxoGXvCWDIas8ax540a9ZfoYo+/QZeQXJPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1834 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, please grant me some time for this patch series. I will try to provi= de feedbacks before end of next week. Meanwhile, could you help to provide the information on what kind of tests = have been performed for these 2 patches? Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Patrick > Rudolph > Sent: Wednesday, January 20, 2021 11:59 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/Usb/Keyboard.c: > remove Get/SetConfig calls >=20 > From: Matt DeVillier >=20 > SetConfig is already called during device enumeration, > no need to do it again here. >=20 > Signed-off-by: Matt DeVillier > --- > MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 37 -------------------- > 1 file changed, 37 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c > b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c > index 5faf82ea57..77e20b203f 100644 > --- a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c > +++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c > @@ -801,10 +801,8 @@ InitUSBKeyboard ( > IN OUT USB_KB_DEV *UsbKeyboardDevice >=20 > ) >=20 > { >=20 > - UINT16 ConfigValue; >=20 > UINT8 Protocol; >=20 > EFI_STATUS Status; >=20 > - UINT32 TransferResult; >=20 >=20 >=20 > REPORT_STATUS_CODE_WITH_DEVICE_PATH ( >=20 > EFI_PROGRESS_CODE, >=20 > @@ -816,41 +814,6 @@ InitUSBKeyboard ( > InitQueue (&UsbKeyboardDevice->EfiKeyQueue, sizeof (EFI_KEY_DATA)); >=20 > InitQueue (&UsbKeyboardDevice->EfiKeyQueueForNotify, sizeof > (EFI_KEY_DATA)); >=20 >=20 >=20 > - // >=20 > - // Use the config out of the descriptor >=20 > - // Assumed the first config is the correct one and this is not always = the case >=20 > - // >=20 > - Status =3D UsbGetConfiguration ( >=20 > - UsbKeyboardDevice->UsbIo, >=20 > - &ConfigValue, >=20 > - &TransferResult >=20 > - ); >=20 > - if (EFI_ERROR (Status)) { >=20 > - ConfigValue =3D 0x01; >=20 > - // >=20 > - // Uses default configuration to configure the USB Keyboard device. >=20 > - // >=20 > - Status =3D UsbSetConfiguration ( >=20 > - UsbKeyboardDevice->UsbIo, >=20 > - ConfigValue, >=20 > - &TransferResult >=20 > - ); >=20 > - if (EFI_ERROR (Status)) { >=20 > - // >=20 > - // If configuration could not be set here, it means >=20 > - // the keyboard interface has some errors and could >=20 > - // not be initialized >=20 > - // >=20 > - REPORT_STATUS_CODE_WITH_DEVICE_PATH ( >=20 > - EFI_ERROR_CODE | EFI_ERROR_MINOR, >=20 > - (EFI_PERIPHERAL_KEYBOARD | EFI_P_EC_INTERFACE_ERROR), >=20 > - UsbKeyboardDevice->DevicePath >=20 > - ); >=20 > - >=20 > - return EFI_DEVICE_ERROR; >=20 > - } >=20 > - } >=20 > - >=20 > UsbGetProtocolRequest ( >=20 > UsbKeyboardDevice->UsbIo, >=20 > UsbKeyboardDevice->InterfaceDescriptor.InterfaceNumber, >=20 > -- > 2.26.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#70585): https://edk2.groups.io/g/devel/message/70585 > Mute This Topic: https://groups.io/mt/79981643/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20