Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.

["Xue, ShengfengX" <shengfengx.xue@intel.com>]

Hi Zhichao,

It's OK for me, thank you very much for this suggestion and merger code.


Best Regards,
Roy
Phone/WeChat: 13584008328

-----Original Message-----
From: Gao, Zhichao <zhichao.gao@intel.com> 
Sent: Monday, August 15, 2022 9:47 AM
To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Xue, Shengfeng <xueshengfeng@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Xue, ShengfengX <shengfengx.xue@intel.com>
Subject: RE: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.

The commit message should be limited within 72 characters.
Suggest the new titile "ShellPkg/SmbiosView: Display extended memory info in smbiosview -t 17"

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, 
> Zhichao
> Sent: Tuesday, August 9, 2022 5:57 PM
> To: Xue, Shengfeng <xueshengfeng@byosoft.com.cn>; 
> devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Xue, ShengfengX 
> <shengfengx.xue@intel.com>
> Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool 
> is not show Extended Speed and Extended Configured Memory Speed in 
> type 17.
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: xueshengfeng <xueshengfeng@byosoft.com.cn>
> > Sent: Saturday, August 6, 2022 10:02 AM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao 
> > <zhichao.gao@intel.com>
> > Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Xue, ShengfengX 
> > <shengfengx.xue@intel.com>
> > Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show 
> > Extended Speed and Extended Configured Memory Speed in type 17.
> >
> > From: Shengfengx Xue <shengfengx.xue@intel.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014
> >
> > if Configured Memory Speed is 65,535 MT/s or greater, and the actual 
> > speed is stored in the Extended Configured Memory Speed field. but 
> > current Smbiosview have no this logic.
> >
> > Signed-off-by: Shengfengx Xue <shengfengx.xue@intel.com>
> > ---
> >  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> > index a0ee286c9a..0ab9f5063a 100644
> > ---
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> > +++
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> > @@ -878,6 +878,11 @@ SmbiosPrintStructure (
> >          }
> >        }
> >
> > +      if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> > +        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> > +        PRINT_STRUCT_VALUE_H (Struct, Type17,
> > ExtendedConfiguredMemorySpeed);
> > +      }
> > +
> >        break;
> >
> >      //
> > --
> > 2.26.2.windows.1
> >
> 
> 
> 
> 
>