From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.11918.1660528428545261456 for ; Sun, 14 Aug 2022 18:53:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XVNgNhL4; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: shengfengx.xue@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660528428; x=1692064428; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+PLlL88P7S0BxX2szEZ8mn+SeR8BaH+OGOjG/3jGPPo=; b=XVNgNhL43Pk+D8jEISfSi1cSEYzKIyD04eiN/x3AWey+BV124NEkycYQ gVvW6SoTHaW8j735yUJffAiq4p2H0ih3Reg62Jd5qS/zXS2yYjHpXQtdo s4t2H1/c85Y7vpyIlsRO2t9+9OJ4nf9AyPjLcLC4eURFPqdm/6s6ZLuTx jU6mGul8VRBVDzE0G1dThJ45h9g8Bbdiu14osrpWwChFs5gtxEP9Jdb79 MWtcArg/T4CG/z4V5CMY7hoH66a7KeG0rTrO/tXbVlBlxaG4EeMV/Niy5 OhKTEvemmSZkWvTuEt6gnJytOgELXmIHkcGVpOQ/lCKE3m122f42pZtMD Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="272264114" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="272264114" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 18:53:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="582715480" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 14 Aug 2022 18:53:47 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 14 Aug 2022 18:53:47 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 14 Aug 2022 18:53:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 14 Aug 2022 18:53:46 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 14 Aug 2022 18:53:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ib1bnlVEYKMt1VETNPeFrojK1INs7vt6e38+ZIZi3dhbbLeD+EbfT1Tw16HJcVzrCXviQD6KYz61X2+/vZ4L+l0gfTcpRCjgUtuYXO3dUkVoBhlu47JBbGICM/xiv2EKvRYFWUj6HoScjZAmv9V5T5MvIrzvcdxldGaHgPceHg+cwECvncA02q/5Vw5qE499P/dlGlORCnfliw8UqBwI+1UIQonHRcEYdXYFwkEKF5dfqISAwjOjPrmdsxNb6fWm3xWENUKDIwsyz1DlCIcZ9K9amc/aelKcOIMF4Y8lqtlJjygi6OIkhDu9xikzNgNevTCS9U++inImAgZOy8qmxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJ9T3sk5P0G+bedVpVvjBkO5F1HFSXZFGd08F9fPx/w=; b=A6Gk6NTuHImUwgnrLglbI46T9qD7KKmVK/7nGY+Mf5zImE6F0xDmq4+nBkFqZMdWeafXGIgerZLcQ2qtWHjBSsGe7bOE7gJOAtWRd1ZhE6wg8/ocyrNbbSNkKRo99G2osOdwSbe0ORuTBWiwEWLvkT1bq5WFDWUxjJtXRB2Jk95E6e5+t1pez8pixojoqdz87tTAc2XIJEQES/MSVZqSwYHbgfFTq8UYoGHoUl+yWn5OS3LAf1Ibs/J8BbLBn75jG1MdReL0KRQYbp889JoAy1pShY3rObSKviQYvcIBoli2UR0SJ9x+WEfjEu2f7BUJwzEmJJDqAvoLbLQGv9yCzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3706.namprd11.prod.outlook.com (2603:10b6:5:13e::28) by MN2PR11MB3615.namprd11.prod.outlook.com (2603:10b6:208:ec::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Mon, 15 Aug 2022 01:53:45 +0000 Received: from DM6PR11MB3706.namprd11.prod.outlook.com ([fe80::e006:a555:8e6d:fff7]) by DM6PR11MB3706.namprd11.prod.outlook.com ([fe80::e006:a555:8e6d:fff7%7]) with mapi id 15.20.5504.028; Mon, 15 Aug 2022 01:53:44 +0000 From: "Xue, ShengfengX" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Xue, Shengfeng" , "Ni, Ray" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17. Thread-Topic: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17. Thread-Index: AQHYqTi2rw8Xm4S33ESqu5kVp9uIqq2mWkfggAjkdxCAAAI+cA== Date: Mon, 15 Aug 2022 01:53:44 +0000 Message-ID: References: <2fcf297e06328cd25e92756b7fd13ed39cb9231b.1659749541.git.shengfengx.xue@intel.com> <1709A4B7A944DF88.7247@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55f2d73e-a195-445f-0b64-08da7e60fca2 x-ms-traffictypediagnostic: MN2PR11MB3615:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qLQTQR+iJH9wz26JMEO0y4PnqoT2oQWVckyq0hITSdl9rSi8vxg150n6eXGbb1jGxr6VXRp//Wdg+I8UQgSNxkjbrh/dFZxJvgvQ5w0LKgMP7MG0hsurAIk/HYznA0U5I1S13NMqZKbLi7wNY2un7EyXhD9fhG5cthtG1MFwxGfuNh0Ol6RB/yaSiiy3GjprTYEhP5KjcRpLisUHL+j2UUIa2veWPHG1QYwGy9XIFvBTPNmXDK9975ZhuWhzi7xuNmOC8st4X3ARDj1YVrICoXqNu51T4xA8NpjcI+i0bahovqXRlWwIYTRZs9L1cwOMpaAYzSs46FyaDXiBrEUnp6MWV0oeq9m2tOxnsChThWN4Ix4KOLmLz1oipkeueyuaPE7/Vuu3ukJkkobe1PCn7PIZe+It08m86H5wI5/q62z/68F7AW4GTUg5V7vW7EGUG8eXzRzExTSXcdfmly6x1K1NBJV8Ztwj7c7Ug3ubVoP/9YkZzvg/cuTj+oIzwo3EeZZPh/8Uef5rj2OBKYIbCdWXAkGl/bYwQTpb1uyMWx4pr5uknxvAwU5Z8oxAMr3U5GLEkYW1Eh5BC7qPTLWeHQFVWjnrHw8pV/Vka9yOPllKz1Z3zpxdrJx5RwzJtZPnfqPhg4V542JaP+maNcifzK0wHhNKghKhd/vIAdr0vTYLXhREOU04KAw9Un16R0KRxlrkBxqSy/SBRroyhME3B8K0mp1VOLcBkiK9NCotJ6sr7X+mXXepn8PD/dGsFLCaXiFzcEVLBTnSP6LK+wKwA0JbRv3SmekeK9eZM2eMGwXSKMbLPtINHpAP7aTKSOQN0X9VTqJKbBCcb2Yvn4diaqnoYkBy9zD1cNzIlQV3Ih3S78yM2QtNSp0jSfR+rC7D x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3706.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(376002)(136003)(366004)(38070700005)(82960400001)(122000001)(38100700002)(110136005)(6636002)(71200400001)(55016003)(316002)(53546011)(2906002)(5660300002)(41300700001)(33656002)(52536014)(6506007)(7696005)(8676002)(8936002)(76116006)(26005)(66476007)(66946007)(66556008)(66446008)(64756008)(9686003)(4326008)(966005)(86362001)(478600001)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3QqqRS8C+DRFnZr3v6UjfRg+5OHAzx0reOce48kr82T9p2BS1kFr3v41Cx9G?= =?us-ascii?Q?KD1DRgulTWHzQlnsmQt6CnHtKo2SBaNgEB7dTQgWuE5VSXJuORcru7wkUfLy?= =?us-ascii?Q?v0dQL6I6Zlr2ynNVnMquDywrkQr014Of01YsJKYQFoqddzlmK6v1rQdUuQkG?= =?us-ascii?Q?TQGr/GwG3QJL7aC2iyn2U4tg6TXaUZWPBPrCuc2RizuNNL1lN0g/yPClEdpn?= =?us-ascii?Q?ADVlI7AOBZq65l0+RP3ii0azoSsi5/+2cg2waeAh7EDIV/WDqPXgk3fMN7cn?= =?us-ascii?Q?fOfyj0oqqotMhe/SNi9I+1WGsRqnAwdO2AdzrHdqnvL89mBzbnwDbI1ju0Fx?= =?us-ascii?Q?4o1ADkpQ4fGELdneXWVBPIgB2QyEXuo6rRuonozsNUnLvtxaEcoGccAI3x+5?= =?us-ascii?Q?I7rsvXUcFm2ZamolmG3PMywV2WbuawXYYQ1JgDqKCSJooruamKu4wzkYuiuU?= =?us-ascii?Q?9pRwpqUWkeEaz1n302Rs8Aml2XoxoETkdAHyHFBS4EQ2d2F6m3k9unHMahR7?= =?us-ascii?Q?sTb0VnxyPZfYQc33wuC6pE9SKEwpJnQidrPPhFuPCnrVzZsZ+r+HuT6/ggYH?= =?us-ascii?Q?RkFkJ4IMXyV1bOLTWol0vdLrRxxPfmV09KASs7jhd2egoKksNn0ZYuav0+s7?= =?us-ascii?Q?doIlMegUDPmtHPFBmRtvLmnz/tAVP5a/f4/ZD2WoyxDlk+Hm251gXuiYOqTn?= =?us-ascii?Q?W8yJ3w13ep3q81w7l//mLdX+jfrPfEtJdcKXpIlJ9diAdDv8meZXcUbKKaNX?= =?us-ascii?Q?cwc19VdJ+IwRlQsnyGbm4Nyo8jIo4ddaay/QvVDjqx0/78Pmdc7m2/sHgSsn?= =?us-ascii?Q?n0OEb2XcNQd3xVPkvSYQnimnZW/+F+MAAig2kT/gDqcfg0MF1l5FDj55VZ9S?= =?us-ascii?Q?t02rZjAn5A3dn+aqsFDmzJiP7ZpDrMBqQ0la4Qxee4m4yWPUWuO9NIbBu5gy?= =?us-ascii?Q?iun6UNxoZ4IONfereWCGXXECYCeeHPgwbrb7/H8QtNrCkvISePucK+dH3uSU?= =?us-ascii?Q?XAPUOM/Lxio1Qvs9YSqmo1TQmEhrBz4D3dUBtYYEUmRtoaFF5HWKLTMt85rV?= =?us-ascii?Q?wY0ndd4UNZ+iXdlH4wxpViiMs2ZXE/+q8aaEOEYA95riUGf3oXRzi+PgR3en?= =?us-ascii?Q?fWfSFIbxiyisXuBlRe6hKF75c3IroY/MDdFu43vyQPVacblXA9AMg01o32lL?= =?us-ascii?Q?4TDbiS+xEsCNeD2cQ5h3Tc8YgPa+qa9LCkfoe4AZg1R/O2FK0mvZdtjk2iiQ?= =?us-ascii?Q?U8XlCcGUwVYM/i5uBTauPGNy9esYnQEkfRacPeMmjk8dAu4G5hqubtx2KTp+?= =?us-ascii?Q?GWDvEMNoLS7tbR7rt7dv1spOuvTICtG1xDfY8MUdI7sjPqEfSGomdKzd5zYC?= =?us-ascii?Q?LgMtEX4/BNC9vGzE7H8acgpwUOxlIDjlsCV4F4t2sO/9dkG2UCQ5QorGj5eR?= =?us-ascii?Q?Img//uMMyvHN5wBfBwaP+z9YAshWyXJ+oYat6uAsw8/ixxAU5PPmHx1oXO94?= =?us-ascii?Q?XjXmT8BqL2EsFXZeS9CWjKJKsuGt5ja7LjQmZd5yatBJ6+QVxHQ8Pvg1rLjc?= =?us-ascii?Q?xR5Oo46xpU74bXpj3xNUZrFtIAqZr+13x3nuukR9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3706.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55f2d73e-a195-445f-0b64-08da7e60fca2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 01:53:44.6316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: On9vXTlKVHnDVQiyr1vtCHayDIFhMe4uplPYvhEkTA0d4+FYy2cQLh2TipDiPKJeHvrBYFjnwUnC5Md0fgfuu4YOgSFk5IEGx5CiZBlbN9w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3615 Return-Path: shengfengx.xue@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Zhichao, It's OK for me, thank you very much for this suggestion and merger code. Best Regards, Roy Phone/WeChat: 13584008328 -----Original Message----- From: Gao, Zhichao =20 Sent: Monday, August 15, 2022 9:47 AM To: devel@edk2.groups.io; Gao, Zhichao ; Xue, Shengf= eng ; Ni, Ray Cc: Gao, Liming ; Xue, ShengfengX Subject: RE: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is n= ot show Extended Speed and Extended Configured Memory Speed in type 17. The commit message should be limited within 72 characters. Suggest the new titile "ShellPkg/SmbiosView: Display extended memory info i= n smbiosview -t 17" Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao,=20 > Zhichao > Sent: Tuesday, August 9, 2022 5:57 PM > To: Xue, Shengfeng ;=20 > devel@edk2.groups.io; Ni, Ray > Cc: Gao, Liming ; Xue, ShengfengX=20 > > Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool=20 > is not show Extended Speed and Extended Configured Memory Speed in=20 > type 17. >=20 > Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: xueshengfeng > > Sent: Saturday, August 6, 2022 10:02 AM > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao=20 > > > > Cc: Gao, Liming ; Xue, ShengfengX=20 > > > > Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show=20 > > Extended Speed and Extended Configured Memory Speed in type 17. > > > > From: Shengfengx Xue > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4014 > > > > if Configured Memory Speed is 65,535 MT/s or greater, and the actual=20 > > speed is stored in the Extended Configured Memory Speed field. but=20 > > current Smbiosview have no this logic. > > > > Signed-off-by: Shengfengx Xue > > --- > > .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > index a0ee286c9a..0ab9f5063a 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > @@ -878,6 +878,11 @@ SmbiosPrintStructure ( > > } > > } > > > > + if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)= ) { > > + PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed); > > + PRINT_STRUCT_VALUE_H (Struct, Type17, > > ExtendedConfiguredMemorySpeed); > > + } > > + > > break; > > > > // > > -- > > 2.26.2.windows.1 > > >=20 >=20 >=20 >=20 >=20