From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tqfJ0AVy; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 07 Oct 2019 18:09:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 18:09:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="193251390" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga007.fm.intel.com with ESMTP; 07 Oct 2019 18:09:35 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:09:35 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:09:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nxh6vyT8lwbQHwy59qJzf9buPPWc+PiHSLC7KKcASJz/KyTzpXrGhF6VV+KFUGNG3a10egBEHMlSqO3l3iKVHaNyfsyxdwiZWrwsC1TcuoQNKIiHzaAKNzrvXYtb8v1SfJZPaBKO7cTvaQo3uGUl2zd63SW5iyIFl65yfLjUBGkcyPHPsF3+zCxGdSwuP1pdn45np+ozcYyURzvQWP7Duh7Od/iXmbXB0ZVEGK4rnTD5iJpMiIpDYJkd0djbWBm4DjUcPB1+HGJojbbaVI2Cu4+jjF+bPuGN4OPOckOhG5FRW7ICtIU96GxCRyq0Mzv59XcOSeefUeFoqtskVjUPfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BchdkLsTtt2AJzumZkUB/V30YGAiwr1XrwWK+cMcVE=; b=E5oUElRwAtV3h0MZPndqBkrM3zQCmaczVMaArajQrD9GBRsaVXjZl3ZteQwITqojYNrgHHfQ7XCc3En1SMDvAgac8mbpl4dSwxb+rejyNjp2sCU5mU95wv9jsB+AqeCgpFhOkSWFRNzMkR9AuLCMkhsAe6f8fO3bcPDtc6fAEQA8itY4QcBmA7n0xX9fS1gFwkXaAhb7uIA1s46WhZ2Wpown+kEZiDR42W5xz77bzvbGo2Ogumfbi817EpnPh0+9HvrbDNmyiWGwc9im4DG6o69eWmqe1h074Tp/iZ0P2lzxc0Vm5UpvgtyxThWhSSIG8hhBTJM1mnaG6cOOZqO4Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BchdkLsTtt2AJzumZkUB/V30YGAiwr1XrwWK+cMcVE=; b=tqfJ0AVylRIJ1r5FiiJ3ScYopeWq48mmCeprRdeJxLFV42X5w83399WxhevfrRkHYatunlqT/XYQSimqGMZjYagY1K78XW8W/vRfLohtM+P7GX5JHhAyn+lMIeTRfEPG+tcPW2zGdGbTblXp7nQPRuHWyWxnFdRygeEzOLyW1Mo= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3818.namprd11.prod.outlook.com (20.179.17.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.25; Tue, 8 Oct 2019 01:09:32 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 01:09:31 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" Subject: Re: [edk2-platforms] [PATCH 2/5] KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM Thread-Topic: [edk2-platforms] [PATCH 2/5] KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM Thread-Index: AQHVei9m0zK0PQkS4020XzhvPkCdGadPyGkAgAAjppA= Date: Tue, 8 Oct 2019 01:09:31 +0000 Message-ID: References: <20191003211259.49664-1-prince.agyeman@intel.com> <20191003211259.49664-3-prince.agyeman@intel.com> <02A34F284D1DA44BB705E61F7180EF0AAEF33BF0@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AAEF33BF0@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODU4Yzg4YWYtNjBjMy00YTc5LTk3ZGMtY2U2NTIzZWRmNjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicmpINWxiOVpUdm1pNiswYWhFSHRoSWhzcDdqTGdzYldwcjhzd2ZQNHJMQ0pxeXp6MFloVWtPUlJuSHpjTjNteiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4aa1208e-555e-4cbb-cccb-08d74b8c2d02 x-ms-traffictypediagnostic: DM6PR11MB3818: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(366004)(396003)(39860400002)(376002)(136003)(346002)(13464003)(189003)(199004)(19627235002)(99286004)(71190400001)(74316002)(66946007)(110136005)(76116006)(7736002)(2906002)(66446008)(66556008)(305945005)(26005)(66476007)(64756008)(53546011)(186003)(52536014)(14454004)(256004)(5660300002)(3846002)(6116002)(71200400001)(102836004)(4326008)(14444005)(76176011)(6506007)(316002)(33656002)(7696005)(107886003)(86362001)(478600001)(6246003)(55016002)(9686003)(6436002)(229853002)(446003)(25786009)(81156014)(81166006)(8676002)(66066001)(2501003)(11346002)(486006)(476003)(8936002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3818;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OlQ3u1RgeSxL+3R9Vxrbisyyvj/YABNI+zeJe5YD3XNQjfDgllAM2AuMst5940OAVustaA9/LaGPjT1XQVzqu2j7CibDOyZoqf6zqn0FFpVf8FWhtZtWONUDzmJqC5AVTnwIz8HAbgCtiDW8qPPLzgON10oVTOLAtYddj9Pm8oFlkvSKjLr87X5qyG0aWEZF86sNswVZhtCORysq0tLSCKHf8ieTgKWxsqrLgzfXW/ExraDb70CeK8tyAKxvCdRnAW/QXenMtIQMFks/Bgq8IN/gmNlKeVYIBNzNgsePhumGErYgsFWKfB6Vb5oFmZniIah8+HyaVnYavCjXN154Bw/MpKeU427Iqrc4BrBcop7W4MfE88K8bKK5MqjC+k/Sa7W0lgtG4nk0a99uuafFK8As3iFDNRbcbIiQ8tW8ePE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa1208e-555e-4cbb-cccb-08d74b8c2d02 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 01:09:31.7198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ns2gC0sRA88/a7j5sklk6GT50zlrqggeA714UHoJw9uwZVUSfpaDWc6jgrO8Tm6JFdoWOnX8Xhp3pOZIj+rsleEaSg0HkttsdPRBIYMT3a8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3818 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For now, this is definitely possible. It may also be viable long term. The table is closely tied to the FV layout= which is standardized under Minimum Platform. Firmware volumes that may come and go = like those for a particular advanced feature would end up as child FVs under a FvAdvanced = parent that would be covered in the BIOS Info table. It seems that the FVs that will ev= entually be described in the table will remain fixed while their contents are customized by individu= al boards.=20 Also due to the FV standardization, the FVs that compose the IBB segment de= finition in the table for S-ACM verification/measurement can likely be consistent across the boar= ds in addition to the post-IBB FVs which leads to a standardized IBB/OBB definition. Some boards = within a package may have Boot Guard enabled while others don't but having the FVs identified as= IBB, post-IBB, or exclude from FIT in the table will not negatively impact the Boot Guard dis= abled case. I agree we should start with KabylakeOpenBoardPkg having a single copy of t= he PEIM used for all boards. Thanks, Michael > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Monday, October 7, 2019 3:27 PM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Sinha, Ankit ; Kubacki, Michael A > > Subject: RE: [edk2-platforms] [PATCH 2/5] > KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c > and Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > are identical files. Can we move this up to the parent KabylakeOpenBoardP= kg > and use one PEIM for both platforms? >=20 > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, October 3, 2019 2:13 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH 2/5] > KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM >=20 > Added BIOS Info PEIM to KabylakeRvp3 to publish the BIOS info HOB. This > PEIM currently publishs the board's microcode region info. >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../KabylakeRvp3/BiosInfo/BiosInfo.c | 93 +++++++++++++++++++ > .../KabylakeRvp3/BiosInfo/BiosInfo.inf | 48 ++++++++++ > .../KabylakeRvp3/OpenBoardPkg.dsc | 2 + > .../KabylakeRvp3/OpenBoardPkg.fdf | 1 + > 4 files changed, 144 insertions(+) > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c > new file mode 100644 > index 0000000000..6a058a0fc2 > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo > +++ .c > @@ -0,0 +1,93 @@ > +/** @file > + Driver for BIOS Info support. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define INDEXPORT_TO_ADDRESS(x) (x) > +#define DATAPORT_TO_ADDRESS(x) ((x) << 16) > +#define PORTWIDTH_TO_ADDRESS(x) ((x) << 32) > +#define PORTBITNUMBER_TO_ADDRESS(x) ((x) << 40) > +#define PORTINDEXNUMBER_TO_ADDRESS(x) ((x) << 48) > + > +// > +// Internal > +// > +#pragma pack (1) > + > +typedef struct { > + BIOS_INFO_HEADER Header; > + BIOS_INFO_STRUCT Entry[1]; > +} BIOS_INFO; > +#pragma pack () > + > +GLOBAL_REMOVE_IF_UNREFERENCED BIOS_INFO mBiosInfo =3D { > + { > + BIOS_INFO_SIGNATURE, > + 1, > + 0, > + }, > + { > + { > + FIT_TYPE_01_MICROCODE, > + BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION, > + 0x0100, > + FixedPcdGet32 (PcdFlashMicrocodeFvSize), > + FixedPcdGet32 (PcdFlashMicrocodeFvBase) > + } > + } > +}; > + > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_PPI_DESCRIPTOR > mBiosInfoPpiList > +=3D { > + EFI_PEI_PPI_DESCRIPTOR_PPI | > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST, > + &gBiosInfoGuid, > + &mBiosInfo > +}; > + > +/** > + Installs BiosInfo Ppi. > + > + @param FileHandle Handle of the file being invoked. > + @param PeiServices Describes the list of possible PEI Services. > + > + @retval EFI_SUCCESS Install the BiosInfo Ppi successfully. > + > +**/ > +EFI_STATUS > +EFIAPI > +BiosInfoEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + VOID *HobData; > + > + // > + // Install PPI, so that other PEI module can add dependency. > + // > + Status =3D PeiServicesInstallPpi (&mBiosInfoPpiList); ASSERT_EFI_ERRO= R > + (Status); > + > + // > + // Build hob, so that DXE module can also get the data. > + // > + HobData =3D BuildGuidHob (&gBiosInfoGuid, sizeof (mBiosInfo)); ASSERT > + (HobData !=3D NULL); if (HobData =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + CopyMem (HobData, &mBiosInfo, sizeof (mBiosInfo)); > + > + return EFI_SUCCESS; > +} > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.i > nf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.i > nf > new file mode 100644 > index 0000000000..94543408b1 > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo > +++ .inf > @@ -0,0 +1,48 @@ > +### @file > +# Module Information description file for BIOS Info Driver # # > +Copyright (c) 2019, Intel Corporation. All rights reserved.
# > +SPDX-License-Identifier: BSD-2-Clause-Patent ### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D BiosInfo > + FILE_GUID =3D C83BCE0E-6F16-4D3C-8D9F-4D6F5A03292= 9 > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D BiosInfoEntryPoint > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES IA32 X64 > +# > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + HobLib > + BaseMemoryLib > + DebugLib > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > + KabylakeSiliconPkg/SiPkg.dec > + KabylakeFspBinPkg/KabylakeFspBinPkg.dec > + BoardModulePkg/BoardModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + > +[Pcd] > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase ## > CONSUMES > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize ## CON= SUMES > + > +[Sources] > + BiosInfo.c > + > +[Guids] > + gBiosInfoGuid ## PRODUCES > + > +[Depex] > + TRUE > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 7090852192..ef69a19aa4 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -324,6 +324,8 @@ > } > !endif >=20 > + $(PROJECT)/BiosInfo/BiosInfo.inf > + > # > # Security > # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index 2b8eab36a1..81181710e6 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -242,6 +242,7 @@ INF > $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPreMem.i > nf > INF IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMe > m.inf > +INF $(PROJECT)/BiosInfo/BiosInfo.inf >=20 > [FV.FvPostMemoryUncompact] > BlockSize =3D $(FLASH_BLOCK_SIZE) > -- > 2.19.1.windows.1 >=20