From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=IGXdPOfn; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.a.kubacki@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Mon, 07 Oct 2019 18:31:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 18:31:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="187156651" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2019 18:31:45 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:31:45 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:31:45 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.56) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:31:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OR77OJ7yvgoIANRtPJ6D5NqTEovwfcUOS3pSpO6XJUvbgu9nAKf9X6Ncu0Xh5vkyfTkiCDGCYF9S8Mp9nx0L4naVjQX/Syb2r5Gwjw80eTAX1/aggjQ1bQFELOR93gXKSUKrQknog3C0AaL+FbGLzUmk7g6vZ7QRnq1rJm15Q/GXGMNHzyR4RrGavqqRKyhIilp5ylfQkWc8l+H4dZ9RYNwcfNv4yrGOp8tlQEyk9d7FHV7aRgP7zW2xyZR5PBgjO9SAeebOWuu0Ce2wFHaLUjjPT9gpw9+fdL4OKUqGCTC7vwUoRUUF610eTBnFu+6IqyRxe+ceYNOHbWb7s2I/8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3Co9Td2KuMiH7pq18mOCmX24CjueSF2KtgTAjEvVzw=; b=VJdclhdeQa5FXYmdMPrOdxzkDtXE8Q4yOrVToeyYEqkAMwmrnrsfCnlpEOUFm7d1DWM4GbrhtKjluE6V95Gu314JsR22ytp+DLq6eVcyllR+2amF0PVaHrHFgb5JVdeLB3jUwYNTAaQlCS6C0VAUI5bXCoHJp0nFlWU89dEiAv/stoNR4KhqliFzUKFHlyP7hqz6Ruym5TBg83IZpevmzbsptW6NC8yyRaW7M+5Qjrai0lASql26eyOXjW3KX06fPyDI+ua45cv5bVwQH7I9zOVkrswxu9ykkr82wT2Gut8Wwpc6YlH5/mSNWqkubgio/ZIu26pjFlNyxb7dhO25jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O3Co9Td2KuMiH7pq18mOCmX24CjueSF2KtgTAjEvVzw=; b=IGXdPOfnt7yQ55RpglTLH8ayrC+CUPqrgTEY4+JCMVtm3GGE/zhrGFBFbGk1tucILiNJecAhoxhNDXrMthciJJd4/WeRc+f6PzjqJCnlQOt9vbRpvfUGg7YFytI4Sq5iLAjIJ+YVvVEZ2Zcg29xfZqAUPFTOvvvmU6nrXDTb0pU= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3802.namprd11.prod.outlook.com (20.179.16.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 01:31:43 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 01:31:43 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" Subject: Re: [edk2-platforms] [PATCH 3/5] KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM Thread-Topic: [edk2-platforms] [PATCH 3/5] KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM Thread-Index: AQHVei9p12Jzk7YOxEqs62k3wohwradPyGqAgAAzTwA= Date: Tue, 8 Oct 2019 01:31:43 +0000 Message-ID: References: <20191003211259.49664-1-prince.agyeman@intel.com> <20191003211259.49664-4-prince.agyeman@intel.com> <02A34F284D1DA44BB705E61F7180EF0AAEF33BF8@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AAEF33BF8@ORSMSX114.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiMzM5ZDItMzcyMy00NTk4LTgyYmEtMDkwODViY2I0YzJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUUhXb1BDNzJEWVE2Zlg2VnVwT2Z0MlFiUlN5VWJrcEZKWVNpb21jRmI4WjZDNzQ5NWU1aVlUM0lmdTM5ZVhUYSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c7a03fd6-807b-4161-6ad9-08d74b8f46a2 x-ms-traffictypediagnostic: DM6PR11MB3802: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(346002)(136003)(39860400002)(189003)(199004)(13464003)(55016002)(76116006)(8676002)(99286004)(81156014)(7736002)(476003)(8936002)(66946007)(305945005)(66556008)(2501003)(66476007)(66446008)(64756008)(81166006)(86362001)(74316002)(9686003)(2906002)(52536014)(33656002)(5660300002)(186003)(6246003)(66066001)(26005)(229853002)(446003)(11346002)(486006)(102836004)(6506007)(7696005)(76176011)(53546011)(3846002)(6116002)(14454004)(107886003)(71190400001)(6436002)(256004)(19627235002)(4326008)(14444005)(25786009)(71200400001)(478600001)(110136005)(316002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3802;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yEfWcWDfW03/R1Ub9eXZvl5OVdIFD699cfByOBb/wjUpy3rGWt2e7v2y5gtfG/TuW7LfrUvssa1qjQ5UFms6i96YWNKA/RicJnU7xw3nJb52XGQjTNmSx3ERkzDawoxeUlTGyBA6GnZTEKKYRtqubfyLP5lBrVmzf6Qx3BWlSZRIUTD223HyDGHB1Bg7v0SGxG82w6PsDTg4+vAeo51s0qxaviTVoxZlZy7s0JNgonXsLTXBQlyvHSBEu9PchHQ82MEAnJEh9u97RyTBDvTDIHJj5QhlJKVLrk+GcwipiCT6VddJmosYtrTYFUZ6NAkgnk7KYK/hXGvs9ZaMUUQzyLAc4TPlFCMhlXtLql9GknDHQlrmStqm7FYb745D3Z7f9asx4ggIk9vJbbu1q1T197DMfUsjv8gukqP9qvD0Vh8= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c7a03fd6-807b-4161-6ad9-08d74b8f46a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 01:31:43.1741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q6vzkmX8i9qcpSLhETqcBCdcBbKvC57IbF/z1BUE2Vc8SikVWnT//USouSId451uQ0+swOUWBXMf5IeSHokp8N1BPyrjR7wu/QvS7vrLSfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3802 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable As mentioned in patch #2, the same PEIM can be used for KabylakeRvp3 and Ga= lagoPro3 for now. > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Monday, October 7, 2019 3:27 PM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Sinha, Ankit ; Kubacki, Michael A > > Subject: RE: [edk2-platforms] [PATCH 3/5] > KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM >=20 > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c > and Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > are identical files. Can we move this up to the parent KabylakeOpenBoardP= kg > and use one PEIM for both platforms? >=20 > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, October 3, 2019 2:13 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH 3/5] KabylakeOpenBoardPkg/GalagoPro3: > Add BiosInfo PEIM >=20 > Added BiosInfo PEIM to publish the > Bios Info HOB. Currently this PEIM publishes one Bios Info entry which is= the > microcode region information. >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../GalagoPro3/BiosInfo/BiosInfo.c | 92 +++++++++++++++++++ > .../GalagoPro3/BiosInfo/BiosInfo.inf | 48 ++++++++++ > .../GalagoPro3/OpenBoardPkg.dsc | 2 + > .../GalagoPro3/OpenBoardPkg.fdf | 1 + > 4 files changed, 143 insertions(+) > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > new file mode 100644 > index 0000000000..4db9d4685c > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c > @@ -0,0 +1,92 @@ > +/** @file > + Driver for BIOS Info support. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent **/ #include > +#include #include > +#include #include > +#include #include #include > + > + > +#define INDEXPORT_TO_ADDRESS(x) (x) > +#define DATAPORT_TO_ADDRESS(x) ((x) << 16) > +#define PORTWIDTH_TO_ADDRESS(x) ((x) << 32) > +#define PORTBITNUMBER_TO_ADDRESS(x) ((x) << 40) > +#define PORTINDEXNUMBER_TO_ADDRESS(x) ((x) << 48) > + > +// > +// Internal > +// > +#pragma pack (1) > + > +typedef struct { > + BIOS_INFO_HEADER Header; > + BIOS_INFO_STRUCT Entry[1]; > +} BIOS_INFO; > +#pragma pack () > + > +GLOBAL_REMOVE_IF_UNREFERENCED BIOS_INFO mBiosInfo =3D { > + { > + BIOS_INFO_SIGNATURE, > + 1, > + 0, > + }, > + { > + { > + FIT_TYPE_01_MICROCODE, > + BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION, > + 0x0100, > + FixedPcdGet32 (PcdFlashMicrocodeFvSize), > + FixedPcdGet32 (PcdFlashMicrocodeFvBase) > + } > + } > +}; > + > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_PPI_DESCRIPTOR > mBiosInfoPpiList > +=3D { > + EFI_PEI_PPI_DESCRIPTOR_PPI | > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST, > + &gBiosInfoGuid, > + &mBiosInfo > +}; > + > +/** > + Installs BiosInfo Ppi. > + > + @param FileHandle Handle of the file being invoked. > + @param PeiServices Describes the list of possible PEI Services. > + > + @retval EFI_SUCCESS Install the BiosInfo Ppi successfully. > + > +**/ > +EFI_STATUS > +EFIAPI > +BiosInfoEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + VOID *HobData; > + > + // > + // Install PPI, so that other PEI module can add dependency. > + // > + Status =3D PeiServicesInstallPpi (&mBiosInfoPpiList); ASSERT_EFI_ERRO= R > + (Status); > + > + // > + // Build hob, so that DXE module can also get the data. > + // > + HobData =3D BuildGuidHob (&gBiosInfoGuid, sizeof (mBiosInfo)); ASSERT > + (HobData !=3D NULL); if (HobData =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + CopyMem (HobData, &mBiosInfo, sizeof (mBiosInfo)); > + > + return EFI_SUCCESS; > +} > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.inf > new file mode 100644 > index 0000000000..a0e18cff9c > --- /dev/null > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.i > +++ nf > @@ -0,0 +1,48 @@ > +### @file > +# Module Information description file for BIOS Info Driver # # > +Copyright (c) 2019, Intel Corporation. All rights reserved.
# > +SPDX-License-Identifier: BSD-2-Clause-Patent ### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D BiosInfo > + FILE_GUID =3D 3132E669-D16B-4AA7-B09B-BC0EB5F40E1= F > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D BiosInfoEntryPoint > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES IA32 X64 > +# > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + HobLib > + BaseMemoryLib > + DebugLib > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > + KabylakeSiliconPkg/SiPkg.dec > + KabylakeFspBinPkg/KabylakeFspBinPkg.dec > + BoardModulePkg/BoardModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + > +[Pcd] > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase ## > CONSUMES > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize ## CON= SUMES > + > +[Sources] > + BiosInfo.c > + > +[Guids] > + gBiosInfoGuid ## PRODUCES > + > +[Depex] > + TRUE > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index d67e0cc000..64e25168c7 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -244,6 +244,8 @@ > } >=20 > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostM > em.inf >=20 > + $(PROJECT)/BiosInfo/BiosInfo.inf > + > # > # Security > # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index 56bb0edaad..a095c044a5 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -240,6 +240,7 @@ INF > $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf > INF > $(PROJECT)/Override/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformI > nitPei/PlatformInitPreMem.inf > INF IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMe > m.inf > +INF $(PROJECT)/BiosInfo/BiosInfo.inf >=20 > [FV.FvPostMemoryUncompact] > BlockSize =3D $(FLASH_BLOCK_SIZE) > -- > 2.19.1.windows.1 >=20