From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YzEWYdD+; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: michael.a.kubacki@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 07 Oct 2019 17:34:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 17:34:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="187147731" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2019 17:34:46 -0700 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 17:34:46 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX159.amr.corp.intel.com (10.22.240.24) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 17:34:45 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.54) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 17:34:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQK+pyOLrswz7B+RLwIrMA7iarzo7eQlgiHtLjFwNTPbs9vOwBSLEs3q2zXpypr7NmvSPijYc/4wZv4nU9aYlm0ppefez+KRYcDqaFfPZlNvzWQGWTUo7icryuj5vSpzQp3IpTYFI++ak6Jh2iGoBYTUUwixdh4f960lJCdBXRmMJ0yISc4ANeF/2LS5+U1lEPl4AuYM0kKFwOoC1Jyl8EjY7MeK3kYMfxwbmVXfndRkW3E5M6f+Rvx0LKnjklxxRPfUs4FkaD74a7ibbRuUBOQQne4lKor4jnepBmaySuhkI3YC0nNpiWP5BmTdw3GxML6aSe1KGX8h9m2QmXxLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+t4cyvlOTe1eIElhnKhJBK2+jaW6XXKWCF4lBE5VCWk=; b=eu4tpJH1rj7SKtqu5qONv5XwmhozxHoN4hU9koRaWeINzLNK5bujcs9R6fYGJJgBBTTYse19eB5zL4dqgRr/LYirg1S33gmIrhwwBGZwwZXTynWB1ZT4ULfmgTeNnpUHlyX7qWHEPyQbq++Cnz8CbkBAMNKikbWPo5aZoIltEca9Lw9LTENQnZJNXPTGUmX55avyxVqcVwiGRIvDPL5W9g7tggRtwQs0nhdD+hJM7PDUfhU38rVPVX128uegxXuME9PLGZum9Rqnxxw8RAH3wsby6adwZRKA2xDOeTJzOX8JdY4+mBepx99WOuY1XNB0/jE9MRohwE0xiRRAO/QAFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+t4cyvlOTe1eIElhnKhJBK2+jaW6XXKWCF4lBE5VCWk=; b=YzEWYdD+sfjnyNoux3lNl3a3AlMDhQSY9VV6qHkp9EJNVa5v2nRxkpMU9jUCDsUkCUTWxcEekk5DzYcw/E6viLFIqGyBDJJClQgw/FulQmgZXEEccYBXcsS9CWH+I05ypIKOEdahlJvGVPG7/grgxSlNe+5mRPJ/MyR8L+JNHxo= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3626.namprd11.prod.outlook.com (20.178.230.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 00:34:44 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 00:34:44 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB Thread-Topic: [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB Thread-Index: AQHVei9jNvLoIg0KoUGK1FjRak00AKdP6YPQ Date: Tue, 8 Oct 2019 00:34:44 +0000 Message-ID: References: <20191003211259.49664-1-prince.agyeman@intel.com> <20191003211259.49664-2-prince.agyeman@intel.com> In-Reply-To: <20191003211259.49664-2-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ExNmFlMjktNjYwYy00ZjQ0LThiMjgtYTBiOGYzOWNmMzI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZXlcLzNQTVFUR3Nhc2o1RjMwdFk3bkJhZVJsZDNcL2xiYkRHUmNOUkRicW10QzY0UHFWR1gwaGptQkhsQUlaVWRDIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbe8924a-c97b-42aa-ff1d-08d74b8750ac x-ms-traffictypediagnostic: DM6PR11MB3626: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(376002)(136003)(39860400002)(396003)(199004)(189003)(13464003)(9686003)(7736002)(2906002)(305945005)(55016002)(8676002)(86362001)(81166006)(66946007)(81156014)(76116006)(186003)(2501003)(64756008)(8936002)(66446008)(66476007)(66556008)(33656002)(52536014)(74316002)(5660300002)(6246003)(66066001)(99286004)(26005)(229853002)(446003)(11346002)(486006)(476003)(102836004)(71190400001)(4326008)(7696005)(76176011)(53546011)(6506007)(6116002)(3846002)(71200400001)(256004)(6436002)(110136005)(54906003)(316002)(25786009)(14444005)(478600001)(107886003)(14454004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3626;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AReqH5XY2b8d1f0Wfg5Rt6U0Y1B7uPRi7ufGLZmdJ7pBtr3sDXyBHlAiTs9HvniuX/EY0BI60+oGvqgH+D5msZdpGPjvBFhrChhIroBUZJ0LBjw1yWfUWZgjA0ieMxnftIOD8davMuzxi9Z6tLP0A/z1nGkiWr+4X9x32+dWOSiy8ohFDzbj07TGxYCtptHLWi/vHob+P3AonrSKPXZ0tU4bIdPVmYOBEmfP408Is+6+QitprY1pzljVubuj3ywJLgB2DvxRZI0v4ffX1fNYoF6jZ8+F5VOaCl3waAEDX32kHWVFEEf+zmt2AeE0Dn2KPzGziYhasJUKzkEx+ozmJ+gVSZsbiSHFER/jdwBqxQSBYs/dFmYLMy5/zRumMKn9pXo6yChxRIGEvpQfSfPCcRIvhb+6HGXgTt7zt8XjE5Y= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bbe8924a-c97b-42aa-ff1d-08d74b8750ac X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 00:34:44.1008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZS1+/At53Fr5A50aiCrRoIxEc8mSs9VnzI1fVsOfjlsC3lbZq4C3OlNIlSDEIDcJAn4iA4meegsIPNoxrNEuWfesq7Bg5ZzPO7qk7IWfNWk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3626 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Library/BiosInfo.h: 1. I think the file description can be more accurate and useful than "Driv= er for BIOS Info support." This header file is not a driver or restricted to any particular drive= r in this location. I would generalize the comment. 2. This file is not related to a library. Why was it placed in the Include= /Library directory? > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, October 3, 2019 2:13 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB >=20 > Added gBiosInfoGuid to be used to > publish BIOS information HOB which > is needed in FIT generation >=20 > Also added the Bios Info header > file BiosInfo.h >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/BoardModulePkg/BoardModulePkg.dec | 3 + > .../BoardModulePkg/Include/Library/BiosInfo.h | 62 > +++++++++++++++++++ > 2 files changed, 65 insertions(+) > create mode 100644 > Platform/Intel/BoardModulePkg/Include/Library/BiosInfo.h >=20 > diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > index 6f13945ca8..035427b2f5 100644 > --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > @@ -36,3 +36,6 @@ > [Guids] > ## Include Include/Guid/BiosId.h > gBiosIdGuid =3D { 0xC3E36D09, 0x8294, 0x4b97, { 0xA8, 0x57, 0xD5, 0x28= , 0x8F, > 0xE3, 0x3E, 0x28 } } > + > + ## GUID to publish BIOS information HOB gBiosInfoGuid =3D { > + 0x09d0d15c, 0xe9f0, 0x4dfc, {0x9e, 0x0b, 0x39, 0x33, 0x1f, 0xca, 0x66, > + 0x85} } > diff --git a/Platform/Intel/BoardModulePkg/Include/Library/BiosInfo.h > b/Platform/Intel/BoardModulePkg/Include/Library/BiosInfo.h > new file mode 100644 > index 0000000000..bba1c07bff > --- /dev/null > +++ b/Platform/Intel/BoardModulePkg/Include/Library/BiosInfo.h > @@ -0,0 +1,62 @@ > +/** @file > + > + Driver for BIOS Info support. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _BIOS_INFO_H_ > +#define _BIOS_INFO_H_ > + > +// > +// BIOS INFO data structure > +// This is self contained data structure for BIOS info for TXT // > +#pragma pack (1) #define BIOS_INFO_SIGNATURE SIGNATURE_64 ('$', 'B', > +'I', 'O', 'S', 'I', 'F', '$') typedef struct { > + UINT64 Signature; > + UINT32 EntryCount; > + UINT32 Reserved; > +//BIOS_INFO_STRUCT Struct[EntryCount]; } BIOS_INFO_HEADER; > + > +// > +// BIOS_INFO_STRUCT attributes > +// bits[0:3] means general attributes > +// bits[4:7] means type specific attributes // #define > +BIOS_INFO_STRUCT_ATTRIBUTE_GENERAL_EXCLUDE_FROM_FIT 0x01 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION > 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_POST_IBB 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_NON_IBB 0x20 > + > +typedef struct { > + // > + // FitTable entry type > + // > + UINT8 Type; > + // > + // BIOS_INFO_STRUCT attributes > + // > + UINT8 Attributes; > + // > + // FitTable entry version > + // > + UINT16 Version; > + // > + // FitTable entry real size > + // > + UINT32 Size; > + // > + // FitTable entry address > + // > + UINT64 Address; > +} BIOS_INFO_STRUCT; > + > +extern EFI_GUID gBiosInfoGuid; > + > +#pragma pack () > + > +#endif > -- > 2.19.1.windows.1