From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SWdckY+i; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.a.kubacki@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Fri, 04 Oct 2019 14:16:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2019 14:16:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,257,1566889200"; d="scan'208";a="276166543" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 04 Oct 2019 14:16:16 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 4 Oct 2019 14:16:16 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 4 Oct 2019 14:16:16 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 4 Oct 2019 14:16:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvOJCFOtRFMZklIbZ+SwoWO7CeRBneR2Rf9EGovcBeFSTcAgQZyx0BKeDTLV0WUysA1uLqEEA8yiFd6HYP0fOc3k0OniUJBYI82zBrtiGpojfRnCgTKUy6tOtzZuJ2++X0vK2vF29pXyEJgzqP3KASOSXxh8j0NKdUHe85+RKHf7j3RMqyUYv/gL59ealYIS+GWUTrg1TKdgGJyr5i3+2VVy3+kqHbJeoCi4+tVogEwohMWYrlXCc8vO9rirnA3IGS3B4h7ImZVoMZDdEjNA9EH4d11ersOmU8F54HgkyhaVwRcpQaXwMC7xAm9K9sLAbbwqaO5dESZk/5WXVKNENA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mhDbbntK5vWxJcqXrvUYoypmnVktFI0MOIFFODfbkf0=; b=n3UlxuNrOyrCALznYrNz+wuaRDrpBJayn8rv6bXycMoy79pvEAIdfSD0W8Zg+2tTNnUivAVMbxp4nhQTAE3WmuLQeGuMCsmVQP2CH2Pt0uYjPXOXH6ltmJMnzQZInlTjcayhqfEBqJXasapwZaUWpcKV3bHFmkeRAgZ8YqD973JqtzvBJMyoQSgd3hG+n+uyEg9u08gvKXHxSidr6hgz1GNFNOHhP/6Ov26FTgyiygHAjA7NsTU+vEA7XPo7jQGwXBZAq9ldRaR6Y0wpadzpP4nBXg0xt8sdDlgR/2wfDLlMlIyIPquVtwiHFzm5cRq599OxJhx8xn7UuHYwQwQvwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mhDbbntK5vWxJcqXrvUYoypmnVktFI0MOIFFODfbkf0=; b=SWdckY+iWera+YzOYadrY9qbLa5ZbOa6ZOMe0vV0Vx8W+H/8ygE/EAC0su8VfSJ/AJCvF+mJEqE6h5TucqcpR+f2/xDwYHys0V2HWhjTlJlOZV2ujjBgmqLuXS0vxu0FRtbDIIyK5es8odhtB1Y+iJ2vom0TBfCHqpOS868e1bo= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3770.namprd11.prod.outlook.com (20.179.16.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Fri, 4 Oct 2019 21:16:13 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2305.023; Fri, 4 Oct 2019 21:16:13 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Topic: [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Index: AQHVevBpS3eFuzR0gUKXgqog1S6nNqdK+8VQ Date: Fri, 4 Oct 2019 21:16:13 +0000 Message-ID: References: <20191004201417.5020-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20191004201417.5020-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWUxZjczNGQtM2NiNS00ZjUyLWFlYTUtMjA0Y2FlNzkxZGU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVUh1NmxIS2lCRnRQdUxoV1d5WityVVlteGc2RDhmd0t3TW1CWjd5cERTOEV6RTdGR0ZUQjgxaTdZdUtoWkVHQSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52776788-8f87-463d-96d7-08d749101610 x-ms-traffictypediagnostic: DM6PR11MB3770: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 018093A9B5 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(396003)(366004)(136003)(39860400002)(13464003)(189003)(199004)(26005)(316002)(52536014)(25786009)(66066001)(110136005)(186003)(81166006)(81156014)(8676002)(8936002)(6116002)(99286004)(76176011)(6506007)(2501003)(7696005)(14444005)(256004)(2906002)(53546011)(6246003)(54906003)(74316002)(107886003)(486006)(86362001)(476003)(305945005)(11346002)(7736002)(229853002)(3846002)(6436002)(9686003)(33656002)(446003)(55016002)(14454004)(5660300002)(66476007)(64756008)(66946007)(66556008)(66446008)(4326008)(478600001)(102836004)(76116006)(71190400001)(71200400001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3770;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wMwuT8NwwYFKLl00ZpJDYmeoGLhbkxOSOfmgXflfNSma6R/X8iKyn8mYZKLDjOYbwhCOV3ZogmLMkoOQEVXiXb+wBLmrlFpFjcjKimOlls6lZ4wuJ4LfUecuEW2euKHn6lABr1tvLxQ7GkqJzK3s05tRl2U04vvRYTulCIoWLUmf+oRWrEY5yVG03olI4UjGz3zShIFWHsbxdz4dRUp74p0fG1/RJInA621kQ1yTfuDFMKEJI82bBYcewniGhrcunhssK6MKqNHxsKn2c0oJ0FZ13zcPfN0hZUG7kVeNw4as2uPJjOzCIP8D7sQOWVLVVGbEIkvUvCZkYOrDYTXBi0R71YCthj1AhE3LWe6T0HYjQ7O8KkxUSzzCK2Ie0ZT0KRDgzJxwOcDfk5pVvWSk5CkvOrBYzTN0WjBrV4aA9UI= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 52776788-8f87-463d-96d7-08d749101610 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2019 21:16:13.2576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uedmtp6k8cP4L7f4caDXWalZdJ+Vr4+uVzH4uJSA2tutnFLY9HRKarVfaMLftzWhFEagDGS2y2tBDczT6Nhdmrb+9KEEbZJGPUECShRXt8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3770 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Friday, October 4, 2019 1:14 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in E= ISS > bit ASSERT >=20 > Current ASSERT logic checks that the EISS bit is still set after we clear= it. This is > incorrect, it should be checking that that the EISS bit is clear after we= clear it. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSp= iLib.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > index aadc367a9f..c34c378de2 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > @@ -184,7 +184,7 @@ DisableBiosWriteProtect ( > B_PCH_SPI_BC_WPD ); - ASSERT ((PciSegmentRead8 (SpiBaseAddress = + > R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) !=3D 0);+ ASSERT ((PciSegmentRead8 > (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) =3D=3D 0); return > EFI_SUCCESS; }-- > 2.23.0.windows.1