public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 0/5] Add FIT support using FitGen
Date: Tue, 8 Oct 2019 01:38:15 +0000	[thread overview]
Message-ID: <DM6PR11MB3834752D3F67951BCA8B2CA7B59A0@DM6PR11MB3834.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191003211259.49664-1-prince.agyeman@intel.com>

* Please include the version number in the subject.

* Although minor, the commit description unnecessarily varies between commits.
   It would be better to keep it consistent.

   #2: "Add BIOS Info PEIM", #3: "Add BiosInfo PEIM", #4: "Add BIOS INFO PEIM"

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Agyeman, Prince
> Sent: Thursday, October 3, 2019 2:13 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms] [PATCH 0/5] Add FIT support using
> FitGen
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2210
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2211
> 
> This series of patches
>  1. Add the generation of the FitGen tool to build_bios.py  2. Add Firmware
> Interface Table (FIT) to the final images of:
>     a. KabylakeOpenBoardPkg/KabylakeRvp3
>     b. KabylakeOpenBoardPkg/GalagoPro3
>     c. WhiskeylakeOpenBoardPkg/WhiskeylakeURvp
> 
> What each patch does:
> 0001-BoardModulePkg-Add-bios-info-HOB: Adds the gBiosInfoGuid and the
> Bios Info struct for the Bios info HOB
> 
> 0002-KabylakeOpenBoardPkg-KabylakeRvp3-Add-BIOS-Info-PEIM,
> 0003-KabylakeOpenBoardPkg-GalagoPro3-Add-BiosInfo-PEIM,
> 0004-WhiskeylakeOpenBoardPkg-Add-BIOS-INFO-PEIM:
> Patches 0002,0003,0004 add bios info PEIM to KabylakeRvp3,
> GalagoPro3 and WhiskeylakeURvp boards respectively
> 
> 0005-Platform-Intel-Add-FIT-generation-tool
> Adds the FitGen tool binary and FIT generation to the BIOS build process.
> 
> Prince Agyeman (5):
>   BoardModulePkg: Add bios info HOB
>   KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM
>   KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM
>   WhiskeylakeOpenBoardPkg: Add BIOS INFO PEIM
>   Platform/Intel: Add FIT generation tool
> 
>  .../Intel/BoardModulePkg/BoardModulePkg.dec   |  3 +
>  .../BoardModulePkg/Include/Library/BiosInfo.h | 62 +++++++++++++
>  .../GalagoPro3/BiosInfo/BiosInfo.c            | 92 ++++++++++++++++++
>  .../GalagoPro3/BiosInfo/BiosInfo.inf          | 48 ++++++++++
>  .../GalagoPro3/OpenBoardPkg.dsc               |  2 +
>  .../GalagoPro3/OpenBoardPkg.fdf               |  1 +
>  .../GalagoPro3/build_config.cfg               |  1 +
>  .../KabylakeRvp3/BiosInfo/BiosInfo.c          | 93 +++++++++++++++++++
>  .../KabylakeRvp3/BiosInfo/BiosInfo.inf        | 48 ++++++++++
>  .../KabylakeRvp3/OpenBoardPkg.dsc             |  2 +
>  .../KabylakeRvp3/OpenBoardPkg.fdf             |  1 +
>  .../KabylakeRvp3/build_config.cfg             |  1 +
>  .../WhiskeylakeURvp/BiosInfo/BiosInfo.c       | 93 +++++++++++++++++++
>  .../WhiskeylakeURvp/BiosInfo/BiosInfo.inf     | 48 ++++++++++
>  .../WhiskeylakeURvp/OpenBoardPkg.dsc          |  2 +
>  .../WhiskeylakeURvp/OpenBoardPkg.fdf          |  1 +
>  .../WhiskeylakeURvp/build_config.cfg          |  1 +
>  Platform/Intel/build.cfg                      |  1 +
>  Platform/Intel/build_bios.py                  | 57 ++++++++++++
>  19 files changed, 557 insertions(+)
>  create mode 100644
> Platform/Intel/BoardModulePkg/Include/Library/BiosInfo.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.inf
>  create mode 100644
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/BiosI
> nfo.c
>  create mode 100644
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/BiosI
> nfo.inf
> 
> --
> 2.19.1.windows.1
> 
> 
> 


      parent reply	other threads:[~2019-10-08  1:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 21:12 [edk2-platforms] [PATCH 0/5] Add FIT support using FitGen Agyeman, Prince
2019-10-03 21:12 ` [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB Agyeman, Prince
2019-10-07 22:27   ` Nate DeSimone
2019-10-08  0:34   ` Kubacki, Michael A
2019-10-03 21:12 ` [edk2-platforms] [PATCH 2/5] KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM Agyeman, Prince
2019-10-07 22:27   ` Nate DeSimone
2019-10-08  1:09     ` Kubacki, Michael A
2019-10-08  1:30   ` Kubacki, Michael A
     [not found]   ` <15CB87D9C8A2CD86.11065@groups.io>
2019-10-08  1:41     ` [edk2-devel] " Kubacki, Michael A
2019-10-03 21:12 ` [edk2-platforms] [PATCH 3/5] KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM Agyeman, Prince
2019-10-07 22:27   ` Nate DeSimone
2019-10-08  1:31     ` Kubacki, Michael A
2019-10-03 21:12 ` [edk2-platforms] [PATCH 4/5] WhiskeylakeOpenBoardPkg: Add BIOS INFO PEIM Agyeman, Prince
2019-10-07 22:27   ` Nate DeSimone
2019-10-08  1:32   ` Kubacki, Michael A
2019-10-03 21:12 ` [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation tool Agyeman, Prince
2019-10-07 22:27   ` Nate DeSimone
2019-10-08  1:37   ` Kubacki, Michael A
     [not found]   ` <15CB88314AAB3150.15045@groups.io>
2019-10-08  1:44     ` [edk2-devel] " Kubacki, Michael A
2019-10-08  1:38 ` Kubacki, Michael A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3834752D3F67951BCA8B2CA7B59A0@DM6PR11MB3834.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox