From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=r+TfUu7q; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.a.kubacki@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 07 Oct 2019 18:33:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 18:33:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="223092973" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2019 18:33:11 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:33:11 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:33:10 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:33:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bXsOzz19EdJDv5Bqig8WZnw8PcTg+JDEMd6i+RqJC0zUfaE00A1zEry66dlY/eJHnm5vXE8nMzwQ9HFndllgf7GMinRpX6QCl2lJj2JtoeKoRDXEbU8Jo/qGlr+xSwnlyMrd5a0LRvwNaSgq9BBJK5i7gVBK05+RUCUA6pdbiZy3V159IfwJhfZBVgB8n/UdW5qKVjRYsATtTGuo36AQ0995L6VbzSVzemLXLz8Oc0DlqGzXd6jHwzPa1llhcKNju94sIBfq6DykY1SdZDQ/It5a7spuePf12JeTWcqIpehMu1t5d1mwZq7lVPwNK0PWN8rba4iPK/OvK5q/0JYE8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YFDMtBVrWfwaMemng+mUqVsFqaB49xxgr9VXZZ505oE=; b=NTKtKQ+FYYzE0w+1zasY7e0hvesZzky4EMOfc4t+xgeN6DnYds+87SPkDgEhjR6NfGZVYx+3Cr1Bjwijk18s/67gazqXU9iuvL0dm0qV8Dr/06XcbWVAXr5/BkF80+LvYFenVNzcj4tgAyg/lcThdrF9Np4jIBa1nWmvwQ/CMonEcr3cyQNIVqNaGzMm9qnGxWio1ymAsTckc6ClFDbBQln6HlNx1aQpUJ0Ro1Drwl+RsKurizlUNwVU7srOx00XaThFSb/V0PZ1dYOL2+Gg9NWjshsz+56NyXYFonQLPRc9Mp5+o8a9Tt5tlZHm4a79pEGLv4qHOlAFhxago19NcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YFDMtBVrWfwaMemng+mUqVsFqaB49xxgr9VXZZ505oE=; b=r+TfUu7qI/q3Pioe1mhGHFkU0w8AJ879sjyr9a+FQvBEJaVzZN5QvBVjB1IifJbb9euhnB7KCOfBhy8xKxbjMuwZuSa5dHNoD7kNvpxJGBtzPnt60paly3cwKNCjJeOVBTH0kZmSgd07sq+QRShNBU1S1McpgHvBlR6zkYlmWt4= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3802.namprd11.prod.outlook.com (20.179.16.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 01:32:45 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 01:32:45 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 4/5] WhiskeylakeOpenBoardPkg: Add BIOS INFO PEIM Thread-Topic: [edk2-platforms] [PATCH 4/5] WhiskeylakeOpenBoardPkg: Add BIOS INFO PEIM Thread-Index: AQHVei9pEqsWFUTQTke+DDeYFGdHv6dP+/Xw Date: Tue, 8 Oct 2019 01:32:45 +0000 Message-ID: References: <20191003211259.49664-1-prince.agyeman@intel.com> <20191003211259.49664-5-prince.agyeman@intel.com> In-Reply-To: <20191003211259.49664-5-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmQwZjZkZTYtNTYxMi00YjMzLTgyMWQtYWFlMDcwOTE3MTE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMURLZ1UrZGcxOWlCVXRiMlFXdUV0S2dBa0ZGdlFKaTVSOTBxYTcyRFVOSzJJOUcxd2JBZHh6d3V3WkNQeEpRdiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92fdedf2-8480-461e-4979-08d74b8f6b9d x-ms-traffictypediagnostic: DM6PR11MB3802: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(346002)(136003)(39860400002)(189003)(199004)(13464003)(55016002)(76116006)(8676002)(99286004)(81156014)(7736002)(476003)(8936002)(66946007)(305945005)(66556008)(2501003)(66476007)(66446008)(64756008)(81166006)(86362001)(74316002)(9686003)(2906002)(52536014)(33656002)(5660300002)(186003)(6246003)(66066001)(26005)(229853002)(446003)(11346002)(486006)(102836004)(6506007)(7696005)(76176011)(53546011)(3846002)(6116002)(14454004)(107886003)(71190400001)(6436002)(256004)(4326008)(14444005)(25786009)(71200400001)(54906003)(478600001)(110136005)(316002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3802;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nsL3G4JkxYjpKLaWIJNw0mmmD/sH9zYm0rBntCZZtzzCRXY36inGlPdwqt7fCpK6AmPe9aKBmfb50JPFsqbA1xSYnvPu7QP1cZBkDnVsqpEZOu2jnuS0cGMdz28USIz/BAjOXNRzDX7ur16vnpVCUHsxlogL/wCNwj0KuQUJ8TumIo/6IfDfMRhvk7vbJIkGa/xjjzKqpX+02NpPhu53K8WO/vu1YvKE2iz2M6tSxDPig6wjRXEOXprl4B4TUI/r1ZA16SC3siH3b6qg4qHSJ4nbCfAvG6O1emkLjzDJt13Ls2ahGXx3vNwdg9goQoRa/9UPnQx0rH8eeWCZf0bNw9n0cIxHuXr1jeBB0BV7GH8ktmbCi3WxLd7LefwRebeS5RXz8Wu/MmEvek/5KVfP2xNxl14FKrF0voh9FfDGH1Q= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 92fdedf2-8480-461e-4979-08d74b8f6b9d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 01:32:45.2382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aTo1LhweaLDnlBDq/nx2zy1QtvOG+3ny8xyUbr/DoA5ZPCuoIo8knsSyXe7NPWnDmyzKRWeW9cWhbVV5fqD23kE91lb3NJ/tVz3t4F7aRFA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3802 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Same feedback as patch #2: BiosInfo.c: BiosInfoEntryPoint () function description should be updated. The function = installs the BiosInfo PPI but also produces the BiosInfo HOB. It also looks like you can remove the following macros for now: #define INDEXPORT_TO_ADDRESS(x) (x) #define DATAPORT_TO_ADDRESS(x) ((x) << 16) #define PORTWIDTH_TO_ADDRESS(x) ((x) << 32) #define PORTBITNUMBER_TO_ADDRESS(x) ((x) << 40) #define PORTINDEXNUMBER_TO_ADDRESS(x) ((x) << 48) > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, October 3, 2019 2:13 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH 4/5] WhiskeylakeOpenBoardPkg: Add BIOS > INFO PEIM >=20 > Added BIOS info PEIM to publish Bios Info HOB. This PEIM currently publis= hes > the microcode FV info. >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../WhiskeylakeURvp/BiosInfo/BiosInfo.c | 93 +++++++++++++++++++ > .../WhiskeylakeURvp/BiosInfo/BiosInfo.inf | 48 ++++++++++ > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 2 + > .../WhiskeylakeURvp/OpenBoardPkg.fdf | 1 + > 4 files changed, 144 insertions(+) > create mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/BiosI > nfo.c > create mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/BiosI > nfo.inf >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > osInfo.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > osInfo.c > new file mode 100644 > index 0000000000..6a058a0fc2 > --- /dev/null > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > +++ osInfo.c > @@ -0,0 +1,93 @@ > +/** @file > + Driver for BIOS Info support. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define INDEXPORT_TO_ADDRESS(x) (x) > +#define DATAPORT_TO_ADDRESS(x) ((x) << 16) > +#define PORTWIDTH_TO_ADDRESS(x) ((x) << 32) > +#define PORTBITNUMBER_TO_ADDRESS(x) ((x) << 40) > +#define PORTINDEXNUMBER_TO_ADDRESS(x) ((x) << 48) > + > +// > +// Internal > +// > +#pragma pack (1) > + > +typedef struct { > + BIOS_INFO_HEADER Header; > + BIOS_INFO_STRUCT Entry[1]; > +} BIOS_INFO; > +#pragma pack () > + > +GLOBAL_REMOVE_IF_UNREFERENCED BIOS_INFO mBiosInfo =3D { > + { > + BIOS_INFO_SIGNATURE, > + 1, > + 0, > + }, > + { > + { > + FIT_TYPE_01_MICROCODE, > + BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION, > + 0x0100, > + FixedPcdGet32 (PcdFlashMicrocodeFvSize), > + FixedPcdGet32 (PcdFlashMicrocodeFvBase) > + } > + } > +}; > + > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_PEI_PPI_DESCRIPTOR > mBiosInfoPpiList > +=3D { > + EFI_PEI_PPI_DESCRIPTOR_PPI | > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST, > + &gBiosInfoGuid, > + &mBiosInfo > +}; > + > +/** > + Installs BiosInfo Ppi. > + > + @param FileHandle Handle of the file being invoked. > + @param PeiServices Describes the list of possible PEI Services. > + > + @retval EFI_SUCCESS Install the BiosInfo Ppi successfully. > + > +**/ > +EFI_STATUS > +EFIAPI > +BiosInfoEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + VOID *HobData; > + > + // > + // Install PPI, so that other PEI module can add dependency. > + // > + Status =3D PeiServicesInstallPpi (&mBiosInfoPpiList); ASSERT_EFI_ERRO= R > + (Status); > + > + // > + // Build hob, so that DXE module can also get the data. > + // > + HobData =3D BuildGuidHob (&gBiosInfoGuid, sizeof (mBiosInfo)); ASSERT > + (HobData !=3D NULL); if (HobData =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + CopyMem (HobData, &mBiosInfo, sizeof (mBiosInfo)); > + > + return EFI_SUCCESS; > +} > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > osInfo.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > osInfo.inf > new file mode 100644 > index 0000000000..f268de00f5 > --- /dev/null > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/BiosInfo/Bi > +++ osInfo.inf > @@ -0,0 +1,48 @@ > +### @file > +# Module Information description file for BIOS Info Driver # # > +Copyright (c) 2019, Intel Corporation. All rights reserved.
# > +SPDX-License-Identifier: BSD-2-Clause-Patent ### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D BiosInfo > + FILE_GUID =3D A842B2D2-5C88-44E9-A9E2-4830F26662B= 7 > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D BiosInfoEntryPoint > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES IA32 X64 > +# > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + HobLib > + BaseMemoryLib > + DebugLib > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > + CoffeelakeSiliconPkg/SiPkg.dec > + CoffeeLakeFspBinPkg/CoffeeLakeFspBinPkg.dec > + BoardModulePkg/BoardModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + > +[Pcd] > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase ## > CONSUMES > + gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize ## CON= SUMES > + > +[Sources] > + BiosInfo.c > + > +[Guids] > + gBiosInfoGuid ## PRODUCES > + > +[Depex] > + TRUE > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > index eea809140c..00a89f4507 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ g.dsc > @@ -246,6 +246,8 @@ >=20 > SiliconPolicyUpdateLib|MinPlatformPkg/PlatformInit/Library/SiliconPolicyU= p > dateLibNull/SiliconPolicyUpdateLibNull.inf > } >=20 > + $(PROJECT)/BiosInfo/BiosInfo.inf > + > # > # Security > # > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > index 611078e4b4..867cee8a64 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ g.fdf > @@ -237,6 +237,7 @@ INF > $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPreMem.i > nf > INF IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMe > m.inf > +INF $(PROJECT)/BiosInfo/BiosInfo.inf >=20 > [FV.FvPostMemoryUncompact] > BlockSize =3D $(FLASH_BLOCK_SIZE) > -- > 2.19.1.windows.1