From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Uqb0fkyD; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 07 Oct 2019 18:44:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 18:44:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="206541339" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 07 Oct 2019 18:44:27 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:44:27 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:44:27 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 18:44:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RHCkbr7zi93NJzvDtmcxPbiUO1c0Cff7Ne4R3kHO5Gu03x0LjNKuCn/NhWBSUwxj9ciSaaaaBNWe27PHJ+n9D4bJf300sbnKcDKDZrPbxTEpsmbNr/skjxE+M+iMLSRhpSrYgTxnAMy1SxrwTC3dorGWjkg8NRousSYYwLF33WtC6rA1YRP9OLc+PgAcd+0ATO3YQF4IKgXP0JGr9JlEc1cKU1MQuuKvJI7r2S+Q1L58vR7lTWujFk9M7Cx5uOLpnjHy+CV3o9fjeE1upF2dZ+8RiKrJUsR6/hO8N5ddmB5wW6mvhx8UVE9ybL9SzR7G87xLueIaXSyAVWsf7RJp+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VubQJ9nHaAg9LRpHyknYY0aobtWEbI1g4hnNlbYXuj4=; b=NEbaxFwOPuzBfFXwNnzC6FZXlxUK9dKacKDkkLZ3h2WF8HIGqgRtd4OT0WvuKTNQelQwItLAMcvLfUAKnnUnTejIKg7BlUrKXW8K7Nf3kmfx0yGUg6Xe2nA+EpkL86irfF72aGZg2iQWGtUAlOvmfNKpLoVr4HDDHIHN4xIcxuRZVNwbnDivF4jgoBEZqnwc80d5nY9Plz9xZWnEmhUlyRlSUcNAYR+TamLc0UWiYXuDzq/4GTuC8QL/1w3k3Ncf1/rmOJL/4jm2/gzxMqqIJDHV8a1hWtiPWYNUAuf0PID9zhKe91/3zxDQjRi3qYr0YLr//OSW0cTkco8/EG2jWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VubQJ9nHaAg9LRpHyknYY0aobtWEbI1g4hnNlbYXuj4=; b=Uqb0fkyDG/ErkEb5i9MjnI9yQoo8SuENkxrrKjdKBxOw/14laukXOavc/aEUMLIrLLRZT1mljTjzF+BMImAtbj42JjRWFQ1P/4xUZHzIlP4nwtqjubj28s0kFR1vFhxJn7KDirGedEK0EZHaTpJrl/3SDIzXcR1249kOI0Jgqww= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB2716.namprd11.prod.outlook.com (20.176.99.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 01:44:11 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 01:44:11 +0000 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Kubacki, Michael A" , "Agyeman, Prince" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation tool Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation tool Thread-Index: AQHVei9m6V5Y2+/j30KIXHEAURFLyKdP/V/QgAABZtA= Date: Tue, 8 Oct 2019 01:44:11 +0000 Message-ID: References: <20191003211259.49664-1-prince.agyeman@intel.com> <20191003211259.49664-6-prince.agyeman@intel.com> <15CB88314AAB3150.15045@groups.io> In-Reply-To: <15CB88314AAB3150.15045@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzVkZGY0M2MtNGUyYy00M2FkLWI4ZjMtMGMzYTAyNjNiYThmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVVR5T05rK3BOVzBJdHFVNnVaSmw4aHFVNldSZlwvdWZVd1NnNUt6OHNcL3FCMnBNc0owTlY0U0Y3ZjJrSnFwaXdyIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3a63af17-c7ab-4dd5-ae2f-08d74b9104d5 x-ms-traffictypediagnostic: DM6PR11MB2716: x-ms-exchange-purlcount: 3 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(346002)(39850400004)(376002)(396003)(136003)(189003)(199004)(13464003)(6506007)(14454004)(52536014)(11346002)(102836004)(81166006)(8676002)(476003)(110136005)(76176011)(81156014)(446003)(316002)(66946007)(7736002)(7696005)(33656002)(66066001)(107886003)(2501003)(6246003)(76116006)(5660300002)(66476007)(66556008)(64756008)(99286004)(66446008)(4326008)(54906003)(2906002)(25786009)(6436002)(6306002)(229853002)(9686003)(486006)(256004)(14444005)(55016002)(53546011)(305945005)(74316002)(26005)(8936002)(6116002)(478600001)(186003)(86362001)(3846002)(966005)(71200400001)(6636002)(71190400001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB2716;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y10TuPmfU6QTVRWCbIMqRA//d3p0P03FWFqC8TQ9rbLvMbVDgb/Jt0aig0d4sKDE1eu2W2knZcXWmm6tobe7H0WQDW67oFdtiUmIBUbsxMzWAFrR7LfiphxHY7g5EtdGrU2Ju9zvDTc9CIBASlQFPQGOR1XyvQFuusDe6dYK/xx7xUZQ4wpd/jCZkO8eX+GGSfxxIgGICZE7QNxh0FqerY7b/R++/7mDLgOb7TWkBnlsSuplyR6EXMTtE0d6HRUwHG3OyL2pvF8wXkd+B+axZ/uhnvzCWUxxpiqXgpMfXK1OskIfK09gfdBbziZ5wQE6NmW55H2vThA6YcEYJMhbJ5VG/oWYOMVZOaeSoK5SrvZIJc2e8UBOFF8c2VgfRZmm/LYIA+K1rNhDax0FD6RyXYHwtU3ioLclwpZpG2zZZKh86g3U7kJOw+UR1jvHXRwtaiMN4+lNBwhehixuwoHiTw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3a63af17-c7ab-4dd5-ae2f-08d74b9104d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 01:44:11.7969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0svR8wPIFhBIpOlE4Kx0nIV7AJVL7Uf+xJU6tE8WQR+tifNd92T9k0RkXb6fiIvX6YrKBVGP2rhr7Msjz0ADzttJs1/C2NiYHtFboIiTp0g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2716 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looking at the commit message in more detail, it should be cleaned up in V2= . Please try to clarify the following specifically: "boards to specify the GUID associated with the its Bios Info PEIM" > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Monday, October 7, 2019 6:37 PM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 5/5] Platform/Intel: A= dd > FIT generation tool >=20 > Reviewed-by: Michael Kubacki >=20 > > -----Original Message----- > > From: Agyeman, Prince > > Sent: Thursday, October 3, 2019 2:13 PM > > To: devel@edk2.groups.io > > Cc: Sinha, Ankit ; Desimone, Nathaniel L > > ; Kubacki, Michael A > > > > Subject: [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT > > generation tool > > > > Added fit generation tool to the build process. > > > > What was done: > > > > Added BIOS_INFO_GUID to the build.cfg > > > > Added BIOS_INFO_GUID to GalagoPro3, > > KabylakeRvp3 and WhiskeylakeURvp build_config.cfg This allows the > > boards to specify the GUID associated with the its Bios Info PEIM > > > > BIOS_INFO_GUID is passed as an argument to FitGen in the FIT table > > generation process > > > > Cc: Ankit Sinha > > Cc: Nate DeSimone > > Cc: Michael Kubacki > > > > Signed-off-by: Prince Agyeman > > --- > > .../GalagoPro3/build_config.cfg | 1 + > > .../KabylakeRvp3/build_config.cfg | 1 + > > .../WhiskeylakeURvp/build_config.cfg | 1 + > > Platform/Intel/build.cfg | 1 + > > Platform/Intel/build_bios.py | 57 ++++++++++++++++++= + > > 5 files changed, 61 insertions(+) > > > > diff --git > > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > > index 8c6c51abb4..3f64239a29 100644 > > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg > > @@ -31,3 +31,4 @@ FSP_PKG_NAME =3D KabylakeFspPkg > FSP_BINARY_BUILD =3D > > FALSE FSP_TEST_RELEASE =3D FALSE SECURE_BOOT_ENABLE =3D FALSE > > +BIOS_INFO_GUID =3D 3132E669-D16B-4AA7-B09B-BC0EB5F40E1F > > diff --git > > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > index 78f808bfaf..f6ae4b342a 100644 > > --- > > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > +++ > > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg > > @@ -33,3 +33,4 @@ FSP_PKG_NAME =3D AmberLakeFspPkg > FSP_BINARY_BUILD =3D > > FALSE FSP_TEST_RELEASE =3D FALSE SECURE_BOOT_ENABLE =3D FALSE > > +BIOS_INFO_GUID =3D C83BCE0E-6F16-4D3C-8D9F-4D6F5A032929 > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_confi > > g.cfg > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_confi > > g.cfg > > index 1b0619bc1c..1dfe5ffd10 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_confi > > g.cfg > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_confi > > +++ g.cfg > > @@ -31,3 +31,4 @@ FSP_PKG_NAME =3D CoffeelakeSiliconPkg > FSP_BINARY_BUILD > > =3D FALSE FSP_TEST_RELEASE =3D FALSE SECURE_BOOT_ENABLE =3D FALSE > > +BIOS_INFO_GUID =3D A842B2D2-5C88-44E9-A9E2-4830F26662B7 > > diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index > > 2040774d1b..6aee96694c 100644 > > --- a/Platform/Intel/build.cfg > > +++ b/Platform/Intel/build.cfg > > @@ -48,6 +48,7 @@ SECURE_BOOT_ENABLE =3D FALSE REBUILD_MODE =3D > > BUILD_ROM_ONLY =3D NUMBER_OF_PROCESSORS =3D 0 > > +BIOS_INFO_GUID =3D > > > > > > [PLATFORMS] > > diff --git a/Platform/Intel/build_bios.py > > b/Platform/Intel/build_bios.py index > > 46285df19a..ea098de705 100644 > > --- a/Platform/Intel/build_bios.py > > +++ b/Platform/Intel/build_bios.py > > @@ -196,6 +196,31 @@ def pre_build(build_config, build_type=3D"DEBUG", > > silent=3DFalse, toolchain=3DNone): > > if return_code !=3D 0: > > build_failed(config) > > > > + # > > + # build platform silicon tools > > + # > > + # save the current workspace > > + saved_work_directory =3D config["WORKSPACE"] > > + # change the workspace to silicon tools directory > > + config["WORKSPACE"] =3D os.path.join(config["WORKSPACE_SILICON"], > > + "Tools") > > + > > + command =3D ["nmake"] > > + if os.name =3D=3D "posix": # linux > > + command =3D ["make"] > > + # add path to generated FitGen binary to > > + # environment path variable > > + config["PATH"] +=3D os.pathsep + \ > > + os.path.join(config["BASE_TOOLS_PATH"], > > + "Source", "C", "bin") > > + > > + # build the silicon tools > > + _, _, result, return_code =3D execute_script(command, config, > shell=3Dshell) > > + if return_code !=3D 0: > > + build_failed(config) > > + > > + # restore WORKSPACE environment variable > > + config["WORKSPACE"] =3D saved_work_directory > > + > > config["SILENT_MODE"] =3D 'TRUE' if silent else 'FALSE' > > > > print("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D") > > @@ -404,6 +429,35 @@ def post_build(config): > > :returns: nothing > > """ > > print("Running post_build to complete the build process.") > > + board_fd =3D config["BOARD"].upper() > > + final_fd =3D os.path.join(config["BUILD_DIR_PATH"], "FV", > > + "{}.fd".format(board_fd)) > > + > > + if config["BIOS_INFO_GUID"]: > > + # Generate the fit table > > + print("Generating FIT ...") > > + if os.path.isfile(final_fd): > > + temp_fd =3D os.path.join(config["BUILD_DIR_PATH"], "FV", > > + "{}_.fd".format(board_fd)) > > + shell =3D True > > + command =3D ["FitGen", "-D", > > + final_fd, temp_fd, "-NA", > > + "-I", config["BIOS_INFO_GUID"]] > > + > > + if os.name =3D=3D "posix": # linux > > + shell =3D False > > + > > + _, _, result, return_code =3D execute_script(command, > > + config, > > shell=3Dshell) > > + if return_code !=3D 0: > > + print("Error while generating fit") > > + else: > > + # copy output to final binary > > + shutil.copyfile(temp_fd, final_fd) > > + # remove temp file > > + os.remove(temp_fd) > > + else: > > + print("{} does not exist".format(final_fd)) > > + # remove temp file > > > > # Additional build scripts for this platform > > result =3D post_build_ex(config) > > @@ -426,6 +480,9 @@ def post_build(config): > > except OSError: > > pass > > > > + print("Done") > > + if os.path.isfile(final_fd): > > + print("Fd file can be found at {}".format(final_fd)) > > > > def build_failed(config): > > """Displays results when build fails > > -- > > 2.19.1.windows.1 >=20 >=20 >=20