From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.1439.1571366681166382929 for ; Thu, 17 Oct 2019 19:44:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=x94BloNJ; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2019 19:44:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,310,1566889200"; d="scan'208";a="200578303" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 17 Oct 2019 19:44:40 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 17 Oct 2019 19:44:39 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 17 Oct 2019 19:44:39 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.53) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 17 Oct 2019 19:44:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbeUC9Z3L7Cnt42L8R8tfBg7xUniKkYeeFwYP8JNn6aQZPWh2Qs6r2mvew9q0+cbf+cC++vjkB/am2PoD3JoPZEB3tEkMkcFiWWmDrFoDHNECllylhwzRkyPg/XQ/znu22sgvBEURlOwWtSnM6FuasjYe/vWeirM6ar1iqlAzskCmlmIRBTAIDce4s6LqSPtjbNaDNuoCw/QgmOPeG200K6y/HOU0dSjYjN3kZHpo6sI/cVt2/u+5j6bLT82PSu1o8+NY2MmUdJ8VKklin1SWlmxBnJw33p86EM+JGqoDFLEK6x9A60HurfJPVrg3Gt0mtOnx9e9SZ9GEBncJaPJ2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iH5nQFZw7jLB+GJKjq7bwo3w5+GTpU9iKaUB61YGSgk=; b=fIWlP6tdOlTGzLqpFjvGMYXPRvske/Tzt4lC9O1Z5bzNTpBXBwn7/5QNXx6n+cJTfEGFgBP03raqKcu9SPAXK5sqBw6RuOoKYz9cmOI30teDqeDibUrVWHw3X5O+csR1yfWqoSqVra7FaCNyypl34IVknC/LACWKo0/riglDjmTE/6uIv0+ybDJMdQCVtzcMe17ELDv9ifYbhO1kp1fiNs+bv7UyZggC3upwrv8uD7w/jyTaDcGqF/LrRY45PEh0SEBq5iAqQlzRIuNz5S/nagDWNM+60n4KUi50eDn5yvVx/wK2LM/ZMvrEeamO2N1ArMoHxuBQLElhlURu35jFYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iH5nQFZw7jLB+GJKjq7bwo3w5+GTpU9iKaUB61YGSgk=; b=x94BloNJD5vSTlCsLqz4xigbf+doMNlHh3X4LJdQ6xKWBxod1FDjVb9UpFHAPCMH63Q53isZz2LUe38odnIMd908YxpWiaxzRQ8YPVdbSZfG8wcPZCXkkzwna7pea41K/aFBGSS8ij15GmLGliMOospR4fRgy4SSjv2kT07c1EA= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB4025.namprd11.prod.outlook.com (20.176.125.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Fri, 18 Oct 2019 02:44:36 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::21f7:6d8d:919b:d755]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::21f7:6d8d:919b:d755%6]) with mapi id 15.20.2347.023; Fri, 18 Oct 2019 02:44:36 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info HOB Thread-Topic: [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info HOB Thread-Index: AQHVhUdQmMJ5y+WJbkulXH4Ox0TvkadfsQUw Date: Fri, 18 Oct 2019 02:44:36 +0000 Message-ID: References: <20191018000145.3140-1-prince.agyeman@intel.com> <20191018000145.3140-2-prince.agyeman@intel.com> In-Reply-To: <20191018000145.3140-2-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTRlOGE0ZGQtNjkzNS00NWEwLWIyY2MtYTdhM2QyNTI4N2MyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMlJqMWhwTVA3Q1pqbjhxdFl2eEJyUGVrVkpueFRLNmZXWHBUUXpUZjVnMklBRm1NYmhlajFpWHhBeXc5XC9ubGwifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7531e84d-5815-438a-ecbd-08d753751d89 x-ms-traffictypediagnostic: DM6PR11MB4025: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01949FE337 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39850400004)(136003)(376002)(366004)(346002)(396003)(189003)(199004)(13464003)(11346002)(25786009)(76176011)(229853002)(6436002)(6246003)(2501003)(99286004)(8936002)(2906002)(5660300002)(33656002)(86362001)(55016002)(9686003)(66946007)(6306002)(76116006)(81156014)(71190400001)(7696005)(66446008)(64756008)(66556008)(8676002)(66476007)(71200400001)(81166006)(107886003)(6116002)(3846002)(446003)(102836004)(305945005)(256004)(26005)(186003)(478600001)(316002)(66066001)(14454004)(74316002)(7736002)(110136005)(4326008)(54906003)(486006)(52536014)(6506007)(53546011)(476003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB4025;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:3;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2jREAaOQ9/odHDCkeQQdCsSJuUdOaV6d/KYmbb4BmGlTByexl5zQ0Ao9zOwqLrJwhbAKv8yn7u6IbSiLqzZIEiRc0r8J7uF9Y4FUt5OtL/GUbNaIPKWlqCD6dBdmZJ1V/15u5KBbuOMYmGOT2OFr3I2JfdWNbXY7LnmoSSvTPxGy4ruEFulIXiiLQgp4vERUxkSxP7LdZKAysfKWOJOsEh5vi83J38GqC9xWxRNAr4JZ6r967RlXnuHvYr3JKUon4DvJ1p4CGDxU9nXzT6Gm1u4OOfjhJWqz0wxQdyoNRNazHrEDjNtEKbkRrPLmamnotwRPGPa1pBwtUpuu8gmbYDo+r2n4SlJXa+q8jYmlJvZkbiIxuFXHLS1yDdF3Yi7GlthBD8A1GL6zaMG8gJNdrN+CWG/p1InK9yyw1YoKYQk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7531e84d-5815-438a-ecbd-08d753751d89 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2019 02:44:36.6232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9K7Frafmixz0ytBXF7rPhqM5P7ZrCqyDAihrqYC6fwjHNBt2HPsS0Edt6rjLJmHDLxLiriWsKdBqi76AyIocMNldQwtC8KfXXo9czHTNz3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4025 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Thursday, October 17, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v3 1/4] BoardModulePkg: Add BIOS Info > HOB >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2210 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2211 >=20 > Added gBiosInfoGuid to be used in > publishing the BIOS information HOB > which is needed in FIT generation >=20 > Also added the BIOS Info header > file BiosInfo.h that defines the > BIOS info struct and GUID >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/BoardModulePkg/BoardModulePkg.dec | 3 + > .../BoardModulePkg/Include/Guid/BiosInfo.h | 61 > +++++++++++++++++++ > 2 files changed, 64 insertions(+) > create mode 100644 > Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h >=20 > diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > index f96fb09aa1..f461cc7cab 100644 > --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > @@ -39,3 +39,6 @@ > [Guids] > ## Include Include/Guid/BiosId.h > gBiosIdGuid =3D { 0xC3E36D09, 0x8294, 0x4b97, { 0xA8, 0x57, 0xD5, 0x28= , 0x8F, > 0xE3, 0x3E, 0x28 } } > + > + ## GUID to publish BIOS information HOB gBiosInfoGuid =3D { > + 0x09d0d15c, 0xe9f0, 0x4dfc, {0x9e, 0x0b, 0x39, 0x33, 0x1f, 0xca, 0x66, > + 0x85} } > diff --git a/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > b/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > new file mode 100644 > index 0000000000..d73409ea6f > --- /dev/null > +++ b/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > @@ -0,0 +1,61 @@ > +/** @file > + Definitions and GUID for BIOS INFO. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _BIOS_INFO_H_ > +#define _BIOS_INFO_H_ > + > +// > +// BIOS INFO data structure > +// This is self contained data structure for BIOS info for TXT // > +#pragma pack (1) #define BIOS_INFO_SIGNATURE SIGNATURE_64 ('$', 'B', > +'I', 'O', 'S', 'I', 'F', '$') typedef struct { > + UINT64 Signature; > + UINT32 EntryCount; > + UINT32 Reserved; > +//BIOS_INFO_STRUCT Struct[EntryCount]; } BIOS_INFO_HEADER; > + > +// > +// BIOS_INFO_STRUCT attributes > +// bits[0:3] means general attributes > +// bits[4:7] means type specific attributes // #define > +BIOS_INFO_STRUCT_ATTRIBUTE_GENERAL_EXCLUDE_FROM_FIT 0x01 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION > 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_POST_IBB 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_NON_IBB 0x20 > + > +typedef struct { > + // > + // FitTable entry type > + // > + UINT8 Type; > + // > + // BIOS_INFO_STRUCT attributes > + // > + UINT8 Attributes; > + // > + // FitTable entry version > + // > + UINT16 Version; > + // > + // FitTable entry real size > + // > + UINT32 Size; > + // > + // FitTable entry address > + // > + UINT64 Address; > +} BIOS_INFO_STRUCT; > + > +extern EFI_GUID gBiosInfoGuid; > + > +#pragma pack () > + > +#endif > -- > 2.19.1.windows.1