From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.199.1571247122096429429 for ; Wed, 16 Oct 2019 10:32:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kXqtMYG8; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 10:32:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,304,1566889200"; d="scan'208";a="189748153" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga008.jf.intel.com with ESMTP; 16 Oct 2019 10:32:01 -0700 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 16 Oct 2019 10:32:00 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX124.amr.corp.intel.com (10.22.240.120) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 16 Oct 2019 10:32:00 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.59) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 16 Oct 2019 10:32:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9L9Zx1u4RCKgizOcGGHCE8jRsjiVN0kAINBCZQl2Nq/XtAmsL2dkXuPtiVM+M6wL66N5zfBGDbcp6P13cD1C1fdujjyrW56OP8MmtwJL1B2EPfGjw/Mq3sGJTwkJ7EFamC0p9Sz7y8r10CWYTg5qjxsrow+7sM6o5dYeOujSkQlkTvmrxiy0RfWDU8G5AkHuc1hTcaK8WAfbCthdO6R03h4UIin1V3gbE1YBxoG5wA6f5bkb16ibr/ig7E+3IlxgAGLsYlMlej7JEqBZMc1a7EHVqCxaxSysAjOxtMBHoi+o7gZacVU/oihjpgWshXfuVtkRZn0f5ivjoqZ+085kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Grdp+4SjkSowjFaYvcj+jnFtEAvdQGSj/8aDvpurujU=; b=lu6HP3SaW9Uly35ygDvizhwoQdVgKHIQWmi5e/Ao8Z4Fmr8Z/9hngGyhafCEsat4cv6ok1f+0kkv21Zt4FefYBemaPvTLZxr807KOof1eqlcnBeWZIDKdNJd2meQEiFWt48QlKgSOIrtYZS4tIxbMSQaSpmsIbe/4GzeCSu1Eo0b6+GS333aIyslt/jwndrcWZjCBf0yLu/GNvcrDTQ6CpEyHzTbYnrrlEdFmi27D5IDa2Y11D3ro46mxSGtciHfSDOWgeLLOIPiqnilvt1EB8y7t02mFbBfhGGhnjsh21Log4kJXkugr1gRqeOILPBjme8b1aHqJyCnYTed2WCLLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Grdp+4SjkSowjFaYvcj+jnFtEAvdQGSj/8aDvpurujU=; b=kXqtMYG8BeW3xtzg2S+WaMkouaFFYUgMS2qfVA9v81aKHTC0BjYiplTxHbXxPu3aMqUUM6gvp8Gb1yqELlCeTYYk/FC3vXb0NKpSyZ8bFMj3n9IwdbvM4zeVsSwLC5oLNxconj4u5KWXOB7ghg5TlNRqjl/Zk+VA5vDpk43SFPc= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB4219.namprd11.prod.outlook.com (52.132.248.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 16 Oct 2019 17:31:59 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::21f7:6d8d:919b:d755]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::21f7:6d8d:919b:d755%6]) with mapi id 15.20.2347.023; Wed, 16 Oct 2019 17:31:59 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info HOB Thread-Topic: [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info HOB Thread-Index: AQHVg6sbCcDDVDaJQkaMhpnEG08vqKddhOpA Date: Wed, 16 Oct 2019 17:31:59 +0000 Message-ID: References: <20191015225109.18992-1-prince.agyeman@intel.com> <20191015225109.18992-2-prince.agyeman@intel.com> In-Reply-To: <20191015225109.18992-2-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjIzYjE5Y2ItYWU4Zi00MzljLWFkYTctNWJmM2IzY2M5OGVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid0F0WklRV3QzN09rdEdGN3FjQ09ac1FQUGNCY3kyTGxvR2RwNHRTMzVuSDFyWFJ5MDI3ZTZCZW9rXC9mR3BnZ3IifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: feb292d2-2ded-423c-62ba-08d7525ebfce x-ms-traffictypediagnostic: DM6PR11MB4219: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0192E812EC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(136003)(39860400002)(376002)(366004)(396003)(13464003)(199004)(189003)(76176011)(316002)(53546011)(6506007)(478600001)(14454004)(446003)(11346002)(99286004)(25786009)(26005)(74316002)(186003)(71190400001)(71200400001)(7696005)(7736002)(305945005)(2906002)(52536014)(5660300002)(102836004)(2501003)(110136005)(54906003)(4326008)(55016002)(33656002)(6436002)(3846002)(229853002)(107886003)(6246003)(81156014)(256004)(66946007)(476003)(86362001)(66066001)(486006)(81166006)(76116006)(66476007)(66556008)(64756008)(66446008)(8936002)(8676002)(6116002)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB4219;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IbZGeVc0bXsDvh8F3c7+sH5rCtWD9doGGkFKUmWiYk6m1Lrs8jNVUcP9oEL/f4Zb5GuGuucGefmWYr6t1L3tPUHzLfyE9y9tL0/87k6l/BWgUjnsz8TZaj2mRD402uHlTLn8P+9ODpwBjoDHjXn0AmTOjIGfEXHwVTutEw7UfYvcF4XT0zcyVmZIzEWFqNwP63Bn/+pv3kynBsAU0n/dmc7ufPCLhg84XIbDwfMuZyWj0bHJOnDkxq+TgwNVcOsxcSOehg+pB1FSpQsEmHqDzbh3WWqcCR827DWrI7GfDN+QXECoKPBDlUDZ5RJ9qVKHawC5Z93zeT2OC+pbbFn3ZMVAxY3gylNxzdjruZllCBNuKez2/O2gvO6xjywC/PkB88Z4Cp1mcR62726KiGy929VNXEX1j5rv2lMs0F0Rlvs= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: feb292d2-2ded-423c-62ba-08d7525ebfce X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 17:31:59.3552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AcgJantYdlPs81LMPXnGAJ3y7Jw7qa3ncSauOLg2spyJW6xC1uCfNH8i05CQrKaJ3IgS3B9bGhWAdG2lXoKAk3jnZNGJD/PdCGs/dMrTdt8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4219 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Tuesday, October 15, 2019 3:51 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info > HOB >=20 > Added gBiosInfoGuid to be used in > publishing the BIOS information HOB > which is needed in FIT generation >=20 > Also added the BIOS Info header > file BiosInfo.h that defines the > BIOS info struct and GUID >=20 > Cc: Ankit Sinha > Cc: Nate DeSimone > Cc: Kubacki Michael A >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/BoardModulePkg/BoardModulePkg.dec | 3 + > .../BoardModulePkg/Include/Guid/BiosInfo.h | 61 > +++++++++++++++++++ > 2 files changed, 64 insertions(+) > create mode 100644 > Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h >=20 > diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > index f96fb09aa1..f461cc7cab 100644 > --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > @@ -39,3 +39,6 @@ > [Guids] > ## Include Include/Guid/BiosId.h > gBiosIdGuid =3D { 0xC3E36D09, 0x8294, 0x4b97, { 0xA8, 0x57, 0xD5, 0x28= , 0x8F, > 0xE3, 0x3E, 0x28 } } > + > + ## GUID to publish BIOS information HOB gBiosInfoGuid =3D { > + 0x09d0d15c, 0xe9f0, 0x4dfc, {0x9e, 0x0b, 0x39, 0x33, 0x1f, 0xca, 0x66, > + 0x85} } > diff --git a/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > b/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > new file mode 100644 > index 0000000000..d73409ea6f > --- /dev/null > +++ b/Platform/Intel/BoardModulePkg/Include/Guid/BiosInfo.h > @@ -0,0 +1,61 @@ > +/** @file > + Definitions and GUID for BIOS INFO. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _BIOS_INFO_H_ > +#define _BIOS_INFO_H_ > + > +// > +// BIOS INFO data structure > +// This is self contained data structure for BIOS info for TXT // > +#pragma pack (1) #define BIOS_INFO_SIGNATURE SIGNATURE_64 ('$', 'B', > +'I', 'O', 'S', 'I', 'F', '$') typedef struct { > + UINT64 Signature; > + UINT32 EntryCount; > + UINT32 Reserved; > +//BIOS_INFO_STRUCT Struct[EntryCount]; } BIOS_INFO_HEADER; > + > +// > +// BIOS_INFO_STRUCT attributes > +// bits[0:3] means general attributes > +// bits[4:7] means type specific attributes // #define > +BIOS_INFO_STRUCT_ATTRIBUTE_GENERAL_EXCLUDE_FROM_FIT 0x01 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_MICROCODE_WHOLE_REGION > 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_POST_IBB 0x10 > +#define BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_NON_IBB 0x20 > + > +typedef struct { > + // > + // FitTable entry type > + // > + UINT8 Type; > + // > + // BIOS_INFO_STRUCT attributes > + // > + UINT8 Attributes; > + // > + // FitTable entry version > + // > + UINT16 Version; > + // > + // FitTable entry real size > + // > + UINT32 Size; > + // > + // FitTable entry address > + // > + UINT64 Address; > +} BIOS_INFO_STRUCT; > + > +extern EFI_GUID gBiosInfoGuid; > + > +#pragma pack () > + > +#endif > -- > 2.19.1.windows.1