[edk2-platforms] [PATCH 0/2] Replace vtf0 bin with source version

[edk2-platforms] [PATCH 0/2] Replace vtf0 bin with source version

[Agyeman, Prince]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307

Updated SimicsX58SktPkg to use the source version of
UefiCpuPkg/ResetVector/Vtf0, so that the binary module can be
removed from the edk2/UefiCpuPkg

Prince Agyeman (2):
  SimicsX58SktPkg: Replace vtf0 bin with source module
  SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf

 .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf     | 2 +-
 Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc                     | 2 +-
 Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf                 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.19.1.windows.1

[PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module

[Agyeman, Prince]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307

Updated SimicsX58SktPkg to use the source version of
UefiCpuPkg/ResetVector/Vtf0. This will allow the Vtf0 binary
to be removed from the edk2 repository

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>

Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc     | 2 +-
 Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
index af83c380b8..efa829ba9e 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
+++ b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
@@ -10,5 +10,5 @@
   #
   # SEC Phase modules
   #
-  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+  UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
   UefiCpuPkg/CpuMpPei/CpuMpPei.inf
diff --git a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
index 5019e362e3..dafca1ad36 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
+++ b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
@@ -13,4 +13,4 @@
 # The code in this FV handles the initial firmware startup, and
 # decompresses the PEI and DXE FVs which handles the rest of the boot sequence.
 #
-INF  RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+INF  RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
-- 
2.19.1.windows.1

[PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf

[Agyeman, Prince]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307

Updated the RESET_VECTOR rule since ResetVector/Vtf0
is now built from source.

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>

Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
index 75a99a5270..0c27cb0ef2 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
@@ -293,7 +293,7 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
 
 [Rule.Common.SEC.RESET_VECTOR]
   FILE RAW = $(NAMED_GUID) {
-    RAW RAW      |.raw
+    RAW BIN   Align = 16   |.bin
   }
 
 [Rule.Common.SEC.RESET_SECMAIN]
-- 
2.19.1.windows.1

Re: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module

[Kubacki, Michael A]

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, October 23, 2019 7:21 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307
> 
> Updated SimicsX58SktPkg to use the source version of
> UefiCpuPkg/ResetVector/Vtf0. This will allow the Vtf0 binary to be removed
> from the edk2 repository
> 
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc     | 2 +-
>  Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
> b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
> index af83c380b8..efa829ba9e 100644
> --- a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
> +++ b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
> @@ -10,5 +10,5 @@
>    #
>    # SEC Phase modules
>    #
> -  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> +  UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
>    UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> diff --git a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
> b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
> index 5019e362e3..dafca1ad36 100644
> --- a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
> +++ b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
> @@ -13,4 +13,4 @@
>  # The code in this FV handles the initial firmware startup, and  # decompresses
> the PEI and DXE FVs which handles the rest of the boot sequence.
>  #
> -INF  RuleOverride=RESET_VECTOR USE = IA32
> UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
> +INF  RuleOverride=RESET_VECTOR USE = IA32
> +UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
> --
> 2.19.1.windows.1

Re: [PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf

[Kubacki, Michael A]

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, October 23, 2019 7:21 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307
> 
> Updated the RESET_VECTOR rule since ResetVector/Vtf0 is now built from
> source.
> 
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf     | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> index 75a99a5270..0c27cb0ef2 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
> @@ -293,7 +293,7 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-
> E77F1DB2D792 {
> 
>  [Rule.Common.SEC.RESET_VECTOR]
>    FILE RAW = $(NAMED_GUID) {
> -    RAW RAW      |.raw
> +    RAW BIN   Align = 16   |.bin
>    }
> 
>  [Rule.Common.SEC.RESET_SECMAIN]
> --
> 2.19.1.windows.1

Re: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module

[Nate DeSimone]

Please remember to put the [edk2-platforms] header on the email next time.

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Agyeman, Prince <prince.agyeman@intel.com> 
Sent: Wednesday, October 23, 2019 7:21 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307

Updated SimicsX58SktPkg to use the source version of UefiCpuPkg/ResetVector/Vtf0. This will allow the Vtf0 binary to be removed from the edk2 repository

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>

Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc     | 2 +-
 Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
index af83c380b8..efa829ba9e 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
+++ b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
@@ -10,5 +10,5 @@
   #
   # SEC Phase modules
   #
-  UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+  UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
   UefiCpuPkg/CpuMpPei/CpuMpPei.inf
diff --git a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
index 5019e362e3..dafca1ad36 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
+++ b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
@@ -13,4 +13,4 @@
 # The code in this FV handles the initial firmware startup, and  # decompresses the PEI and DXE FVs which handles the rest of the boot sequence.
 #
-INF  RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+INF  RuleOverride=RESET_VECTOR USE = IA32 
+UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
--
2.19.1.windows.1

Re: [PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf

[Nate DeSimone]

Please remember to put the [edk2-platforms] header on the email next time.

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Agyeman, Prince <prince.agyeman@intel.com> 
Sent: Wednesday, October 23, 2019 7:21 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307

Updated the RESET_VECTOR rule since ResetVector/Vtf0 is now built from source.

Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>

Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
index 75a99a5270..0c27cb0ef2 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
@@ -293,7 +293,7 @@ FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
 
 [Rule.Common.SEC.RESET_VECTOR]
   FILE RAW = $(NAMED_GUID) {
-    RAW RAW      |.raw
+    RAW BIN   Align = 16   |.bin
   }
 
 [Rule.Common.SEC.RESET_SECMAIN]
--
2.19.1.windows.1