From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=uJCTNxHy; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.a.kubacki@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 02 Oct 2019 18:31:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 18:31:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,250,1566889200"; d="scan'208";a="366887406" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 02 Oct 2019 18:31:16 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:31:16 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:31:16 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.51) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:31:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Btfg+IkamazHFjvn+SIg5DuOlOzuzy4unGgaXm60iGs6kT2TmpDovRtiVdzm2P3z9Cwc2TuOv9BubYx9hiN0CgGVp5qXK3uZgG6d5+HzI+cQbjG1f+pYQC+0pHGJiB5UWkIimI+wfWOo9Jt+KAuo8jYi6/T0vwtYRVYzUF6xviePOriRVL1STg3sL/k6dYQWZtZBTAipdsjAP5HaUPx4+L8zLOKTfMhjULobTccMjS69w+yX4kPJ6QO/zh1HI8Bre/qHnjsnPfAW/g/rMfQUCl/t8onMN53sGKMnWHT/HdvuZhzRxCh59yZcPw8275d+KCyAAY0qVXoi9XYf4hevlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAZDQuOnZdNxcalKfZ00lNTAF53gZAN5LjDhmNksKKE=; b=S69L/i6QEs+3z4CuGs40il/cOB1kZV/f27JOXuLtrWy7TvJ5ApbtFcnG3leOtA+HQv3i5oTyERX0FCTDjWBIM71dwyWr0ib71bQMOjTHBz/Vpd/L/L4wPA2P3Ww2U4jZYwkrz8fyEDRCcabpcHCGE2fvkejHaflFag3V/OZAFfvSqOp+DjHEhZ3JNzuuJQqpp6CUsjD4SRHNafofuU+nZgmv8YPMuL84XVLxn2HIj7AOityrAE6Hoo3YDR2I+kdFgVVFvjiGh/FiWr31ug1UJ7H5lRAF3mbqyOWAS5FHiLszOuaKfvkyC12RaoL3cayCzIKBuWZLVTleohk0i8UrpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAZDQuOnZdNxcalKfZ00lNTAF53gZAN5LjDhmNksKKE=; b=uJCTNxHy0XDm7OnURIPMUS/xz6GIf04LNiKyrtRkTpqUzo9hn77X2oZ4iBpI7jC0u/6xtnVsvPOtFOktOX163zHN2DzXjc6tbW2HUM4IvpGVbZ94ttUMCEdNkZAqEVyo79AsohJSO3MKZMld55hDzHJADzDlsXTy5HMk5f2SNvE= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3865.namprd11.prod.outlook.com (10.255.61.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 01:31:14 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 01:31:14 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Jeremy Soller Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds. Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds. Thread-Index: AQHVePR3Tu+b7vO/Ik23y2M8DJ/ePKdIIcsA Date: Thu, 3 Oct 2019 01:31:14 +0000 Message-ID: References: <20191002073819.3421-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20191002073819.3421-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGM2NmQ1MDctMzI3ZS00YjY5LTk2YjMtNDIzNTY4Y2EzNWY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicXRoK3ZXb2thSlpSbXZWOTdoWEV1QkduOUR0RDg2TFVud3BkdjlVM0dFbGtobTZWa0dxVURRVnFrMm1jandxRSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e7340d3-3d74-402d-9b02-08d747a1617d x-ms-traffictypediagnostic: DM6PR11MB3865: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(366004)(39860400002)(376002)(346002)(199004)(189003)(13464003)(476003)(66066001)(6436002)(99286004)(9686003)(55016002)(74316002)(81166006)(81156014)(5660300002)(256004)(2501003)(110136005)(54906003)(229853002)(86362001)(446003)(305945005)(7736002)(7696005)(316002)(25786009)(6246003)(53546011)(6506007)(2906002)(76116006)(52536014)(19627235002)(26005)(11346002)(8936002)(186003)(71190400001)(71200400001)(33656002)(6116002)(8676002)(486006)(3846002)(4326008)(478600001)(66946007)(66556008)(64756008)(66446008)(14454004)(66476007)(76176011)(102836004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3865;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e+YuWH5aiAZgocxKNQfUo2r0g29MhI6+dxC4EOWhDCU0IlheaPGcb0XhHUxFML/B8wKiOjG/JWbpkDFAA8iusp4XuQzIz/ksmRK4epi6zV2bGXYB17N4vV4yRwOUT/THiTKfRP+pmqfDBkKDkHFlGw1EHlKHhZMX3/Rc0N93R3NMluRtGzEZhqIqWQOfYOjQiyZI/bOOj1O+D6bNUceafI+3E3XL5A+yPYgKrzm6DHI7+upD+IBBoWDTQw44z8+UHo5IN+IROtqcSixm+9rFYksGIcOazSbfYJ1qtlgzTE3Is7xBLa3+du3FIRjPwliV6/zvPfAghQaOstPp0LtUZ7HxFUnD72B1cda7zuswbviPGq8KCyQEo/X56reg9LnQ+RI+wsS+4rTod6qqzf1kSu+R4gIPzM9J8KWrfEmrYU0= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9e7340d3-3d74-402d-9b02-08d747a1617d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 01:31:14.5913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WfwIonAoSJCM69ain3LigSySIKVYP1HHYkVwdj4PVkrkY8+n193HAxzNkCP+5xrktPBPOHK0l9RxOUtrbUv0vhwPvDceb1p523AZdlRiSzA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3865 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Although it is just a comment, the PcdFlashFvFspTOffset value should be 0xF= FF7A000 instead of 0xFFF7C000. > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, October 2, 2019 12:38 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Jeremy Soller > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T t= o > accommodate debug FSP builds. >=20 > Resize the flash map for the GalagoPro3 platform to provide enough space = to > accommodate a debug build of FSP-T. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Jeremy Soller > Signed-off-by: Nate DeSimone > --- > .../GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl > ude.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl > ude.fdf > index b33b1e09a9..1fd7a882cf 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl > ude.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMa > +++ pInclude.fdf > @@ -41,8 +41,8 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize > =3D 0x000A0000 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset =3D > 0x00440000 # Flash addr (0xFFE60000) SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize =3D 0x000= 60000 # > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset =3D > 0x004A0000 # Flash addr (0xFFEC0000)-SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize =3D 0x000= BC000 > #-SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset =3D > 0x0055C000 # Flash addr (0xFFF7C000)-SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize =3D 0x000= 04000 > #+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize =3D > 0x000BA000 #+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset > =3D 0x0055A000 # Flash addr (0xFFF7C000)+SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize =3D 0x000= 06000 # > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryOffset =3D > 0x00560000 # Flash addr (0xFFF80000) SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize =3D > 0x00080000 #-- > 2.23.0.windows.1