From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VJnmAPTc; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 18 Sep 2019 21:25:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 21:25:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="387136938" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga005.fm.intel.com with ESMTP; 18 Sep 2019 21:25:35 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 21:25:35 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 18 Sep 2019 21:25:34 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Sep 2019 21:25:34 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 21:25:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uyy44IZ5PrOnbDW5wgdREQxr+G6tdVpo5KZ47nl1q0E8VC45Ds6b6sfOEFGmhXVJR6Vnd1ukwasvqW+7Udlf1ATNTtlfp1TLA++rrxqAxLM+VbmtDa86RZcJZ7pl0mYrVRdvG/3y9eOBeJJ9VlC0z2b1BT6sY21GaCg5uug1LXi/50LIcqKqC/1oo2zrxookUypDXteCNG5KS57SAZKQnlCqJPMzU6/wMVAL2EEIMvrWVB3M+UrZRYvOkYtHoDMgFpehCa90qrzjujvyffHp4mENaKA0aOlHs1qZp92EGPmZ5U+3k95s4SHKeAccgfcNKWwMZWBI7gMGCQ9In8Z07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNbsi/qIBgkcSkc47MRamc7ZwUNuwJGvV20FwtO5mHw=; b=J5UQ8yqBxUtGGUDBhaNFSioGV+kyN9GJBdQuqFSb3DtHPg+89mG9/s+RhwQkCiXNXiKv2BTvJ6tipV9bCoZdMYFe0nI9Pi1KP7fbf/EqQaX5vjz4uuA1GAYjKvlRh/x8NJE9TF2IOEPWY4a8fdWM88CAOmN3pnQZorJguvRsdmNJmyllyhvaEAZZIdyTSrgBwQJKlOh9qtxEMb7FYgXAcUdK2PrsUFxeLCgaT1WW+Rgooej54PbhKjYTKGcBEXVerI51v0fLrgcewb49MYwLFQdBJJoC351WNZF7KN5xUd51WztZ38pwy+vnI4174H1uX8FrpQsjVrOPVdAVRPk9kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNbsi/qIBgkcSkc47MRamc7ZwUNuwJGvV20FwtO5mHw=; b=VJnmAPTc8abYcYptnlG5y26TOzKwXgz01w1AoGsUqEbougO2feXhj4LUslAOuOSzqmdvu4q/59H9QKJRnvxBDalKAwXTnp1FPtUWAd/6lkNrXqlmPzQ5hOyFj/34guaGxojgioqTpod1olmqunj4dd4pd06+/lu2G1smv8enbKw= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB2650.namprd11.prod.outlook.com (20.176.98.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.19; Thu, 19 Sep 2019 04:25:31 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::c093:6e7b:c014:6658]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::c093:6e7b:c014:6658%6]) with mapi id 15.20.2284.009; Thu, 19 Sep 2019 04:25:31 +0000 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL Thread-Topic: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL Thread-Index: AQHVbCtVBJOIjhYL3EqL7B30lfPzzacya/BA Date: Thu, 19 Sep 2019 04:25:31 +0000 Message-ID: References: <20190916010857.42264-1-shenglei.zhang@intel.com> In-Reply-To: <20190916010857.42264-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzczOGI3NDEtYjJkMC00NmI4LWJmNGQtNTg4NTE1MmIyM2YyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU1lzMUlkY1Y5NFB1WHp4Z1Nvck43TUR1WEdtR1dzVE5CVGF3bFp3OUZKRDY5aUJiSXpGT0U0cnRyWDJOc3UxbCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75247ad0-f829-4273-9c0f-08d73cb9685c x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR11MB2650; x-ms-traffictypediagnostic: DM6PR11MB2650: x-ms-exchange-purlcount: 3 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 016572D96D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(346002)(136003)(376002)(366004)(396003)(39860400002)(13464003)(199004)(189003)(6506007)(305945005)(53546011)(52536014)(966005)(229853002)(7736002)(33656002)(110136005)(102836004)(26005)(54906003)(107886003)(6116002)(3846002)(316002)(478600001)(7696005)(81156014)(81166006)(8676002)(5660300002)(2906002)(76176011)(99286004)(6436002)(8936002)(14444005)(256004)(2501003)(74316002)(66066001)(14454004)(4326008)(66946007)(76116006)(66476007)(66556008)(66446008)(64756008)(9686003)(6636002)(6246003)(186003)(6306002)(55016002)(25786009)(71200400001)(71190400001)(486006)(86362001)(446003)(476003)(11346002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB2650;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Iqe50Mc0DJAy51iaBr262kx1yunZWpJjunqzCU+mC/HMB3dU7M/yoSs+CByFaiLIJuOmHnofAkToH4+7JanzNPMLMqZ9r2FH8l5U/DXbHHpbipCIPUC2k2rYgwIzBwhRjkhIqTzhkUprV28NmZPQi+30t0nYgsqqAsGghSfkaLgAPXPlIla0NLjzM/uXA/Ar/7lown0Ml3VlQTBwxJmYtWTFs4kqnGio6fnjXpPPrQfp27SsnUOQhRtNJiAkBVOU2i46KF20UalTSlTlNG5lXYN9VLaSWIV/RRZZ0XJBcJLpEeasRTcqDW5iSTzO/tkLov07VJzfvUV6isa6dhvG8Vt8iNAlKFsH55/rYArikxns2FFoHqjxMIM+JaaA7YbRo3DAdrgn7PpHsjqw4u49bb2kT6HD3r4pJoIodcnnryQ= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 75247ad0-f829-4273-9c0f-08d73cb9685c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 04:25:31.2611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pjocyjbvseqk8L8G4LrDVy60JjZmYwmGEAGlcLpnRuXmo7Vf14/4Z7NRfMX1YPmvW+gFSd1SLJ23lbZ56bOFWHWQzzAG0JeFGF+hyrVEIBU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2650 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please watch your coding style before submitting future patches. I will fix= this one before submission. Reviewed-by: Michael Kubacki > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Sunday, September 15, 2019 6:09 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add > return value when OutTable is NULL >=20 > Currently there is no check for the parameter OutTable. > So add the logic that return value EFI_INVALID_PARAMETER when the > OutTable is NULL. >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- >=20 > v2:Update the copyright and the if...else statement coding style. >=20 > .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > index 263781a2..83736bf3 100644 > --- > a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck > Acpi.c > +++ > b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh > +++ eckAcpi.c > @@ -1,6 +1,6 @@ > /** @file >=20 > -Copyright (c) 2017, Intel Corporation. All rights reserved.
> +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -610,6 +610,8 @@ DumpAcpiRsdt ( >=20 > if (OutTable !=3D NULL) { > *OutTable =3D NULL; > + } else{ > + return EFI_INVALID_PARAMETER; > } >=20 > ReturnStatus =3D EFI_SUCCESS; > @@ -663,6 +665,8 @@ DumpAcpiXsdt ( >=20 > if (OutTable !=3D NULL) { > *OutTable =3D NULL; > + } else{ > + return EFI_INVALID_PARAMETER; > } >=20 > ReturnStatus =3D EFI_SUCCESS; > -- > 2.18.0.windows.1 >=20 >=20 >=20