From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GSfqfdhG; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 02 Oct 2019 18:23:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 18:23:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,250,1566889200"; d="scan'208";a="195050848" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 02 Oct 2019 18:23:09 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:23:09 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:23:08 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Oct 2019 18:23:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNplv8V+BDT2X8x4ZWdHWmMNyMC3ZOcJE8hmfttjGaD+g+qEdsibRE9IjIL2JiQ2PLwTmFqhhsbC4yfVwaktRDs92ASg4mva0iU4F5MO7eWSDoonHUp/a5n07ahERglvZO0Cy2sMNqAQnv3FDbhKWp0gUZk4eqXL+yyYIIKbrTsbCDKxzZCGd1wR7WfEJE8Q2LNoiY/NbdvQknts2YzxUbXh8SAx8m/YSQiCsUI/FNpygg5jLproY3z7sp3PLM3V1L0ilTYL+pKgDkQYjk4ipA2DCjhNC4K0TV7MKUcksNoju4nI5gG2gECeQ87dHmizuSetmrsq/BILteh85lLPAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ae51SFG8DCgnAXFvl9xWzbTMgmYK1OH3z3UvE8iW1pY=; b=Z+ig1nkS3YHbYYKLgiRwjtCE9lRn+tjgOH4/gNRcrZEwebl2wk5uCT6h/5YI9MGTjdb5rzKA9pNEdHNeev1o3E8N7n4eZyqDJivO5T6FIXkeBjxCCnA6hkWekD/iujR+QdukDtF659E+wW7JbAV7XVYHx5Nh9B/aXf7Ztt7AHKRFcOt7SrUuI5JK9LKHb9s2UxmvQ+a3aQuEjDdbrEtO48B9XFVjAgaUDDSpN5PW8XEGfdUPWCenuOfxdHuTRbo/zKazWKCl4rKgSNeh+30T6F839D3Lcb9lHQj+b/O54hdmx5A681ZwtjSWTrAL4IcyMeJGXcpexd9Z26Jx4NIW9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ae51SFG8DCgnAXFvl9xWzbTMgmYK1OH3z3UvE8iW1pY=; b=GSfqfdhG6WNJcGRoRKGRWBamfUKTBgj6UWV5qoO5mkLaWg0hWqhe/nm4aI3CIWkOfpbFrTOaxYG3B+4FYS2yXnRdeVX+suANaLH5Ek7ACWhHawIzrPZ//8WzRndfasWZOEefZYueaZ7HwiJEuhMnPl3R+DOX91yaweHL+qMmezA= Received: from DM6PR11MB3834.namprd11.prod.outlook.com (20.179.17.87) by DM6PR11MB3803.namprd11.prod.outlook.com (20.179.16.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Thu, 3 Oct 2019 01:23:05 +0000 Received: from DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e]) by DM6PR11MB3834.namprd11.prod.outlook.com ([fe80::59cc:8a30:6b9e:584e%3]) with mapi id 15.20.2305.023; Thu, 3 Oct 2019 01:23:05 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT Thread-Index: AQHVePQpw47DSBxsxkia6xLdBwM6lqdIH8fA Date: Thu, 3 Oct 2019 01:23:04 +0000 Message-ID: References: <20191002073621.3355-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20191002073621.3355-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI5M2JjNGUtMmUxYi00MTk0LWFlNTQtZTYwMTcwYWYzMTRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiakdnY0VzQWZsVTRycm84SVFXM0FFMWxqbTBRdzFyWm1kUHduOEF2RDZvOUx3QzRQRlY5WmNSclpSY0xaK0wzNiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0cddff22-d0f6-44e7-3039-08d747a03da5 x-ms-traffictypediagnostic: DM6PR11MB3803: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 01792087B6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(366004)(39860400002)(396003)(136003)(13464003)(199004)(189003)(110136005)(256004)(6116002)(229853002)(76116006)(66946007)(8676002)(9686003)(66476007)(8936002)(66446008)(2906002)(6436002)(81156014)(81166006)(6246003)(52536014)(2501003)(107886003)(55016002)(7736002)(305945005)(4326008)(25786009)(478600001)(66066001)(14444005)(3846002)(74316002)(86362001)(316002)(14454004)(54906003)(186003)(446003)(99286004)(6506007)(53546011)(7696005)(71190400001)(71200400001)(11346002)(26005)(102836004)(486006)(33656002)(64756008)(76176011)(476003)(5660300002)(66556008);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR11MB3803;H:DM6PR11MB3834.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FlvrGbT1+gdLWfGqzYDtHsx24AtcmO7XuJLxVojECoQQz2EMQvK9OXT3RiVivURvTkg8C2a1LfW/E8G1cMj93JrK6ZIvIvMO9BEIqYg69VgO/BsQ5Jga3ugcRQBMNwpag0mo3BUAtvOPrE77mvSJmrQxK5BM7c1j0UP2NepnIwQk6uUB995YlXWMI90Q+G23C8m0nvLursHVC4t19YEoKcjFlCuiRVfUeuTCvMiiXqwK5KVfbMFKW/9xA1zv0f3kzHFCwZ/aWz/9oHowXMxcW4w+ZrzrIpgPwysO4RCTYLP6lT1Y75o4du3JjkULrI+77Ki3chjTac7VHx1Vb562fO8uhuMFjhMOHZxxS8mMyJGjOfX+CLdA6h//FL8MO8hEqWEHVKTKmqWf05ra0doaUqpf0a3X9Gk49GaNHHoYWhs= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0cddff22-d0f6-44e7-3039-08d747a03da5 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2019 01:23:04.7891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A5ssZZM6XYCj66R73sRbg4YTiDC+n1EwPcwgPczaLNGtMtMEvCc+ybXcP3o3m6UWqufp5IIiy8aAE8vReg/B1dslgIxgqZH0SCBrGs8o7dw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3803 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please change MmioRead8 () to PciSegmentRead8 () since the address is deriv= ed from PCI_SEGMENT_LIB_ADDRESS (). > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, October 2, 2019 12:36 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in E= ISS > bit ASSERT >=20 > Current ASSERT logic checks that the EISS bit is still set after we clear= it. This is > incorrect, it should be checking that that the EISS bit is clear after we= clear it. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSp= iLib.c > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > index aadc367a9f..5fb667dc4a 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c > @@ -184,7 +184,7 @@ DisableBiosWriteProtect ( > B_PCH_SPI_BC_WPD ); - ASSERT ((PciSegmentRead8 (SpiBaseAddress = + > R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) !=3D 0);+ ASSERT ((MmioRead8 > (SpiBaseAddress + R_PCH_SPI_BC) & B_PCH_SPI_BC_EISS) =3D=3D 0); return > EFI_SUCCESS; }-- > 2.23.0.windows.1