public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jiang, Xiaolu" <xiaolu.jiang@intel.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.
Date: Mon, 8 Nov 2021 01:24:10 +0000	[thread overview]
Message-ID: <DM6PR11MB3994F7B51EE8B160306FBCEE8C919@DM6PR11MB3994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <00a601d7d43e$0ae9bbf0$20bd33d0$@byosoft.com.cn>

1. Currently  the PCD value length is More than 1024, less than 2048, 
2. Now we have 14 members, Also need to add 4~6 part to the PCD.
So we Increase the length to 4096.

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Monday, November 8, 2021 9:15 AM
To: Jiang, Xiaolu <xiaolu.jiang@intel.com>; devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

Xiaolu:
  Why choose 4096? Is it enough?

Thanks
Liming
> -----邮件原件-----
> 发件人: Xiaolu.Jiang <xiaolu.jiang@intel.com>
> 发送时间: 2021年11月6日 11:51
> 收件人: devel@edk2.groups.io
> 抄送: Xiaolu.Jiang <xiaolu.jiang@intel.com>; Bob Feng 
> <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei 
> Chen <yuwei.chen@intel.com>
> 主题: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for 
> support more PCD value.
> 
> Currently the PCD Value only support 13 Guid,When use more 13 pcd will 
> cause the build tool fail, Need increase the DevicePath length to 
> support more value.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3718
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> 
> Signed-off-by: Xiaolu Jiang <xiaolu.jiang@intel.com>
> ---
>  BaseTools/Source/C/DevicePath/DevicePath.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/C/DevicePath/DevicePath.c
> b/BaseTools/Source/C/DevicePath/DevicePath.c
> index c4d224ed61..ef493f5506 100644
> --- a/BaseTools/Source/C/DevicePath/DevicePath.c
> +++ b/BaseTools/Source/C/DevicePath/DevicePath.c
> @@ -170,7 +170,7 @@ int main(int argc, CHAR8 *argv[])
>      fprintf(stderr, "Invalid option value, Device Path can't be 
> NULL");
> 
>      return STATUS_ERROR;
> 
>    }
> 
> -  Str16 = (CHAR16 *)malloc(1024);
> 
> +  Str16 = (CHAR16 *)malloc(4096);
> 
>    if (Str16 == NULL) {
> 
>      fprintf(stderr, "Resource, memory cannot be allocated");
> 
>      return STATUS_ERROR;
> 
> --
> 2.30.2.windows.1




  reply	other threads:[~2021-11-08  1:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211106035056.183-1-xiaolu.jiang@intel.com>
2021-11-08  1:14 ` 回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value gaoliming
2021-11-08  1:24   ` Jiang, Xiaolu [this message]
2021-11-08  2:26     ` Jiang, Xiaolu
2021-11-08  2:30       ` Bob Feng
2021-11-08  3:17       ` 回复: " gaoliming
2021-11-08  3:20         ` Jiang, Xiaolu
     [not found] <20211108082136.2707-1-xiaolu.jiang@intel.com>
2021-11-10  2:59 ` FW: " Jiang, Xiaolu
2021-11-12  6:59   ` Jiang, Xiaolu
2021-11-16  1:42 Xiaolu.jiang
2021-11-16 12:46 ` Bob Feng
  -- strict thread matches above, loose matches on Subject: below --
2021-11-29  2:13 Xiaolu.Jiang
2021-11-29  5:04 ` 回复: " gaoliming
2021-12-09  0:10   ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3994F7B51EE8B160306FBCEE8C919@DM6PR11MB3994.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox