From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.6478.1591344799294927320 for ; Fri, 05 Jun 2020 01:13:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qvVVefbO; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: pqrCo4vaQh6YE7NOVC38XDmjtksmbV9lK9CUDPEyCgDMaf3CnpF/6lrgB7R4iXRK0LR/aP2YN2 r3+4UxrnFqmA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 01:13:18 -0700 IronPort-SDR: XgwrryPWmiQqLaoaDNJOCu52qT+RkKEHw4Yy/u2fyL7qD5Zn4dIP+iDet9MpOBrjPPWqeJEBIz Hqm8K+9yrNtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,475,1583222400"; d="scan'208";a="313138561" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by FMSMGA003.fm.intel.com with ESMTP; 05 Jun 2020 01:13:18 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 5 Jun 2020 01:13:17 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 5 Jun 2020 01:13:17 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 5 Jun 2020 01:13:17 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 5 Jun 2020 01:13:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZ61XygaEpvaiDVsGJrui6P/wl0i34X5o5ohZkdgjpb7/I3KwOqPb6OeFFVhqXXcW+xjkqqgwoDPmYogTt75hqErXCAMq5pu8Ff0ewCuNNBnHG8DIHug7WNHI0ducGJvLhyBv5IRo0ZpNOhgk9bhQ8+EDmgeo3vepm3bfuwtdbPXkSPq+/QitiwZsn1DL9IScP9DqqmBbqBSIwrBUc776r7g9iXVlNMz6P0LNA34ssynjoKauvQE35f7eoelvgL4WpP/fUUEUDJG2jT+fB+HaGQHKp1/4SQG0QOBr4sy8497/xlj+lzJezX/XmE02bY+ipMBwNnGDJs0ZFV90Wo2cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+Ectb4hH+DbxXbR+1engKxpOYcqzGfB6WZmqa5mwDc=; b=OQ1q7CVV/1obpBsK15Aw2fMoMPdXm0Moe7GPFr6rvKHLavXQ2TwfCH0WKoJh4KS+xFvcPiW3q7xJMmmYXQmfba791EEcpDWpXAlGHR4l1+r1b+hEZxJJEmnwFXWCPSmMmuTkaSxMR2zXxzzAR+Gt2pjrEBRyx6+f0iIPBx1ip9R//3yNIqz7cxo+UJNqjRUi9GphewPKefIEHZDJnuCYZ73DlJVb6JP/J4/QiEPgG0MvfV6mGC3OtIbxAKQO7qHKADGm5uSlj/tsCDrdAAUpqHlKTWrMKlLbHGSQKFsBFfoatwjxLyEWTHrC16YIfFphjC3i8IX0RszQsogvcr2/iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5+Ectb4hH+DbxXbR+1engKxpOYcqzGfB6WZmqa5mwDc=; b=qvVVefbOPuxDOPBnBcTD0vNQuljEOJLv62lmCbNn2mmM7GpKR4mZz+dSFuKfxYg91YDutUKYc9njcHl5DgLaKlfzu8drRs0MLkqrCXuhu+4nI6E6aVfQrZAs7/nv9DWLyPbYdI9yoazSEySXiOpPkk4NdEcno30tMGIXIwV0z3w= Received: from DM6PR11MB4012.namprd11.prod.outlook.com (2603:10b6:5:6::21) by DM6PR11MB3212.namprd11.prod.outlook.com (2603:10b6:5:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.22; Fri, 5 Jun 2020 08:13:15 +0000 Received: from DM6PR11MB4012.namprd11.prod.outlook.com ([fe80::40a5:ddc2:72f0:d5fb]) by DM6PR11MB4012.namprd11.prod.outlook.com ([fe80::40a5:ddc2:72f0:d5fb%6]) with mapi id 15.20.3066.022; Fri, 5 Jun 2020 08:13:15 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "michael.kubacki@outlook.com" CC: Bret Barkelew , "Gao, Liming" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/2] MdePkg/UnitTestLib.h: Drop FrameworkHandle param from SaveFrameworkState() Thread-Topic: [edk2-devel] [PATCH v1 1/2] MdePkg/UnitTestLib.h: Drop FrameworkHandle param from SaveFrameworkState() Thread-Index: AQHWGAvAI+Uu9Ivt9UOZLDLhYEDGBajJ8jFQ Date: Fri, 5 Jun 2020 08:13:15 +0000 Message-ID: References: <20200421183502.39876-1-michael.kubacki@outlook.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4515803c-c561-44c1-e508-08d809284c66 x-ms-traffictypediagnostic: DM6PR11MB3212: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0425A67DEF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jPuxxV7dLfNJ5cXM3kS3fow0Ngfcbm/8fFv7Irgxm3HpMfna31sWvxAC5NWCssXZpyJe8tprquMG2DKeC1ZNpxHD/c5w5rutN3ruKstEIWDhyXDw/MgGLeHgAOH2Hf9eYniUqir5ARd5vD3AbFH7vkxcZcNzmblhGNfbsXmIzz31MnQG/gldQDSp4Hu7jh5TvnhVfzLXDXg6xDyQEmHgmD6eYWmy6oiWWmkv8fMVw+EwTe50+YrnD57Nn+n3iuPP/Soi3Q2o8mdOxCxuAx88DLy+WMyYz9OlC6LkltDnRULLVZylhvrpwWNk93rdfPu9HpiuPOhbenZXolhtoOZo1Xl3QlNl5vJQ3YN4v9+QUCG9EfLZSDJTe6hVUSG/7Gb9bayztABDS3f5gsPC9NvMTg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4012.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(376002)(396003)(366004)(136003)(346002)(2906002)(26005)(186003)(6506007)(53546011)(478600001)(7696005)(316002)(966005)(110136005)(54906003)(5660300002)(107886003)(33656002)(4326008)(8936002)(8676002)(52536014)(86362001)(71200400001)(76116006)(83380400001)(66446008)(55016002)(66946007)(66476007)(64756008)(66556008)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: UZZJUMPfqa82y/LDXcWP7AgGzSyDx5oqcxmGIP/bFacIkCfQY0dehMfHw79OFwIDhCjksiiuIfGvooXTbN5aeod+iijwlYWREZBqhOv/UO5LU0hDEBc5pMZNUYE9OgAZ0eGrsLVFDXFELSNrrdMgwzaQVc8nR3AN8zy3TdSEiTJdm243mhUFwP1vDn3b0byXu8i+3UlQI9KEcg0aAR7T970S5Xk3F1paKTJ09151onB0t9P5aHUNRFFfCeiX58weBWWhRRHP5OyB62gv/T3Lvr66E1+lAGOONT+VxJelf3WxrfuhO1JegQz+Byv1ut4hq6deeRux14yoHJ1T3t5nLJhYV2xTnbsTs/Ie5z4N6nK9NbT6uJIfGNu/uT0BQExRTRsKHDsDeHZ19MyBikQTPv0XFBtPGIdCnkiX+8cL65xOyKil7k2wyvfGv2pQV2NnDcHqKVGhdzln9EuImLJZ362KIWejjfSSiDgHTqXGFAw= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4515803c-c561-44c1-e508-08d809284c66 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2020 08:13:15.6349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H92/juY6qx7Xxec1So1r9u0VeReWsXCqfHHidLOlad8W3+FhXCwOINWUh+YJx37TJZOHmW35y21pT90nNnjHEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3212 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhiguang Liu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, April 22, 2020 2:35 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Gao, Liming > ; Kinney, Michael D > Subject: [edk2-devel] [PATCH v1 1/2] MdePkg/UnitTestLib.h: Drop > FrameworkHandle param from SaveFrameworkState() >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2612 >=20 > The framework handle can be retrieved from GetActiveFrameworkHandle() > internal to SaveFrameworkState() so this change removes the parameter > from the function signature. >=20 > Cc: Bret Barkelew > Cc: Liming Gao > Cc: Michael D Kinney > Signed-off-by: Michael Kubacki > --- > MdePkg/Include/Library/UnitTestLib.h | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/UnitTestLib.h > b/MdePkg/Include/Library/UnitTestLib.h > index c06c36bea5aa..a4374580a8d5 100644 > --- a/MdePkg/Include/Library/UnitTestLib.h > +++ b/MdePkg/Include/Library/UnitTestLib.h > @@ -313,11 +313,9 @@ FreeUnitTestFramework ( > at least the current execution count) which will be saved by the fram= ework > and > passed to the test case upon resume. >=20 > - Generally called from within a test case prior to quitting or rebooti= ng. > + This should be called while the current test framework is valid and a= ctive. It > is > + generally called from within a test case prior to quitting or rebooti= ng. >=20 > - @param[in] FrameworkHandle A handle to the current running > framework that > - dispatched the test. Necessary for re= cording > - certain test events with the framework= . > @param[in] ContextToSave A buffer of test case-specific data to= be > saved > along with framework state. Will be p= assed as > "Context" to the test case upon resume= . This > @@ -325,7 +323,7 @@ FreeUnitTestFramework ( > @param[in] ContextToSaveSize Size of the ContextToSave buffer. >=20 > @retval EFI_SUCCESS The framework state and context were = saved. > - @retval EFI_INVALID_PARAMETER FrameworkHandle is NULL. > + @retval EFI_NOT_FOUND An active framework handle was not fo= und. > @retval EFI_INVALID_PARAMETER ContextToSave is not NULL and > ContextToSaveSize is 0. > @retval EFI_INVALID_PARAMETER ContextToSave is >=3D 4GB. > @@ -338,7 +336,6 @@ FreeUnitTestFramework ( > EFI_STATUS > EFIAPI > SaveFrameworkState ( > - IN UNIT_TEST_FRAMEWORK_HANDLE FrameworkHandle, > IN UNIT_TEST_CONTEXT ContextToSave OPTIONAL, > IN UINTN ContextToSaveSize > ); > -- > 2.16.3.windows.1 >=20 >=20 >=20