From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.29715.1640238278615251234 for ; Wed, 22 Dec 2021 21:44:38 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=E/LZdFo7; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640238278; x=1671774278; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=X9Yp94Xrm8VDwGei773RYqhejwA7XCthKe2+bh4DPf8=; b=E/LZdFo7y14NVndUzrCj0V6E9kMdS8cUnu8sJ3NDI+k8R+t5m+qd0MP/ 8SRZm3oe5wPfqFx5b71LBo+TveYwkFR91/44H+Iq9pRU7CSm/KAv+9LGO mNoi8p/UfiQOt7f3jMiVNWH7R3z1UC59LamWJ5OGAyfgQhvNn69QSNFHG XGvsDAtai3GZWqwmVrvvuPAbu3phk42x+wjjYI0L7ImFK9QRhhs4niesJ cNpabIaOnUODjqKPffj9FWyXKmurLpxzsJ9S5Bq/niiIVgW56B02jjEVZ +h/np4QrUfoUDkfyiuD5bKkFWMtEDuUqFfhuDEMlUIkRtCtQATSl196j3 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10206"; a="220772428" X-IronPort-AV: E=Sophos;i="5.88,228,1635231600"; d="scan'208";a="220772428" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 21:44:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,228,1635231600"; d="scan'208";a="756649705" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 22 Dec 2021 21:44:37 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 22 Dec 2021 21:44:36 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 22 Dec 2021 21:44:36 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 22 Dec 2021 21:44:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBpfS27j+lyilwV4cELPS6M3npqHLZZyWval8sWlSuSuQItn17Z0w4FldkOn5OAmJRALkpfXcsyPIOcz1oSsKpCFdrvZsLEs3GGhpXe5F3QQFE9vbP2HonfD06ydHPPbuiznO12WrgqW7BkaGQBUp/miXAMkrY4yku9hvTauzZP0497B8kaejG2kmhr2A3RnjTQUqTIk0BMM9nLAQWOUYbYYTMCvHwTyYT34AtRfxGNCPQ4+hr7tVdgjgRgyjRWurDq/jsyypxmkOWArYlV+1Hi1nIpwwYUh4Tp1g/2Oceofb2SkIqHgHoZKyU8JHMtYIQzPU+jZ6olow4Frs/TmJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QpXs5T4XDQkfM6GZAjkma/7X5omM2qNkWtc/cwZ8ugA=; b=H6FeHQeFFXDuldtoxJng5xKnLZTamF/rpUr+xF0Qbg2EkOx5xoRfbZDKUDtMmchWP47jCKFkuArIp35kZkNIQFQm/svdymoWU3ayiVQ2os+91tjzyBstpP8N72hbwjjS5eMVSVfqZUXTHzAHa5s2Tngpd/TCipPAyLQcIW9MLUKAQnsiVEhZIfGAdQ/sdQgc3AheW0GiTAY1YCO+FbN7oifpnWKEeNqAYmHUqdqD5dzNKbE8CbhhRuWCQvghPVY7f1q61/mp8ECPgH8F1jryfjxx8S6lOUPHXakHZtsy2IPjCpdeLu/SetVX0rKd9mo6PDyZIW3U1dBYgD2YaqjVXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB3980.namprd11.prod.outlook.com (2603:10b6:5:192::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 23 Dec 2021 05:44:35 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%6]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021 05:44:35 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Ke, VincentX" CC: "Ni, Ray" , "Chiu, Ian" , "Chu, Maggie" Subject: Re: [edk2-devel] [PATCH v6 3/3] MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem Thread-Topic: [edk2-devel] [PATCH v6 3/3] MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem Thread-Index: AQHX97RuV8xlp1vZXkyg+ks57eLU76w/ijwQ Date: Thu, 23 Dec 2021 05:44:35 +0000 Message-ID: References: <20211223041919.1307-1-vincentx.ke@intel.com> <20211223041919.1307-4-vincentx.ke@intel.com> In-Reply-To: <20211223041919.1307-4-vincentx.ke@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b1035cd-665f-4517-bb90-08d9c5d74d51 x-ms-traffictypediagnostic: DM6PR11MB3980:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DUTgP+cJqnHJc4u1zjIqmW68C4T1g2nI5QqPQF4fCFexjqyoQSalen3g2LTcNRzhBHg9CfYaiTM0lBIf1lcy8Vtr3F/kaHeSu/AQioNkPzb8fqfRIw1M78ZBx6i//oKnJiJFR4thBbHRinw599i2aDvVMhOPHSStF/+u5R1ajzoUb6MaYvnlxA1YW/RJoTl+s9eDfPwahxJC2wRsjak5l3acpxcKxq1nIL4mdyRYCx7+OsexKQtJAt+VjtpjI//CFaNJOW4MSQjiHHSB8vEJ8KCNbwuXya3uDOs0l8OrrB3/8FLFO0jmNba9cwgcedOPDlAmKKD0bRA1Iq6Q3r3OxaViNfz8ZWF5kLQI8phjUU+KEZYqORGViGrPGlM8phJNYleGhU/SJdVW9kTzVhYaI/4KZcQZlBZBkGlTtV/rKaeRYX+2IdiQpNMy474Lr5+rxfran+Ag6gEFBehLvDE3ipsW3YTtGMQ6H65j3FDAPshmKTUVQW7oNkQFFJcrbq4aMlAMNRN2a5rNv86emZ4WEhuUw7A7AFyF7c1wzKZKT+aoMzRKUIPjJ0EZRg9tbdwLzVVvQ2OtnxqTUj5qyWLlk5DWDfeKv4InfB/RKzLbsnCBUgbfRbr8+3Re8QL3iIhfiUNdP2mWifPHqwN0ngNjCcQ6MObGK4z7sD2+bZXnSoCba+G6UxK5VZjj5qNP2eKrxgQmY8Ez/FHHMmY0VoVeTPCDFUmXc6+RxgXoSk8wefClTJW9jlheg3RSXeBYJ/JPoNHFYTYVF+jsAkGsCZkTo2TXTZX1wVaae2HsTcm426LkSxEdXoFaH99vbDr7aGBxhzsLqsgcjF2s31HAH3v7qQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(71200400001)(2906002)(64756008)(38070700005)(122000001)(6636002)(508600001)(54906003)(4326008)(110136005)(38100700002)(8936002)(5660300002)(107886003)(83380400001)(26005)(316002)(33656002)(7696005)(66446008)(186003)(9686003)(66556008)(55016003)(52536014)(86362001)(76116006)(8676002)(66946007)(53546011)(966005)(66476007)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4MKYkhZmrqDoo+si2l8YpZVvMBRI13x0b/AjAqG5oa5tqi2JvDgBuTIMjcN4?= =?us-ascii?Q?Bxr+2zOJCMOGH5rocEZHk+LxWZWCQ/GrP7ZLo0UIo5ACmCUSFXZSwK4W5tHT?= =?us-ascii?Q?mhORokNSqcVeq6EaNmnZ4xklqskx6gjrNnqbhoFHoFukfwRQ1uBsFzf7BycV?= =?us-ascii?Q?4kUXRg91RPD104q9g4YNMQgZ24LnrvwSJxyqk+44YDjTlBUpD0RCG/6q8uK+?= =?us-ascii?Q?n8u5Ahh8QbuofHr5Ovnkzohmy05CCiavsfWzNSh/wS8G2Z3jGC3/09ckyiDF?= =?us-ascii?Q?c9j+S0XizJYzPInByQh++05E9IyKlmFbh+wBlJFGNoLyUoAQOS0BQVQeip43?= =?us-ascii?Q?Z6PR1Zgnp77EnNxhmSSwDGOWQxhQx4I56EtaoPIUgoxfxsRCns6gEaGLZvTr?= =?us-ascii?Q?kl0v1ySzpMOA6BZFyYV5RP6M1Vgei2Xfrj5ZGIDjJinsOWFZj3hL7aJiaZRL?= =?us-ascii?Q?QhVH0YtngRDbwbkGI0JzdaPhoJ3DqcVtgRpz5I1ALE15Pqpmw1s1BfaYC6ri?= =?us-ascii?Q?5WUCiC0Ve6zbFS1zqMqcecJ1JF8iQeFTssK7WD+ZMIMSozgjmLQacbQmkxA4?= =?us-ascii?Q?a0ZAV/G8ymzVErBrq9+5M6EaiiDqglHJ6gxmLxJL21zquM3uwg4KlIvg1IrR?= =?us-ascii?Q?OP4wtS7Cic6B6/3gBRb7KaGZkk+zHGcNtPYoAeWTk4ESzIDzJJiJfwTKE1H0?= =?us-ascii?Q?YY5ElwHrbjD86Uw0MzWU85m/pmU4h7iQXmG+eSrMOdkPiw2ekME1t4qaegWt?= =?us-ascii?Q?hGPZ1VEGwSZb9D6jGkc+XoIA6nk0nDWeP9TC15hLTbFQ65ME9u98rWOZCout?= =?us-ascii?Q?dM9BYGv3JDJBTYT5tMHAV2YoE72kciqsy5nuVOPWNkLYr5Z4Ry2YOnv7ccce?= =?us-ascii?Q?7kg3mNayD8sucI0ZD1cl6zn2IfI+D03mIwZpoXgsg2bB1mxX0Ns3jml7XH+I?= =?us-ascii?Q?IpcchN6CZvvB73LHfUyln9MNhSxO5JdalMGqXff01f8Ab7tpqW0Ew9ilo2WD?= =?us-ascii?Q?rdHLpXQfyz0DIao+h3Bx19+YyKTzxb2HBzf+9tD/Rh12j47jheX8PLWLcBdm?= =?us-ascii?Q?kBTaiPD8d8csYcfwE44/ZG4MBVp/fn2GOb802Q70VOiXC9efHA1hZJ7fwHNr?= =?us-ascii?Q?o7gZyVT13ISsCfEf/CA+dEggKPJm4GMy4d1JZ93hMPKtI666Fg5G3CoGVSDH?= =?us-ascii?Q?JkUUVn3IQhrMVis9yaiJH7/A8fT/f0lNOpkzeEH8D9JzmVLvhZ1QS+yQzlJH?= =?us-ascii?Q?aWSjuZQUPpbdoA+EB6isO8cE55ZkJHnLp4EEAFqYMdU50twq5QRUAFxiYK3k?= =?us-ascii?Q?BtyVFHJR/6yJTn6wqCHs0v1Ztgi60JwSF235se80Ipl2WSfOcj1tZVWzCoTW?= =?us-ascii?Q?6SPvzNQWIXYQXtvDgu86HQp0+zaEVVwY+KR10ERjI8CLh1M+TIFe/O6tPID9?= =?us-ascii?Q?1qETytonBKZllQEgZK6D8feTDOinXGdK1vXcpmgHi1W0EubHqQlXCqK1OkXX?= =?us-ascii?Q?i7tgqt3Cnoll3fuhMWILH46mM8nu3E651CjSJh8g3Jc2dXia3474v3Jl9k+P?= =?us-ascii?Q?pwYMwKEf4BLYmHqgoK/IGb8pnxZREd4TSh8zN6uzBGGdEPx3Y6jxNpblIdz0?= =?us-ascii?Q?yX0olU0dweWIq+/YRECaM1Y=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1035cd-665f-4517-bb90-08d9c5d74d51 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 05:44:35.4697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LfJaEHamEncMBECxNR/cpxjDzD3TizxHw6NrdwfFXbkhPdHdJkeL6hyu5g43bLpA0WclxIG63VT38UI18kneOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3980 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > VincentX Ke > Sent: Thursday, December 23, 2021 12:19 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Wu, Hao A > ; Ni, Ray ; Chiu, Ian > ; Chu, Maggie > Subject: [edk2-devel] [PATCH v6 3/3] MdeModulePkg: Put off UFS HCS.DP > checking to fix timing problem >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3776 >=20 > Put off UFS HCS.DP (Device Attached) checking until UfsDeviceDetection() = to > fix timing problem. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ian Chiu > Cc: Maggie Chu > Signed-off-by: VincentX Ke > --- > MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++++++++------------ > 1 file changed, 19 insertions(+), 28 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c > b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c > index cffe8e02a7..864bf6928d 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c > +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c > @@ -1353,23 +1353,6 @@ UfsExecUicCommands ( > } > } >=20 > - // > - // Check value of HCS.DP and make sure that there is a device attached= to > the Link. > - // > - Address =3D UfsHcBase + UFS_HC_STATUS_OFFSET; > - Data =3D MmioRead32 (Address); > - if ((Data & UFS_HC_HCS_DP) =3D=3D 0) { > - Address =3D UfsHcBase + UFS_HC_IS_OFFSET; > - Status =3D UfsWaitMemSet (Address, UFS_HC_IS_ULSS, UFS_HC_IS_ULSS, > UFS_TIMEOUT); > - if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > - } > - > - return EFI_NOT_FOUND; > - } > - > - DEBUG ((DEBUG_INFO, "UfsblockioPei: found a attached UFS device\n")); > - > return EFI_SUCCESS; > } >=20 > @@ -1443,6 +1426,8 @@ UfsDeviceDetection ( > ) > { > UINTN Retry; > + UINTN Address; > + UINT32 Data; > EFI_STATUS Status; >=20 > // > @@ -1451,22 +1436,28 @@ UfsDeviceDetection ( > // > for (Retry =3D 0; Retry < 3; Retry++) { > Status =3D UfsExecUicCommands (Private, UfsUicDmeLinkStartup, 0, 0, = 0); > - if (!EFI_ERROR (Status)) { > - break; > + if (EFI_ERROR (Status)) { > + return EFI_DEVICE_ERROR; > } >=20 > - if (Status =3D=3D EFI_NOT_FOUND) { > - continue; > + // > + // Check value of HCS.DP and make sure that there is a device attach= ed to > the Link > + // > + Address =3D Private->UfsHcBase + UFS_HC_STATUS_OFFSET; > + Data =3D MmioRead32 (Address); > + if ((Data & UFS_HC_HCS_DP) =3D=3D 0) { > + Address =3D Private->UfsHcBase + UFS_HC_IS_OFFSET; > + Status =3D UfsWaitMemSet (Address, UFS_HC_IS_ULSS, UFS_HC_IS_ULSS= , > UFS_TIMEOUT); > + if (EFI_ERROR (Status)) { > + return EFI_DEVICE_ERROR; > + } > + } else { > + DEBUG ((DEBUG_INFO, "UfsblockioPei: found a attached UFS > device\n")); > + return EFI_SUCCESS; > } > - > - return EFI_DEVICE_ERROR; > } >=20 > - if (Retry =3D=3D 3) { > - return EFI_NOT_FOUND; > - } > - > - return EFI_SUCCESS; > + return EFI_NOT_FOUND; > } >=20 > /** > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20