Re: [edk2-devel] [PATCH v1] MdeModulePkg/AhciPei: Fix MMIO base assignment

["Wu, Hao A" <hao.a.wu@intel.com>]

Pushed via:
PR - https://github.com/tianocore/edk2/pull/3338
Commit - https://github.com/tianocore/edk2/commit/1dccbd1a382aa57719e4e0432b3bd6a03a888507

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Tuesday, September 13, 2022 12:36 PM
> To: Czajkowski, Maciej <maciej.czajkowski@intel.com>;
> devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1] MdeModulePkg/AhciPei: Fix MMIO
> base assignment
> 
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> 
> Best Regards,
> Hao Wu
> 
> > -----Original Message-----
> > From: Czajkowski, Maciej <maciej.czajkowski@intel.com>
> > Sent: Saturday, September 10, 2022 2:11 AM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH v1] MdeModulePkg/AhciPei: Fix MMIO base assignment
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4041
> >
> > There is a mistake in getting MMIO base using PciDevicePpi that can
> > lead to the data corruption.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Maciej Czajkowski <maciej.czajkowski@intel.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c
> > index 98dd732a4023..47367f43f73a 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c
> > @@ -405,7 +405,7 @@ AtaAhciInitPrivateDataFromPciDevice (  {
> >
> >    EFI_STATUS                Status;
> >
> >    PCI_TYPE00                PciData;
> >
> > -  UINTN                     MmioBase;
> >
> > +  UINT32                    MmioBase;
> >
> >    EFI_DEVICE_PATH_PROTOCOL  *DevicePath;
> >
> >    UINTN                     DevicePathLength;
> >
> >    UINT64                    EnabledPciAttributes;
> >
> > @@ -454,12 +454,13 @@ AtaAhciInitPrivateDataFromPciDevice (
> >                                    &PciDevice->PciIo,
> >
> >                                    EfiPciIoWidthUint32,
> >
> >                                    0x24,
> >
> > -                                  sizeof (UINTN),
> >
> > +                                  1,
> >
> >                                    &MmioBase
> >
> >                                    );
> >
> >    if (EFI_ERROR (Status)) {
> >
> >      return EFI_UNSUPPORTED;
> >
> >    }
> >
> > +  MmioBase &= 0xFFFFFFF0;
> >
> >
> >
> >    DevicePathLength = GetDevicePathSize (PciDevice->DevicePath);
> >
> >    DevicePath       = PciDevice->DevicePath;
> >
> > --
> > 2.27.0.windows.1
> 
> 
> 
> 
>