From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.516.1686108067511763901 for ; Tue, 06 Jun 2023 20:21:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kOG73ynr; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686108067; x=1717644067; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3I23IZXYbxXe2ITqy2kB459VhuukXTrj3AKk13+nYcA=; b=kOG73ynrpB+K+f1GaBW+mPMlp4qhwga8uITEjPo6FeF6p6c6o7WlkHyC xzL7Yc6uULVFRssu2s17KX/xjtE+HB8A9iOaGD9CwDUrtp7fh6z3ZMr4t gohXd97NXRHZmIlkJ6xREhYgfhUa9PcS4iOoI4vTyE1CzA/lbJudN/Lle 4X2xzlRCobjliggHtnxM2TESybQnRUEauLtHYMArMArAi7MalHv/1IQ/F pyaVP5EVnZrYdnViG3mk4rEEA5Q/A6nNRX5BD0pxljuGE20bFSjoNsNTr mRE3XX50mj9jRg8/d7qBRDajbVX/GzsrzTdWCbuKW6YYQykMMJxea+wNW A==; X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="422705999" X-IronPort-AV: E=Sophos;i="6.00,222,1681196400"; d="scan'208";a="422705999" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 20:21:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="742415147" X-IronPort-AV: E=Sophos;i="6.00,222,1681196400"; d="scan'208";a="742415147" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 06 Jun 2023 20:21:06 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 6 Jun 2023 20:21:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 6 Jun 2023 20:21:05 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 6 Jun 2023 20:21:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSsqxXVVwnyWrWJvhNFt1rLZ0uN8KCiuDoFauUR/OLsfx6muZzif6vwyrY8ff9HjgBORucbmYu/gtXD1VwyF1AfXNUy123bxeAroqQOJTz7BAtJSeBwNAzkfgveLb6JB9uiLc1kjlidLtk/xgkfyEC2djiD55ew+v3FqfHvXuw9AO66fNPinKo7BApu5LrQLE01Yb2n2ndQ8Ifhk09IhRn7owLan9wDDBtzhJrrkJ+cfSZjvtUh58Iq/iC+qys/0BCxXhCRtMoYrNEB0GDxJpjah+oxEPmACyTL71FGNxBkEb/47zmDHTn+qJhOlTWy9vUqg4hlug/nbDTjncxqmTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i1Go78IomjnwEyIgUPLN56o/O1NJdTUCQGAcXbhY3Mc=; b=hqbHhwjmFUzeOzM0HdsXCWvHjD+h8cEApotDBG1W//UBBG1X5JQk+s+kjn/NFB4Jyb+JznPR2RK19pTMAPuThCf7Xqtsyfo+j3/BhDdbxdCOaUtIf03mQ9+zqwz6pgE0Hq7hUL2iWDt2jdtxQEfKYmJJrXRBDLxHN52p6n9rRXz5ve2fO5eWob8ncdx72Sc/LRlAuDq1Gr8uKgHc7m4ewJGqoKsk8ZW7v9MQpts4bPy6c00kPFvGXEbbMofhv5DwiAgLp0NlFaoamkwnBbK/0ovIrTI55P2SzMPnxTpAJkvp6S5q/P0Pwe45Lel5vwRKhT6eU/B5xF3qSdN2UpdUdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CY8PR11MB7921.namprd11.prod.outlook.com (2603:10b6:930:7d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 03:21:03 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30%4]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 03:21:03 +0000 From: "Wu, Hao A" To: "He, Jiangang" , "devel@edk2.groups.io" , "Hsueh, Hong-Chih (Neo)" CC: "Chang, Abner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjaEROuhuDY7qr02+W0SYB4rkMK9zxJ5QgAC+DQCAAmKz0IAH3WyQ Date: Wed, 7 Jun 2023 03:21:03 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d21dead0-8696-4352-9606-25ca7d77c028; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-31T14:41:31Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CY8PR11MB7921:EE_ x-ms-office365-filtering-correlation-id: 6d155255-e997-4955-8c20-08db6706394f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RFbNv6W6qrRTqlaipPsFxz/DeUGmWcomwmtafQb53r3FOitqDDd8htMHNiXsEAh2tmLytN4tgiBlip3obwDIuDv0VI50OX0B9/ldQqBMBxquHid9XGDUGE7joGQvnei9OW3qzaES8rdIyA6VR/7mYqEjuD5ikdJepZRYYe0NoQrEWYThzzbxhPiCEj9Nt4lQz0bQFDJIrXqxqLEedWDaYYKgE3AiqDtyuIccSpkwjJl41ziA5agelcTaD6Ox6+T8q07cqewxvzMTQOLeaCSbAu+5AOpN0UDsciQjROrVmNarCYKAgS3LZyGKkVCqA8anGSHLagShZ7W5rrOvJyecMP1f51cZwDypRvHLrwkZdw+cO+Yslu+NlkNAw3btpRmn4efn82RuBVIQKgbrS0rekU/Bx1HxN3yz+fautA6MveYA3YGFaHPu914W2b+RYcF0987XeEGAujtA5wLZ9vsmS2Oyqkd6PKsNWVn4xyXwsHn6oof5tCW62+z/XdlKjdmsevypB8yGOTccvMal1dPbhxxzLezM+7iIy770pdPvsCfWhBy04D1X8KNTZcxiefgqx0x+NBNyyA6HEBJIljqMSvRdpd7KSdX2X6u1ZqfVBmTPtF9xjtrPEcp8YtuJ1dpnYXvDLeyw/S0EZEtEZuJStg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(39860400002)(396003)(136003)(451199021)(41300700001)(316002)(110136005)(82960400001)(122000001)(52536014)(5660300002)(66899021)(2906002)(76116006)(4326008)(66556008)(66476007)(64756008)(66446008)(8676002)(8936002)(66946007)(478600001)(71200400001)(38070700005)(7696005)(966005)(86362001)(186003)(38100700002)(55016003)(53546011)(26005)(9686003)(33656002)(6506007)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?djZDjcCJ5n39vHv1qd6mnuidgNkM+Jqq8s5AF6HFxET+N1spin/ch52gKVMa?= =?us-ascii?Q?4OiD/722cMCcXoS6DYAXNDVmKEC67nMXuKkibx1mZCuwZrqrwbDZRFr1ApWa?= =?us-ascii?Q?NNPMHo9A0yYhLGDhNHWm4zHEHyB9375oVRePvw3q5p9nhFTonnL7uty36uZj?= =?us-ascii?Q?hNfc7dgu2JvU8MHXrDsV7wGaKgmGm33JggUH1NrkVSVYYMnQBegtNtiS/6Ts?= =?us-ascii?Q?cz5RXNNiab+5THMeAdeFyBWN/TXR6WQc8a0VbZlaMKY0C6oSBXyPFkctflW9?= =?us-ascii?Q?q/xHipUfKWPg3aZGR5xsUSLkxdeErb7PAdVBq40jI1ID2ExcB2aBkLAxhrP7?= =?us-ascii?Q?s89Tg2UROjXtRiGBJfDb6AxNnqhpsZmjSNol/mGK1ytNYVBrVi2BLW9W+t4e?= =?us-ascii?Q?C3cVItbVgk/9/iZlpnJ33/BQdwEhvXtk8w1dShl2e6nWdHwz1g0YgexuPZi9?= =?us-ascii?Q?SFsdBsGHMBXt8nZ49t+5tdxScGqaCxhIOZ7Rdjf4XA/gLodXW3TcwrUM6r2Y?= =?us-ascii?Q?XtA2WmXZ5A94SKTrbJK8n21vlWvcER7VexOe6P8hQ+8LQ919GAoQsaXE6qsD?= =?us-ascii?Q?sEdTwHMDd1OQ5dVkrFgphHbYD89pn50CdpzXH2MLn2JCO4xQ45nZ79QvNQgC?= =?us-ascii?Q?PrwNb93rPN4WsgQPg4kFEPgftWlikYi6FscmeSCUxQBPnX2qEABjQBzb+RlL?= =?us-ascii?Q?JoTDm9HIuqjkpY3T5lTuCJbBn3n8NedU9t6SAO3MyCmGjiPWGCELPLo+/DK1?= =?us-ascii?Q?BNjjG0YbpJZJ02Ysfigbrqu0Rpeg1i/Pq1EiEm7b+IODk4jG0FimijgXTXXv?= =?us-ascii?Q?I4HQxsJVrObty6bM+a8yTbs66ZlPbs4TN+KV34C7/lrs7/yVATdLviP2FliC?= =?us-ascii?Q?HWH4N+ylWPvEm54QldPAsWIG+AHq83nrqVt+JwS8wM4ZZ3p8WEeRXFjS3YFF?= =?us-ascii?Q?2qy1yzgRI/rgRYWAKU6OmSpT7Gz4Z4RDu/CzEtpS7oM/QVhjF/Bl8Bekp03z?= =?us-ascii?Q?sCZHDFA348cOdG1wDv/zSuyHTI/34lNncmTe+hDjEdplPPfyG5h7uHROz4lW?= =?us-ascii?Q?pTSLbC6sBCbefjjS6+XI+96XR8EUhXnlZZaicn6eUYKu1ls5CIA5JalSfj2C?= =?us-ascii?Q?A6zLiraOoz6Yx/9tO1jsaGXASFGi9qYV/V2cDogFAgJWD42zOuvN7N25rMiG?= =?us-ascii?Q?0cDTI0LCRZcXv6CgyMvsyqpVH7AgQNCKfSV6hOwa2t4XcShV2UUfC6OCDGCQ?= =?us-ascii?Q?OanXv9bnKLjwLKY3MbsAPMPiMh/PCT87H3c1s46TiPFx4lCtcwIeDAJP6P5L?= =?us-ascii?Q?+ZLjugIzZdzuC9RilnMUIwOlq/fUX1m4oHL8AHzfimYjX0J1NuSiAj/cg8cr?= =?us-ascii?Q?FtTgSSLzP6MC7NoIIqiJmf2u3JNWm6XwqTMPG70XfMt2M0T5y2EuNY8/M9nI?= =?us-ascii?Q?Ad9KLJ1vjYo4jBMDXvSjvf/xWXvYUJHvMbaq6vvfRKAeuE9BHK/skbHl7dVO?= =?us-ascii?Q?Dzl1/SQRMuoSusAkxc0JAe/eGG3MZ7Fw3bYN5Q/I6G+EEnBxS/RnXRbKKHg4?= =?us-ascii?Q?/1FmmAikOXsJNOAGHLHKPP8/hrpyS3rB8yl7ov/y?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d155255-e997-4955-8c20-08db6706394f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2023 03:21:03.1559 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jsG7ZUag086oj5+E7y5/MqeqiFI7xmQgZHNlKr0Yct7l00EsdjFw7ZRTFx40sqVOA+xZhh8jASL0Wbw7rreV2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7921 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged via: PR - https://github.com/tianocore/edk2/pull/4478 Commit - https://github.com/tianocore/edk2/commit/67fc78d026490ea4c375eeb19= 724abb40e7be8f2 Best Regards, Hao Wu > -----Original Message----- > From: Wu, Hao A > Sent: Friday, June 2, 2023 11:14 AM > To: He, Jiangang ; devel@edk2.groups.io; Hsueh, > Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM >=20 > Thanks. > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > > To: Wu, Hao A ; devel@edk2.groups.io; Hsueh, > Hong- > > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier > > port in AhciPei PEIM > > > > [AMD Official Use Only - General] > > > > We did crisis recovery and Opal HD password unlock from S3 resume from > > SATA HD test on two different version of AHCI host controllers. > > > > Thanks, > > Jiangang > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > > To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) > Chih.Hsueh@amd.com> > > Cc: He, Jiangang ; Chang, Abner > > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier > > port in AhciPei PEIM > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Thanks, the code changes look good to me. > > May I know what tests have been performed for the patch? > > > > Best Regards, > > Hao Wu > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Neo > > > Hsueh via groups.io > > > Sent: Wednesday, May 24, 2023 1:07 AM > > > To: devel@edk2.groups.io > > > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh > > Chih.Hsueh@amd.com> > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > > in AhciPei PEIM > > > > > > If there is no port multiplier, PortMultiplierPort should be > > > converted to 0 to follow AHCI spec. > > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > > > Signed-off-by: Neo Hsueh > > > --- > > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > > index cd55272c96..7bd04661d0 100644 > > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > > @@ -3,6 +3,7 @@ > > > mode at PEI phase. > > > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > > + reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > > EFI_STATUS Status; > > > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > > + // > > > + // If there is no port multiplier, PortMultiplierPort will be 0x= FFFF > > > + // according to UEFI spec. Here, we convert its value to 0 to fo= llow > > > + // AHCI spec. > > > + // > > > + PortMultiplierPort =3D 0; > > > + } > > > + > > > switch (Packet->Protocol) { > > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > > Status =3D AhciNonDataTransfer ( > > > -- > > > 2.40.0.windows.1 > > > > > > > > > > > >=20 > > >