From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.34609.1670815647726685244 for ; Sun, 11 Dec 2022 19:27:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lAITUPx/; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670815648; x=1702351648; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u41uzDRqGUUzb+25q/eyw9eT8ht+AcVYIMeq1UcPg2o=; b=lAITUPx/ss3Vf9vfoQ0ulVjBizfNomacA4S8x1cjx8YNPhNVXGRQ+48b HAfVroVp4Cjlh80NniELbXGOdew4Lu5hbPy1HPE23TLf9ud9WQXUJAYlO 5NvPqVNSoIgPkVCX3T/JE4XOtkXNputhgOPqXn8DUnsA4TSB9Rp6RD8F8 ygxM7AX5va+6dtOUszZyslI4oHItajwxKgmIcmytTZqTz1UI0ArPZUS7F uQI4QwMCQjTLgFCYP7Shx1lM8Sh4iSY4tNyg4GcocyYG899GNaIdW6Gyo ugjuYMWF94YluyyjrcgH5fqtIkQPGXj5thAHV0wmkjjQIJXETeuw+8owD g==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="382066382" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="382066382" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 19:27:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="711520377" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="711520377" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 11 Dec 2022 19:27:27 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 11 Dec 2022 19:27:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 11 Dec 2022 19:27:26 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 11 Dec 2022 19:27:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=as6WleVyEkoW4l2CNKHmQO9yU8LOn/jL41z1OOv9IFawwpPtzy070BIRfC/u1wVDZP7PivTLg6zb4Lq0r0Gan7D6tiRKjpN9/JlMU0sC4m1V+LyblkrV8ytEe3d7eB819OHQNIVrFyniwWyjXn3VKX5SK7vVjyqwDrLsuyZ+l3yZMJ+3rBImY3Fuor6E59s7OgHvFbSABoTP1zXVPP/d+Boskpg1Hkac33vPxgppnxUqDbl9f3Se3PdG7YSiYNUKC7jPXaJkuDzQ1h0dtx6jA+gLVMVr31BmO7/clm2id6+xYSRkX0/JUQWWc60BAuDD4+QX+XgxCFFxNPZ7wr1qHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waPbPV52mcZecJJEho0X9j9Gj4g6/CaQSjh4zhN8uWs=; b=W/IzV+m4bv9Wc9SjP+HbCZSNxKNHcoUzv+fryU25kMM+RyPdVL+gUaeENNwLTILQuEHvt1Y7JrKm4ofXwpU7BUMvdzJ5spWBNCNqdcX14krJFzg3ySYKjfATwjQ1fU1eXIp4DvOAS1btDTzrPsS9t5lph5SlYuhNNPnmLllJBIgU4Llce3t7g109vbUUNL9/o02wz22d1QEye7/qprML4xVf4tTfl29RPsMOP9B/wE159WZObwfo4NUqbsRhs09vnlK6iZCHQrxLQOEP/mMNCc1JAHRjuwgq1ytTCTPyn5TgMw692GPj0+fibuQmeFq3UgszoZCtem9+3vfsXpdooQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM4PR11MB5312.namprd11.prod.outlook.com (2603:10b6:5:393::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 03:27:22 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 03:27:22 +0000 From: "Wu, Hao A" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: "Kuei-Hung.Lin@amd.com" , "Ni, Ray" , "Zeng, Star" , "Sun, Zhikai" , Garrett Kirkendall Subject: Re: [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block Thread-Topic: [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block Thread-Index: AQHZDKny0ryZBJjHE0KJAlod0k8ADa5pkipw Date: Mon, 12 Dec 2022 03:27:22 +0000 Message-ID: References: <20221210151240.1548-1-abner.chang@amd.com> In-Reply-To: <20221210151240.1548-1-abner.chang@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|DM4PR11MB5312:EE_ x-ms-office365-filtering-correlation-id: b1739e93-0029-4d9c-9966-08dadbf0c858 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YpQNQxFf4dwkHoOht7AmEEUvGhJylNq4EOmf9gky1D9YVIix33V9nSeIBB+NAxovOp9zDfy4ECJkkQBtFfUcfS3m0ksHqpMAzWzpUxxr69N5AMxC3XNXOE4KoGz4sQdc3QmbxtLqkwEgZJZLa5zYM1PT2PdzhMGEfifVrOMSQab6iYGUtFAoKm13ZMusPDyBIlcXDH+p0MNR3bolMrLof4Wf3mkoCCOPSyBCj4LFIWMY2Fc7Z4Vqb3S0ZkkVTe7G91m/LeCiubmQutK79V8uZc1H6vXKLGMoKzY6oQ96bDYinxnSJUBsARZ3a2yuYeD4ue54wyIZTQtMewbg3UusBKdvb5rD126+U6CqnBaUUTw0p8wYwuIJuUCT+z6K2SRbPKyBC/IrjDM7lLjOYu7275rN6pHCIaO7KrUXCl7viinJxixm2VxGiGOOQRWpXQr9T+8o7VEtybmfL/iLrAOn+nMPFJNeS7++WRIVW0wzk8jCThzhRy2QiuFReAaXcRy/YJef40qwc9Qn/49iOklgpIDoMoeOJMt0BwoHe0Q64Jxg/C54eBQmWKI/n05Su5gzWpfBoV4gCqM9IrDPt8jvX62V1uq67l10lvLUlGB2tgE86wuKN9FZhr4mbS/RWTZ6FUdyxCkAkP1XfjqqFMg8+h6KegDzKD0Dc5FxcxFUdkQhhv51V/yhOsBBcz61XFTnwE2MO9p8bFqJ+4YcgANCfdV1wctOobS6BMmVNhYJelw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(38070700005)(55016003)(86362001)(7696005)(33656002)(966005)(478600001)(71200400001)(53546011)(6506007)(9686003)(66446008)(5660300002)(52536014)(4326008)(8676002)(66946007)(64756008)(66476007)(66556008)(41300700001)(316002)(110136005)(2906002)(19627235002)(8936002)(76116006)(54906003)(122000001)(26005)(82960400001)(38100700002)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?41Et1Ycu9L4SuitvyUc9L4aRjkC1hPl6nwc5HGJ42QPY7N6tu9zAj9LZ0Q8k?= =?us-ascii?Q?wTNYdTYaIvEoVNkiPCHF7tDWxVyZz2ZkEfxHJHxLlWB++twQfzuwX0qS0Fkb?= =?us-ascii?Q?yKEArVyTkGVjJbZSzolkJ4pjbF8EkUo2Oi2895ykSYjCPMRuVXi7KaQdRGHl?= =?us-ascii?Q?XXCL/XFEeOnT5+SNnGaBIZzcJPO96F9xLQxcaPPGxtpiFP0Men5aoAMGTsy2?= =?us-ascii?Q?A0ckqMMqWAfObFSdjBd5GP8+KW351QdOa7RaLRNZmAY0XzGVtx/5hZILLEw/?= =?us-ascii?Q?1qJkZWyNVqIYA2k1oMMX06z35PKsbr3FEiZ4y+kXvIuQ1H1kTKTHiXzqxDWr?= =?us-ascii?Q?sqYWhPzFe/Htxf72U7h1/mAHAGLy4oFHr1wvQexN5LJVK0/yGDcu/Z08jX/S?= =?us-ascii?Q?49JRD3GTVcoUxVRemedJhqntU0xPSXJQJkT3W1YvkWmiSlo9joWmEFgI13WR?= =?us-ascii?Q?QaiwDC7aUJTFqhL1gqPQAymqsvEzBe7+b7YgD9s7IdeomHCtGnv3RVeKBdCq?= =?us-ascii?Q?nt9mKaVorl2KvPILezYFE6/VLhi4dpBMFANBCwqYMBoxqU5C7baUi2mX8JYo?= =?us-ascii?Q?Vquh/o/btON1cTcTM4lXaxIQKxCxG1J3gRHiNIMpCcD/V3lBsgX15sBvL/vm?= =?us-ascii?Q?k6fOaYdSQiFcItWFmZqazpJJIR6WWktcTbsk1KdR2+jXW8bTp6XzFM4NoE71?= =?us-ascii?Q?CPtc+tn0cDZnKVd07oeycSZekb1WPEedIuCN6u1isjz1x7UlWFxX9F2GCL4E?= =?us-ascii?Q?roL2xWFM3BYaKyzANV/1IKmIgyGHpf6VL7EACD6SNNJfu615X/CUaCIzJakr?= =?us-ascii?Q?g9Nx5fHGGjT4B2opk79L6oq7v6WeICp+kwx9OxUeZK2IC4U/52J0f+4x4rw3?= =?us-ascii?Q?TBpRJRcgW+hTTGkUzrRQBXLy+2ZPv6d2iGRkiq7W1UxNjZqH8pPef3j2JRG5?= =?us-ascii?Q?RFoKTqpyBKv8dtSqa82vgOdLzNVq2X+ELTALcjgUKoDHV3Ry9vd3xgox4Mbt?= =?us-ascii?Q?V5+gZ+AbqAJRSBRccdnJsibQqFukib/q2+9BKrrM8x7tcHVCsUTDrFxW0f8d?= =?us-ascii?Q?LgLOKwkIiqIl46MtjzZh3cak7Z3QYPy/ZDPnQqetir22/UrmXT9nkh7+bKTS?= =?us-ascii?Q?FkmYo3zs2Zly4XFV0WJGqM6gmBpxXTLJ7cTahWa1RNSkiSGX1CC84npoYdnV?= =?us-ascii?Q?6UYDGxRaiSNBTIa0gDWLrWHp1mjoJb+pbevtYFggpuMfXCOzdQNOkdviSpOz?= =?us-ascii?Q?puQ4x/z8iKZd4tdeejYjv2q0YUfRFOs5CzeYDzcYG6mNV9YG/Rqh8kFLYFGD?= =?us-ascii?Q?Rf6imgrXJHhoZuvz3B+YBWJWHDRwtJz1Nl8BmE0PoMHnOGIlv88xJRFpDaLg?= =?us-ascii?Q?nQcSAAn9XNEz7nNSb1Wr70mZpI/02MjbO1HhIici35EV3TrppZIBNePCfA3o?= =?us-ascii?Q?4eLbbcuEvySYWNPxWFBvQTZUxDMIu64rvXgpLRLyjcwhQjuKUJigraD5RYoC?= =?us-ascii?Q?KEWNTu1xrOSI8GADWGy9OKMrSwbj82W6ZWzlKawB+dahpCr7sC+sMvSoXNmi?= =?us-ascii?Q?eZgDcgBjhPJ+wALPcuQu428YDwDm3WZtrRipWXW3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1739e93-0029-4d9c-9966-08dadbf0c858 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 03:27:22.5605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Oi26hGINUAxL44/3ybCTHgTEnAD7Fj8MZse1TV3Whh+JOhLUvaTZZtKqC8CcHnZ7wS/YzIjMog3ZoVj4HYs8sQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5312 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for a question, may I know what issue was met that leads to the propo= sed patch? Could you help to check if it is related with the topic discussed in https:= //edk2.groups.io/g/devel/topic/92833071#92165? Thanks in advance.=20 Best Regards, Hao Wu > -----Original Message----- > From: abner.chang@amd.com > Sent: Saturday, December 10, 2022 11:13 PM > To: devel@edk2.groups.io > Cc: Kuei-Hung.Lin@amd.com; Wu, Hao A ; Ni, Ray > ; Garrett Kirkendall ; > Abner Chang > Subject: [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block >=20 > From: Abner Chang >=20 > In V2: Add AMD copyright. >=20 > Unlink the XhciPei memory block when it has been freed. >=20 > Signed-off-by: Kuei-Hung Lin > Cc: Hao A Wu > Cc: Ray Ni > Cc: Garrett Kirkendall > Cc: Abner Chang > --- > MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 29 > ++++++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > index c64b38fcfc8..39ba31b0913 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > +++ b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c > @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based > on gPeiUsbControllerPpiGuid > which is used to enable recovery function from USB Drivers. >=20 > Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -365,6 +366,32 @@ UsbHcInitMemPool ( > return Pool; > } >=20 > +/** > + Unlink the memory block from the pool's list. > + > + @param Head The block list head of the memory's pool. > + @param BlockToUnlink The memory block to unlink. > + > +**/ > +VOID > +UsbHcUnlinkMemBlock ( > + IN USBHC_MEM_BLOCK *Head, > + IN USBHC_MEM_BLOCK *BlockToUnlink > + ) > +{ > + USBHC_MEM_BLOCK *Block; > + > + ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); > + > + for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { > + if (Block->Next =3D=3D BlockToUnlink) { > + Block->Next =3D BlockToUnlink->Next; > + BlockToUnlink->Next =3D NULL; > + break; > + } > + } > +} > + > /** > Release the memory management pool. >=20 > @@ -386,8 +413,8 @@ UsbHcFreeMemPool ( > // first block. > // > for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head= ->Next) > { > - // UsbHcUnlinkMemBlock (Pool->Head, Block); > UsbHcFreeMemBlock (Pool, Block); > + UsbHcUnlinkMemBlock (Pool->Head, Block); > } >=20 > UsbHcFreeMemBlock (Pool, Pool->Head); > -- > 2.37.1.windows.1