From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.2789.1640067322607094183 for ; Mon, 20 Dec 2021 22:15:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=E187PPon; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640067322; x=1671603322; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+qGAOEvc0u7uarzaqd7CqBxw/u6rDfANt/PcBOgwXD8=; b=E187PPonPJlWZlkqg54SoWwC2CcmrFo0Iy45ZGb+cmBP+TlkP+4rz8+z Kkic065E2wogdjM/B//RHJheQ1ruKst8I3u+iJygROFqto8Y0Ao8dKpUJ v+HRce/OPHuvywwlh9Nxzh+CfBOyNEY8Rq3OF4QxjMA8xtoHz4MVfCtQK oj+1WYKgSaNaZ1Xrek7ohcqUjzeGRyrt+Ca2clxwPk/QSK1O7m/TMhrcQ IWgt+6olWxZfg5VRSOaEu8WJfF/a8+6swsWCxiCjYJL7ri8FvSVj5KZmZ 70w3M+ESGhLjF/YWqwi7YD5uVYDoNXmnZQm/3MpCKDB7O6JZcvIrW0H81 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10204"; a="326633540" X-IronPort-AV: E=Sophos;i="5.88,222,1635231600"; d="scan'208";a="326633540" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 22:15:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,222,1635231600"; d="scan'208";a="663854758" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2021 22:15:10 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 22:15:09 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 22:15:09 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 20 Dec 2021 22:15:09 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 20 Dec 2021 22:15:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoIPai9Qayir2cap4A5v6vMakK6ydZ8JrUk9cPWAdmxXIkP9LGUw0peb0xviJ2KyduihBN4Npq6iw5sSINAwBDFyHJNMkWsN/la5HIyDETfaPBCIAZlKREJmD9uZ993pAMvb8o8BcM8zzhBfsZfkXJKvNxgnqrm6P3mMy7A+H+7rtfW01PPNbIZHO4bXEYFXwGSL9OXxrNK6/j2obBp5WQ+O6+y7h2ZGyRyS87ZNogzbHQFJSvXyPl6zu9iuALDq5ECDyVQCuPOxF+zudkFmqAn3lZqEyqgwrT+4jwKBQ80HSGGq2VEv7PRC/mirmMDxxNAnVI1eOgH3m0zZHDIwLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bk7MZZ9iLE1JIvHhffRarEy/zMO9OmWHGy7lg6juSaQ=; b=JwegeN45qgElTtbGDhFPobzW4OdJmVsqbRfnemxu8jocb1u0LEmS/gb9OAFuSFYWV55SNTNw/vscEVowhNhay6SZVrJvgRkv9pFvEH12EhBV3PYNOpUm4zVcaM8zpP5OaO+nNttjd+9IQKdTI0tj3OnE2EN+Zqze2TrXnAzD59cuSv9z5EL8P6BTLSnDo6PtUhbGDxD4PLWrU7CiPSsj0WEX9cyyXCLBMKCO1K40JtA3i7tM2rTJEa7Bo/PEynz0+asuO7tFRJDmKNr7zqilWaPv/uSfR+i5AabYWDX5lHOXSL5rkZaml2RHnfAfyQ6BWh9m2uX9/+6+KRmkazMa0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB3113.namprd11.prod.outlook.com (2603:10b6:5:69::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec 2021 06:15:07 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%5]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021 06:15:07 +0000 From: "Wu, Hao A" To: "Ke, VincentX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chiu, Ian" , "Chu, Maggie" Subject: Re: [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem Thread-Topic: [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem Thread-Index: AQHX8x2G4d6X9TVyT0mjGBNRICpQFqw8fZ6Q Date: Tue, 21 Dec 2021 06:15:07 +0000 Message-ID: References: <3251e10d5f7b004a93bccba80d3e82916e0bb672.1639728124.git.vincentx.ke@intel.com> In-Reply-To: <3251e10d5f7b004a93bccba80d3e82916e0bb672.1639728124.git.vincentx.ke@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: efc46060-6649-43eb-cdb7-08d9c4493c7f x-ms-traffictypediagnostic: DM6PR11MB3113:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:31; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yF6vsx0G+YEV0+sA1UXc5qKG6XxVFZyvYNMF6kBnQWUCEpv8H3OFFVVgw3xsXqfcL5K56nYaQQrIwmUhCwkTgdLbJvVvFPTjIgyaVhbyRvOUg0UwhF7FZ2mffqzA0B4hljjl6Ar/YH/BrEtHRMCm47GfAu1dZo2TFBGdyxzH/uWtEu5v4Ho7B/IKtAcB2g5ekVL397CuQvaeFBsrYeuRdbG84Q5+Vq+opGFmK84/mM6kVf3OyvPun3tdO/cW+BS1ShwW+8coa1FyjFNJ9ENmy4VXG+CRih1WOHfohQD3EZpMX+Qb23P/qfUhC1DmTxdaXRNBT0cE0atdfITqxV6b92sgB8s0h+ASTu61ft2JtRzZyLGqxZReds0OrTOsaYy36mVlFOPYjugwEsdWLTI0M5oCQEbT4V3dV9CyERQ5AV7IX3JzeWNdL1VBhzsXtLM1Ac0wJidFm/N7wvipCYScIh/LsnwtOFT9wvp2mAd1TKSO+8LoR3B7+pbRzgC+qk03CLq3HwenJeTAzmE0yKrRt8hzkfHfLLLV1F79F89/UkA165Dbpi29xlpbiaCGxR7NaQvnv2RgICGP2Zn7yJiyADYjYWatTZ/GvQRmkuH796g3zVLa66j4maa0mYn5z56X8AepwnUe4liBMbrJTITnVR8VfAEdFUMiAZ4Qct2IMReACXoRItzCPI3CLCxrjSmTUhcL1zsK9jofsBBUAoS2/1OYoJiGRfaLOCwsocg8QFmrRLrqdGAHWeCesiNnEQAjK8REwpFc8H46br33RnQAoTqD/zu7FWZl/eEeZ3jPeq4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(4326008)(82960400001)(83380400001)(107886003)(66476007)(76116006)(54906003)(5660300002)(966005)(8936002)(9686003)(53546011)(6506007)(110136005)(38100700002)(55016003)(33656002)(186003)(122000001)(8676002)(316002)(7696005)(64756008)(66556008)(86362001)(2906002)(52536014)(38070700005)(71200400001)(66446008)(66946007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AaQR7zfLWjPRvmBBbZF7N81PEz32Vr0ZVZ+9wBuz1C5CvelmsZowBgQYqaH6?= =?us-ascii?Q?VCtxLRrMpMtf7FFl8HmnJ0fL/IsVN5pHuiYHXBQcF2V90D26RQgBTi5K34/S?= =?us-ascii?Q?5Of6GxBm0z/IIh8gwm2ue0p1bWZkV/wOBD7LobtSrGIFY8uuCbXIq49gar05?= =?us-ascii?Q?H0CocbNYojNTkswITlnZ9/Ki9H0lkLLesRaMIy6X/5uVkCnNiIPVMTxPKblo?= =?us-ascii?Q?HRAG4lJYG54rm3k/wT5LUfRCjdLR/HLjDVC96NOUmRdVVXwJ/dgSLJ0tnLhp?= =?us-ascii?Q?HIGvgKxE7wB0mZU9bFo0+NgMFv/j4iasgMudY91Biv33+92l9NCHipaDXja4?= =?us-ascii?Q?2jtvFdnv2cGJemyrGZ4n3l4G6vG4QYc1L6VTzhjEJFqtbQrfmKSdmFBpOe03?= =?us-ascii?Q?+KaJv8G47aUqiSN2ijNck0iLNLuUnoooqMczaRg39L+kOEFAt0x57aLQANef?= =?us-ascii?Q?w3r3pW2MUNcesOKigPdMxwgKY2yyXGsdAIP7wjmItWyWxq0ZYkUYBUF3850Y?= =?us-ascii?Q?GMkI02PcmzvyEq/1+xA7QyaK9oVnTl7TQPEk7tNRgbcdUoHTwXaj4Z+gi02C?= =?us-ascii?Q?xQWLe7HtxIpJB5VTbEwJryfhIaZp2IWllV7Dm8zBIX0K6AlKKl2bCJehZUbp?= =?us-ascii?Q?V5zSXB2b7bKzOIHNrhMb9neiWa5lhMBn6MQoMAWtUlc6f5mCZUL1nE192TM1?= =?us-ascii?Q?M2HXNExoG+UNQgobAtxjSagNDDKu53n7kVQPSnuBfPxn692Hpa60oUFZv0eX?= =?us-ascii?Q?Lzm1VwxlyADSZ+g7N2IsPZqQb5bsmXd5kPuGyZvIHUZsGFmbGn2Dj055jFqO?= =?us-ascii?Q?5PuKEKnVDSrjOJq0oj/k9TKjHxm/dbjNVnOjMTbLMQUMTNvs7DcTOfyAUoxx?= =?us-ascii?Q?TFSnp2Ssk/wynMPhBDWnvwCyD4ue8k/tMvacgerLqSfAYKUffCBnOEwXRlEm?= =?us-ascii?Q?yhRTfSda6harLNvG/KeCm+sqfVwaQMcd9//ndgdMITtLz9AF+IG+gFXQEvez?= =?us-ascii?Q?IAK0rc79iLYsYw8SkMtW8ncCCI0rt5UMTGqYXzUyhSv0nNFQhTU+T6pxTjLk?= =?us-ascii?Q?aXZeq3V0BPZ21V8pmhQ2VrLPGDzgKP0gY8fDuO3WC5hysIfdqeal3c3V898d?= =?us-ascii?Q?MXkY0GmzfwNc4awM16kybUhHGiwhJaLG5d4JzMhZULaOE1JXF7YI36XzFE5q?= =?us-ascii?Q?NoseAMS4OjhdNqZIXYA4eeXunMUiokGlaNdOodQIRF6Gekj00vX2xjvJe7wd?= =?us-ascii?Q?j/LKv1JpeeHA0z0z7IV84z4O7/djH4vawyr4Yb95qh8iz4pE7DXh8awYK4wJ?= =?us-ascii?Q?ugEywSiSJxTEX3lYNOADdWk52ARZ/QO7hHbZ1eVV898S/HTkCGDjZ54E8Y22?= =?us-ascii?Q?uED9eDIv7gyEZtOB1rjABbagYMjNDdJDYGkwrRIJEuu7/P4y0ZGVhox2r9oU?= =?us-ascii?Q?oOm9vv6djr5kw+wW6zOcS2yXvdh/B9zpP2dz63sZ/FSbR68ua9nSGsJKu4Al?= =?us-ascii?Q?kkW5X6tMV0NFE4CyO5maDnk8vVOq4dWYcrAgzEd4mLj/bUFnaYxNk7G0tsM6?= =?us-ascii?Q?wclTpCQ+U06iLhZ1izDJ/Scvqzm2gkX5nxKQydCUHW0uHt9uuZUXn9nugj8j?= =?us-ascii?Q?32aU+Y6ToOY10jXRODAXu9I=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efc46060-6649-43eb-cdb7-08d9c4493c7f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 06:15:07.5051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vkh2txSa5RfwexzGL+GubmCvcPeKIF5bgr9eYGUcZCQRdgyBIIRyvb/YyLV76UHCbpNyqu1p+vO6rMTCpNsLEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3113 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Will merge in a couple of days. Best Regards, Hao Wu > -----Original Message----- > From: Ke, VincentX > Sent: Friday, December 17, 2021 4:10 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Wu, Hao A ; > Ni, Ray ; Chiu, Ian ; Chu, Maggie > > Subject: [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix > timeout problem >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3714 >=20 > Replace with UFS_UNIT_DESC to fix response timeout problem. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ian Chiu > Cc: Maggie Chu > Signed-off-by: VincentX Ke > --- > .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +++++++++---------- > 1 file changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > index b331c0f3e3..9ad1e19fe0 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > @@ -1037,9 +1037,9 @@ InitializeUfsBlockIoPeim ( > UFS_PEIM_HC_PRIVATE_DATA *Private; > EDKII_UFS_HOST_CONTROLLER_PPI *UfsHcPpi; > UINT32 Index; > - UFS_CONFIG_DESC Config; > UINTN MmioBase; > UINT8 Controller; > + UFS_UNIT_DESC UnitDescriptor; >=20 > // > // Shadow this PEIM to run from memory @@ -1126,19 +1126,17 @@ > InitializeUfsBlockIoPeim ( > } >=20 > // > - // Get Ufs Device's Lun Info by reading Configuration Descriptor. > + // Check if 8 common luns are active and set corresponding bit mask. > // > - Status =3D UfsRwDeviceDesc (Private, TRUE, UfsConfigDesc, 0, 0, &Con= fig, > sizeof (UFS_CONFIG_DESC)); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "Ufs Get Configuration Descriptor Error, Stat= us > =3D %r\n", Status)); > - Controller++; > - continue; > - } > - > for (Index =3D 0; Index < UFS_PEIM_MAX_LUNS; Index++) { > - if (Config.UnitDescConfParams[Index].LunEn !=3D 0) { > - Private->Luns.BitMask |=3D (BIT0 << Index); > + Status =3D UfsRwDeviceDesc (Private, TRUE, UfsUnitDesc, (UINT8) In= dex, 0, > &UnitDescriptor, sizeof (UFS_UNIT_DESC)); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "Fail to read UFS Unit Descriptor, Index = =3D %X, > Status =3D %r\n", Index, Status)); > + continue; > + } > + if (UnitDescriptor.LunEn =3D=3D 0x1) { > DEBUG ((DEBUG_INFO, "Ufs %d Lun %d is enabled\n", Controller, In= dex)); > + Private->Luns.BitMask |=3D (BIT0 << Index); > } > } >=20 > -- > 2.18.0.windows.1