From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.5338.1648426471577988038 for ; Sun, 27 Mar 2022 17:14:31 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nzt4q4cE; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648426471; x=1679962471; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=YEkxpYoxA9D0793wHsf6pCULVr8B9JxCWmU16PR1umg=; b=nzt4q4cEOVZCWakSY8yPncctNmZGFlt2W7i1htwlE9qKcpGfDeENq91E 09TtoWrl3cPXykJztCe2wcEjmU88fBK+ogcuOqajbWVXkToeP1HIO4Lui TBXTmjHG5Z4WhXKcRSxA84XvHj7sQZBFRxejUeDPxfRvtrsf6Hhp8Rbjm zMv1PVeNRKOJFiVnS9zvUVkT3JgHvWLR1d5RClYE0XI8WYTmhtrVs+R23 HadPE92uVfT8i1YXAMy5KK1ZBLq3m4AypNr8Mqdt/poYvJ1LzmU7ekdvc bXAuII6gV5P2MNQJULUAwnFPQ8hze+BeCzlUXJX+8Njd92HslppVtcdMg g==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="246372609" X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="246372609" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2022 17:14:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="694192693" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 27 Mar 2022 17:14:29 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 27 Mar 2022 17:14:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 27 Mar 2022 17:14:29 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 27 Mar 2022 17:14:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iL5YJXzu5bxAC08TQ1hpsVKxu3B+OHTH5UMEdxrpl4Hz6h3k5LInyS/HVoq1YdsQD0yX3Y8inrp6uPW69V1kqD/oeP6fEvIHMK1IvMGjEnQHNRhJNIA+X7A7Yv6O01Glh/QAi1KyM6yW1HGXoeTZ4li3cdshCJwCbW4v+vNVTTZvKgxFwP8tezhurJm/QHmtoq3WDRO0tGOmPD2ZNG2bPAjM+IbEWocpPk+6Oa24h+eYL6ETV99SRJt9mp/BqShEfTf1SsP8NWB+Z6a9kwf2o2ZLf1oJaCdOFYjvYWJpJpGoH7gCE5LISmQIVW1cRdAyipPznnQze6b2qbnfIbYv2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OTz4jiabbnlMiPF4qB5gUknfZ2IGumHl7akqQVy/gu0=; b=YompbT+Tvz1iT72HN3A6hAXpu5xjPMGjNrpCzi6CfiE0raigD6v2CbUkpE23JrmdlZ4uMC3rNhcF2IhBa092S+HKRF50Gebtad7j73vZPx1T6KmhlhY4vSID9DuNDEmSpFqdfCHdXS2NTvLoND6u8dMAuVl7hSu+lPxMj9FIQbKoi2Y8lJ72z7svyRUCN//kA2cBxxXJAGfo3Ez9GM6CLcgdBRBVCkuM4gmD4iFQl0ZkpZhrt3NFwHRWF2vMIKqcHMzRY3bZWkkUl0WfJJjKoGmy/Suhpnzk4ZqX4EPLkY1TaLf0k4figNywwCoebgLReU/3H8N6moFK2TuQRL01Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM5PR11MB1978.namprd11.prod.outlook.com (2603:10b6:3:10d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.19; Mon, 28 Mar 2022 00:14:27 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b%7]) with mapi id 15.20.5102.022; Mon, 28 Mar 2022 00:14:27 +0000 From: "Wu, Hao A" To: Pedro Falcato , "devel@edk2.groups.io" Subject: Re: [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation Thread-Topic: [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 implementation Thread-Index: AQHYQXW6XNSlGEfPZECIwK+Pmj8zrqzT7VcQ Date: Mon, 28 Mar 2022 00:14:27 +0000 Message-ID: References: <20220327005748.92041-1-pedro.falcato@gmail.com> <20220327005748.92041-3-pedro.falcato@gmail.com> In-Reply-To: <20220327005748.92041-3-pedro.falcato@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99d9d4b9-308b-42a7-470b-08da104febce x-ms-traffictypediagnostic: DM5PR11MB1978:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2IlRh3OlnLa76j0yXbtPnudsO1eAR9Al9j0tdcAXTFtF5x5w5IjpAJ3fnrBE+aYmgrS1xVNx3u0u/UJUsVw36AGehBdN3azgHiw2Wx4Z20f1RyG3zKCp0Hocvk5HeHURyGj85g7Y2qV/h1tEu2MlO6C18ZmUF7rdSeG4R+11DpMOb0lTq0+k0TM6dduEjlnVQpKferalh8mgdvR8U0wueACNvHx2PaXbF+dQFh4wvsbW3CrmYnS0CGbzhkYT1gDyClGupTa/vEm/1ayKSZ3XMAkfV/MFXCqAFRZZBKYMdwXCv+bAPaDQc2Ybp10fbpnMEP9jJBjRbOp4MfmfKff+0/Wh08FAGvUa8ubxvH+nBsiJgZWFwS18GPNyW+eVjazIW61li9HqGU9gOWNgldukQnOw5kIx3Ulri5UWnEpcDHCb88izmuIJH0VhkwBqRLSU16IHL0aq8/RkTS6lyUJT41tW8HNj+Y81+rPEKOk9XSYq+izza5PsBqV3/+9r6LTUv8J4aS6FOGlJPidZiP1NJ2O3L9ESAEwu+m/MQkRJOI0TQIrCA5IFqoekW5LE+Aq2LWkThzJbI2vxhdQ8LJ6aTKjy6r8vQ7AUl+jXN6lJARhlkg3qbR/DH/DD2Wa4jsD3f11C328h9faHVbQnTnQPU8m7obtbp7Z/GYBQYCpoLfsLT2+Sxbaw+D/etV9MqQOWQYpI3VLS7JZHc0T1WWnfx4RGrd1pgIvWeXkoy29BApJphCni+RuWgy08Fd6zKc8xG5jVsB+krnTTi9MJW6Tv4ZP453/j7v8BuQdnfhkw4wQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38100700002)(122000001)(82960400001)(316002)(508600001)(33656002)(110136005)(966005)(8676002)(86362001)(38070700005)(76116006)(64756008)(66476007)(66556008)(66946007)(66446008)(71200400001)(83380400001)(6506007)(53546011)(7696005)(52536014)(5660300002)(9686003)(2906002)(186003)(26005)(55016003)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CoOtb7lHLCdUF54OjRJYWH00bChl9JLvVoPQEzxrYopeMRQqPPFTRf+BFpsN?= =?us-ascii?Q?duUJ9mRlqIN67ZraRKF0e6wvVBnHI/6Z8bPPx9WgicUHMkbC1qrpGVpG0eI1?= =?us-ascii?Q?8DqHJVQSaFl3ESBFKTAs2Kn6VZkXBVnRuNqPCZRGVZQvfVaW+vRlVFo6JXSS?= =?us-ascii?Q?MGJ7TdOnS1ZowfGpqPjIX5wbitqhawKtYLqJlkfrjxeasit8RQh7w4Y4xc3W?= =?us-ascii?Q?VS81N1uabPT0fIQAffeLiPvdJwIRayRzEkgHnQh1oeOQCV8+ZmHxVTNUGiYW?= =?us-ascii?Q?qHSrsQ8980XHrrSPRuYmTXggrbRB+VHPsV4NfqvA8dhxig51bgrd12lprTiz?= =?us-ascii?Q?Y6sgOeE90LUMOgMT6r3+0CwE5Q7T2BiJGuaAx/203C/JYYE3r80eCsJKjxU7?= =?us-ascii?Q?/iVn+Sy8o+7ex5B936Lvd30ggNkqk5tyN6Dwjd228jjaHdDWEP0CyX7Tl+wL?= =?us-ascii?Q?OVUX0AIGKSCKop5OPl3VRD5peubFJl/EAE63s1SHwDecuxuVRXreOMI90MnK?= =?us-ascii?Q?YdV50OtAMqY4UMOXf7wbxaFSlwX81YjtKqBQyCn9Yq2OwsBXDOMHhiwQ8gJb?= =?us-ascii?Q?RdC0I2KCTl6ZPidH0Q9qLtKpsXQ76d7VXRVIlo/aJd6cFfMQ0toVaoO2yH9c?= =?us-ascii?Q?dvNHthrhP4NJOoVdVy7/MqkdjNJUeBTMABC/dnbit6PjDjXEIMddFqdtc3vV?= =?us-ascii?Q?r6KiayJXrtxqdxBnBX4JCcwonT/+wFN1gvMJrK4rQ7H21PFqQz7ongWncZFZ?= =?us-ascii?Q?m72Mpb19vtDxyCB5EI4ngAfnwr/iFW2Cl4rTsUk8EluQ9nDbsI/Z6NgBbOTs?= =?us-ascii?Q?5jNu2tm+/OayyTl9Jb4odT3UgEgqIVPWd3wKxfYPI6EtYl0Jrc26mw1wuETo?= =?us-ascii?Q?70zMdNYakhfxGIbyURyjpC4RFuVTZpgO/shVIFPtMSeAIcVmorGaBGnIpJFc?= =?us-ascii?Q?48TyzsS0mcGTpiqwzcK5ygQI2DF+86iYRWtRCHq+4JjjIKFYF1TLyFR4Q1V4?= =?us-ascii?Q?aVvEaQ0tFVqUNaZFJrJ+H9K5gW0UkFWoZe6Y5YmCsuI6RYxc1fcWHSnDMX5g?= =?us-ascii?Q?ND18fF2EOHsfU4vF72PDfbELMHifkgVR5CFnlsW/xAFQ/C7YtL8h2FbPB3Q+?= =?us-ascii?Q?PF5ZtsOYXj4MVHZjDWqaUEEsS2q1923U6hfaK1uQ9MEBa1+SvCoLIzOOUkP3?= =?us-ascii?Q?oBuS+BWUjYrX7Mw+Ayg0IHiA4CjluxdzA7B063T8k9GZmYxgHr+D3QwcInma?= =?us-ascii?Q?QVJfsLCoDl4NLDs0XVt9U1LgtfKclirAehOGoNFgHBUnO41WZ8tu+C+ICfsX?= =?us-ascii?Q?MMKwiA/G6XWtNlh6c7fqOkPFj5MBu1TXddC6lo+sbtFitLUMSYu4nJSGj0mw?= =?us-ascii?Q?VR3qoIcn5K5dZq0ZgXNTRLi8OYevAhCyJzS5ayvTN32fWk6HoB9mOT5+dZst?= =?us-ascii?Q?A2op4bPaYA1RyxX2sML+dIdWnl9b1k0W0ImSDhyYrMHQFCYHA/qNZHf28B5s?= =?us-ascii?Q?KeP1r1gL9s3dZ96/87rIydBTPUBYM2l30ZMtqitGFLFRRozxGD/pR9ThidIA?= =?us-ascii?Q?7Gx0jWlSLOTdM294QGGXBEYI1yahRP6gYCc6ch9JYjL1AArAAqZFKuOLFXHa?= =?us-ascii?Q?axepYA/hlV6o7O0IPt4vLwmgfaNATgfDykf+OnphjzNvE2uCjmcwoENFpBfg?= =?us-ascii?Q?8ZqQonihT2ytXGmkJV3fIZAvY0Ds51mBd3KbTVIu2G6CYn2vDQqD2EZZewjQ?= =?us-ascii?Q?lO4C8tN+8g=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d9d4b9-308b-42a7-470b-08da104febce X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2022 00:14:27.0346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9Fg71cAfJNIvGa8VhXH7iAbC1wNN3j6K5GkmgmLXQfLO0at57SmGCCpiKXODAnCDtPxFLabimT2gxYnqCUAARA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1978 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, My local test shows that the results between the old (SourceLevelDebugPkg) = & new (MdePkg) CRC16 implementation are different: UINT8 Array[16] =3D {1,2,3,4,5,6,7,8,8,7,6,5,4,3,2,1}; UINT16 a, b;=09 a =3D CalculateCrc16New(Array, sizeof(Array), 0xFFFF); b =3D CalculateCrc16Old(Array, sizeof(Array), 0xFFFF); Result: a =3D 0x0af5 b =3D 0x2778 My take is that for the SourceLevelDebugPkg case, the CRC16 result should b= e the same (at BIOS host side). Otherwise, the target side will have issue = for the CRC check. Best Regards, Hao Wu > -----Original Message----- > From: Pedro Falcato > Sent: Sunday, March 27, 2022 8:58 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [PATCH 2/2] SourceLevelDebugPkg/DebugAgent: Delete the CRC16 > implementation >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 >=20 > Deletes the CRC16 implementation as CalculateCrc16() is being merged into > BaseLib. >=20 > Cc: Hao A Wu > Signed-off-by: Pedro Falcato > --- > .../DebugAgent/DebugAgentCommon/DebugAgent.c | 35 ------------------- > 1 file changed, 35 deletions(-) >=20 > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > index a1e61a6ef90e..62c6a235d425 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t.c > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen > t > +++ .c > @@ -126,41 +126,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED > EFI_VECTOR_HANDOFF_INFO mVectorHandoffInfoDebugAg >=20 > GLOBAL_REMOVE_IF_UNREFERENCED UINTN mVectorHandoffInfoCount =3D > sizeof (mVectorHandoffInfoDebugAgent) / sizeof > (EFI_VECTOR_HANDOFF_INFO); >=20 > -/** > - Calculate CRC16 for target data. > - > - @param[in] Data The target data. > - @param[in] DataSize The target data size. > - @param[in] Crc Initial CRC. > - > - @return UINT16 The CRC16 value. > - > -**/ > -UINT16 > -CalculateCrc16 ( > - IN UINT8 *Data, > - IN UINTN DataSize, > - IN UINT16 Crc > - ) > -{ > - UINTN Index; > - UINTN BitIndex; > - > - for (Index =3D 0; Index < DataSize; Index++) { > - Crc ^=3D (UINT16)Data[Index]; > - for (BitIndex =3D 0; BitIndex < 8; BitIndex++) { > - if ((Crc & 0x8000) !=3D 0) { > - Crc <<=3D 1; > - Crc ^=3D 0x1021; > - } else { > - Crc <<=3D 1; > - } > - } > - } > - > - return Crc; > -} > - > /** > Read IDT entry to check if IDT entries are setup by Debug Agent. >=20 > -- > 2.35.1