From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.2853.1644549327857868058 for ; Thu, 10 Feb 2022 19:15:27 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FleYzBs+; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644549327; x=1676085327; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=X3yf9PnKojBGd1ZQmN9sv9+zswsaNisPS2E19yyrnrE=; b=FleYzBs+vGm0WYBgMWyE/dOTaGsaY1fnkOqFFsDGPa2aFGiAHBTCnvLx AaylcFk8w9AEqtB79eS9UIKBAyjv5HWiAqNhmHsSGR64nLjzX22N1j4Xr M4mNwm+CemaUn42yk/dKIxY7+3FsMARjFSA0cCyJ9jvS9UiyNt+DqKB4b kJmmTDaIpXGq2+aHjvLY4k5xNXya95+9z05j1rnEiwAchm9DKnE60lOzQ tvxni4+wXir5aT5wKy66N5VG+CyPgAI0/TyqHrX3A7V0O5VbV1nb9SuuH ERjZsP8rLtA5C6B27kdT8GyD1nED0CjVUhCat7BM1W0348xFYd7zcuPMq Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="229614367" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="229614367" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 19:15:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="568889197" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 10 Feb 2022 19:15:25 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 19:15:24 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 19:15:24 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 19:15:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L4G9Gi16RS9WvDoDqBU8GKU4GsVP73a03DkTsfeYja2BnTp3buxNdut0qwY2bb4B7QSTM9K/Bq6nppoVFt0rNzoGOoazvHVIvhAnqHuCm86eCyX9zJUGhaqFiVhkRNbLynm9UQ46CWO+dmysZFKaB9dvMSdwpsW0sApy1+dTXQc8Br7kzJuxs0iMviOdC1IBS/C+axhn3ZtNbAIgk5XkupbJp5uXlAU3AfdtnMY6fcoVYyE4Zc9Q43mw+2e4nS0TDsQgGKwlxoIer21DPS/9L5W/IxcqXxjnUiFRo5Phvd2mYkBnWMHKnHNXGra+Yb7t/Z9iJunoIqRZAehz74H6Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ljx/axNP9TmKhS2lX8A8V4zAINz3tc65ePF7DVoKfXk=; b=ETauLcrTqbfWjLCt5t075rnTznhrVJuAdxGWVwqNG7eb6CH+1oD8LwZry/VeKvdbXokJyqrWZI8PRUqJ2lxW58/gE5Je8FPv0AoUuacAF2jeJL6HK/mj7eF+B1t8znx1Xq3Zh3Sz5kgfJTdZyL1u4DP3/E1IU8s4aiAD94wkfStyiRKIIkdJYoMtQo7s1NoijvVk2f9EIsdASwx8oo4ybS/aiIxPz7WZCv3Vl6QcjX5KXNjuZSuIe7/5Q3DK/+odc2WwG2XBrtwsAJqEjOlSvRKj1tqUZmDfPz5Iuykv86MCkDw4iRMHB9YVa8bPt66Qoe8BgavN5OmgxTybUPbwyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CO1PR11MB4833.namprd11.prod.outlook.com (2603:10b6:303:99::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 03:15:21 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::707a:603c:30eb:bcdd]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::707a:603c:30eb:bcdd%3]) with mapi id 15.20.4951.019; Fri, 11 Feb 2022 03:15:21 +0000 From: "Wu, Hao A" To: "Rhodes, Sean" , Matt DeVillier , "devel@edk2.groups.io" , "Gao, Liming" , "Wang, Jian J" Subject: Re: [PATCH 09/18] SdMmcPciDxe: Reduce timeout for SD card reset Thread-Topic: [PATCH 09/18] SdMmcPciDxe: Reduce timeout for SD card reset Thread-Index: AQHYHsSxC6r8BgnqbUacy764sUEwYqyNoURw Date: Fri, 11 Feb 2022 03:15:21 +0000 Message-ID: References: <5bb2cf0ef0b2602aad18e486ce0546309154fa1b.1644527848.git.sean@starlabs.systems> In-Reply-To: <5bb2cf0ef0b2602aad18e486ce0546309154fa1b.1644527848.git.sean@starlabs.systems> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa98bd29-05c6-4bd8-72e5-08d9ed0cbd1a x-ms-traffictypediagnostic: CO1PR11MB4833:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OyT7T6FPeKJuyoNHgFW/mNUBPxTwJeqC+ncNTRBr0GaM+Bp3j0zVPly21MObgSx2+5H4ECqdaxdSZjy90EwqxeiSJWv5KpQU9oQTAzw6AczNKI1uAkU8NbNPoG4b2B8XWWNQYIp0F2lWm+cRAWSbyL7y55KBXMSmabAK3IkthIsHv+UHSJ7QZkkyX+6zlpL/tSVHXVzA0VgnVs7ajqQWbMeXq5bGM87gyP0MXv1j1RisJMAo/HKGVB0vXTtk2pvxAZWDzWaDiHBHLSTsqvTo/dGxEChIfUo+2CVW96hZVFI1vw4r9IJnXwPxG+drW4WyVtYYGbpwmdjLReI4sUNGH62rXva8W9rJOrOn3kUGyD9QWssFD16SEpyInweWYbIFfvNrc3asaB0YnaaPM4mMu7trZRsTmcpvjDw5V1+7IlNbQx3R46Y+jUUNJnhNWJ6GgUnRCQukoJBSPosBJuZgrOK94U0C51rYD3YEQ6B85JZ9bWsbvtR2jxMVVLxTplnzniEhqZTeSpa2Ki1987ulq1brIABnOGcQhplJS9cFA9nrgHX3lIEezoMXnMqFR7Z/UQGwlpeFcFpgnddw0f48+PqcTA0S9ikAgUHYFimMaM3yx0SHPPDKK8p/tUq6qtnIIZQybU1eXIoptMZ2ir4DsaLqO8hJpVIMoFZe6Yr3hxWGGTqSXJcNGFLqSsTNmYxXHMgJaSihmXoojrjcrTO2ww== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(71200400001)(33656002)(76116006)(186003)(5660300002)(8676002)(66476007)(64756008)(66446008)(66946007)(66556008)(8936002)(52536014)(508600001)(316002)(55016003)(2906002)(38070700005)(83380400001)(6636002)(38100700002)(26005)(53546011)(6506007)(86362001)(110136005)(9686003)(82960400001)(122000001)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ni4yLgu0/YZA0nklhCHDeoSZmALiejEwJIP2gR0rPn/BD+2TsfTWEkwTZ+0z?= =?us-ascii?Q?6EARnFaYW2GgtJcl7P6jV1vmpSO1wiA1rea8KBrZ2wtyd+iiK+QKpOT9v7SS?= =?us-ascii?Q?vjlvb+Ipq4wlyK9dUipPknY+QQ0f0MlNtM+guyzTUcuC3S3WOL1w7aSnfiAs?= =?us-ascii?Q?FD9ssylgJTjK7qHsC5j0coZGQh5hOQqQlrvO9j5BlzQGFcIyzRsDE9z2G+Sg?= =?us-ascii?Q?3+JiNUS7QlQfMyyheszH+Je9snSmlIc1+jvUps2uK+4yIHFMtUXyzaoV30qF?= =?us-ascii?Q?DSPyNF1N+/oM3AU0gagqFy/WBqqT+jPcu76yhrE1U+I00GUjerMOC2BoMtJv?= =?us-ascii?Q?LfE+Cg043b97hoXINZG+pGcG/ig6PSVgfVdV9tbSK+BksC3P97p3JiDIXkPg?= =?us-ascii?Q?j+PlqnWc4F2Rjk4vYWpYUmhu+mx9+D8TqGMAZeSR4LfMKsaesLMnNyWJkaOu?= =?us-ascii?Q?dUajnR8gXViwmmujY+rpvFss176uTW6YhiJbFiIsGJCUxGpE8TfZlvzvWzSN?= =?us-ascii?Q?R15CH4fnUiYSQYLFNpWE1co+kKxtOFq4OtAMYTCq/QMlc/hJfPKM+mRPC9PX?= =?us-ascii?Q?GgiCSP+gXVbLrGbzkuYColoA6VcWQJmiZbn6FT70xZnzT2gKmeXfB+nOwHRG?= =?us-ascii?Q?uzD5TCDfvJe2VXg7PeSJSVOjg9/iAgF0MA5jHg2uiaGTZT37CK3uXa44XHmh?= =?us-ascii?Q?ADds4pNbuKTk35W5BITOIpFsEmm0rRLqI4pl7aYyu1y4OkOMsVSAJmG1RLMF?= =?us-ascii?Q?B5zqu9zqsWit7hW47zdh6m9ITPIXN280wY/TCwS3PXs6zxQGZYLDOZHBf9TF?= =?us-ascii?Q?U2KkT3PPiaT8hS94mcCv5pUQ9fPdxwQMFFR6rWyg7RaEUduOcq3vqFscH/np?= =?us-ascii?Q?fx2Ea5Jek4X/6e6ZAlXBO01AhUHTMAj59U7MI9vYpDhGCShJr/sZ21OwaU+p?= =?us-ascii?Q?ps1hM/TGfxMI290I8x+9YzPUbqLkI//3sxA0XoMjhyd4zwhI0qS171ZuOOnn?= =?us-ascii?Q?FRij/qEUuNfW7pVK0F6n19dBeunzn891wgIf6Qnb4WcI0AgMBwN4tSGMdzbf?= =?us-ascii?Q?qgd4jwsYwJ6OgkgqVjluw0rK+ZxWa+jYiUfv4EnA1XgSTUdvqiAT4l3tSCZv?= =?us-ascii?Q?14BgRQBQ79BG3EHZWa4YekT1SDypnveSxTudTjhi73qFkxBhp78DxeT5Ukz8?= =?us-ascii?Q?CN/FB7A2r3mSyI6zP2Ugs7hfE4yCBRAJK6raHtz+Dh13iY7opkhL52S1GLgi?= =?us-ascii?Q?tvFz1oiawBFTwfBlmfWkLMumCaLidgLUvnhuzVGYAnBLi3BoyFlL9mhLj6O9?= =?us-ascii?Q?2VqxXc9YY2wTQ8yfSBdCefSz0hb/4AkJ+UeC0KSK7Z+xtf5NvtPwzGEdLg8x?= =?us-ascii?Q?5RZNKQH6GF+OUlMdcFZJO4qMJG/HideEy0503liIxCtLU+8qVuM36oYVY3Ba?= =?us-ascii?Q?/3GsjTyDc4CP/r19gRFm5UVq/sDbqJm5/m8Srrjr4eYHeoIITPg8oeFVvdXB?= =?us-ascii?Q?U+BViS1ojdmzEU2Gw/LJBwrv92vmIW2WvR61NA8YMKSyJp1dfDSc+vO8A1O+?= =?us-ascii?Q?knxG0oHzlwFQV9dCYbhQ7y9nCcpdf70cnxUzTppVxHzIRpUcRguPz4nTKZ/+?= =?us-ascii?Q?UgHwmmHuisOUAQoIeSo0nZ8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa98bd29-05c6-4bd8-72e5-08d9ed0cbd1a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 03:15:21.6403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j77NTLI4vvgCcpft8sD33ePkFTOMIVyTbJx6mNgkK196QhSK49PC48YVS8yEt0p6XHP9htXnzuarm2NikOVTOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4833 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, I think we have encountered some devices that will take as long as 1 second= to respond. How about adding a new PCD called gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGe= nericTimeoutValue (in microsecond unit) in MdeModulePkg.dec '[PcdsFixedAtBu= ild, PcdsPatchableInModule]' section? Please leave the default PCD value as 1000000 (1 second) and you can custom= ize the value in your own platform DSC file. Also added MdeModulePkg maintainers to check if they have concern for addin= g a new PCD. Best Regards, Hao Wu > -----Original Message----- > From: Sean Rhodes > Sent: Friday, February 11, 2022 5:25 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Matt DeVillier > > Subject: [PATCH 09/18] SdMmcPciDxe: Reduce timeout for SD card reset >=20 > From: Matt DeVillier >=20 > Previous 1s timeout causeed stalls on boot splash with no benefit. > Reduced to 100ms and no interruptions to boot when no SD card inserted. >=20 > Signed-off-by: Matt DeVillier > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > index 85e09cf114..81fae8e262 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > @@ -49,7 +49,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; > // >=20 > // Generic time out value, 1 microsecond as unit. >=20 > // >=20 > -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000 >=20 > +#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 100 >=20 >=20 >=20 > // >=20 > // SD/MMC async transfer timer interval, set by experience. >=20 > -- > 2.32.0