From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.35721.1639537175713554042 for ; Tue, 14 Dec 2021 18:59:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=O0MEsXKH; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639537175; x=1671073175; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ctsGLGabhs23BhkWm2XGRzxv9MMvkKm+CQ4gKDpL+mc=; b=O0MEsXKH+rWcD3FhP8oaWZwF3lZkkZXJdp/gmf2iLMGiFcpBhS3xOauC SgBapyn2UwtELcGjudFLfprCjVTbqlzPObJRDVDUSz86gtnuLddIDZO8Z +UrNlGVGllILNRURUkzcpooxgo0E/n6fzF2sTNm4DiUoPrh2ZIKPzOaib Tg4h116XMZ7mAQOlRZGJ8P7lGsoRkNOEA15a1Av/eJAaqTWpINbDpl5y1 BhXuknbk1HzjbH/QGGDasFtIgmGvVdAyEv06zoUUHW51+/J3PpPbMHNgP GKORDDRrbRv4sLe0Ass5WaXfJ7NKNwv4Cxn79zCxFZOVokNOPG/VJZFZn Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="325413092" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="325413092" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 18:59:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="682314537" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 14 Dec 2021 18:59:34 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 18:59:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 18:59:33 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 14 Dec 2021 18:59:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzwU3K9vFqbLZC+bMUZGiIxIIStZCE7qNESj2xpsO038xIQQnKzEEURnOhRupMy0mxNVd7gJ3idd76Eanb2J6mWG+k6WHg4n/aRclpu3tEVQ+LQgCDtl7etVDFKQcAVk6XtMDZFTms6uNg7gs8KD6FlUbWG0KcM7NCZmp9NFqJ/Nbzn+gbhLei2A54wKO8SeSEI25JPTwpn9Y+/MS2qV/+MXSeiM05S8oCW9V2bR/4Tik3lqkljRHP3YewJ66Lf/VGR4+wi4QmBhNsEmva/j8yBH8Iu8sObCEifS4PR17k5pGtU5t/M61lTX3hIgYQBXlN/XhVSHy6DECSMvBk+SMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8gehPoq98+RIuzkVsxEKwV3OkHghFvR1OAPUwO7wpw=; b=OySyjUY76M4ytFhVhE4+QkBhuRVRvYBmhJ/9poSqBIlqenNC9lTxETm2eZH175AQ3jeZWTf258oSUAVQP/M0P8MFLk05GRepNKmQhUCtR0IhDZmeQ0olYkMZXGxzjqQJmoHgKgoECxYIiPmBskViJq/TrWPaX66T08XCkiODDYrpu4r5TIZKj0A/DwlkBBJK27sPGQn+Tp1JkvoZfFLj3pDoc62kuzKEMWV0ZCwhTfj6FqrQrdKvNFPswF7/3kMhfVJ8y19oPA/ZHHJbF6TSGrS+30EJJr3d1KVlS0GFSMswgaJQXk6NObWXcUaydXSSju8ORqDRYTKIqpMCEZfiSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b8gehPoq98+RIuzkVsxEKwV3OkHghFvR1OAPUwO7wpw=; b=f93SQJg8VXrLiXwuVS/MsB/gmIrF+MqiZ03PPXrw9KdbLs/lc3XrgchQjdZ5fFtoayJl0hP5LYOBWwxk1tXMssJJ3qLTnyraA7Ln/jJ77CV/kwhU0S1dGncW66WwMjqgOxajISf8q+Imx1ClR39H+WXlhqLuvDMG+m3JPluWw/U= Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB2683.namprd11.prod.outlook.com (2603:10b6:5:c6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Wed, 15 Dec 2021 02:59:30 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%5]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021 02:59:30 +0000 From: "Wu, Hao A" To: Jeff Brasen , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Topic: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Index: AQHX8RRhP+NC435QqEyMgowdUQbl8Kwy2ghg Date: Wed, 15 Dec 2021 02:59:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c656344f-bbcd-47a2-5592-08d9bf76ea58 x-ms-traffictypediagnostic: DM6PR11MB2683:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hi9FA8nTrfPGRCOENo7rvdbzTb6ujZJ/jKvE0zVlPEpLS5cm7DDSB8xs9rLxjssiwJV6isopO6eHrGZzfCV5N9byfLTMI3i3ofi6mihZtMS7bpd2FBI556uv5pUmcRa7lPHaKwEoYi8KhXC+MyeNPS+h7LUew2mPW6PMCBfyrBeEyADQ8m6B7f1k/irvMyeaB74TaVSTicylfoc50o7cC7C5eZYedaQKMMP0bOE+Pf71Pa21dZoREzbms9pND6OIFlalQ+3R24DWV/Qf6tVLPg2wYsyB9yKMcbAQlazj2p0HrTn00Bgy1h3DmfOLeYIXAlQn3j4rE6SYk7SqRRlGWMg/J5tQeVf1MXhBp+dP/AsmTrGEtV4R6uOcNXYyw2rltQEC9SdKLvgMnfK2t+PRi9kwIHNEIvuxH6mrAfNTptYnaSNdKfmTLsdY0lJO1GuCEd9szi9iF3567garT3eExkW49pJrejpFO+tF2kg83nami7iNUsZh5X+eAQmZa7A3pbCP14HTrgWDrBt/wAMRs3jIGiCs0DsDzUUFODICDTRU5CxpCZpPWAr31riUj0Z4+HNMTJpP2QGcC3m8182ZJxOU0wVMF/BBxBrM+cHM7ZP3jqq3yZraJi/WNFtqgoFi2C44foxfIwoq7yUMAqIbjatduHJBhMREG48ZFbEYl8elw8wKsLZTO2JtO4nHNH1vsrHUDJ21+otbOupRBrpIig== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(9686003)(33656002)(2906002)(110136005)(86362001)(8936002)(82960400001)(83380400001)(76116006)(53546011)(4326008)(66946007)(107886003)(508600001)(5660300002)(6506007)(8676002)(7696005)(66476007)(64756008)(52536014)(71200400001)(55016003)(122000001)(66556008)(66446008)(186003)(38100700002)(38070700005)(316002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/m6ZZTDpKKgxEPOepqvEveWIS9f5q4PKeTyAghcSQpKA/eXs3rTKGF7WkA7o?= =?us-ascii?Q?lTCQS5Lw+JvpSgozbc1bXsvfYNeOqWBBQ8E9P8eevgnO8PJzYd4xXil7dq0S?= =?us-ascii?Q?GU5lcAXTTOQaeQXq9lV924TCQTBif1a8ni46kuqt/pj/dGXTLYMaLamVsKXq?= =?us-ascii?Q?JjXDgFkLYgkE39Qi5rD3p7TvT7ix4Bqgyg6Xyk/P4FEPh5S453RzNVCPMThe?= =?us-ascii?Q?qvd3Sf4ljSupBI9i/ZFfJk973/CfZmWKQBQalu1HEtPiV49eLh4TtM0F2SJZ?= =?us-ascii?Q?zJ5TqZmdMLH9re6vnAghCsu/aYxEm1AlnbHHyNI9426/htqk3FBqc+1aEv40?= =?us-ascii?Q?V/AkfOM1N7txShv/TMtbMjuED+idGXr+BDUSPPqkA7lYWroEsMKuRanYsIqw?= =?us-ascii?Q?qQXtOw175D32FpgSobOESwwIv1uQbeUiEQ+2CIjDuM/9jL+vw95976aV9udk?= =?us-ascii?Q?OUbvwSouJy0fhNmxB1cSIbNrMOFTzMbIkNMM7XzhITdYj/sS5wHuG4TI/Ru6?= =?us-ascii?Q?f6tPdMXL9/IXRWd/QhsTzc9zJvuUA4epCgE8xL1IDvrWw4v/4IMjH09wH5A4?= =?us-ascii?Q?FL/H8/d1J/QoBMmyfpv0CgPvSkLI5gkfv+s9rROkioKrJJCnW02TVbwYgXvq?= =?us-ascii?Q?ur8NpdDOlwp5TJMOCfmI1i6AlQlQSjy9S08P5piIYaknHbGkX+1lj/RbzeZy?= =?us-ascii?Q?zaZs79NLqihNEWiLH1BLqwGhKoYwUqRedPgoRCOpRvGrkK93FGDTMqQjY38t?= =?us-ascii?Q?zwWKVRveGisFjekCo0X3DG1r9UL746z6EjVFBaHwMOqExtpRLto4xxVujITb?= =?us-ascii?Q?/xXGHoPLkhJZ/oL/d5hlzbsl1IZzwDT92I2Q4uPfI5YhOXVmyLlP4x8WORao?= =?us-ascii?Q?YqeevCcqjsJCTHztcT+1fdyRa0lsWYzNavdUQwQ6VpHMc4Kw/pL3Vf6VUcs+?= =?us-ascii?Q?FT4sickufQ8ZdGT/pE+P9b2rPE5ti98TT+Q/5M91I9phsDwEB8rrHyJ2A6+9?= =?us-ascii?Q?Wo+cHpxo8t0dPttZv2k7Sbu7JZ/C2yelzS2StrmD7KT8R/cYhZWga8ZO1Db/?= =?us-ascii?Q?SoHtJBJo9Ee4ZHznLtDAnoDvKw4VXgmtHT+jf57EB+MRLwvcsp7DboBjBajV?= =?us-ascii?Q?/vy+1UyX310yxpPNC8eNeDsPT8mr6PeeLWYz37LbaE9dXrefaBEfxQAJtzS/?= =?us-ascii?Q?9+KhfDX/lUPK+mgrQRIPcu67SL+mnS3n1eNCq90XYa7fyyNyJgLeybYnukh3?= =?us-ascii?Q?xw7LntodcC/Gmd7EDVsYa8rUuE7H+e6eVku+sqxAv3mTSVSi0wRdk8ZmFHo+?= =?us-ascii?Q?PWzHJKcu+jebDn8K7O0dbAGgdd3iKCo0VKzM7jVoVYv81kc3NXBYX3cOFcg0?= =?us-ascii?Q?AsDdMtVnt0E5oVFdNF98UgaOkaA7ABZWp6QYRhue7n9sH5tKUa/gBDi4lluP?= =?us-ascii?Q?MSzjodi6w6mMiDcTYvE+Dt5EIJ/tURmf2LkyTNrZZK/ObBIieO/67r9YwZfl?= =?us-ascii?Q?dx3BUcvpOMeJLGVfUeEJDszXbPJRJtDqh+lExnY82BZ7+lqBnnaorlS5/LyA?= =?us-ascii?Q?My409hDNfa87zu/pomoahBc3vqXCbMeTuYW08zxnOmQXFtbTIdNdXXKW8Gi4?= =?us-ascii?Q?d++gILx7txrJ9jRRM5+Uf6I=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c656344f-bbcd-47a2-5592-08d9bf76ea58 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 02:59:30.7089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LIYj+0qETahMBkUXZjcjaHuxwRnq2XlO1Fo7rueGMqFli9NSuWTFpqp/NcyQBKd2335m1XsNvi/LOPlNrz4V+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2683 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Jeff Brasen > Sent: Wednesday, December 15, 2021 1:59 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Jeff > Brasen > Subject: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY >=20 > Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBACK. > This allows services like variable services that run at TPL_NOTIFY to be = hosted > on ScsiDisks (i.e. UFS) >=20 > Aligns with the eMMC driver that also uses a higher TPL. > This change was made in 3b1d8241d0dac25c5e678c364fa2754ac1731060 Sorry, my take is that this change is not equivalent to the one made in the= SD/MMC stack. For the SD/MMC change you mentioned (commit 3b1d8241d0dac25c5e678c364fa2754= ac1731060), the TPL is raised to TPL_NOTIFY only when: a) Operation to the linked lists that manage the asynchronous IO tasks b) Callback functions that process the asynchronous IO tasks The TPL remains TPL_CALLBACK during the BlockIO services and the majority o= f the BlockIO2 services (operations to asynchronous tasks linked list are t= he exceptions). But the proposed change in ScsiDisk modifies the TPL level of the entire Bl= ockIO/BlockIO2 (and other protocols) services to TPL_NOTIFY. For me, this is not aligned with the "TPL Restrictions" documented in the U= EFI specification. Best Regards, Hao Wu >=20 > Signed-off-by: Jeff Brasen > --- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 22 ++++++++++---------- > 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > index 98e84b4ea8..b6e5848e77 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > @@ -514,7 +514,7 @@ ScsiDiskReset ( > SCSI_DISK_DEV *ScsiDiskDevice; > EFI_STATUS Status; >=20 > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); >=20 > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); >=20 > @@ -581,7 +581,7 @@ ScsiDiskReadBlocks ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -733,7 +733,7 @@ ScsiDiskWriteBlocks ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -898,7 +898,7 @@ ScsiDiskResetEx ( > SCSI_DISK_DEV *ScsiDiskDevice; > EFI_STATUS Status; >=20 > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); >=20 > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); >=20 > @@ -975,7 +975,7 @@ ScsiDiskReadBlocksEx ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -1154,7 +1154,7 @@ ScsiDiskWriteBlocksEx ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -1323,7 +1323,7 @@ ScsiDiskFlushBlocksEx ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -1717,7 +1717,7 @@ ScsiDiskEraseBlocks ( > EFI_TPL OldTpl; >=20 > MediaChange =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_ERASEBLK (This); >=20 > if (!IS_DEVICE_FIXED (ScsiDiskDevice)) { @@ -1907,7 +1907,7 @@ > ScsiDiskReceiveData ( > AlignedBuffer =3D NULL; > MediaChange =3D FALSE; > AlignedBufferAllocated =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -2122,7 +2122,7 @@ ScsiDiskSendData ( > AlignedBuffer =3D NULL; > MediaChange =3D FALSE; > AlignedBufferAllocated =3D FALSE; > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > Media =3D ScsiDiskDevice->BlkIo.Media; >=20 > @@ -2294,7 +2294,7 @@ ScsiDiskDetectMedia ( >=20 > Status =3D gBS->CreateEvent ( > EVT_TIMER, > - TPL_CALLBACK, > + TPL_NOTIFY, > NULL, > NULL, > &TimeoutEvt > -- > 2.17.1