From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mx.groups.io with SMTP id smtpd.web10.5568.1645670648901351068
 for <devel@edk2.groups.io>;
 Wed, 23 Feb 2022 18:44:09 -0800
Authentication-Results: mx.groups.io;
 dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=n48ZkWmQ;
 spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1645670648; x=1677206648;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=h2n49X2mSIPlOcTwQ1UWEWCjpDh2xkkiujMenoysNmQ=;
  b=n48ZkWmQVHDnf4glEgy1L9zA0IV6uFN8xAqu9lfsnghcvnY5uAPjy88U
   yVWbccbghzD3SQHrs6P391bdMXHm0scoBgf/8YAsPECBs2jBedSosRzam
   cG1YZzwVOByZlaUBGlAQcNovrXc0UFefectzMtJyX3wUYe1KlbWqLMD7D
   4HiyJW04yppsjN10E76+dIMv/AXDXK8Sr39OyoeaubFp27IIAhz+VVTMq
   RQqfFkI4XlJ0+5jps2yuGEg/IhOH741PJpS10bg6mVgZ3dq7ZVwm2/dKA
   062JFLCee9BeSpvUo57nE2IFxHLk6tTBt3RbHkuc7KCPEwekZxylMXdJe
   w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="251870312"
X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; 
   d="scan'208";a="251870312"
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 18:44:08 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; 
   d="scan'208";a="639557900"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
  by orsmga004.jf.intel.com with ESMTP; 23 Feb 2022 18:44:08 -0800
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.21; Wed, 23 Feb 2022 18:44:08 -0800
Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Wed, 23 Feb 2022 18:44:07 -0800
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 18:44:07 -0800
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Wed, 23 Feb 2022 18:44:07 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iiFgTLJ/+m6ULFRHad9dUO+Jbj1xoV7pfiE9PBQIFyceWRlleTyEtfWk74+1BssZ3oZ7Zy3HufRwE/XzihhcTj0AKg9R5Wyxbi+0qrzrQrtScUNyHd34pzGQlLfEMfLY5NeK616CeclpTWDHMj4owkTKBijZ0Axc39EtQ9C0J8AQrTQYqaxqxkIWnJtzxLHJJbZbTuDYvfMFYL+LZxPmr9tYPofrbT6ixPh/1RhcsnOkmyffmi8Gw8J9Y+9JLjQCWmANZlPoQJcY++jEUDVMzokm1YY8PJE6hPTVhAV1Y9Zdz1KJ/zu7Yw2tvVup9DqlblZHmnQQoNQLG4ScQfwlUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3TYI1J5KOsE7+ESviqi+5Agz99p3sMz2UTWWeTRXQAY=;
 b=SE4VIrR8FWenrRQcNI1VaaXlaSZvc8S/G5HiczMTzY5BkVhGVITRjDm77zO+0A6iKWyLKAnWOOI/u2A/MAuWkjoXPm1KYavmJuAxcdk4dFCGExAsRlS0YxHdqc1LjJ1lXQzrbroY702oUvDgz+21q0uCxGudC4XokegtXv7WDTSakB9ueiM02lepywIaMsKutEVUL4/+fQOOrVxURbnsMKqSvE9KrP2lVeSVlcFcZdcbLD8fcAJ3WrWBPU4uGoi4BWn3B0lVUzYVmjjkMFsd5tloDQ5v6JNYC/p6i/gSGvL/SPCeDefXwzaEvMFGDsbzVb+DOX+UdSX8+cAfO/EfRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31)
 by BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb
 2022 02:44:05 +0000
Received: from DM6PR11MB4025.namprd11.prod.outlook.com
 ([fe80::2dd0:9ba8:a8c:fc96]) by DM6PR11MB4025.namprd11.prod.outlook.com
 ([fe80::2dd0:9ba8:a8c:fc96%3]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022
 02:44:05 +0000
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Rhodes, Sean" <sean@starlabs.systems>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Dong, Guo" <guo.dong@intel.com>, Matt DeVillier
	<matt.devillier@gmail.com>, "Ni, Ray" <ray.ni@intel.com>, "Wang, Jian J"
	<jian.j.wang@intel.com>, "Gao, Liming" <gaoliming@byosoft.com.cn>, "Rhodes,
 Sean" <sean@starlabs.systems>
Subject: Re: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable
Thread-Topic: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card
 configurable
Thread-Index: AQHYJJiHWgsItLLJJ06xGCKkDjEc06yY7SZg
Date: Thu, 24 Feb 2022 02:44:05 +0000
Message-ID: <DM6PR11MB40252133EF6DB44A776F335DCA3D9@DM6PR11MB4025.namprd11.prod.outlook.com>
References: <bced944f45650f3a4ddd4d6e99531f2b51450190.1645169028.git.sean@starlabs.systems>
In-Reply-To: <bced944f45650f3a4ddd4d6e99531f2b51450190.1645169028.git.sean@starlabs.systems>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d0b2f573-57f0-4539-64e5-08d9f73f864a
x-ms-traffictypediagnostic: BYAPR11MB3477:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BYAPR11MB3477F9029E2DCDB2A30FB81CCA3D9@BYAPR11MB3477.namprd11.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: P1b7HJHecRdsFWHTEYoQj0Xd+5+mTTpqqy85PlxuofAvsCQ11PkDxYAch/CdI5G8jMydxXowf8CPnkEu2BionR1kDO6OiWo/4aZoUqUMtZF9Ys6RlluBhhq25k9H/o8wlvCvwDb+NJ5lwX8bQXguHyB/yrHsiLo4blf56BXl/+1xRLL4UEN8Ze35NA1M0ifN9oDjP6F6r1z2TPv/I47lHog5KaS+FEkPcKIxhR2rbVgNC3ryK4yw1iAlXOIREVvI57amdvMJkvbI1vz1qjCAw5Rc40BovComdlz6h0BKfFy2QlW5M1OXPrn9mnShzWPWmsGDvvK4OUwVX3lXiX2euBIHGcEHKYk2aH7HHYAd4jrFq3KAAR9vKSOA/j4QkE2uuW8PH3Rcn/5kzd0kjaeZmXRxzGdkbi9ZF+/Vn47up/jXS/7D4kHzaW1XbbjZbsjvhSWcfC8mYeYbm49Hqk3mHewh0LExpONO3/UFGMC1ba45C0aqA7ulSudmHqgTSpTzpsmlQlPiQwGTHkFw0/7nf7R+dlLAc/Ayk2YCd34ATp+BAkaCA/wukixyJG2KApX6a170tEjxV0xZtWs9nzM2EQYcdd2B83eYaOBrsugvcj5eJVIUlubrtPRXqPtmLtD9VpBc3LyTDHmDC4hfLKR4Yq6V5qunwxgWPVtsjqK1pPr8SocCN6wA+fvBZDCWX7IixMtAE+P3TCyvDOPeFcSPu78Qv+v6++fbX4hBs3JrqdDI0n20ZMnzGkeP2c4701Eh
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(316002)(55016003)(83380400001)(110136005)(54906003)(38100700002)(86362001)(26005)(186003)(64756008)(2906002)(9686003)(4326008)(71200400001)(53546011)(8936002)(33656002)(122000001)(508600001)(82960400001)(38070700005)(6506007)(5660300002)(7696005)(66946007)(66556008)(8676002)(52536014)(66476007)(76116006)(66446008)(14943795004);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WheRktEjJFGEoldRClAjiP0DVMF9dUduXBB7zWFAMYWW6s/coV74yVn8KPy+?=
 =?us-ascii?Q?vMLKCUrBM4iFjOqd5c6Lm5k81W82b929U4qbehn26tEfDXBgQPAMX4wWXAwH?=
 =?us-ascii?Q?QIApvlMcPHKz1VmXfvi+WK4CAuG+rtHmusFF2dSfadvmIr5QGFTso1g/ti5z?=
 =?us-ascii?Q?FaqMO7RTOQNfHCM2jNhc07ZSGdhi5lvMXt+jthKJ/pkxQcBxyO/Gv3H8q1HL?=
 =?us-ascii?Q?/Lxkw1bntdTdBxnX6B5JJK73Z3qcdUyVVF4hk4njtUbKwQmsKUNVbMT8YmiR?=
 =?us-ascii?Q?l0LYH17NE5FydBynfAMet3L6AHxkiyRz9hLcQYBCZnksgFRGF2U8zFvVgomr?=
 =?us-ascii?Q?OhBGyfiCrD1xK+ydDXbMqK96giSwXPG8fw13v9j1sgS8G4kwpqbtKcjqiPqG?=
 =?us-ascii?Q?Lw7krBE90kqjHSCLVmi/fo9zW10eMeEv7at5tmzdDBWR5H6wt34RgoMliMiX?=
 =?us-ascii?Q?krompU1pcSyTspyWda9/3d5Pr/vm9Ps5r65Q5E+YcobrvvMmUlEATbY5T11r?=
 =?us-ascii?Q?xgt+VP15P0c6LEIZcK3apNbis4zwLyj6mHLjFiUjA+I5KsYB0/fFe5raPlY+?=
 =?us-ascii?Q?OcoyuJSNCMkrzozDj4i9kvYQdp5iHDfCHdOSrBZTQIvNWMxPACkkBcZarSy1?=
 =?us-ascii?Q?MHxafs0iogd56o3n6loMiFARtWC8cOlEs+0o/9E6Jke9z7sdLNBZ41Szlwr5?=
 =?us-ascii?Q?QG+xGcJaZ4hNHdoTvOzvAkE/BP5y+4EzPY0hWXmarAeNLXXLFZco4Jmxc1gH?=
 =?us-ascii?Q?UKOinY56e4CJM0O+4CYwd80oTX69mYXnJH8fdoh3HU53U3PefY4jFpHs1ekA?=
 =?us-ascii?Q?t5VDj0v2UMr66bp/l9SflLvrHms6shsPS5sky8Y2ydO7Rk2D3ha6io0lzCgu?=
 =?us-ascii?Q?4kbUCOZ8cnnFVFw3YMgXJZ8CES1hYU9znt36kf6/+TmmyUTWdlJztolD5n32?=
 =?us-ascii?Q?w+0K3hOgifP+0qhcI1bN/mTXzaehBhD8W4DUYr4m1fmOGlupaBEAEjltrN0D?=
 =?us-ascii?Q?gCp1DM2rkyTTIEi1JBSGqOC8nSrsQ21Gau2s3K2pC0br1Ul3Dp31+83PW675?=
 =?us-ascii?Q?x6/65zF/nlmUsXVN5Jk/qyQkEo/K2/JH04g4KxenveR+JLaT+FjBmf1DtLjd?=
 =?us-ascii?Q?wzKkRE3bHbyPHJ3jJC2cGteD9ILfhfhIplTr4LZ0OL2fenvP95LrcpdQ0RM4?=
 =?us-ascii?Q?wOU8Mi2+nTRZYoFpu9oSb7v1dJPPmOAP1mqD2n/rcGdUVqgTuAqPigPP4+FW?=
 =?us-ascii?Q?chSu2uNWdkd0QUnsnYJU1110LJ5KPgo7Es2x+9rdUzsKwMwLLxVddYAFU0UW?=
 =?us-ascii?Q?D8rfgxOyhFDzI0gXzLngFbJUxDTT50HxO2urtKLH7+KFbW2UadoUTfoQbHXO?=
 =?us-ascii?Q?Aqk178cBPqStp4fG0iQ54BZIkprt/+1fz4RZj07+nzo+DGaw+yzMqQUj51KK?=
 =?us-ascii?Q?xL5RHJMG+JYQ43TQhdvSWTOhYGt4P50myoS+MipV75wOEPfUkQwpX3ZON+bP?=
 =?us-ascii?Q?4vQQks3jie25fXXNN7eYK5N1TxA1LZsRl9S35nfYVQCA7TmINOfGRl4+qIVr?=
 =?us-ascii?Q?MEgcmqpypm8HQlmNROS48wVkbECbRgqPZNGsAD8o0GZF5EM6DKgGfiNZ14za?=
 =?us-ascii?Q?MIXYkPouNPf57heeYtLA3lQ=3D?=
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0b2f573-57f0-4539-64e5-08d9f73f864a
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 02:44:05.5783
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dYbEd9jNEAiQOabNQ+tVIfFqmWD3xbK18H8ep5Dl81F+T/fVsdZhwi4nl3bM7hMm+KOEL3B3xpUtrAqnJEforw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3477
Return-Path: hao.a.wu@intel.com
X-OriginatorOrg: intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

3 inline comments below:


> -----Original Message-----
> From: Sean Rhodes <sean@starlabs.systems>
> Sent: Friday, February 18, 2022 3:24 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Matt DeVillier
> <matt.devillier@gmail.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Rhodes, Sean <sean@starlabs.systems>
> Subject: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for
> SD card configurable
>=20
> From: Matt DeVillier <matt.devillier@gmail.com>
>=20
> The default 1s timeout can delay boot splash on some hardware with no
> benefit.
>=20
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h    | 3 ++-
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf  | 4 ++++
>  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli | 2 +-
>  MdeModulePkg/MdeModulePkg.dec                         | 4 ++++
>  MdeModulePkg/MdeModulePkg.uni                         | 4 ++++
>  5 files changed, 15 insertions(+), 2 deletions(-)
>=20
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> index 85e09cf114..b76c7cffa2 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> @@ -24,6 +24,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include <Library/MemoryAllocationLib.h>
>=20
>  #include <Library/UefiLib.h>
>=20
>  #include <Library/DevicePathLib.h>
>=20
> +#include <Library/PcdLib.h>
>=20
>=20
>=20
>  #include <Protocol/DevicePath.h>
>=20
>  #include <Protocol/PciIo.h>
>=20
> @@ -49,7 +50,7 @@ extern EDKII_SD_MMC_OVERRIDE  *mOverride;
>  //
>=20
>  // Generic time out value, 1 microsecond as unit.
>=20
>  //
>=20
> -#define SD_MMC_HC_GENERIC_TIMEOUT  1 * 1000 * 1000
>=20
> +#define SD_MMC_HC_GENERIC_TIMEOUT  (PcdGet32
> (PcdSdMmcGenericTimeoutValue))
>=20
>=20
>=20
>  //
>=20
>  // SD/MMC async transfer timer interval, set by experience.
>=20
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> index 453ecde7fd..a9d05736d7 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> @@ -56,6 +56,7 @@
>    BaseLib
>=20
>    UefiDriverEntryPoint
>=20
>    DebugLib
>=20
> +  PcdLib
>=20
>=20
>=20
>  [Protocols]
>=20
>    gEdkiiSdMmcOverrideProtocolGuid               ## SOMETIMES_CONSUMES
>=20
> @@ -68,3 +69,6 @@
>=20
>=20
>  [UserExtensions.TianoCore."ExtraFiles"]
>=20
>    SdMmcPciHcDxeExtra.uni
>=20
> +
>=20
> +[Pcd.IA32,Pcd.X64]


1. "[Pcd]" should be fine.


>=20
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue
> 		## CONSUMES


2. Could you please help to run the PatchCheck.py to check your patch befor=
e sending out:

py BaseTools/Scripts/PatchCheck.py -1
Checking git commit: HEAD
MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable
The commit message format passed all checks.
Code format is not valid:
 * Tab character used
   File: MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
   Line:   gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue      =
     ## CONSUMES


>=20
> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> index f4153a09f8..666c3280cc 160000
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> @@ -1 +1 @@
> -Subproject commit f4153a09f87cbb9c826d8fc12c74642bb2d879ea
> +Subproject commit 666c3280cc11dc433c303d79a83d4ffbdd12cc8d


3. Why change in BrotliCustomDecompressLib is needed for this patch?


Best Regards,
Hao Wu


> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 463e889e9a..40601c9583 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1559,6 +1559,10 @@
>    # @Prompt Maximum permitted FwVol section nesting depth (exclusive).
>=20
>=20
> gEfiMdeModulePkgTokenSpaceGuid.PcdFwVolDxeMaxEncapsulationDepth|
> 0x10|UINT32|0x00000030
>=20
>=20
>=20
> +  ## Indicates the default timeout value for SD/MMC Host Controller
> operations in microseconds.
>=20
> +  # @Prompt SD/MMC Host Controller Operations Timeout (us).
>=20
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000
> 000|UINT32|0x00000031
>=20
> +
>=20
>  [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>=20
>    ## This PCD defines the Console output row. The default value is 25
> according to UEFI spec.
>=20
>    #  This PCD could be set to 0 then console output would be at max colu=
mn
> and max row.
>=20
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index 27889a7280..b070f15ff2 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1173,6 +1173,10 @@
>                                                                          =
                  " TRUE  - Capsule In Ram is
> supported.<BR>"
>=20
>                                                                          =
                  " FALSE - Capsule In Ram is not
> supported."
>=20
>=20
>=20
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue
> _PROMPT #language en-US "SD/MMC Host Controller Operations Timeout
> (us)."
>=20
> +
>=20
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue
> _HELP   #language en-US "Indicates the default timeout value for SD/MMC
> Host Controller operations in microseconds."
>=20
> +
>=20
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_PRO
> MPT  #language en-US "Capsule On Disk relocation device path."
>=20
>=20
>=20
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_HELP
> #language en-US   "Full device path of platform specific device to store
> Capsule On Disk temp relocation file.<BR>"
>=20
> --
> 2.32.0