From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.25015.1647823757520357694 for ; Sun, 20 Mar 2022 17:49:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eB5O0E1x; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647823757; x=1679359757; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+fzhHWjihDN3AeC0gfvdS6JKzZ15MH5UcVUSVYOQ6KU=; b=eB5O0E1xvDmrgFoN0lMBbp3/lyZNV7ezA1MLAE7EFWHU4cORGGHPEVHX dGoA6pSA7/kokqcgeq59UP5bxpSVLICLvZ+0tKegGhbh3W1ekC55+O0da JwQmkLlVBeAynR32QJi6LoIhtMFheJV3mwngSnPaKOc94VHxSdjy2JOfi VD+8/0eAvY4DCfZ6OYaZKrYpSfND3/Mtnk9GT6HAornN+8ZRq85MyNas0 xIZpKONOgYpp2hMEa2nH9lIcja/uRpu+jmp2OAeF3a4Z/R4fnl7kUUrLb JZiqtG+2++czTfkcheef9+6xyWOzBKho87f+zmsB5nbj24GUjif4/ywwA w==; X-IronPort-AV: E=McAfee;i="6200,9189,10292"; a="237386081" X-IronPort-AV: E=Sophos;i="5.90,197,1643702400"; d="scan'208";a="237386081" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2022 17:49:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,197,1643702400"; d="scan'208";a="692012499" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2022 17:49:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 20 Mar 2022 17:49:16 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 20 Mar 2022 17:49:15 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 20 Mar 2022 17:49:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 20 Mar 2022 17:49:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHWzKfhfwT763Mpem+fLdoRK6kpI79Yj9hmyjMqgiyIcxBl8OT7849RI9i0Z30u+kEXHGOLLIR83Wz+NvB7zLwhq+7+dKggOTh1UKHLhg1r+QdgrtFS/+9UfjCpWCvyk5TH8Z6A2Xdb7o7SgXaL9yd+FpqQ3St7BErllR1tIrI5E8m2Y0b5srjlxE8gGcruP40r7yxs5B4YCj+9dCJvgq+sXOwzA6BHg/w5v/VoiG2ZQ0W5r5bKjtMCNfJ0EajtlhJLuXW+izlIkQaVOm6pYBrbMg4yryccRup69K+aK5e8k4r++X1TqPeR3EhoKvs0C1xKClQVaEodp/DIYDM9p9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+fzhHWjihDN3AeC0gfvdS6JKzZ15MH5UcVUSVYOQ6KU=; b=biWwNvIwvmxEDuLsr5z2fs8lNNRj2dLSNCRtzoDczpohza2975/hfUR6eNvlCnUrLTmw3SoG+JBA29mrbP/ckok+pFW8xxtTJGqro9uwONZC/RH2ch1HWQ9mYAfqfRvEILE6YiTT4XdHwdUVMm06AsyNBGjVBZAz8beZzgc/vjMjnXBTQpI7E+ZuXJWYZjvth5AeKFkY2Fe9rtLpNp3qG2ymv1PQ90G9LBkq2WM2O3ZjyO6YB8lLh/ACcAiLIuadlXug9WWigwscBQMXvJ9uFdXG+FAtyA/yguwqmL/RiMl0oTzngAlap78BjPr+boUfhbSGVmBbnrT1lDMIS4q9+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SJ0PR11MB5182.namprd11.prod.outlook.com (2603:10b6:a03:2ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Mon, 21 Mar 2022 00:49:13 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b%7]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 00:49:13 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "littlefox@lf-net.org" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css Thread-Index: AQHYOYN3cYMYlMPe3kiuym82iBUuo6zHTuEAgAG4JdA= Date: Mon, 21 Mar 2022 00:49:13 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5df82ff1-36f9-4d05-8a80-08da0ad49ebf x-ms-traffictypediagnostic: SJ0PR11MB5182:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zOewIcLo2uWgwsRr7BDrF8wG05SvtUWDahyF6ri8bcYo42ylWcUoikhPP6u519TjZMIGgriMJk8PPjjIlwEaxc6l9PIyiknk+tXr0Y/FNoadMPMOS26fc3AW9pqTYAVSJwe4xjrLASnCUfaMluos7qWm1Ns1zkiEdQJ1fNo8oDNSMMZIbpjkcxp2RVkacHg7ol8kLXM4kVIdB2RdCdk1vFnbPb+U4jAf2RvIPI2gIz1Q1I/wEqQJdT/mDSTS2Wpa6J61YP/+4FP4a8NvW0mpytzvZ5+rMLxdv2fdfG2mA+0ceYxjINKw8SJ53d68988Tv5l7CR8kQrD6n5PwfJMmoAISyWHje841u5128Nf04WQg7aHyOuuxIMwkSQ/G7W/AOuHR3m9MDaM9BLgJm2VH3Lm9ByKewla4Zr9gw31iTzmvZR5o3sRtFbCy466VI6FjZDpjHuIVpMb32g0wLTIAHtsI04lnpgGAbtJ23R7JGQOs0BXBJDC8PwwnueUjqv4c6VNrG45h4T9A0eGE4K5SzdKVEYTWwujALhP21zGoxXqNgfLsO9e+gCsOLao7t2iO9EnsOyFebKPx2PI8+GkKcO6b2L659G8Egda43RgZO2WZhDvUEs3BxxdHQ6GuGQ5sj8l+Jw4O/Bg0ne2i0VcWC68aFxPSzB9qRUG0J6Nn0z36oroox9XmvVgFSKf5x1SUYxPJ8vKY9xAg/dRJkhnc4/fc9T427uEXgBGOJQB4i7eInw3Jdt4xg1XElC5fhrc6xeaJWvej3sORBOSFPAP09k2BJk421BdaR4cRPAK4P5OleHSGGgHqKkUOMEQ/TYShcjs89h/poklsraNaAyfJUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(66476007)(2906002)(66446008)(64756008)(66556008)(82960400001)(52536014)(508600001)(122000001)(38070700005)(4326008)(76116006)(38100700002)(8676002)(8936002)(5660300002)(7696005)(966005)(110136005)(316002)(54906003)(33656002)(86362001)(71200400001)(9686003)(83380400001)(55016003)(186003)(26005)(53546011)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iNlydk6geKaeVtuBiB7HJ2DreKkEh/7cYy2/B/u39ZobpkRiF59C6VCFeecr?= =?us-ascii?Q?93DdH924DJg6Xd0hIBdYApmfAx88n2vM+CcB1YDvFXfpNRaQqnVF7q2SD83D?= =?us-ascii?Q?NohA6TRDlote3SpiR2FXmSyl5ouiJNua17rJYxZBMt5XrlvN8UB5plaGfOet?= =?us-ascii?Q?z+b+wRMIKcbxz1jOc3FSEy+RO15Zpo/iUtepY7fX1Zt6aHupBixD9VIs6S0s?= =?us-ascii?Q?RSFR6POyhcAECB8MgoQKmZEVGt3miDNfCKDr11JTY8zu905D09YUYgnDLCWt?= =?us-ascii?Q?fPEKOlLPdvexABUHBxOw87nFnSO+YLBYMsuAlSD/bfen8R+uyRKtYJ/skEM+?= =?us-ascii?Q?vt+GXqeJZQp7cH0lQUZCqrXqU5jCFM2h8PgnB2crm7Wjseij2PkAPHlAhrZW?= =?us-ascii?Q?Q9+TsmrHJAYrBMdEprbmeYyMzsvu4xp/y4jlFtsiDb6QvDnfVKgObi39lydI?= =?us-ascii?Q?FsigyYh7s0SgwvEIQ4IRDrd8pCt//qZQTCPjJkZuSH6y8V+rmRfFL8h61zRZ?= =?us-ascii?Q?28dqYPzA8Omz+gL2l9wnfLi+S+Dvg7Ph77W4rbAcUyIo2CAMRwkWRkg2ZKAh?= =?us-ascii?Q?9o8zBVIbOBaYaLwRpt03mfDPVPd3XBrtMMiBvU2JqUYofc0pUTZ2ctWXvyQu?= =?us-ascii?Q?jMq4kROTD6XSPZQnJJhOwO5XZbxu4jIxv/WFq4AdTRiSqN69vltRJFjPBvlV?= =?us-ascii?Q?7n2xOUDcIOk/xE2F+9n99nBm1vk5fnGvJSswXMU79X68C2lP/Wju9g256CDz?= =?us-ascii?Q?pfNMeQJoohyT/Sl60vTpZjQ/Xwwk+V2RfhLIXItgGAWeCZ38L3Rgn6r+O4dy?= =?us-ascii?Q?qx5z0ObXgkCTeHaavXx4OKFtAqtGQ0K+0scm88XzTACqBRG7XtOXDpfqi+05?= =?us-ascii?Q?dra4CSeqfNtCsRfNLBdyHVg1plU5mSPSC0KAnclNP0+MY+KdRb7SEciRn+nu?= =?us-ascii?Q?C/YXPCLJSaAuEFFnR7jxWRH2YX1o0gmn021q3eqL8ASC/NQkzhq/OMimiJwM?= =?us-ascii?Q?TVrZXsmyWycFE8Nm7brCttazydweHSA8aKb5vtu6DzP7skwRlaw1Idw8kMPz?= =?us-ascii?Q?z+8OKpuDEpLlgAtCi0zOq6KikfKkmJ0JzEV+g6K5JzOEkTbwAH0bs5C4Zt1g?= =?us-ascii?Q?Hdh3dmO7InW5pvDEd033Mg04Sey3g+Ha9HWgkYqDKACEFFfwvkBbqfCtjWtq?= =?us-ascii?Q?3ub8q0rfubv6e4ap3QAOsqLXLxv8rfi4TMmq+Pfg78Djif1uUb3XGIbuiev8?= =?us-ascii?Q?izeu50vp/+8V0bPSvdo6eeBYKyl1Y/CEKicviOjkX8kXnBAKQKDPT173Ot5k?= =?us-ascii?Q?baVAfHrO9JHjag3Dh8yzeFtCk0WKzaNHAJbjFjytkIIaj2TEffg0cwafBt3Y?= =?us-ascii?Q?RXIAeER2TPQVGbAFwwALP6P5OED+uzKOaRTK2Bd1PfVn9QHsfOB8XAo+8nxJ?= =?us-ascii?Q?qkkM2hMAiGOeFrVAfvDUDjEbqPMS6w5m?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5df82ff1-36f9-4d05-8a80-08da0ad49ebf X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2022 00:49:13.8262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uJ4FBx6G0sciVi5ehwteSXK0MzkEVac9ndUc5AeT9pidCelHSXUSJNYL/30JyxkrnaSXFaPRknpVHmZN3qsKjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5182 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, Could you help to follow the instructions at: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess#the-developer-process-for-the-edk-ii-project and send the patch mail to the edk2 mail list? For the patch, could you help to refine the check to: if ((Private->Cap.Css & BIT0) =3D=3D 0) { Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Mara > Sophie Grosch via groups.io > Sent: Sunday, March 20, 2022 6:31 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Wang, Jia= n > J ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check > for Cap.Css >=20 > Hi, >=20 > sending again, because I forgot to CC reviewers. >=20 > Best regards, > Mara Sophie Grosch >=20 > Am Wed, Mar 16, 2022 at 12:56:25PM -0700 schrieb littlefox via groups.io: > >Fix the check for NVMe command set being supported by the controller. > > > >Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 = in > that register, making the OVMF think the NVMe controller does not support > NVMe. > > > >Uncovered by commit 9dd14fc > ( https://github.com/tianocore/edk2/commit/9dd14fc91c174eae87fd122c7ac7 > 0073a363527f ) , which changed the number of bits included in the Css reg= ister > from 4 to 8. > > > >Signed-off-by: Mara Sophie Grosch littlefox@lf-net.org > > > >Patch is on GitHub: https://github.com/tianocore/edk2/pull/2637 > > > >$ git diff --stat master > > > >MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 +- > > > >1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > >=20 >=20 >=20 >=20