From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.36927.1679468340499857768 for ; Tue, 21 Mar 2023 23:59:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=V6MtVDZc; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679468340; x=1711004340; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TYLI2+p2KU2rwNQrlCNUuP8HeNyyPDdc8F30MnNt++Q=; b=V6MtVDZczYvaeo6gnJSPB1oIajnrUgCGDtH4n08WSILMVP5+kWafXXIC ZgKYCZUIapo/BG6TKsVAKG2jfR8Bkl009XrEHmGvjWur5V+8c1fONlwL9 aHAAnoTpCvDCM8uU1K4ruC9fhUwjVxlGXZPhCaYfhszj+1fyu/Rb0vciC 9X/TqF+aG1zy88tAGGPIf1r4tKiiRaFWW/OglnyW4OjM3owxK6thViGYK Cp0ckb837xfzDWE/CtIlF8zS8pZviF3aRgc+r1wk+Ar+g4vJiosEBt4QV evkmOKcoF0SrFScaFK9rrxU78qc1sMYUMnzQ+0b/k8W2HKtBOyooeIfge w==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="425428020" X-IronPort-AV: E=Sophos;i="5.98,281,1673942400"; d="scan'208";a="425428020" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 23:59:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="856014236" X-IronPort-AV: E=Sophos;i="5.98,281,1673942400"; d="scan'208";a="856014236" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 21 Mar 2023 23:58:59 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 21 Mar 2023 23:58:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 21 Mar 2023 23:58:59 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 21 Mar 2023 23:58:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaNA65idbQJsloIKjIhLKOFaBjioob682sNlmCn6Gb/W9HyxgIRveTRIawug9gQcc53rEjBgH6ZTFsPAIPrwPU4qbkedGt130TLv6zhPH7QD4Q87x3CrtUcwHnAvAAV0QCUVNOIaiE0gC3rKUYXfOr+06csHq2T736bxBD3ry3ysBXSBwH9x/KZq0+m2nTLIKZ67uyLsBcqFzzkUb/h6phshoAJoasMQdvinAHlLp6gnC2amSHEg99l8Y/C6GFIttzFcI5Z2ShFW3K1wYua+bJQNjP8e/BS+nCLfj8zyewJXYR9an1wgvdM1XVNnPHqd1VBMj6qSdyqM6TirgYzEyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Ghszydk4k0GZuDM5GuMf/BCu5NFseUFGXPj3dC6VzI=; b=KMevTYh+h2fzWuBY4oSHGqxEoFZ/vZfvNua2v7K8/YwPHWRL6LrX3CCq3H27bGFDDa3SvlC82e3xShiXWDndbZcLOylN6JOkHhXjU9weGPlghQ1nPv9Cj8il7Tcs+mEpNXdb2YJuz9j1Y7qAGzy7+RZ/FqtgfTOFWlqZESLGliXAUEurRHjDdvywlNwMSWnHclGLkoQWzxvE4HrY8fkw9KvVyNJ5f62s5wVycUi1+HG98LxwWY1eiUl6vybpUfT/46D0tzQIQmcDT3Cd08gs2mN6sVa7i/zjFHARsYV84TGA8UDU+IbxbWrhfKeyNChx8AiVFg4AdrIb5KeidMUD4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MN0PR11MB6033.namprd11.prod.outlook.com (2603:10b6:208:374::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 06:58:52 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::f1aa:69b5:fa2b:859d]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::f1aa:69b5:fa2b:859d%4]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 06:58:52 +0000 From: "Wu, Hao A" To: "Albecki, Mateusz" , "Anbazhagan, Baraneedharan" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chang, Hunter" Subject: Re: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors Thread-Topic: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors Thread-Index: AQHZXDKb/2tcWJFVSE+C7ALmihNi1q8GXYuA Date: Wed, 22 Mar 2023 06:58:52 +0000 Message-ID: References: <20230321202015.1877-1-mateusz.albecki@intel.com> In-Reply-To: <20230321202015.1877-1-mateusz.albecki@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|MN0PR11MB6033:EE_ x-ms-office365-filtering-correlation-id: ae01df45-0980-41e3-d119-08db2aa2e56e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b92tHEiosuPTCQZMvyhnvV3zzIUgUOwxSmq/Maox4tuH1GfFmzwMMii4cWT3r5k31zo+Z9odCSfmacSXOURcnSUXnPzFa/G83B5G0yvojxWSPkHp+x/ZFaKkQU6hqEUmCvfVRZNjmpvPN7dPMSIMtUKq/urrQqyyK5DL6jdSSHg5+DKHySQyvWO5JvnZQycbmsuTcQ0XpT37+57IXRoXl8Vt+D7GcRlS0lvzY+1KRbQeMiAG1+4kS7kpWzQGpZCy7Kmzvs01CsLCqpUmRB4Ge2FeaXqBEkc9IQy6UYtVuPmi0tmN9detubbaKcEn6xEPRjgG38qbw+qbHEKs1LZ2CTFL9QHuQ3GZEy4F5fdcY8Us8t7vRarc3wiCeJFOjLTWrgAQNJ7zO/iOjg1hdrS5D4T3Wq/lw+hosWdJXdu4IHyvsWxB7gbr1OjQQ6Lbah6x3uCeLUQTJIz4Z9OJtTL/8xzfe35aiOwnsqMLB7Iz1v1MGrDm0x5nY70Rtf6moTe7LDFKCkdEuOX0AL3S5gQhS+SdqvVQ7woMFCLj791olqEpCV/QPywP9xX0hbPu/15GddtWBCac0bbUSky8yHgNK61GuwioTlP/tx5h9fl1fpci2Nf2qCorad9BW8QxuKk2IAYD0XlkXmFK0tM28Y/mmYqgl1G42mCEvlHlETUA5DRa9dNNrGh9JyUrprvbGtiVxnT5Rg1gP0o89Fqy5etFvYpJCjnfxoxPVLr2JqGrwk8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199018)(9686003)(316002)(186003)(122000001)(38100700002)(54906003)(2906002)(110136005)(86362001)(82960400001)(107886003)(52536014)(53546011)(8936002)(5660300002)(6506007)(26005)(33656002)(71200400001)(41300700001)(55016003)(966005)(38070700005)(478600001)(66446008)(8676002)(66946007)(76116006)(64756008)(7696005)(66476007)(4326008)(83380400001)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nGCWH5kwDzfY2V5EAR50fshZnS2v8lqYfEh9VM42OW0CN9/G2h7dqkkJzy8H?= =?us-ascii?Q?QX1FFb/9NHXmZBDglyJMPdv1XfWTfswXWQAqzbdrvaPNKVQ/DIivwNus+ssw?= =?us-ascii?Q?LDXuxp2cAgsA9x9+E1lIdpOIy0Wb2ySHUYU/C6YIpf5Oj2Hkx9/MDE5YsPER?= =?us-ascii?Q?MZEEeQbQZI6ivnCtiNChvhDZRP0p+yGQEh4lt89Y6Gl9dFLkCmPK0vQZ46pN?= =?us-ascii?Q?gTk8+Rk5A8wWXWEWxWkXAwfINRv6OJyLVRpdBb73Uck4G4R/GHW4ZTp5AHgb?= =?us-ascii?Q?JSh1AeMqpDTefRnUHHz1XsTEkHCo+ctucAgMV0EoTosN1iFjGPeON2aKcFsc?= =?us-ascii?Q?K1o0nBlhFNzTPBCtw+xk1WH1cTmFCTCXlhPp3X4eVQL7DO4PwnsgCh04fo2x?= =?us-ascii?Q?z4oNWALLLju6s/PcCBWeFe6KWCes4QfV7q5bN6KIR0k5aRvDd0zMiZdXaTvx?= =?us-ascii?Q?tAkz1e5NZbbNogh/T9CJBKWpZTdxaTkLq3WjAYLDV7kqk4vJnfVUsEaSbGQv?= =?us-ascii?Q?J6BCr3TJ00SMg9r7fQONt3z7vgmenZ6bUOQGGQomzK7p28S+UAw9jNZG87z0?= =?us-ascii?Q?cw8gv0NBSdbs/x0hn+aG5iYqfJ9JXFb4zoVZWupZtJba1BalIGYtFqLmyKX5?= =?us-ascii?Q?sXZaRK8t77jQjQ1acc/74ObUVuu8jrvAV5QJXa7noqmPZcpz068NBYzFuRXA?= =?us-ascii?Q?g7KMnvI2qv6gxWMpclaXFQpBxY3Fphz4zfUmdkXtjqIQTO4MfZTD9rMY8cWy?= =?us-ascii?Q?RWGqkzrGGGZ2bjIcSpwQ+kwkpiPVywX7l05Jb4F0AHeJP5KT4eOPuyRXB2LC?= =?us-ascii?Q?0pYNCFL6S87qbn60lTd0v7+JF151QhGCoAaifd213CzXSy5ScmUb0FYUkgIJ?= =?us-ascii?Q?kmGR7N+b2c4T3Afjp56EwZDTH+1LvtbogQ28wJx3mQH+B06aMowFLbkv31s6?= =?us-ascii?Q?x2ljTKJSQvBrNYkoJ4ztjuAVz8GpeAQW626cXcH6yl5eRNToRQsgLoKOQ4V7?= =?us-ascii?Q?AtPWuJhdbbDuAyREM+jWJHVeYV44nVGJUs5MpaeujFyyxDxM3dFYyrLw1mdz?= =?us-ascii?Q?WrtWdu2R9qvqNgUgtOXhDnMPLQV4yO8oQjj8SuTXRNptpD85QOLQ/J/KwW35?= =?us-ascii?Q?8ImwLcfxZSq1D+jrnhbxsaiem18+jxuyAu0VEceb5yT/R1IwKFiHakt5k/rM?= =?us-ascii?Q?s5hb1lOX/D75vwDxxVwt0XUn7/5Ctwv/hgxt+xW3P5mYyPLEAxOmGB+cvR3A?= =?us-ascii?Q?CmoBIUx8toRM9F64hSul+X2XgHcT25VSTL8nT7RK6gPDRw5gTBh39FgCm9sY?= =?us-ascii?Q?iHQ3TMsMAFHwo6yAMcUzx6c7SDes2sDaobaiJ9y1HIPLfHPjWRUF+WsXr/Uw?= =?us-ascii?Q?TcOhibxBOYQvni4AXXRHVsK0Ayls9IleMUC/2RWlUE7FJ/dX7f85OMuP+B7k?= =?us-ascii?Q?ZOuo0IB+tZOOFkogKzR5Ibv6Yr3D/zAm6Pc4Xv+3ZgFjuV2boGBDxV4mtt8f?= =?us-ascii?Q?s+hl6vGJCFSoNM9ilEWtnPoD/gMkk2+taChofxii6nOgD3mzO17DcKgzpiEP?= =?us-ascii?Q?9Clbksfq93TFrhvhNezxe20HKthK7tRl8MYZzRDt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae01df45-0980-41e3-d119-08db2aa2e56e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 06:58:52.4901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Uu7dj1N4bx0+QIVEPqb/0PO0fL8OYo2/Uceud9dCoCJWL2xFjV9rPisLYKzqHCzn1YgYJIfcngZzDWjc8SEVlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6033 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mateusz, the patch looks good to me. I noticed that there are some check failures in https://github.com/tianocor= e/edk2/pull/4157, could you help to address them? Hello Baraneedharan Anbazhagan, Could you help to check if this patch can resolve the issue https://bugzill= a.tianocore.org/show_bug.cgi?id=3D4011 when switching back to: "#define AHC= I_COMMAND_RETRIES 5"? This change can be accessed for integration at: https://patch-diff.githubus= ercontent.com/raw/tianocore/edk2/pull/4157.patch Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: Albecki, Mateusz > Sent: Wednesday, March 22, 2023 4:20 AM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Wu, Hao A > ; Ni, Ray ; Chang, Hunter > > Subject: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient erro= rs >=20 > Fix for the recovery logic which causes hdd unlock to fail if user suppli= es > incorrect password. Every failed packet used to be recovered which is cau= sing > the incorrect password to be tried multiple times. This patch series fixe= s the > logic to only retry commands that failed due to CRC error. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011 >=20 > Github pull: https://github.com/tianocore/edk2/pull/4157 >=20 > Tests: > - tested basic linux boot from AHCI on qemu > - tested basic linux boot from AHCI on custom qemu which will fail 50% of= the > DMA commands with CRC error. > Observed that all of the packets that failed were successfully retried.= Custom > Qemu: https://github.com/matalbec/qemu/tree/sata_dma_50p_fail > - additionally Hunter Chang tested and confirmed that the password issue = is no > longer observed. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Hunter Chang >=20 > Mateusz Albecki (1): > MdeModulePkg/Ahci: Skip retry for non-transient errors >=20 > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 69 +++++++++++++++++-- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 3 +- > 2 files changed, 67 insertions(+), 5 deletions(-) >=20 > -- > 2.39.1.windows.1