From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.315.1685939498355780883 for ; Sun, 04 Jun 2023 21:31:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Lj0B8eT4; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685939498; x=1717475498; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=1uC5HjmGEvOn7pYbr1uityiY94CxQopV2v+ymj7GpV4=; b=Lj0B8eT47v+wwBQ9b1IS4QmcHBUdlfQeTqAAiroKRv8JVaUTTYJ7xJ1l icosLH73sgowUjHiyiWby81PqM5UrTwvkDelPkDy7JkKvndLXl331bzSt KkzU+6LUhY6bDFiNQAPieIAfsLyjSuo4T+l95VNdHSQBhTKeT/xsE9bNh jAu2cqFFlg1G1rkZrHXq+BQ7HZ8vd4U88fslsY/7QX8oCUEhDd3uAaTF8 uuU6foikoGxaeraeYOXdbBq9r8HDjTx3tAe+AGW2JiqADwZduoL0NTznL 9RPUjFF3JK2u7XRiL4G46eV4UMgYAUYj/0RzUpVnnZgFz+n8rmL7FJtfP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="335897521" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208,217";a="335897521" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2023 21:31:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="738236062" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208,217";a="738236062" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 04 Jun 2023 21:31:37 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 4 Jun 2023 21:31:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 4 Jun 2023 21:31:36 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 4 Jun 2023 21:31:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 4 Jun 2023 21:31:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXCJuwVpRifcsk8PJBhq+q8WkmJ/tKNj3S4avCI7B3nhk5IGFAU/aDPXyMObHQ6pV6wZzqMOD5G+lSScbpN9Kz/FwftoFqDxBUl8ybB5vq6/W5sysauPkJ7pAX995vbhEyYkzkxnwdK6yYv/kmJRWo0AcvsNlfmurEt9IwEC9fGv7VrGTEjXRPEbhUo0yFU27NwshD+kkfiPUEj2JRzcTsKH27PDWE42l2VcNCumorjj8e9DlL/vbcogJqBHQ8lsd5r0tejE4hwrMeVBSAPFe2PsjaCn5afchcCNNOEItWa/Jzba73n1DOaFtiL3h7u53TljjeBoK6pkDcs2X8m3qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=diWDInZusyqtR0Cd5wKwbMkU/+HC7UvEfHMektAYlJk=; b=jlbl6KKjPZd4KNTvy6nlZTkrbsqcUoHX4PaKrkHCkWZ5QhL2NmCElcSvOJU/wIhW+0SWBbDFvn9RGo3p0gY1bWOiQt9mK5c23RgXoCGmG6RDNdq2MHCiC+vYkEtodgBNunQa7TFdg71cdCK+QbppC1SFDIBZDl+WaIwY99HPKEoQwwev3b4mQS5A2PVNZJE27juqQPpKf+SEywBPeZ6jjWVaVzVaWs3b689pJLKnKAyEBCXxuAa/rV7qutJonEnzHv8GSb9oOyevCBlZlnXBMNqWFmseSuIqVX2O+P1U3Ev5l9cOsoIcGkVyVoEH1DHyfF8V6qn5akTp0CW0ESn5pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH0PR11MB4822.namprd11.prod.outlook.com (2603:10b6:510:39::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Mon, 5 Jun 2023 04:31:33 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f%4]) with mapi id 15.20.6455.030; Mon, 5 Jun 2023 04:31:33 +0000 From: "Wu, Hao A" To: "Hsueh, Hong-Chih (Neo)" , "Chang, Abner" , "He, Jiangang" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjaEROuhuDY7qr02+W0SYB4rkMK9zxJ5QgAC+DQCAAmKz0IAAvsUAgAAf9YCAABwSgIAD0WGg Date: Mon, 5 Jun 2023 04:31:33 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T18:11:56.552Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH0PR11MB4822:EE_ x-ms-office365-filtering-correlation-id: ee7105da-3cfa-4936-e519-08db657dbda9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2uP4sVAHGIQTkf7qsdmVF9SUgR3Ca2vJ0aHzoYLk4WNnmhmhI2Rw9KapKbdnqBKaBAPrcX3X/HQK82XDUtykOIONoqgeuuN+IpfmoEZNlbPCigmqRuBr0F2hg05jLIc+txKns7kIdegla740BG5tQPj5atMRZGwZ40+Bn1cCNvdkXogVXPfswfpvc3VPl83jXFw6gdB0XLNOvTuoATXWEC9gWfUW0Hsiy4V9E8wTXKs3+VY5T+aXiXbKbJJ+lviL3aDnnla1hM1NLIqVr/Q67SRYFeODxgxOwOTIcCZGPPI8tn749qtfFiI/VTVeYxH138HEmi9mRaj5oTkMaxAFYrRMHOgaTkBk2uAHi0kFSl4lwixNP9zO6Kr9Avarm3pK7vHP0/rCznBCbJCEyq3CLoIJEoCQdlyW0HBonMFiEBJs7mv7W6ZgypyvnTh2Q4i/oR2REQpjmydb972J1YXaBcHQ0jrbLC4umJof/8g11aUsxe+Kc8/sZ2V0WGrDg3vbVsczvUuPB/1vPWdoRayOXL1jX37F9w5EKH8Pjw0PXaxXiYHaZJS2ZhahmgXjR7tTIfzbgmPrpJ9lOn1KP4PPeKlxE2sOJEVKS0fMAPQkibMd69uW1ZB7GDlx4Bf8ANQke2ZPw3+DZYrFA8qa5zNr4w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199021)(38070700005)(2906002)(86362001)(33656002)(166002)(5660300002)(52536014)(66899021)(55016003)(83380400001)(71200400001)(7696005)(966005)(186003)(26005)(6506007)(53546011)(9686003)(82960400001)(478600001)(110136005)(76116006)(66446008)(122000001)(316002)(38100700002)(66476007)(64756008)(66946007)(66556008)(41300700001)(8936002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ydgdX/fmylagh+CfAG49SVgANUB7FJpATefCiQXgWpwDnz2dQl76p+Q6i/f?= =?us-ascii?Q?sTZHMSZphSwf9n5LmSjGkrat0l1OCTgycDGDuZC63b05ssTp+Cpj6XZoFncI?= =?us-ascii?Q?LonopMi5pdYgphPAsgzT0BkYc9SUqK5Sm7TfxfMnOJ4Sbrb/UxmjT+ux61D5?= =?us-ascii?Q?skTG8GSDv1qcl+Ce06o4vO9xxpyPo4NNitELdjrWBGerpxLX2BT3LX/h5J4n?= =?us-ascii?Q?2olz6Oe7O4nTPyJ9ENHPkL/k0nEMOw/SjK5UR3kBZLTXtlLzBBaw2VWyXi3Z?= =?us-ascii?Q?b7/AzVqHyhpaQvMqMSiaJgR2hqKRNOdaqOGaRMMg1B6gxARlgh7IeIcgctLW?= =?us-ascii?Q?jg9BQhRIDf+VMrLaS7CHofHhcVzAXN3wTLrqmbfbcqx7COxeAaPsb0TJp7q9?= =?us-ascii?Q?CiKa0jS1M6EgHq5JJuSWHi5hxYc9vzfMZ07s/OiYkWHJAf8qX/Oa3wlf5KNM?= =?us-ascii?Q?miLXHswI26lEdHk/wNuqFaky1nN4vkjooxkfC0ytwoXvPZcrFNt6RN76Gzsc?= =?us-ascii?Q?7aRcBZ26l4sr86JPEJgXm/2hg54j69VQMVA+46Z6XXI/UddwA9BSlNtJA+UQ?= =?us-ascii?Q?jO9KkFzdMVfhIsajntkBTQvBfgJnR9DRuMHSVDaTEsAhJbYucBAdO479Sg+A?= =?us-ascii?Q?CjuKV1YFsx2DeFVLpXqh0p+ZdefhflC3hxwi1yTwrQrYkPWW3fpKKfyHu1+T?= =?us-ascii?Q?tm0x4mz207uCbrz1M+QmJar8XJXVnyYB8oL4r7aIEXo38yHwgq1B5cIPA+ct?= =?us-ascii?Q?MYUydW+TUoB6t2xpev1P0oodJ6TNpMT7YDzniJyqDm7Db3ViYeXXnJr473ES?= =?us-ascii?Q?cnwdVUO8O/eXI9XsoeqlRwBdSa3ty6TU1YLfr8yuJdaDTrpIPA5mJzqZvzk8?= =?us-ascii?Q?Obd+6TPX8vXsfeCcuhUR9TSwyegSMpkV8lOfNapesh6B/juO2XaYsGE6sPRq?= =?us-ascii?Q?28ycdDjpq7vQCtn7m4FQme/YNnbjZL0fiTqgy9hadU/tshNuY4EuuqiJ8JFi?= =?us-ascii?Q?/7ceCOQb7mOZ+4ofSbhmWigU2Zz64Z8V89PYFAUcluTo0KqgJqT+59X9++Gy?= =?us-ascii?Q?7UblzZh+PGNG0M5gDGyUvZWrwtHRCDEi9IfOugcF7S+eNFYmXnl7RlRiaWHx?= =?us-ascii?Q?UZdMiwDeFly7ZJyfqvHyMwOujXTc8sr2pX03IzfskWmr0cSQJ7hwXozT66Q5?= =?us-ascii?Q?XINjpMqXli0J8DFhg7wG2yd7hRTuWZnsNIkDGkmGglNQBI1l5A68D4uFw3WJ?= =?us-ascii?Q?D/rvbJIJXLII9WNW0ZcS7H0K+THg3mSrymx4hXEg3WGQi3q87TsethhmmKMU?= =?us-ascii?Q?ThOFVc707YTG69NHdquU2rHKKPsCpA8FOumxbsAuzEznz4u/TJrldX7uCD9I?= =?us-ascii?Q?C+oE7HI4LOujdsCZdwDH0i4ReZsnrfAF3VhwtKzIKvSJCfuFNMweG3LNBMNr?= =?us-ascii?Q?DVKB7UHHRj9enkIDM2Zh/fDwFM1WGVhtkgSHbuRQEWYwOg6VX34uKwVlFHjW?= =?us-ascii?Q?BgKVRnMuEdtAxtgKt993sAjH5fj7Y7Olms8mc1PYZHgttyL3ITQHVm6E8khh?= =?us-ascii?Q?QKQ72Jt9Z2QkfmPpzSz+PzLaZsYZxeZVYZm41uxu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee7105da-3cfa-4936-e519-08db657dbda9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2023 04:31:33.0227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OHwsvLddZPf1hwp0CAT0iPijoRH4pQdyHkXUI/zqrT34Gv9JR1noZFdKu6EY0IG6aB2KSjS1jQjco8whiEEPqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB40252F2AF781E09DF7CEC59CCA4DADM6PR11MB4025namp_" --_000_DM6PR11MB40252F2AF781E09DF7CEC59CCA4DADM6PR11MB4025namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks all, Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/44= 78, but failed 3 times (all due to some canceled CI tests). Will re-try tomorrow. Best Regards, Hao Wu From: Hsueh, Hong-Chih (Neo) Sent: Saturday, June 3, 2023 2:12 AM To: Chang, Abner ; Wu, Hao A ; He,= Jiangang ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Abner, Thank you for your feedback. I updated the commit and re-create the PR as b= elow: https://github.com/tianocore/edk2/pull/4471 Regards, Neo ________________________________ From: Chang, Abner > Sent: Friday, June 2, 2023 11:31 AM To: Hsueh, Hong-Chih (Neo) >; Wu, Hao A >; He, J= iangang >; devel@edk2.group= s.io > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Leo, Please add Hao's RB in the commit message below your signed-off-by, thus we= know this patch has been reviewed. I also suggest to update your commit subject to "MdeModulePkg/Bus: Fix port= multiplier port in AhciPei PEIM". Please resend the PR with above updates, then Hao will add "Push" label to = this PR once your change passed CI. Thanks Abner From: Hsueh, Hong-Chih (Neo) > Sent: Friday, June 2, 2023 10:37 PM To: Wu, Hao A >; He, Jiangang= >; devel@edk2.groups.io Cc: Chang, Abner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A > Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang >; devel@e= dk2.groups.io >; Hsueh, Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu > Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A >; devel@edk2= .groups.io; Hsueh, Hong- > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (= Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang >; Chang= , Abner > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.co= m; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > >=20 > > --_000_DM6PR11MB40252F2AF781E09DF7CEC59CCA4DADM6PR11MB4025namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks all,

 

Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478, but failed 3 times (all du= e to some canceled CI tests).

Will re-try tomorrow.

 

Best Regards,

Hao Wu

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
Sent: Saturday, June 3, 2023 2:12 AM
To: Chang, Abner <Abner.Chang@amd.com>; Wu, Hao A <hao.a.wu= @intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups= .io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Abne= r,

&n= bsp;

Thank y= ou for your feedback. I updated the commit and re-create the PR as below:

&n= bsp;

Regards= ,

Neo

&n= bsp;

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Friday, June 2, 2023 11:31 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Leo,

Please add Hao’s RB in the commit message bel= ow your signed-off-by, thus we know this patch has been reviewed.

I also suggest to update your commit subject to = 220;MdeModulePkg/Bus: Fix port multiplier port in AhciPei PEIM”= ;.

 

Please resend the PR with above updates, then Hao w= ill add “Push” label to this PR once your change passed CI.

 

Thanks

Abner

 

 

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Friday, June 2, 2023 10:37 PM
To: Wu, Hao A <hao.a.wu@int= el.com>; He, Jiangang <Jia= ngang.He@amd.com>; devel@edk2.groups.io
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]

 

Hi Hao= ,

 =

Thank = you for your review.

 =

I alre= ady created a pull request for this commit, may I know how to proceed to me= rge it into master?

 =

 =

 =

Regard= s,

Neo

From: Wu, Hao A <hao.a.wu@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang= .He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Hsueh, Hong= -Chih (Neo) <Hong-Chih.Hsueh@= amd.com>
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use On= ly - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@in= tel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang= .He@amd.com>
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel= .com>; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
> Cc: Chang, Abner <Abner.Chan= g@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@int= el.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; = Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.H= e@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>=
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.i= o <devel@edk2.groups.io&= gt; On Behalf Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io<= /a>
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-
> > Chih.Hsueh@amd.com><= br> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_DM6PR11MB40252F2AF781E09DF7CEC59CCA4DADM6PR11MB4025namp_--