From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Denis Nikitin <denik@chromium.org>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Cc: "yonghong.zhu@intel.com" <yonghong.zhu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Ramasubramanian, Karthik" <kramasub@google.com>
Subject: Re: Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted
Date: Thu, 6 Jan 2022 00:46:03 +0000 [thread overview]
Message-ID: <DM6PR11MB40253439F77E465EFAAADEF8CA4C9@DM6PR11MB4025.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CADDJ8CXgARjNUi0kzbvy4n4FO7vCS_RrDJqbOS8A42779zajaQ@mail.gmail.com>
Hello Denis,
As far as I can recall, the fix you mentioned is a change that to please the static analysis tool.
My opinion is that it not a critical fix.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Denis Nikitin <denik@chromium.org>
> Sent: Thursday, January 6, 2022 3:19 AM
> To: Wu, Hao A <hao.a.wu@intel.com>
> Cc: liming.gao@intel.com; yonghong.zhu@intel.com; devel@edk2.groups.io;
> Ramasubramanian, Karthik <kramasub@google.com>
> Subject: Change from "BaseTools/LzmaCompress: Fix possible uninitialized
> variable" patch was reverted
>
> Hi Hao,
>
> While updating edk2 in Chrome OS we noticed that the change in your patch
> https://edk2.groups.io/g/devel/message/19270 was reverted in
> commit:
> 5ec5a236d1 BaseTools Lzma: Update LZMA SDK version to 18.05.
>
> If you think the fix is critical I think it should be merged in https://www.7-
> zip.org/sdk.html.
>
> Thanks,
> Denis
next prev parent reply other threads:[~2022-01-06 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 19:18 Change from "BaseTools/LzmaCompress: Fix possible uninitialized variable" patch was reverted Denis Nikitin
2022-01-06 0:46 ` Wu, Hao A [this message]
2022-01-06 7:20 ` Denis Nikitin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40253439F77E465EFAAADEF8CA4C9@DM6PR11MB4025.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox