From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.126.1641863031582134909 for ; Mon, 10 Jan 2022 17:03:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Z/AA+m6o; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641863031; x=1673399031; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ZqpV7Yu+5FohdaPMrpI2xk8hWhm7iEHtlFNuynJoERU=; b=Z/AA+m6okpu0CHynnsVWIK/gQT600KKfmwLnKdo+w/BpLGR8ADwnVf3B tUt35X7Uc+GRB51/d4o0bMFtYYahwamJCHsibkj+y8xI7w6lo1NQ1rol+ x6mBIUybPNwGndh05tvuk13g/XoBlHffutBrhisSZ3b3svCPUSQFqCCTY CqtBZytQ43B3YC441b92NTzyatV1i36eycK9EQYTFZiDme2UK4Jz/fPk2 xpCd15COsi01k7jIupgOp3TZ2Ya/hdBjmGlyuvQ9gnUpVKYbfjUq5InDX rqwkAt8Bvyo1IJ3QXEA5HQNJzvI4yj6oNrMNP6RpVgcqRe3AFo90dOvyn w==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="243168699" X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="243168699" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 17:03:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="528511205" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 10 Jan 2022 17:03:50 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 17:03:50 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 17:03:49 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 10 Jan 2022 17:03:49 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 10 Jan 2022 17:03:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MomSL7f94KG+psOTFz+1rAMPHbUuJuGBQCiZQhmRI5U4m+MzwQc2dniQcSEFmKczOHuQa85fUWXTMxjdzIuDfKDSdm3Dw/Byx38JOVu+ikeI3fPA86l9ZIwm6eDTd1Uakc2/VbdoEkp9mMAmN5ujvJi5BEzuLecZdvXhOYxCcqWEZ7iMmp92LPqwWG9pkBgxudYBTVSSrT15SPgdaxp78V4CCvPHpKrtO0i/DYYrjHJ2uaszF5tNRieqTQA4zvsoBEggWfpluVHsYISFK+OV2RXEW+XjPP3/aiALkHA6zOKKLQfBlKRMh2jogqsvPjL6OZDGBGT2smrmUK/T+Frw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hDxqd37TuNDyUIvSSkl/3u1yr2uO6USzP857imAFooE=; b=T6LHt1+9DN0sYnGms2mGshfEUUQ30epDRg2mzSxU25KAtNd4/fZqXJTZXLlsSPlM20SvfJYP0Xa2glmBF1iyWjkmDobLBfvFz0iEQ/yIhF+5nH0l/Juy+VUO8jzf5celnb1X1EMAM2YuMFwhqcRq56FYUj0BBqI6aIEMD4VBwadEMZECL3vuedNjwRaaEAQwmEPvl39PVROk7LMeB14lQVT6b5/5Z0TBYLtbsOT/hx0TrA68+vvMcHlfPwi7vVhkBwEf0NEBbSoD3cNbCno8Kna3Mycyt5sUqnSDtRLTC1LWfO/O+WN6Djz7qCJ5FHjKk5a+/Vtk8oLDIIM//Dwing== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB4172.namprd11.prod.outlook.com (2603:10b6:5:19f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Tue, 11 Jan 2022 01:03:47 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%6]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 01:03:47 +0000 From: "Wu, Hao A" To: "Lou, Yun" , "devel@edk2.groups.io" Subject: Re: [PATCH v2 3/6] SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. Thread-Topic: [PATCH v2 3/6] SourceLevelDebugPkg: Replace Opcode with the corresponding instructions. Thread-Index: AQHYBjSgx7sWNpu7Dk+09CIspRpDJqxdAbTQ Date: Tue, 11 Jan 2022 01:03:47 +0000 Message-ID: References: <20220110151253.3848-1-yun.lou@intel.com> <20220110151253.3848-3-yun.lou@intel.com> In-Reply-To: <20220110151253.3848-3-yun.lou@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b7c9f5e-df6e-4594-0ac8-08d9d49e392a x-ms-traffictypediagnostic: DM6PR11MB4172:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 84q0S3ECARTmnoUNf2OtolqThkkWJCRM6d3UROUEO8RJiYgJcSiW/+Mc6FV6u7vtFowNffMuw05OpG9ivfBLgXVQt6O70E0J6HzPNv3S9YRbV8/hF6MjBlHk5W7b6dPEwyMwUT+22NBXhwVTJlmmSIngxi7F9T4jWJGPGz1fYIRo4YZoI3W6ZRU3j2d6WVkvYVRSnRYyGDreXwfgQMrJrSsugwMwpgE/ekGC5dIK0jZ+jScSCzFshGKWllm3gKYAIJqnG9c96d/vJg5SFZeRIU+5Z2a0zNO9FSSNqjlBD3VShnlXZZRwXhsNUCHta8O4VrCKrtdk5NemwUvkvFiHlV0cHfkxlesfTXN7XgI+lqW0BYA+tGg6lGqj+v+W642IVGpUEtEnK9K8DX9TvWgOUByaXCujVxyxHo+OPZ29IDjGiKKs/psrbWWgw6dFLN6YwuBb98sItzb6iTbdR9pfrisCiEBvgNOUwRxYygRoDY8IwK1qks9LybEVFLZW1dTFDoNKoEoY3Jz2ylA38qcBmS64EeWSdA5cCLFTaxgwh4Po5nLmOquDAkYWFnlp561cgRrTW2SvPVozKKdkK3i4hmrFI2erPVI23SYCoEg6IrrLGDuq5Q+R9XXT2jDE7yZVgapRrjY3sPrAeW2/UbXi1z7EBQYap0MIotr1rjqIT1y2tydEGiqUiybGcedLdtzlcKhSradokIS3YkYIiSEfBapmtxFIpyl/7RSyt+aZuPzXe9xM6w0rPSWjArK1QPlLl7SRJCrDhVfgFYB8YXArqS7vWC8IA0CliMlA7s3TC4B1JP0sOhZ+Xe6BB0aTpqsV1y9ZqODc7sFztREANxVYaA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(7696005)(8936002)(55016003)(71200400001)(26005)(66446008)(38070700005)(33656002)(186003)(66946007)(76116006)(66476007)(83380400001)(110136005)(5660300002)(966005)(66556008)(38100700002)(122000001)(53546011)(52536014)(86362001)(508600001)(316002)(2906002)(82960400001)(9686003)(6506007)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vxw8Fm52xH8T+Dc0sYmTAH7ZEmlQiVB6zmva/YmzMePhzrKisHftAIACyF/s?= =?us-ascii?Q?zhp4EgGUQq8dcx7dHEi6GkyoLM9NwRydzAPpo0sP10KqtrfNaHeGgr+K/hkB?= =?us-ascii?Q?flxRkYYwppuGYRIsanRbwKySE+u4uOXa8KmPUYSSUHqldvcz2kJGpoebxmvv?= =?us-ascii?Q?GFbAhXSzdgdNK92oVSkkq8fKEkPCWQI7fJRW/JD1OGmAk/t7bcSZmvClO6R7?= =?us-ascii?Q?fTEWvmeM4sdEn2oU5qDUhNvDRunU4auPXYlK3ba2DdTflR4vDB73LuX94WNk?= =?us-ascii?Q?kUSDjS3IkeZR0ffnkA6eETnpFxqx41GZoM+3GHUcz2eQaRaIUdL6IIp9go0t?= =?us-ascii?Q?3R6ApltaibILQYsIkPw+gCCRZn+tsUbxdobweg4kAyo2Z5UVBl9TC2/qqPCV?= =?us-ascii?Q?5LWyGSvPDygP5dNnIP2xL3BZPMsOJMJuYnxLf/DHzp3GgEbxnO/1Nj+hvm+X?= =?us-ascii?Q?TUaw1EO3eHK6x5LRyL8xRPGcmWmHvR4rnDH97dPQPMovrx9Pip8UA3V+z4TQ?= =?us-ascii?Q?cLNtEyCPEZ0eakTBy108ObxcfeKR9v+IztiVKxRij5wWkG3wUpk763Qmwlj8?= =?us-ascii?Q?vg9N/yMHtLL/94Hu/Ky50WWRILrEyfwSW7JiEyMTXez9FbV6Tc8mDaKRre3w?= =?us-ascii?Q?ivtGXriuorKL6mk85wVFl7uks08yF3wTVitDCRtjvRgh2xWM0ZqENld9/BEA?= =?us-ascii?Q?uJ4NZYT3E9wCcPHJF4gQECDAFzRkFZIMc5tJrMNiQ1s83B2GxGo1Sqd2J/4u?= =?us-ascii?Q?6GjY97NabIwGc6L/7FDcGubEw2+djlybTvuNodJPIzy7p5ALiBfzUDUPriA8?= =?us-ascii?Q?j6SdOmmzq9k2ZxNUWsn9SJt/9qfs+nqN+bIClzIlANNE1sVvVrcJDmfD30dD?= =?us-ascii?Q?7/DGLszvXcOz9FTnqrNarHTcgLIe44CNyTDiYpmwEO66ajokeh9AR+IPfHH/?= =?us-ascii?Q?yelh/E1MmklNqzLt25OhMEaVLLnhHFUZoAG8zrxAoqXPpUivLgqEHJDg+QzU?= =?us-ascii?Q?rQgaq/rhIpfVYbyw+uGuhLkH8lx0YuzEJP17o4hZKk8qYqDvyR8XkUOrvFRt?= =?us-ascii?Q?XlKNnBBxAZM3fBH1MpX2+kKRGcSOXMRWreVk6zvxUaZ6fYmSCfqON4jG4OnK?= =?us-ascii?Q?7jHHpo9CZ6OxwvZhMjoQgbodJKulno9deEf4KSc6EQO9fBN0qF6DNeqWKbFJ?= =?us-ascii?Q?qrN8zXlF1uDtHPeYvbCCt2oMzPBPiXU2zIWcllwL4v/jrB7/1Bem+rU1IB8Z?= =?us-ascii?Q?QP2youy2ZqKiD1sptuSgJr2P/OFXJb6w7+JedlKB8Hy7c6UezXgsBv5Bv0nr?= =?us-ascii?Q?psLBCRAKf9TgfOt/zJjxOkjqxkHcrCyI4VuPKp/J1GzqmsS4HfgQoa1GY87k?= =?us-ascii?Q?f9f7PfM3pu1QRT8GBgMRNp0RfYP8LWjDguXpLyU/FhsaY1xw9WYHeD+HzdDk?= =?us-ascii?Q?07Hvlfbw69fHmdfBLi6VtRxbM/gMAnu5Zc9+HkkgFao0Skb7gTKcVp3YAsbv?= =?us-ascii?Q?itRs16mFKgGi7g+Us1ZKXMT8dXZzN6Gq+/ASn2+i/7T4ux/cAMydyCqu55V8?= =?us-ascii?Q?BVlksB8pN2DX3h+/OLQdxRbe9p01tZ+4/ZaW2MXem6HjbIPOuVT58PfEkltK?= =?us-ascii?Q?qLoua3jXqT2OGKmbhL6qC0Y=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b7c9f5e-df6e-4594-0ac8-08d9d49e392a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2022 01:03:47.7832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OG9m89FtkVZbjIfCpPyKRi6ZEoBdHYpTorvQkHx4pXIlBkzbt2Ee8GWwBQ22f0ZZxRlKYlZ1+M2YzhMnKh/QrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4172 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Lou, Yun > Sent: Monday, January 10, 2022 11:13 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Wu, Hao A > Subject: [PATCH v2 3/6] SourceLevelDebugPkg: Replace Opcode with the > corresponding instructions. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3790 >=20 > Replace Opcode with the corresponding instructions. > The code changes have been verified with CompareBuild.py tool, which > can be used to compare the results of two different EDK II builds to > determine if they generate the same binaries. > (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) >=20 > Signed-off-by: Jason Lou > Cc: Hao A Wu > --- >=20 > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/Asm > Funcs.nasm | 6 +++--- >=20 > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/Asm > Funcs.nasm | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/As > mFuncs.nasm > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/A > smFuncs.nasm > index 912256ba45..b5e5a96e34 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/As > mFuncs.nasm > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/A > smFuncs.nasm > @@ -1,6 +1,6 @@ > ;-----------------------------------------------------------------------= ------- >=20 > ; >=20 > -; Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
>=20 > +; Copyright (c) 2010 - 2022, Intel Corporation. All rights reserved.
>=20 > ; SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > ; >=20 > ; Module Name: >=20 > @@ -321,7 +321,7 @@ NoExtrPush: > test edx, BIT24 ; Test for FXSAVE/FXRESTOR support. >=20 > ; edx still contains result from CPUID above >=20 > jz .2 >=20 > - db 0xf, 0xae, 00000111y ;fxsave [edi] >=20 > + fxsave [edi] >=20 > .2: >=20 >=20 >=20 > ;; save the exception data >=20 > @@ -342,7 +342,7 @@ NoExtrPush: > cpuid ; use CPUID to determine if FXSAVE/FXRESTOR are = supported >=20 > test edx, BIT24 ; Test for FXSAVE/FXRESTOR support >=20 > jz .3 >=20 > - db 0xf, 0xae, 00001110y ; fxrstor [esi] >=20 > + fxrstor [esi] >=20 > .3: >=20 > add esp, 512 >=20 >=20 >=20 > diff --git > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/As > mFuncs.nasm > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/As > mFuncs.nasm > index ccee120ca1..b1019e017b 100644 > --- > a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/As > mFuncs.nasm > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/As > mFuncs.nasm > @@ -1,6 +1,6 @@ > ;-----------------------------------------------------------------------= ------- >=20 > ; >=20 > -; Copyright (c) 2016, Intel Corporation. All rights reserved.
>=20 > +; Copyright (c) 2016 - 2022, Intel Corporation. All rights reserved.
>=20 > ; SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > ; >=20 > ; Module Name: >=20 > @@ -293,7 +293,7 @@ NoExtrPush: > rep stosq >=20 > pop rcx >=20 > mov rdi, rsp >=20 > - db 0xf, 0xae, 00000111y ;fxsave [rdi] >=20 > + fxsave [rdi] >=20 >=20 >=20 > ;; save the exception data >=20 > push qword [rbp + 16] >=20 > @@ -314,7 +314,7 @@ NoExtrPush: > add rsp, 8 >=20 >=20 >=20 > mov rsi, rsp >=20 > - db 0xf, 0xae, 00001110y ; fxrstor [rsi] >=20 > + fxrstor [rsi] >=20 > add rsp, 512 >=20 >=20 >=20 > ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >=20 > -- > 2.28.0.windows.1