From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.414.1663037609589557432 for ; Mon, 12 Sep 2022 19:53:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ffMkHi7W; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663037609; x=1694573609; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Ev2KW3G4IM1OVvvHpNgCstIGvelnBy5rGkeXTXzq5t0=; b=ffMkHi7W2S/CpDkNJsx8P8UQhL7+jj4WD4N/mEikXyD7Gi3LC2pRTK7z ba7r+fmsJ4ugpq7g5+2Iuz1rj57tjomvXfJs4ih0mpDIadkwEJ+y6E13u uUdgTURCteT0WeqISHeUwQB1DkSwhvgteVYvCHcndEZwOzXWYeJiJSRpn sHJ4GYfIIs37iKatzKNqWHI5vSwBytjg5/9o0Gr3I2k6XkhqOmSplsAX2 dkIFlXV6pRGDZwliGOPMNVDh73givejxVO1kCfOoZuMapjViNgVff4QMl 7yOmeoHUb+mUp/4FtjsFAM1u8zqg2MWpjGpugiWPYJutCFJlg/oHjlqDk Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="299360226" X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208,217";a="299360226" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 19:53:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208,217";a="646735899" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 12 Sep 2022 19:53:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 19:53:28 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 19:53:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 19:53:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ci2SYsgpFI0crmzEiuP8M+Py0AUOO5wUpzygY9IzNIFY60zzCByXb97r12CCZgsw1hP9PEyiC33o+S0+T+FKjVk1nk+wEkRt1EbUJiA2MjlGZ/VbGlI3vGEDpuqVIhP3seRhePxsmR9T58bhvd9S/n7Mp3XD/B17lsg/Hx69WOrZslaMDnrhbtzNan33ICTWOXrQ4B3bdeGu6Mzb4mr1Q1KMB1PYoloofGqe1fUAa8LyvJEnE9FbfYEVBHCngmV+wzZDIKncmwWHw6sRicUNcmIn0krT4zIvmP8wqK3JpXIs6lSqzp404hb8WFdVPXLO0Xj7eZXaFs/nyxJLobBxlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ueBoK+HwcUnvEpbsO9emhooHuEX1lb+vhil/Uj2U70=; b=BZq0yN3WwRMDDAXeKoMZZXItNfzz/OS45pqrE3ran5cSZljE4BxS8rRfMy9ieYTW4w8NLPThNo7VHbnRE001kbVCYy1IvnXKoUPCb49Of04fay07cm+MW4WwB6G5KACicdgKEa6BhDNdJ+PLTIRwlLE0E9j82TTOOQCgfWzybIPu7YDV4BhCFtxdLyUe2Q0L4TFN78U5fQjF/zPyVL0BkQmK0uUnvJYApuXfvZKuxK/i0v1SaaerVQvwMyxu+v0uiI44vHjDIYnWF+tMEXQhr+rFwbCKgbYRm1evyxMrLp80VraF5Lr3wnJtLj5jD14sVw0P/rKKiXDHYtUeUDWrYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SA2PR11MB5195.namprd11.prod.outlook.com (2603:10b6:806:11a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 02:53:22 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6144:b5e3:5217:f60e]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6144:b5e3:5217:f60e%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 02:53:22 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Anbazhagan, Baraneedharan" CC: "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Topic: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries Thread-Index: AdjDO47NgG9qllpbRjOTlew4fZd/cgAEsYpwAPNjZBA= Date: Tue, 13 Sep 2022 02:53:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|SA2PR11MB5195:EE_ x-ms-office365-filtering-correlation-id: eb756cfe-fc28-49d2-4725-08da95331edf x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+J6f0if0at8x86BclDmGYiEtQ4X0CgUfqylX9MJ3p7OkZde06Ihte7wdJyBAYy0f+6fP/G4m49c0AD1H7KAAVbx8ZxTQHfJ84meSI69CcPXzUafgaYpEJ44/zHgjxrPj6cbSxhPGTAVMVm/+WauDzNmzO1TXRkyuragjgrN4eI5AqSj2QGECw3mdxiTlp9HlAv+dNv5OwWT1UZi0tQV+UzbReH5I3cZAU1Pdyb2dOk+xASF9x1SPmWyx+eIk7F+CLvGzKURKXjxN0r17QB/VK456LFbI7B769nWGTDEWSRUmgpsHTRf9PtxfxlKXR7mY/3qZOuVoL4P6jFa8RLiWnMUZ3mVSewqhA0URZL9s7of1/ju4GPsj+5nod6Ck6HbcUCXnRfNjbgPVKFyIv/WIzHqLhC97ChdmV2zrTzULhWXtJ7JWHb5OFFeA9y+VkfvWMr77NX5wRwduMR5ioAJJqigVeeKUO66NKLVsO+tHabq/yU+puGCvuZCuQ1ubM/Yz4A9WkqeqC3TROPb5aFeLz/Re0CExvX6IWldceiTRagFmcTrZLHSjFuRkbifoqry71g8bsJCnSPqSunAwZHiYYYcBXH3Eq/8jI2HyYo5AgaIvSZYRJgVoZyPyB8MD5q4LfT28XaFER5URh4SOVBvOyd0EbfUvUd7iuwOP9MdYLTQ3Y7zl6Ct9wU3jTdbSqIaRg8UVNmnnp4D+W3Qqv7PL0u11mt7ajZx21R6SJY252OEF2HS2wZwWUHW1VgNUAUmdx0gDgICgZvOOSZztqEPTJER0QIfW6JnPWe0lm9RaBK/yBcd18iQax7G2ldxScSUMvXlXZ/sdwgC2fCJHpq/Bw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(136003)(39860400002)(366004)(376002)(451199015)(66476007)(316002)(54906003)(26005)(66946007)(41300700001)(55016003)(76236004)(76116006)(64756008)(66446008)(82960400001)(107886003)(4326008)(53546011)(966005)(478600001)(8936002)(110136005)(52536014)(122000001)(5660300002)(33656002)(86362001)(38070700005)(66556008)(8676002)(38100700002)(186003)(71200400001)(2906002)(166002)(6506007)(83380400001)(7696005)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IFo3l01XC+hC8pjtSmoocwqFNOX+payLvreAiNjXGO+3pa6+PaSePZC/8gGb?= =?us-ascii?Q?w4ufxUdVI0ERNQCX/GdzPHGZX/zzL1B82lo74RAYslPrla4Ak/PDigQS5vCH?= =?us-ascii?Q?zVKY9WfslIfEg/LoGwlDK3V7PlgqF1Xxotez2IKbvEjtfTooJEhwiX4ZiwVP?= =?us-ascii?Q?HYsQuG+Q8kE3t+9IqEZBoCl/4eXycuKPhwQJbRbLY/aWakirWSR5VnsxX7Ri?= =?us-ascii?Q?nW47mB4q1nCDr8XxPro2DHuj6Z0H6MMpoBkyw/93ioNKJ2FFEXTjyNKdRkEO?= =?us-ascii?Q?uJdqhgg9YzMckKgNrA0JkLQKjKTGMA6w4Acf4A4Dv4ADjzKs0ut5e0hghWbg?= =?us-ascii?Q?qbdxE1N2kHWjdbyEdWzhRpoQe6mknikflJqhItfK08hx9Cnper/7cL+QNxeF?= =?us-ascii?Q?h/Ef83g4d3UaVWnuTjvR6rj8U7FTimiclyraGlZ6atw7MuZNcmF6ZSP0R/Ld?= =?us-ascii?Q?VGu+8OiX2OAepGTX+DEPiTPN5E/NRQCyKZoQsgsrO4fmNkpCUI2Fojhhb0OH?= =?us-ascii?Q?KlQCs7nTKUgbxdzUYybzLcl0PW7TNW1oEdtmiwK2l8jSTyzcDWGQXNCgztAF?= =?us-ascii?Q?ldQnOH+es6dQmwr2qm3kMKWzwMnE7To9zMeO6ZejZahjP+up+MinDEfotK1i?= =?us-ascii?Q?LHGSQUEBfuFmYQK0ZNC5BT5nZxOlxiz/EVG0cXXbGHlprcc7TZKaiQDjSdlX?= =?us-ascii?Q?z2iaYS6MSwtVCyvFjrNrgGOvQjv/PW/6YBPyvzS+AZkyCdAT02KQM/iVl6UZ?= =?us-ascii?Q?tQFXwf1zxy2AFqBhdVanuBrBDgJoVF/1j8zWVweAmPKVprr8v94PRiljJRYh?= =?us-ascii?Q?y1GGCYw4CVDcAsna345mv82wUpMikqjdU8zq9KjttZH0ovj3Sjqgu/GMawLd?= =?us-ascii?Q?E/vlUlj7wMdG2/+vWfu6V9N7sFP4ofVorgQ4ky3WraZpxJwgCcG98nx/PcqN?= =?us-ascii?Q?Ej4wai546LuAIqeBpDsyYCabmw8DI4SyjP2cC41yLAvN1iqGqKTMN0X3GGCp?= =?us-ascii?Q?G+54cJiV/eiIOzQ57ovcDPf7StdY9DVV6G3bNKsnBX6i7QWJYgmjDDqF1Yk9?= =?us-ascii?Q?OvwZlhaZd3hbcWGaQ/3nCL9vSBGKHWzLnAXKxWNLWiQzgkwCml2ADBXAET43?= =?us-ascii?Q?rUw/m3P0zGGLhcSwnsuYuJ7eJdvcNeg62Ih2DOjRYVQr3eUJM1k0uC9+QruV?= =?us-ascii?Q?g+Vy17+d5B54SEmSTCtP4AwEZJsp4TYXJQQikVFw7eBuDutzTu3FYItGaWVi?= =?us-ascii?Q?VkUDtvVHz/WH1V8hIA87QLBiOR9HPezd33yySOuOrxozx8jkO/iCZBHxhi/+?= =?us-ascii?Q?+wid0HWQc35+VYgn2FSgnl+VplbpiXZR3UFX5egnMsxApVIvFhIooNC5Xf52?= =?us-ascii?Q?nwfu0bKU42A8aTJ+Iu7/fejp9mP3316eFBSBN7G6a3Wus4ibmpSfHJlMpWl8?= =?us-ascii?Q?hv6ULfhP9pN1KVfhi9sT8VA3fobxiG+mnixXK315y/3OC0Xh7vYkwf2FKJFJ?= =?us-ascii?Q?mYP3SdutuiB4KO0HEBdja2blOP90BU+Li5BVsznPSVPpTw9S8ll+SHTxmD5I?= =?us-ascii?Q?hePn55g+cVTwy1DB+AWaq2JsUefBL89TRHDwzpZr?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb756cfe-fc28-49d2-4725-08da95331edf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 02:53:22.0010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UQ2PJQMlkk4yDeUeQl/QbNcQt92cs6htjqqMozyBz4FWu3qe2hr/cUr37ELG2YWYylbtueipJH8V2b0dQ9WkHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5195 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB402535F57751BF3825F02B98CA479DM6PR11MB4025namp_" --_000_DM6PR11MB402535F57751BF3825F02B98CA479DM6PR11MB4025namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged via: PR - https://github.com/tianocore/edk2/pull/3327 Commit - https://github.com/tianocore/edk2/commit/db7afaee91423e988df316062= 4d04c3c534f294d Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Wu, Hao A Sent: Thursday, September 8, 2022 2:44 PM To: devel@edk2.groups.io; Anbazhagan, Baraneedharan Cc: Gao, Liming ; Ni, Ray Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for= AHCI command retries Reviewed-by: Hao A Wu > Best Regards, Hao Wu From: devel@edk2.groups.io > On Behalf Of Anbazhagan, Baraneedharan via= groups.io Sent: Thursday, September 8, 2022 12:38 PM To: devel@edk2.groups.io Cc: Gao, Liming >= ; Wu, Hao A >; Ni, Ray > Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHC= I command retries REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h | 2 +- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 3 ++- MdeModulePkg/MdeModulePkg.dec | 4 ++++ MdeModulePkg/MdeModulePkg.uni | 4 ++++ 4 files changed, 11 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.h index 7802ebd200..7fe9ac2da7 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h @@ -193,7 +193,7 @@ typedef union { #define AHCI_PORT_DEVSLP_DITO_MASK 0x01FF8000 #define AHCI_PORT_DEVSLP_DM_MASK 0x1E000000 -#define AHCI_COMMAND_RETRIES 5 +#define AHCI_COMMAND_RETRIES PcdGet32 (PcdAhciCommandRetryCount) #pragma pack(1) // diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf b/M= deModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf index a3e42a9ab4..78caa3c458 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf @@ -65,7 +65,8 @@ gEdkiiAtaAtapiPolicyProtocolGuid ## CONSUMES [Pcd] - gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_C= ONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount ## SOMETIMES_C= ONSUMES # [Event] # EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 7d98910832..58e6ab0048 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1574,6 +1574,10 @@ # @Prompt SD/MMC Host Controller Operations Timeout (us). gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000000|UINT3= 2|0x00000031 + ## The Retry Count of AHCI command if there is a failure + # @Prompt The value of Retry Count, Default value is 5. + gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00000= 032 + [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## This PCD defines the Console output row. The default value is 25 acco= rding to UEFI spec. # This PCD could be set to 0 then console output would be at max column= and max row. diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index b070f15ff2..33ce9f6198 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1166,6 +1166,10 @@ = "in the DXE phase. Minimum value is 1. Sections ne= sted more deeply are
" = "rejected." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciCommandRetryCount_PROMPT= #language en-US "Retry Count of AHCI command if there is a failure" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciCommandRetryCount_HELP = #language en-US "This value is used to configure number of retries on AHCI = commands, if there is a failure." + #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleInRamSupport_PROMPT #= language en-US "Enable Capsule In Ram support" #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleInRamSupport_HELP #l= anguage en-US "Capsule In Ram is to use memory to deliver the capsules th= at will be processed after system reset.

" -- 2.36.1.windows.1 --_000_DM6PR11MB402535F57751BF3825F02B98CA479DM6PR11MB4025namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Merged via:

PR - https://github.com/tianocore/edk2/pull/3327

Commit - https://github.com/tianocore/edk2/commit/db7afaee91423e988df3160624d04c3c53= 4f294d

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Wu, Hao A
Sent: Thursday, September 8, 2022 2:44 PM
To: devel@edk2.groups.io; Anbazhagan, Baraneedharan <anbazhagan@h= p.com>
Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni= @intel.com>
Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable = PCD for AHCI command retries

 

Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Anbazhagan, Baraneedharan via groups.io
Sent: Thursday, September 8, 2022 12:38 PM
To: devel@edk2.groups.io=
Cc: Gao, Liming <gaol= iming@byosoft.com.cn>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD = for AHCI command retries

 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4011

 

AHCI commands are retried internally which prevents = platform feature

like drive password to process correctly entered pas= sword on subsequent

attempts. PCD allows the platform to determine the n= umber of retries.

        &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;         

Signed-off-by: Baraneedharan Anbazhagan anbazhagan@hp.com

---

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h&nbs= p;          | 2 +-<= /p>

MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassTh= ru.inf | 3 ++-

MdeModulePkg/MdeModulePkg.dec    = ;            &n= bsp;            = ; | 4 ++++

MdeModulePkg/MdeModulePkg.uni    = ;            &n= bsp;            = ; | 4 ++++

4 files changed, 11 insertions(+), 2 deletions(-)

 

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= hciMode.h b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.h

index 7802ebd200..7fe9ac2da7 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode= .h

@@ -193,7 +193,7 @@ typedef union {

#define   AHCI_PORT_DEVSLP_DITO_MASK =      0x01FF8000

#define   AHCI_PORT_DEVSLP_DM_MASK &n= bsp;      0x1E000000

 

-#define AHCI_COMMAND_RETRIES  5

+#define AHCI_COMMAND_RETRIES  PcdGet32 (PcdAhc= iCommandRetryCount)

 

 #pragma pack(1)

//

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/A= taAtapiPassThru.inf b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThr= u.inf

index a3e42a9ab4..78caa3c458 100644

--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapi= PassThru.inf

@@ -65,7 +65,8 @@

   gEdkiiAtaAtapiPolicyProtocolGuid &= nbsp;            ## = CONSUMES

 

 [Pcd]

-  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able   ## SOMETIMES_CONSUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEn= able          ## SOMETIMES_CON= SUMES

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount   ## SOMETIMES_CONSUMES

 

 # [Event]

# EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModu= lePkg/MdeModulePkg.dec

index 7d98910832..58e6ab0048 100644

--- a/MdeModulePkg/MdeModulePkg.dec

+++ b/MdeModulePkg/MdeModulePkg.dec

@@ -1574,6 +1574,10 @@

   # @Prompt SD/MMC Host Controller Operat= ions Timeout (us).

   gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmc= GenericTimeoutValue|1000000|UINT32|0x00000031

 

+  ## The Retry Count of AHCI command if there = is a failure

+  # @Prompt The value of Retry Count,  De= fault value is 5.

+  gEfiMdeModulePkgTokenSpaceGuid.PcdAhciComman= dRetryCount|5|UINT32|0x00000032

+

[PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]<= o:p>

   ## This PCD defines the Console output = row. The default value is 25 according to UEFI spec.

   #  This PCD could be set to 0 then= console output would be at max column and max row.

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModu= lePkg/MdeModulePkg.uni

index b070f15ff2..33ce9f6198 100644

--- a/MdeModulePkg/MdeModulePkg.uni

+++ b/MdeModulePkg/MdeModulePkg.uni

@@ -1166,6 +1166,10 @@

        &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;   "in the DXE phase. Minimum value is 1. Sections nest= ed more deeply are<BR>"

        &nbs= p;             =             &nb= sp;            =             &nb= sp;            =             &nb= sp;            =    "rejected."

 

+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciC= ommandRetryCount_PROMPT  #language en-US "Retry Count of AHCI com= mand if there is a failure"

+

+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdAhciC= ommandRetryCount_HELP  #language en-US "This value is used to con= figure number of retries on AHCI commands, if there is a failure."

+

#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsul= eInRamSupport_PROMPT  #language en-US "Enable Capsule In Ram supp= ort"

 

 #string STR_gEfiMdeModulePkgTokenSpaceGuid_Pcd= CapsuleInRamSupport_HELP  #language en-US   "Capsule In= Ram is to use memory to deliver the capsules that will be processed after = system reset.<BR><BR>"

--

2.36.1.windows.1

 

--_000_DM6PR11MB402535F57751BF3825F02B98CA479DM6PR11MB4025namp_--