From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.2590.1649302292558816167 for ; Wed, 06 Apr 2022 20:31:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GWEpEi3/; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649302292; x=1680838292; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vOgISSTANCpMRoMkcQkQucI32e23SumsxQ+xGuywjQw=; b=GWEpEi3/I5+AeojpzghiD908B4muV7/cU1GImflemEl3oSpTkuwgQJlO oA2ATNd3lEnTxysUajNSOs/h1XfWQsnVhHfrBJEPOCyeLol/vkUI/wg8F F96zdpd0chx31s3edcB5Gc/AsVumGyE1lCGWxw0aLzM4gGMCjd7UuL6i4 AasG3n/Ro0GtnaI2xXnfMiAK6254SVCYj7mPHnqKF/tKWW3CgKmYCj85K xvVuOJ1xZgJZknNGDhao5i77HvzKBbmt3pv4f1ITbAraLwBQacaa5fqBK YSENnxn7prmHFKz1JUoNN3XfaIh0UZW7FHTaf8xQdPWKXqjUpyMr0rge1 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="260913979" X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="260913979" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 20:31:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="588636703" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2022 20:31:31 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Apr 2022 20:31:31 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Apr 2022 20:31:31 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Apr 2022 20:31:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MlqnNAjjAscGBLE/9HwQMMhvxF5juQQkw7opXS//IhosLjgJo0rpDNo+gqmCytv9i81KzwAj0URgp/UXlM+B0CXWHmMWAr7rQ5IUXuToGbvqk5CPYmHFPzOEIPtZdGX+xYgh7vDJ5Hlmdk0RB2le638JWqUB2E3ejKYoNV77VMIu59gcYF4/haK5W+jKeRFKaLYthfBqE+4uG7QtxN8mtSY/yn3ZkbiaCuS+mRpS/DBC5DAU1iotuusi9V9zl5d5vLlOh0hMXYIisNxJDfyvoAb1nLKVOh3kRzVX/GzR/bi27KA4ThGB4YJ+g+bMpHpdLYOIMUhfPlWSpTrZr9IA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aaBJWV6bXm5baum52OLmLHcunofN59MqbYkDLmVqzI=; b=MczyiJmbTiwtZ3BWQ4JU2lk+qXU/bEnOru/9nO2wHrGZVukI+2FvZcxg5A0+B7hn+Q7XwkIlGPxjyDFfYroXj23gVxAUu0e//ZEdmKLHjXboqRek1aPNrrd4HT6mQUhoOXFNYeEvuvWNFK4oBdn4s5o5SBOvzmjb5GvqP3jiIxmstUxf9XjghdXwHL/Vo1JUXIoXcwHUwKMVxHIdsTKFAWKlogggTJl5VVe3xfWJrxyE3jox4BMYd6joJSXUzofVIX2K1+Dl9f8S065AW1BPPFpfxvyw6Jfut4jcBSYIe545IexzuXl2sDh3foHm+UFqdr3EGUDurJXwhCxkHHMkQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SN6PR11MB3471.namprd11.prod.outlook.com (2603:10b6:805:c1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 03:31:23 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::7852:37e2:513c:470b%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022 03:31:23 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB Thread-Topic: [edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB Thread-Index: AQHYSdMwFSoDG3nIgUeYv2oArhPbuqzjyzBg Date: Thu, 7 Apr 2022 03:31:23 +0000 Message-ID: References: <20220406162648.234-1-mikuback@linux.microsoft.com> In-Reply-To: <20220406162648.234-1-mikuback@linux.microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41d6b7f2-7e41-4b5c-2e19-08da184716ed x-ms-traffictypediagnostic: SN6PR11MB3471:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WwSoO15k10UhVTv84qudPFzQGxoQvMJRK5L7JksIhzQRLQfydRxhmVplLvUN7YCHXAxKlsKdW+XaRokNbarR1PeJ+8mkcY08MC/tZevSv+mev/SVuV/e/YzpJJDGoyt2TYt/jiFVUg+WFuqao0VmnBIBnxrufr4Usf44+5iZK5XWXYJ/C892HV/LC3YQQc4+fBY5u6+e1eNa55O94z3uI6jtEbG4aQ7CpiXdiYAogqaFvbcsfsPsgJIZevGt0qMkupwz45Rrasxcr0n4BYWLg81dNy10z6sgskg1XPFKjwFkR9/aLbVrqyC2784GiKekZbPr7H+Q0IBDThj+IOsbk09EJpDQ7Mac9EvZWWHBBoQ6EDz0mTHpPOukXmras42qK/b9qlDNwDIlT49V+NH1WakT4T9hDA+TkNN+tT0bpxRS6tslR60MqTc6xi5Bllj7577XSaVEjEa883Ol6EInp3a9wj4AfeGeuOsLTjR0TLYPGRqTPyLajS/A79LHysrj8qYklVXO54DL2U/x6rMakKr49fC+esxyecHGD63IqNTwF0+Vbe5QyzzcA8aF6K58QHdqpwZPb/YCnylfOeY5CSr1RmJT9B5TNixo4hJBkl9uhS8K5hHx3//525HSO/EtSUwFHUTxxngfnUvYTdbBzEtDNuF7fr1Mh1e84J/I4cmpC8aItOjGirRiP5E3AFIXt/KP8Rs5s7O35RMIxmkjek58j4Gt563uYdwBz3k+pDLzYYBxnWSsTH7sLL7w3ojidOTHRMv2oHTlk2Rf7ZumOr6Mx+uyWrFAlk5za7cwEUJ0Yg+vSgrcHf9RkB2S0cwWBHg4DNltDLMldX2CGzf0Aw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(9686003)(7696005)(6506007)(26005)(54906003)(86362001)(316002)(5660300002)(186003)(2906002)(55016003)(53546011)(71200400001)(83380400001)(110136005)(508600001)(966005)(8936002)(52536014)(33656002)(38100700002)(38070700005)(66556008)(4326008)(8676002)(66446008)(122000001)(64756008)(66476007)(66946007)(82960400001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ixAcY1udcT6pHuLetUqO8aLkiyR/i2S4zRZN7BT7MmUic+137ywmk+WoSBlE?= =?us-ascii?Q?x6OFUP1MEAalljXp11qSbn+xYWcYji2syqnB9QC4LjHoXXvtaTJ3+dA7Aqgu?= =?us-ascii?Q?BS/uiYT7P+Eqhiy+E2afYKtyQD/w5ZnQjuscddno//BfTbEgAW25j3CT0ezW?= =?us-ascii?Q?3RXvojEWtFH0bC9Kig+/d7bne7YB7zQi0ZC/ZJklOAfk4+iDoB8sIhKe0ymp?= =?us-ascii?Q?JKqWKjQnO1qgTGDIAxA2OYFEL8ivjbtjELibHQvtas3j5dW33Bcyenac01oe?= =?us-ascii?Q?2DjL2zrleAXUzpdXMaqMpshOAuSJVZROBlFV6VWCMVi9fG8S6PGeKVL8smvC?= =?us-ascii?Q?LuL+lK78WIGcvcuqIyzMoe3UnbSPwW4IxbfnT2P4T/nXier5Cg2VWq4miVaB?= =?us-ascii?Q?zr180lWqv0ztgTBbWNtLXbH9FKpIsSmo1BPJVRNoFpqJ6E4QQwk5EUuCVjz4?= =?us-ascii?Q?6lD53B1WQKirYy57QK9Jrct7ax/r6rNn48a1RZ9tXbxER2c77TvToepirgG9?= =?us-ascii?Q?BOPdjlkIoZwxXvI1hWVjvmVvKSATycJsPyqWSkjAecR+EhLko31A0A+YRv7/?= =?us-ascii?Q?hFv1HTZ7pBZP6dyOD8+fLJo3aW+nGYpAzRFNjbBm2g2Hi43Lcoqtuuz6tI3n?= =?us-ascii?Q?o5hgDOoMbJjg544tVQoHYr2b2uP0pRnbzqeik58xJVDPwJ7twnZl8Ot+uGQM?= =?us-ascii?Q?sGdDK5TyEu5ctXk1uRxpad8DEaXKGgJeGw4kIyNer4eXaPW5NLsFZacF+6gN?= =?us-ascii?Q?JtMJ2ivE0j5j8e/wLZs2Pu8rhmXD07YY2K5oa5aPWCEyzB7iXqyqW3M6667A?= =?us-ascii?Q?Nw/xiTky6JjX2NCHOw5+8UU45NU+W/QbhZEPd7zEF2Zn8vtoUMnVAwgLnrp3?= =?us-ascii?Q?d+qhZKbt7I6AX3HzGgnNb8rmhqtgeYK1+MEcT7+L37QZ1KOAybIp2x9MJSCI?= =?us-ascii?Q?/xjyYxLTtwkW7HYauqp1W5aRHKXFSRz9gI5cjFvilUrmRwbrP5XOelFjHJC9?= =?us-ascii?Q?4BYGAymXgB4VJDhjhw4hbmSClH8pBw8OqT9RpasH0HppKg4m6eD8mmdGsM26?= =?us-ascii?Q?xAi2yj/sm+XW7qTeHrRDXdVMFFvdgDw6Xg6TekCtASvOJPYuc6gdpMJgHSFg?= =?us-ascii?Q?HN+donMtD4NbtWuXwZvmdWGimZHV0mLfBUqPbvwXVJWelGrdwmgh65TreK94?= =?us-ascii?Q?0JcgucSHt54fmr1sDZZO3QWrdlltXM9QiEry7rblSjwk0eNqWzoh5f8J/bPj?= =?us-ascii?Q?glFNUnmTaNWY79TcjKfnTs2y/+3q+oS4G15w7VQQDXbIAyyCL30LUxO4Ay7Y?= =?us-ascii?Q?utUbq+GYHn/rv05xzKEfbDK5d9f2IqzA9891cZu2BI2V36xX5J11aKhnXwKo?= =?us-ascii?Q?bZSnzl/PSZl0EvPhQv0m/OqVSZtf51rlOhi5siFHGbwUNd3GUgeAwIFH2/c4?= =?us-ascii?Q?kue24ONVTRMMue3dsEJAgxn4KQu8jQWLJ39/QrRgBGSWRHxuVSybUUgyOck4?= =?us-ascii?Q?mY5tYPhIbWM8+zQltrCpZevMETJCHoj5LnCqSENQdPGC4IsQnKWJ8TqtHwtJ?= =?us-ascii?Q?PoJUUQLwcCblRZwVS5xFsigIEyl+RQ7QmUOZYDjVevHHk3ENH4kAckl6ZjE5?= =?us-ascii?Q?Nh5E4IsboelSQnswxfo9+gadMS+f42JLJ1u89RlEbB9ELpjqiBbadhAxWkNj?= =?us-ascii?Q?NmmRHMfTUVrZqg3J7hug1pclNWJIT/IkvyGQXWt2FZSt62x6aiD0lLMLwww+?= =?us-ascii?Q?+tQOFeT03g=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41d6b7f2-7e41-4b5c-2e19-08da184716ed X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 03:31:23.1952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l14EOZ01xeGU4op4BDRW5L8GTyuX/tYQGMpGDgyvn+7ibUBiVBpby7LsAnGNqYIRsBy/oODuTKgTPfQ/Rf2qMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3471 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for a question: GetVariableFlashInfo() seems being defined multiple times across modules, d= o you see value in abstracting it as a library API? Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Thursday, April 7, 2022 12:27 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: [edk2-devel] [PATCH v1 0/3] Add Variable Flash Info HOB >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3479 >=20 > The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm, > VariableStandaloneMm, etc. (and their dependent protocol/library > stack), typically acquire UEFI variable store flash information > with PCDs declared in MdeModulePkg. >=20 > For example: > [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64 > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize >=20 > These PCDs work as-is in the StandaloneMm driver if they are not > dynamic such as Dynamic or DynamicEx because PCD services are not > readily available in the Standalone MM environment. Platforms that > use Standalone MM today, must define these PCDs as FixedAtBuild in > their platform build. However, the PCDs do allow platforms to treat > the PCDs as Dynamic/DynamicEx and being able to support that is > currently a gap for Standalone MM. >=20 > This patch series introduces a HOB that can be produced by the > platform to provide the same information. The HOB list is > available to Standalone MM. >=20 > The PCD declarations are left as-is in MdeModulePkg for backward > compatibility. This means unless a platform wants to use the HOB, > their code will continue to work with no change (they do not need > to produce the HOB). Only if the HOB is found, is its value used > instead of the PCDs. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Liming Gao > Signed-off-by: Michael Kubacki =20 > Michael Kubacki (3): > MdeModulePkg: Add Variable Flash Info HOB > MdeModulePkg/Variable: Consume Variable Info HOB > MdeModulePkg/FaultTolerantWrite: Consume Variable Info HOB >=20 > MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c = | > 111 +++++++++++++++++--- > MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c > | 7 +- > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c > | 92 ++++++++++++++-- > MdeModulePkg/Universal/Variable/Pei/Variable.c = | 66 > +++++++++++- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c = | 42 > ++++++++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c = | > 25 ++++- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c > | 20 +++- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c = | > 20 +++- > MdeModulePkg/Include/Guid/VariableFlashInfo.h = | 36 > +++++++ > MdeModulePkg/MdeModulePkg.dec = | 4 + > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.h > | 9 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > | 11 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf > | 11 +- >=20 > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandalon > eMm.inf | 11 +- > MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf > | 10 +- > MdeModulePkg/Universal/Variable/Pei/Variable.h = | 2 + > MdeModulePkg/Universal/Variable/Pei/VariablePei.inf = | 6 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h = | 17 > +++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > | 6 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf = | > 6 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > | 6 +- > 21 files changed, 455 insertions(+), 63 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/VariableFlashInfo.h >=20 > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#88461): https://edk2.groups.io/g/devel/message/88461 > Mute This Topic: https://groups.io/mt/90293658/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20