Re: [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Ranbir Singh <rsingh@ventanamicro.com>
> Sent: Saturday, June 3, 2023 12:09 AM
> To: devel@edk2.groups.io; rsingh@ventanamicro.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix
> SIGN_EXTENSION Coverity issue
> 
> From: Ranbir Singh <Ranbir.Singh3@Dell.com>
> 
> Line number 365 does contain a typecast with UINT32, but it is after
> all the operations (16-bit left shift followed by OR'ing) are over.
> To avoid any SIGN_EXTENSION, typecast the intermediate result after
> 16-bit left shift operation immediately with UINT32.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4209
> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com>
> ---
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> index a77852bae054..ccd4c5f05b59 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c
> @@ -362,7 +362,7 @@ IdentifyAtaDevice (
>      // Check logical block size
> 
>      //
> 
>      if ((PhyLogicSectorSupport & BIT12) != 0) {
> 
> -      BlockMedia->BlockSize = (UINT32)(((IdentifyData->logic_sector_size_hi
> << 16) | IdentifyData->logic_sector_size_lo) * sizeof (UINT16));
> 
> +      BlockMedia->BlockSize = (((UINT32)(IdentifyData->logic_sector_size_hi
> << 16) | IdentifyData->logic_sector_size_lo) * sizeof (UINT16));
> 
>      }


This patch seems to have the same issue with the concern raised in https://edk2.groups.io/g/devel/topic/99293622.

Best Regards,
Hao Wu


> 
> 
> 
>      AtaDevice->BlockIo.Revision = EFI_BLOCK_IO_PROTOCOL_REVISION2;
> 
> --
> 2.34.1