From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.28503.1658979012949006456 for ; Wed, 27 Jul 2022 20:30:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=duXt1ufh; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658979012; x=1690515012; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=RQIYPO7JGfsJF20GQA+4tnFsAoIGDhfhGoS4gm/4WGI=; b=duXt1ufhDvPSBaXsGqtvvyGb2UslzLRcjeCSVmlhHrtKAxOq/1poZJd4 N8zM/NVz3Ii55/ionCX7gi2LERhbd7F2zXvt7Om/3Ezxt7ZQ1sPmPnpFc JpJ3ow3O65NrZN8zpEamptptHxz9hKDQeJnWDn+zc0TEprFqZYZGaNIpI wEkPLH8kF/8sEdJmdlBh/k8e9t9DOOgsfAtk0pgq91dfAgK4HpZ4N+17T w1Bk71anTZvCJ+Bi8DFE8dmXaYc3Ic7CtIe+jV5Oy4rDSjLtczL9cVD5l /J5OtoVoeDmVfgd/tVnsTWa4qvEHJPavu6ux8lFrO2JqVttYTRw9GV4HS g==; X-IronPort-AV: E=McAfee;i="6400,9594,10421"; a="352406620" X-IronPort-AV: E=Sophos;i="5.93,196,1654585200"; d="scan'208";a="352406620" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2022 20:30:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,196,1654585200"; d="scan'208";a="928069535" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 27 Jul 2022 20:30:11 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 27 Jul 2022 20:30:11 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 27 Jul 2022 20:30:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 27 Jul 2022 20:30:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KazGJQpupLhYSbxZvSiG5Z334yZ8VsMrvdpT0bvDmi0Mhz0J8NmWQxSi/OU/KeMrSVisZ3LN7mQF6M29csrdeCCmDuyfQN06pbo3YtBaAeV5SYN5yOMHrPQ2uK51TCJlZNFZs5IktnHJnMSE85RTm3OWXuqy/J2+d+NCY5Kqj3dYcucw1sspf26X6ilrQa8CZBnHBbLRZrUcJXsufuaPPYt3HAeBIe/BykN8/hsIBmXqEXxSJOjXNYjYaUxNkishFCpOz32UnPwe7ex9b+rEe2O1jweRWyoZGxw/MBQ10v7zbicqP/k1YxhexnNWZssE5e9GngWvty0amfqOHPbLuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bN9yzMGraFMhN+bHny+nwg3GZjPD44HqiKWHlkVdIO4=; b=AKARKTYTjgEiKJBUS5sK2tKiEbs4f5bO0KyjaPGWp9VJ6OQ8YiGO/FrZisAyOcQwR5IVbiicr96ntLg9d5OQc83CiSXMfimGy1E6lJPR9Hym9Vf424O+IDulw/kvoOlrMpXwHaizz0rZyhKfnAUQZSYe2zIXWeacXe3u2pX6aZcy7spzRtJyTq1odUJfK17/Y/79ySJKat9VFLaezdVJzovgUqVx+aoqRy6NNFkNsEAJpT2/B/2sHcyRPNRygpbj9hSf8SqopM79wkIRFQD+A26RvH8d/E7rBMRAOpVP8KaEFyob9tGj7uzk7JI1xHgSGahLSuU5YjQMFIcmZ9jRjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by BYAPR11MB3686.namprd11.prod.outlook.com (2603:10b6:a03:fc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 28 Jul 2022 03:30:09 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::e9b3:7cad:874e:77f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::e9b3:7cad:874e:77f%7]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 03:30:09 +0000 From: "Wu, Hao A" To: "Ni, Ray" , "Gao, Liming" , "Czajkowski, Maciej" , "devel@edk2.groups.io" Subject: Re: [PATCH v2 1/2] MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition Thread-Topic: [PATCH v2 1/2] MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition Thread-Index: AQHYobRKrLsIcw1vK0e91eFi/lYKNK2S++zg Date: Thu, 28 Jul 2022 03:30:08 +0000 Message-ID: References: <20220727122733.2251-1-maciej.czajkowski@intel.com> <20220727122733.2251-2-maciej.czajkowski@intel.com> In-Reply-To: <20220727122733.2251-2-maciej.czajkowski@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67d0730a-41a9-48be-9fba-08da704978de x-ms-traffictypediagnostic: BYAPR11MB3686:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QfeGm4KsVkufO/jS+0Zuxk5Pau7YdD4A8ehRomR42WWn0kK/9b8IFENTQgrT/4INdynYgv3XhaBqRbVGAe4imBSqvpay34ansJNFp/FvJ/WPLYJIRo6YLYr/y4GPe79TUJWYuNHrxRXOhFt/ZgIE8jWNieiESZmg1c4JfCw+ptbcbqpcAK6Zf+SpvTz52LB9q+SF7BEMqip65m+tWL6ukdHL6CMFG1zhnGc1Wdtc3ByppZ6I/O2C2yyXwgfDymem2KC+Hh62AjlRYOQ41q/6VqPCC9SyswifxG5AVYqmfSiKAWFnALLZxCQyDx9+4IE8rQULPKgpZplGSmBGUrs4LWHMrBtTr/hpIY2vrr1DFt/6DbqHe2rlVm69bZsaiHc5ZBEGdtFQfNZH3dg8vmqdG1WOyX+t45NKwL0DOcJYkXACWap1bJZKkUSnQWpi0NBr726CB+QBEnJRZuwiU32UpShSCZQOQ6hz/LtnffWaAdCZrfm4gs8afuZ8X7qL86rvW1kDyvWT2O9fZ9Sq4eRTP0mxxQ9XhK3xJUftzKSrRrI9v7clZjlKR3YufXPetaAnvJvbKz2T/qog4wr7lA+pTXlKfm4gZ3VvMlxlxcEyW9xYen0k6sjjJCWumDeXXaav8LzGH3tQxCi5Lz/nSzJ2Zsz1cboFsdjJClaXT8Vm5UlDX1T8DR9uRHFAPan4ntxgxnGMN3Bh2uAfYlyZ7LS55FOv74GbDeCxzITgwA7Ilzq5J4gOptbFuIxfP5yhaj/DV7FOY4xldZlUuq/TgAa7N61fWgJOUSaaZpdt0O8uQYBL55duo8FdQtMg3H3hTDi0FqCeExl8yHnVzduLZ6xz7N9yFFRE4aczHA/f0qCi0ju1XnwR8eHKaTjTyA2QuVvP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(136003)(396003)(346002)(366004)(316002)(38070700005)(66946007)(38100700002)(86362001)(966005)(33656002)(66446008)(66556008)(76116006)(66476007)(122000001)(110136005)(478600001)(71200400001)(5660300002)(64756008)(82960400001)(6506007)(7696005)(53546011)(8676002)(186003)(9686003)(26005)(2906002)(83380400001)(52536014)(41300700001)(55016003)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DjC1sT0bba57M+nYiQtFwfV1lqRrmonnopuhd7mO+STViq1CxPQfrkwEanva?= =?us-ascii?Q?uLoQb5/J+gDLwkVyKddmpXLryvwj33o2ZceTP0ifflO1CUbaHwj6gT67LUzU?= =?us-ascii?Q?LmCJ9mJwG41eELTWlsjwovBwhocA7aDQ6e0GyUwyZHD0gbH3BKSgc8V4+W90?= =?us-ascii?Q?z1GQJ0YmALxINmGSiSB/i0+0TTEp4fOwWXbzSjT/SJOmdONZD4hfn8q1nj8m?= =?us-ascii?Q?rkiW36hxyvW0d0tt/ZhW6AX0x7DZ2+cjTXhN1PBKcFMBXw44Rna43r796sRN?= =?us-ascii?Q?6mi386CrZlvRPGTBsBJ9gCYgex/eLZquU052PjoidtaCOtRSTG8uwIryEpUR?= =?us-ascii?Q?LJQKoYWPebnyWM9BqR+wSj5oF8GoFbj8C0jj9QySRKa5sIwX3TLOQZftqTld?= =?us-ascii?Q?/wnrte/lQktBs4fHq0LiBHOTiMK5oWFuxRvr+kUUZWYNqsvrYL+HkDod0nje?= =?us-ascii?Q?M/37lz0CPbHrpWKUq5PuXroZ3gzjG9gA1EgSV6CPZLeqK0ajMzi84rmP20v9?= =?us-ascii?Q?HcYzNze/2U2pbMUekPWn8bVrJiicUydqSdQkOZnSmj8o52r+5WkscOlWAJHo?= =?us-ascii?Q?moQQsHB0Mez7Iu2VanN/uY6915dhZNjEuhOYFAB5qNKeBGKoR9fqDWXf0mvk?= =?us-ascii?Q?DgsqdP0BUonQBn0yy0LBK4zu/GKGuHC3msg5l6y7VKQ9qAT5AVIjPIC9xg1m?= =?us-ascii?Q?VfRByxe4ZmOiOeMIKZGNYgo7ed+knGgozzQGJY8zOzmHf7egrQTnOtBJIg4A?= =?us-ascii?Q?TB0Dl4e9SI2TtuITt5cDYYmtYAuVC85BME3czMtg0QSFPNM5OiYaquRoJfSs?= =?us-ascii?Q?IBLp+Aeko6VUECvTFjfGXwpGxdyp6j/Znb6OyWRTlYLhmqgDrWO2KuzCrGAZ?= =?us-ascii?Q?vyEqviG6jrTKFnK7fhyJ6N+z8F+RbBSGbbsrX6vigCB/NCPXCQ7IY/jahjyN?= =?us-ascii?Q?+O1wsvm4WchKNbkQIrfOfSWnIhvifVt5LzDAB8L2KVPEerHyZyyT5ZLLfdYL?= =?us-ascii?Q?37N5OUXPIvaeowxP0eYUvkTEskJ+WFvNDpSvwnVZ6Y+b0CBHXvD25zqUMcUO?= =?us-ascii?Q?C2A1WB3HUB+h9sKgP3HwNIRbk9o3HKTqIadF5M7YrYTf126mJiFEyvStyhnJ?= =?us-ascii?Q?zIK910HbF0m4egKQY5S1UY0rrrO/hhKrH/XrpS5ML8WbN1het+1nIctS2Dz7?= =?us-ascii?Q?2A/Me28fuuihrwjY+Jsr77qxjPX+Qoaonex2YJr13RFjy1gOYW4nMyMEdfiq?= =?us-ascii?Q?lI5KjlY6AyfAbo2ecPpVZf3wQHo4s9EqzDLW9L5LjOKc7kKhWZL+muCJygqp?= =?us-ascii?Q?OHO6oB/aBmrbPshOtG3ZYjX6Qpx9UeBa0X1NuVzqqbR4Mj3bXfKaMGF88eWD?= =?us-ascii?Q?lJxoGQK7IGuMmyGjGT74LByu1EwdqAg6M7+/63Kw2GdUFmU8/ZKXKnuG1fBH?= =?us-ascii?Q?TFnvN5T1Lryh6PQOOKAF0uE4qmvSwC9RBWsrWZEuMmISdi/fM4eUu9YI1/OB?= =?us-ascii?Q?TKvyuvhH40v1HkjajyHbJw/dUbtnQI3rNNW979Kp3YuUyuFG5nIhdsS1wRmK?= =?us-ascii?Q?D1RJne+qjsgyCakEN78js8q3SCWhcUGm81rhxkfW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67d0730a-41a9-48be-9fba-08da704978de X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 03:30:08.8969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3lyssSL4/8TyjPh9KpvqJs8Q3H36YA3CJTx5OEhCQR5GlmllAPjkc+wEUDbdjGnj6uKgyVMa+yMFf6v9uiwUAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3686 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable As previously mentioned in https://edk2.groups.io/g/devel/message/90345, th= e PPI interface looks good from the device controllers perspective: Reviewed-by: Hao A Wu Sorry Ray and Liming, do you have additional comments for this newly introd= uced EDKII_PCI_DEVICE_PPI? Best Regards, Hao Wu > -----Original Message----- > From: Czajkowski, Maciej > Sent: Wednesday, July 27, 2022 8:28 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Gao, > Liming > Subject: [PATCH v2 1/2] MdeModulePkg: Add EDKII_PCI_DEVICE_PPI > definition >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3907 >=20 > This commit introduces EDKII_PCI_DEVICE_PPI. The purpose of this PPI is t= o > provide a way of accessing PCI devices to drvice drivers such as > NvmExpressPei or AhciPei. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Liming Gao > Signed-off-by: Maciej Czajkowski > Acked-by: Hao A Wu > --- >=20 > Notes: > v2 changes: > - added acked-by tag > - minor change - modified header guard to follow coding style >=20 > MdeModulePkg/Include/Ppi/PciDevice.h | 32 ++++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 3 ++ > 2 files changed, 35 insertions(+) >=20 > diff --git a/MdeModulePkg/Include/Ppi/PciDevice.h > b/MdeModulePkg/Include/Ppi/PciDevice.h > new file mode 100644 > index 000000000000..6750ae6ce394 > --- /dev/null > +++ b/MdeModulePkg/Include/Ppi/PciDevice.h > @@ -0,0 +1,32 @@ > +/** @file++ Copyright (c) 2022, Intel Corporation. All rights reserved.=
+ > SPDX-License-Identifier: BSD-2-Clause-Patent++**/++#ifndef > EDKII_PCI_DEVICE_PPI_H_+#define EDKII_PCI_DEVICE_PPI_H_++#include > +#include ++///+/// Global ID fo= r > the EDKII_PCI_DEVICE_PPI_GUID.+///+#define > EDKII_PCI_DEVICE_PPI_GUID \+ { \+ 0x1597ab4f, 0xd542, 0x4efe, { 0x9a, > 0xf7, 0xb2, 0x44, 0xec, 0x54, 0x4c, 0x0b } \+ }++///+/// PCI Device PPI > structure.+///+typedef struct {+ EFI_PCI_IO_PROTOCOL PciIo;+ > EFI_DEVICE_PATH_PROTOCOL *DevicePath;+} > EDKII_PCI_DEVICE_PPI;++extern EFI_GUID > gEdkiiPeiPciDevicePpiGuid;++#endif // EDKII_PCI_DEVICE_PPI_H_diff --git > a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 2bcb9f9453af..7d989108324a 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -509,6 +509,9 @@ [Ppis] > ## Include/Ppi/NvmExpressPassThru.h > gEdkiiPeiNvmExpressPassThruPpiGuid =3D { 0x6af31b2c, 0x3be, 0x46c1, { = 0xb1, > 0x2d, 0xea, 0x4a, 0x36, 0xdf, 0xa7, 0x4c } } + ## Include/Ppi/PciDevice.= h+ > gEdkiiPeiPciDevicePpiGuid =3D { 0x1597ab4f, 0xd542, 0x4ef= e, { 0x9a, > 0xf7, 0xb2, 0x44, 0xec, 0x54, 0x4c, 0x0b } }+ ## Include/Ppi/CapsuleOnD= isk.h > gEdkiiPeiCapsuleOnDiskPpiGuid =3D { 0x71a9ea61, 0x5a35, 0x4a5= d, { 0xac, > 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } } > gEdkiiPeiBootInCapsuleOnDiskModePpiGuid =3D { 0xb08a11e4, 0xe2b7, > 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1 } }-- > 2.27.0.windows.1